poorejc commented on issue #50:
URL:
https://github.com/apache/incubator-flagon-useralejs/issues/50#issuecomment-821766828
> All of the tests in the [merged
branch](https://github.com/apache/incubator-flagon-useralejs/tree/UncleGedd-sendOnClose)
are passing on my end, using Node version
poorejc commented on issue #50:
URL:
https://github.com/apache/incubator-flagon-useralejs/issues/50#issuecomment-815408726
Great info, @UncleGedd. I’ll try testing it again with your parameters ASAP.
Thanks again!
> On Apr 6, 2021, at 4:45 PM, UncleGedd ***@***.***> wrote:
>
poorejc commented on issue #50:
URL:
https://github.com/apache/incubator-flagon-useralejs/issues/50#issuecomment-812802241
Did some quick testing on
https://github.com/apache/incubator-flagon-useralejs/tree/flagon-userale-50
BLUF: flipped out visibilitychange for pagehide listener.
poorejc commented on issue #50:
URL:
https://github.com/apache/incubator-flagon-useralejs/issues/50#issuecomment-812796025
@UncleGedd, @confusingstraw I beat up the webworkers pretty good in Chrome
and Safari.
BLUF: The web-worker solution does appear to work, but there's still
poorejc commented on issue #50:
URL:
https://github.com/apache/incubator-flagon-useralejs/issues/50#issuecomment-812314024
> I finished up the spike and put it in a branch
[here](https://github.com/UncleGedd/incubator-flagon-useralejs/tree/spike-workers).
I was able to get a decent unit
poorejc commented on issue #50:
URL:
https://github.com/apache/incubator-flagon-useralejs/issues/50#issuecomment-811511744
@UncleGedd thanks again! I'll take a look at this branch tomorrow, test like
hell. Also, I'll try out some of the other events Rob discovered aside from
poorejc commented on issue #50:
URL:
https://github.com/apache/incubator-flagon-useralejs/issues/50#issuecomment-808621268
@confusingstraw you've always been someone I consider imminently sane.
Sounds like the right way to go is [3] Websockets @confusingstraw makes a
compelling
poorejc commented on issue #50:
URL:
https://github.com/apache/incubator-flagon-useralejs/issues/50#issuecomment-806930053
> No problem! Also, welcome @kevbrowndev!
>
> Regarding the other failing unit test:
>
> ```js
> it('sends logs on page exit without navigator', () =>
poorejc commented on issue #50:
URL:
https://github.com/apache/incubator-flagon-useralejs/issues/50#issuecomment-806908863
> Ok, so I've tried writing a cypress/journey test for `sendBeacon` and it's
pretty flaky, but manual testing works in the browser (Chrome) consistently
though
poorejc commented on issue #50:
URL:
https://github.com/apache/incubator-flagon-useralejs/issues/50#issuecomment-805452663
@UncleGedd are you open to helping me test this out a bit? I'm digging into
this one tomorrow night, but if you're into it, I would love some more testing
on this
poorejc commented on issue #50:
URL:
https://github.com/apache/incubator-flagon-useralejs/issues/50#issuecomment-803046568
That's great literature, @confusingstraw. Thanks! I'll checkout firing on
pageHide and test against page refresh and navigation, closure. Looks like
support for
poorejc commented on issue #50:
URL:
https://github.com/apache/incubator-flagon-useralejs/issues/50#issuecomment-802499142
Removed sendOnRefresh from Submit event handling:
```
Object.keys(refreshEvents).forEach(function(ev) {
document.addEventListener(ev, function(e) {
poorejc commented on issue #50:
URL:
https://github.com/apache/incubator-flagon-useralejs/issues/50#issuecomment-802497782
Updated sendOnClose to flush logs queue:
```
export function sendOnClose(logs, config) {
document.addEventListener('visibilitychange', function () {
13 matches
Mail list logo
