Github user SlavaRa closed the pull request at:
https://github.com/apache/flex-sdk/pull/24
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user aharui commented on the pull request:
https://github.com/apache/flex-sdk/pull/24#issuecomment-152585318
Hi SlavaRa,
(Apologies if this gets posted twice. I think email replies as comments
isn't working)
Do you have a link that supports your claim that the
Hi SlavaRa,
Do you have a link that supports your claim that the compiler cannot
generate the correct optimization? This article seems to imply that it
can [1]
IMO, the string concatenation is easier to read. I would want to see
actual profiling that shows that the string concatenation is affec
Github user SlavaRa commented on the pull request:
https://github.com/apache/flex-sdk/pull/24#issuecomment-152506154
"I think "looks bad" is a personal preference."
Perhaps, but in this situation, combined the two approaches
StringBuffer.append and string concatenations.. in this c
Github user Harbs commented on the pull request:
https://github.com/apache/flex-sdk/pull/24#issuecomment-152503636
I'd think the compiler optimizes the string concatenation, so there's no
difference in performance:
http://stackoverflow.com/questions/1532461/stringbuilder-vs-string
Github user SlavaRa commented on the pull request:
https://github.com/apache/flex-sdk/pull/24#issuecomment-152467858
I would like to help in the development of the compiler.
But there is no desire to work with code that looks bad to say the least.
Using string concatenation cont
Github user tomchiverton commented on the pull request:
https://github.com/apache/flex-sdk/pull/24#issuecomment-152466884
I don't see any reasoning behind why this was done - is this approach more
performant or something ?
---
If your project is set up for it, you can reply to this e
Github user SlavaRa commented on the pull request:
https://github.com/apache/flex-sdk/pull/24#issuecomment-150963665
https://issues.apache.org/jira/browse/FLEX-34946
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
