Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

Hi, > No reason to be :-) Knowing what evacuates to true with == and false with != > is hard to remember and get right. Evaluates was meant obviously. Autocorrect can sometime give amusing results. thanks, Justin

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

Hi, > Ahh!! You are right. Stupid. Sorry about that. No reason to be :-) Knowing what evacuates to true with == and false with != is hard to remember and get right. Thanks, Justin

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

Ahh!! You are right. Stupid. Sorry about that. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

Hi, > if(styleable.style !== 'undefined' && styleable.style != null) > > You will have both cases handled. (styleable.style != null) will cover both cases as well - and probably a few you may not want :-) Until we sort out the way to do this I've just put in something that worked on both

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

Hi Justin, I saw your commit. Why in that case you cannot have? if(styleable.style !== 'undefined' && styleable.style != null) You will have both cases handled. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

Another place where things differ is member variables: public var a:String; On the SWF side, this variable defaults to null. On the JS side, it defaults to undefined right now. In the case of a member variable, we could set it to null by default on the JS side to make it more consistent. For

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

Hi, OK the issue is that we getting different results for AS and JS. For code like this: var a:Object = {}; var propA:Object = a.prop; var propB:* = a.prop; if (propA === undefined) { trace("A undefined"); } if (propA === null) { trace("A null"); } if (propB === undefined) {

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

Justin, I just pushed fix and it should build both version. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

HI, > I didn't run it in the browser. I run swf in Flash Player projector [1]. How are you compiling that? Looks like "mvn compile” only produces the JS version. Thanks, Justin

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

Hi, > if(typeof a !== 'undefined') { > } Are we really concerned that undefined may of been redefined? (Which would probably cause a whole lot of issues.) Seems it may be a little expensive to me compared to a straight === undefined. Thanks, Justin

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

I didn't run it in the browser. I run swf in Flash Player projector [1]. [1] http://www.adobe.com/support/flashplayer/debug_downloads.html - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

Hi, >> 2) I build "DataBindingExampleWithFlexLayout" and run swf version and I see >> Null Pointer Exception in SimpleCSSValuesImpl. > > That I’ll take a look at. It’s running file here for me. What browser / what was the error you were getting? Thanks, Justin

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

I'm not sure whether I understand your answer. I don't actually talking about checking between null or undefined - cause it's obvious it is depends on scenario. I'm talking about a way in which we are doing it - What do you thing to use this "typeof a". ? Thanks, Piotr - Apache Flex PMC

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

Hi, > if(typeof a !== 'undefined') { > } > > And of course if we consider null: > > if(typeof a !== 'undefined' && null !== a) { > } > > Thoughts ? It’s really going to depend on the context / code. In some case it will be obvious with one to check. In others we may need to change the code

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

Justin, It it was discussed and the other were agree for the warnings can you raise a jira to remove them later on ? Additional things I was speaking a bit with colleagues from JS team in my company and asking them about checking "undefined" things. They were saying that they are checking such

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

HI, > 1) I see following warnings [1]. The warnings are fine or rather the compiler shouldn’t be warning there - this has been discussed before on the list. > 2) I build "DataBindingExampleWithFlexLayout" and run swf version and I see > Null Pointer Exception in SimpleCSSValuesImpl. That

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

Hi Justin, I just tried develop and build framework. 1) I see following warnings [1]. 2) I build "DataBindingExampleWithFlexLayout" and run swf version and I see Null Pointer Exception in SimpleCSSValuesImpl.

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

Hi, > What will happen if some of those values will be null ? For example > styleable.style ? Styleable could be I guess but there wasn’t a null check for it before. Styable.style is unlikely to be null. All test still pass and I’ve tested this with several applications and it never has a

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

Hi Justin What will happen if some of those values will be null ? For example styleable.style ? Piotr 2017-06-01 7:58 GMT+02:00 : > make getValue a lot faster - 30ms down to 5ms in a complex app for JS in > Chrome > > > Project: