Re: [FlexJS][Discuss] Test classList in mdl:Button

Carlos, I see commit. Great! :) I need to write first a long elaborate about this problem with "merging" beads in other thread, cause I have more concerns, before I get back to coding. Wish I could be in one office with you and all guys from Team we could solve it such things asap :) Piotr

Re: [FlexJS][Discuss] Test classList in mdl:Button

Hi Piotr, I think I finished the refactor to class list. I didn't touch your components since maybe you are working on them this will mess your work. So feel free to update as you could. thanks El 1 de diciembre de 2016, 8:37, Carlos Rovira < carlos.rov...@codeoscopic.com> escribió: > Hi Piotr,

Re: [FlexJS][Discuss] Test classList in mdl:Button

Hi Piotr, I saw your commit. I think is better to use classList.add in your case. classList.toggle is used to add/remove based on some condition. I think is working since as there's nothing now the toggle is like and add. El 1 de diciembre de 2016, 8:34, Carlos Rovira <

Re: [FlexJS][Discuss] Test classList in mdl:Button

Hi Piotr, yes, you're right. I saw it as I did the commit, but as it was late I thought in get to it today. I'll make the changes as I can. Thanks! :) 2016-12-01 8:00 GMT+01:00 piotrz : > Carlos, > > I saw your commits with refactoring to classList. Maybe we should do

Re: [FlexJS][Discuss] Test classList in mdl:Button

Carlos, I saw your commits with refactoring to classList. Maybe we should do same in "createElement" for created components if it is possible to make it consistent? I just did it in Chip and ButtonChip. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [FlexJS][Discuss] Test classList in mdl:Button

I think there's no need of utility class. If you see classList API it has all needed methods (add/remove/toggle) or at least I don't find right now more needsmaybe as I use.. So is just use "element.classList.add(some class)" or other uses like this 2016-11-30 23:27 GMT+01:00 Alex Harui

Re: [FlexJS][Discuss] Test classList in mdl:Button

On 11/30/16, 2:16 PM, "carlos.rov...@gmail.com on behalf of Carlos Rovira" wrote: >Right, > >I'm with you that an utility class will be good for the rest of FlexJS, >and >as well maybe is great as well support IE9. > >So for

Re: [FlexJS][Discuss] Test classList in mdl:Button

Right, I'm with you that an utility class will be good for the rest of FlexJS, and as well maybe is great as well support IE9. So for MDL I'll continue with this refactor of classList only in MDL, right? 2016-11-30 20:27 GMT+01:00 Alex Harui : > > > On 11/30/16, 11:16 AM,

Re: [FlexJS][Discuss] Test classList in mdl:Button

On 11/30/16, 11:16 AM, "Carlos Rovira" wrote: >Hi Alex, > >You mean in the case of The rest of flexjs not in mdl? Yes, the rest of FlexJS. If MDL is heavily dependent on changing classnames then the MDL library should support that. But all of our other examples

Re: [FlexJS][Discuss] Test classList in mdl:Button

Hi Alex, You mean in the case of The rest of flexjs not in mdl? El El mié, 30 nov 2016 a las 19:49, Alex Harui escribió: > On 11/30/16, 10:34 AM, "carlos.rov...@gmail.com on behalf of Carlos > Rovira" > wrote: >

Re: [FlexJS][Discuss] Test classList in mdl:Button

On 11/30/16, 10:34 AM, "carlos.rov...@gmail.com on behalf of Carlos Rovira" wrote: >So in order to extend the classList changes to the rest of MDL framework >in >FlexJS, I'm motivated to do so, but hope you could share your thoughts