Re: [FlexJS] Accordion broken

I just pushed changes that make Accordion look ok to me on both SWF and JS. This is the test case I used. https://paste.apache.org/ELvN -Alex On 6/5/17, 10:57 PM, "yishayw" wrote: >Not sure I understand. Is release Accordion working with the example I >posted >[1]?

Re: [FlexJS] Accordion broken

Not sure I understand. Is release Accordion working with the example I posted [1]? I just fetched and logged flex-asjs and couldn't see any accordion related changes. Can you send a commit id? Thanks. [1] https://paste.apache.org/QUj1 -- View this message in context:

Re: [FlexJS] Accordion broken

I haven't sync'd anything since Friday, but I don't seem to be having the measurement problem you are talking about. I changed the Accordion children to VContainer and added the TitleBarModel. Now I see the TitleBar (although it is blank) and the segment contents. When I expose or hide the

Re: [FlexJS] Accordion broken

On 6/3/17, 2:10 PM, "Harbs" wrote: >It turns out the children are actually Containers which have a >TitleBarModel bead. Sorry about the confusion. It might make sense to >have an interface for an accordion-compatible container. My recommendation, as an alternative to an

Re: [FlexJS] Accordion broken

Thanks. I'll look into this today if I get a chance and definitely tomorrow. Peter > On Jun 4, 2017, at 6:05 AM, yishayw wrote: > > Here's [1] an example app. > > The 2 problems I see: > > 1) DataBinding problems [2] cause titles to be undefined. I hacked a fix on

Re: [FlexJS] Accordion broken

Here's [1] an example app. The 2 problems I see: 1) DataBinding problems [2] cause titles to be undefined. I hacked a fix on TLF branch, but this should probably addressed differently. 2) TitleBar.height returns 0, even though the measured height is 30. I think this is a bug, am I wrong?

Re: [FlexJS] Accordion broken

1. Seems to be a data binding problem. (See other thread.) Yishay committed a temporary work-around, but we don’t think that’s the right way to fix the problem. 2. seems to be a measurement problem. The titleBar height is not being measured correctly. This is a workaround (in a custom item

Re: [FlexJS] Accordion broken

I worked around the Promise issue (by copying js.swc to my project and not using the one in the SDK). There’s at least 2 issues still: 1. The title property from the model is not being applied to the view of the item renderer. 2. The collapsed height of the collapsed items are 0 instead of the

Re: [FlexJS] Accordion broken

Yishay did the implementation of this so I was a bit shaky on the details. I just looked at our code, and it appears that we did not actually use panels for the children. It turns out the children are actually Containers which have a TitleBarModel bead. Sorry about the confusion. It might make

Re: [FlexJS] Accordion broken

Hi, It looks like this is the last thing to be resolved before we can make FlexJS 0.8 release. I'm seeing two title bars per item in the Accordion. Any suggestions for how to resolve this, based on the information I've given below? Thanks, Peter On 6/1/17, 3:49 PM, "Peter Ent"

Re: [FlexJS] Accordion broken

I've checked in my changes to the Accordion components. It still is not working correctly and I cannot figure out what is happening. The used as the data to the Accordion are being placed as children of AccordionItemRenderers which are themselves Panels. So there are two TitleBars present per

Re: [FlexJS] Accordion broken

Harbs wrote > \2. The Collapse bead can only infer that it’s collapsed by the fact that > the size is the collapsed size — which only makes sense if the size is > set. Shouldn't .height return the measured height, regardless of whether it was explicitly set? -- View this message in context:

Re: [FlexJS] Accordion broken

With some guidance from Alex, I have the Accordion "working". The problem now is that it appears as a Panel-in-Panel for each item. For example, with two Panels in the dataProvider, there are two bars and whichever is "open" or "selected" shows the Panel from the dataProvider along with its title

Re: [FlexJS] Accordion broken

Yishay had some code to handle the cases where it’s not set via MXML which you removed. I changed his code to simply intialize the document if it was not set by MXML like this: //Needed if the layout is not declared using MXML private function

Re: [FlexJS] Accordion broken

I'm still working on this and ran into a couple of issues. The flexible child layouts no longer provide a way to explicitly set a child; instead they rely in the child's id being used to retrieve the child from the document. Unfortunately, a layout that is not referenced in MXML will not get its

Re: [FlexJS] Accordion broken

OK, thanks. Alex some alternative layouts I can try. —peter On 5/30/17, 11:35 AM, "Harbs" wrote: >The reasons it’s broken is (at least) thee-fold: > >1. Panels contain content and need to be collapsed despite the fact that >content exists. >2. The Collapse bead can only

Re: [FlexJS] Accordion broken

The reasons it’s broken is (at least) thee-fold: 1. Panels contain content and need to be collapsed despite the fact that content exists. 2. The Collapse bead can only infer that it’s collapsed by the fact that the size is the collapsed size — which only makes sense if the size is set. 3. The

Re: [FlexJS] Accordion broken

Something like this: This is the markup of an Accordion which used to work, which doesn’t anymore.

Re: [FlexJS] Accordion broken

Hi, Do you have a quick example of how to use the FlexJS Accordion? The ASDoc on it is thin. The children of the Flex SDK Accordion were navigation components that supported things like title so each section could be labeled. I don't see an AccordionChild or something similar that can be used

Re: [FlexJS] Accordion broken

I am looking into it. I will also create an example for Accordion so it will be easier to test it in the future. ‹peter On 5/30/17, 6:39 AM, "Harbs" wrote: >It seems like the new layouts totally broke Accordion. > >Accordion relied on absolute sizing to handle expanding