Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

[piotrz]

I run another one [1] to align with latest commits and we will see what
happened.

[1]
https://builds.apache.org/view/E-G/view/Flex/job/FlexJS%20Pipeline/job/release0.8.0/18/

Piotr



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/LAST-CALL-Release-FlexJS-FalconJX-0-8-0-tp61275p61971.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

[piotrz]

I see that Maven build [1] of release branch is failing.

[1]
https://builds.apache.org/view/E-G/view/Flex/job/FlexJS%20Pipeline/job/release0.8.0/17/console

Piotr



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/LAST-CALL-Release-FlexJS-FalconJX-0-8-0-tp61275p61970.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: dual issues

[Alex Harui]

If targets only has JSFlex, there shouldn't be any SWF compile at all.
The console should spit out what it thinks it needs to do.

Keep in mind that there are now SWCs for SWFs and SWCs for JS.  Prior to
dual, there was a main SWC with SWF APIs that the compiler saw, and JS
that it substituted in the output.  The JS SWC was only used to build
downstream JS SWCs.

If you have a custom SWC before dual and it has platform dependent APIs,
and you are only interested in JS output, you need to make sure your SWC's
upstream SWCs are the JS SWCs and not the SWF SWCs.

That in turn requires being more careful about which SWCs are on the
-library-path vs -swf-library-path vs -js-library-path.  In theory, if you
only want JS output, it should be as simple as making sure everything on
the -library-path is a SWC for JS.

HTH,
-Alex

On 5/31/17, 8:42 PM, "Josh Tynjala"  wrote:

>As I understand it, the compiler should just take care of differences
>between JS and SWF, as long as your targets option is correct. VSCode
>shouldn't need to do anything​ special except to pass in the correct
>options.
>
>There's nothing related to dual changes on my to-do list at this time, but
>maybe I missed something important...
>
>- Josh
>
>On May 31, 2017 7:52 PM, "Harbs"  wrote:
>
>Josh,
>
>VS Code is now reporting lots of errors in the Problems window. I’m
>guessing it does not know how to differentiate between JS and SWF builds
>using dual?
>
>Is that something on your to-do list?
>
>Thanks,
>Harbs
>
>> On Jun 1, 2017, at 5:10 AM, Harbs  wrote:
>>
>> Bingo. Thanks!
>>
>> SWF output still gets all kinds of errors, but the JS output is pretty
>error free. I still have some fixing up to do before I can see how well it
>actually works, but at least the compiler is not complaining now.
>>
>>> On Jun 1, 2017, at 4:45 AM, Josh Tynjala  wrote:
>>>
>>> Try replacing the js-output-type compiler option with:
>>>
>>> "targets": ["JSFlex"]
>>>
>>> - Josh
>>>
>>> On May 31, 2017 6:26 PM, "Harbs"  wrote:
>>>
 I’m using asconfig in VSCode to compile with these settings:
   "config": "flex",
   "compilerOptions": {
   "debug": false,
   "js-output-type": "flexjs",
   "source-map": false,
   "library-path": [
   "lib"
   ],

> On Jun 1, 2017, at 1:04 AM, Justin Mclean 
 wrote:
>
> HI,
>
>> Am I missing something?
>
> Perhaps try JSFlex in your pom.xml? I believe the
 name changed from pre to post dual branch.
>
> Justin
>


>>

Re: dual issues

[Josh Tynjala]

As I understand it, the compiler should just take care of differences
between JS and SWF, as long as your targets option is correct. VSCode
shouldn't need to do anything​ special except to pass in the correct
options.

There's nothing related to dual changes on my to-do list at this time, but
maybe I missed something important...

- Josh

On May 31, 2017 7:52 PM, "Harbs"  wrote:

Josh,

VS Code is now reporting lots of errors in the Problems window. I’m
guessing it does not know how to differentiate between JS and SWF builds
using dual?

Is that something on your to-do list?

Thanks,
Harbs

> On Jun 1, 2017, at 5:10 AM, Harbs  wrote:
>
> Bingo. Thanks!
>
> SWF output still gets all kinds of errors, but the JS output is pretty
error free. I still have some fixing up to do before I can see how well it
actually works, but at least the compiler is not complaining now.
>
>> On Jun 1, 2017, at 4:45 AM, Josh Tynjala  wrote:
>>
>> Try replacing the js-output-type compiler option with:
>>
>> "targets": ["JSFlex"]
>>
>> - Josh
>>
>> On May 31, 2017 6:26 PM, "Harbs"  wrote:
>>
>>> I’m using asconfig in VSCode to compile with these settings:
>>>   "config": "flex",
>>>   "compilerOptions": {
>>>   "debug": false,
>>>   "js-output-type": "flexjs",
>>>   "source-map": false,
>>>   "library-path": [
>>>   "lib"
>>>   ],
>>>
 On Jun 1, 2017, at 1:04 AM, Justin Mclean 
>>> wrote:

 HI,

> Am I missing something?

 Perhaps try JSFlex in your pom.xml? I believe the
>>> name changed from pre to post dual branch.

 Justin

>>>
>>>
>

Re: dual issues

[Harbs]

Another weird issue:

> /Users/harbs/Documents/git/PrintUI/printui-flexjs/PortedPrintUI/src/com/printui/dummy/view/Image.as(12):
>  col: 15 interface method imageElement in interface IImage not implemented by 
> class Image
> 
>   public class Image extends BinaryImage
>^
> 
> /Users/harbs/Documents/git/PrintUI/printui-flexjs/PortedPrintUI/src/com/printui/dummy/view/Image.as(12):
>  col: 15 interface method applyImageData in interface IImage not implemented 
> by class Image
> 
>   public class Image extends BinaryImage
> 

org.apache.flex.html.BinaryImage which in tern subclasses 
org.apache.flex.html.Image. org.apache.flex.html.Image implements these two 
methods. I figured the compiler might be getting confused by the fact that 
Image is named the same as an ancestor class, so I changed the name and I'm 
getting the same error in additon to a null pointer error:

>   
> /Users/harbs/Documents/git/PrintUI/printui-flexjs/PortedPrintUI/src/com/printui/dummy/view/PUIImage.as(12):
>  col: 15 interface method imageElement in interface IImage not implemented by 
> class PUIImage
> 
>   public class PUIImage extends BinaryImage
>^
> 
> /Users/harbs/Documents/git/PrintUI/printui-flexjs/PortedPrintUI/src/com/printui/dummy/view/PUIImage.as(12):
>  col: 15 interface method applyImageData in interface IImage not implemented 
> by class PUIImage
> 
>   public class PUIImage extends BinaryImage
>^
> 
> /Users/harbs/Documents/git/PrintUI/printui-flexjs/PortedPrintUI/src/com/printui/view/components/DesignAreaComponents/drawnObjects/ImageObject.as(59):
>  col: 3 java.lang.NullPointerException
>   at 
> org.apache.flex.compiler.internal.projects.FlexProject.isValidTypeConversion(FlexProject.java:2304)
>   at 
> org.apache.flex.compiler.internal.semantics.MethodBodySemanticChecker.checkImplicitConversion(MethodBodySemanticChecker.java:564)
>   at 
> org.apache.flex.compiler.internal.semantics.MethodBodySemanticChecker.checkImplicitConversion(MethodBodySemanticChecker.java:374)
>   at 
> org.apache.flex.compiler.internal.semantics.MethodBodySemanticChecker.checkAssignment(MethodBodySemanticChecker.java:246)
>   at 
> org.apache.flex.compiler.internal.as.codegen.ABCGeneratingReducer.reduce_assignToNameExpr_to_void_expression(ABCGeneratingReducer.java:2947)
>   at 
> org.apache.flex.compiler.internal.as.codegen.CmcEmitter.action_237(CmcEmitter.java:4451)
>   at 
> org.apache.flex.compiler.internal.as.codegen.CmcEmitter.dispatchAction(CmcEmitter.java:8067)
>   at 
> org.apache.flex.compiler.internal.as.codegen.CmcEmitter.reduceAntecedent(CmcEmitter.java:39127)
>   at 
> org.apache.flex.compiler.internal.as.codegen.CmcEmitter.dispatchAction(CmcEmitter.java:9362)
>   at 
> org.apache.flex.compiler.internal.as.codegen.CmcEmitter.reduceAntecedent(CmcEmitter.java:39127)
>   at 
> org.apache.flex.compiler.internal.as.codegen.CmcEmitter.reduce(CmcEmitter.java:39104)
>   at 
> org.apache.flex.compiler.internal.as.codegen.CmcEmitter.reduceSubgoals(CmcEmitter.java:39155)
>   at 
> org.apache.flex.compiler.internal.as.codegen.CmcEmitter.reduceAntecedent(CmcEmitter.java:39126)
>   at 
> org.apache.flex.compiler.internal.as.codegen.CmcEmitter.reduce(CmcEmitter.java:39104)
>   at 
> org.apache.flex.compiler.internal.as.codegen.CmcEmitter.reduceSubgoals(CmcEmitter.java:39146)
>   at 
> org.apache.flex.compiler.internal.as.codegen.CmcEmitter.reduceAntecedent(CmcEmitter.java:39126)
>   at 
> org.apache.flex.compiler.internal.as.codegen.CmcEmitter.reduce(CmcEmitter.java:39104)
>   at 
> org.apache.flex.compiler.internal.as.codegen.CmcEmitter.burm(CmcEmitter.java:39406)
>   at 
> org.apache.flex.compiler.internal.as.codegen.ABCGenerator.generateInstructions(ABCGenerator.java:228)
>   at 
> org.apache.flex.compiler.internal.as.codegen.ABCGenerator.generateMethodBodyForFunction(ABCGenerator.java:393)
>   at 
> org.apache.flex.compiler.internal.as.codegen.ABCGenerator.generateMethodBodyForFunction(ABCGenerator.java:347)
>   at 
> org.apache.flex.compiler.internal.as.codegen.ABCGenerator.generateFunction(ABCGenerator.java:262)
>   at 
> org.apache.flex.compiler.internal.as.codegen.ClassDirectiveProcessor.finishClassDefinition(ClassDirectiveProcessor.java:639)
>   at 
> org.apache.flex.compiler.internal.as.codegen.GlobalDirectiveProcessor.declareClass(GlobalDirectiveProcessor.java:430)
>   at 
> org.apache.flex.compiler.internal.as.codegen.DirectiveProcessor.processNode(DirectiveProcessor.java:206)
>   at 
> org.apache.flex.compiler.internal.as.codegen.DirectiveProcessor.traverse(DirectiveProcessor.java:188)
>   at 
> org.apache.flex.compiler.internal.as.codegen.GlobalDirectiveProcessor.declarePackage(GlobalDirectiveProcessor.java:455)
>   at 
> org.apache.flex.compiler.internal.as.codegen.DirectiveProcessor.processNode(DirectiveProcessor.java:223)
>   at 

Re: dual issues

[Harbs]

Josh,

VS Code is now reporting lots of errors in the Problems window. I’m guessing it 
does not know how to differentiate between JS and SWF builds using dual?

Is that something on your to-do list?

Thanks,
Harbs

> On Jun 1, 2017, at 5:10 AM, Harbs  wrote:
> 
> Bingo. Thanks!
> 
> SWF output still gets all kinds of errors, but the JS output is pretty error 
> free. I still have some fixing up to do before I can see how well it actually 
> works, but at least the compiler is not complaining now.
> 
>> On Jun 1, 2017, at 4:45 AM, Josh Tynjala  wrote:
>> 
>> Try replacing the js-output-type compiler option with:
>> 
>> "targets": ["JSFlex"]
>> 
>> - Josh
>> 
>> On May 31, 2017 6:26 PM, "Harbs"  wrote:
>> 
>>> I’m using asconfig in VSCode to compile with these settings:
>>>   "config": "flex",
>>>   "compilerOptions": {
>>>   "debug": false,
>>>   "js-output-type": "flexjs",
>>>   "source-map": false,
>>>   "library-path": [
>>>   "lib"
>>>   ],
>>> 
 On Jun 1, 2017, at 1:04 AM, Justin Mclean 
>>> wrote:
 
 HI,
 
> Am I missing something?
 
 Perhaps try JSFlex in your pom.xml? I believe the
>>> name changed from pre to post dual branch.
 
 Justin
 
>>> 
>>> 
> 

Re: dual issues

[Harbs]

Bingo. Thanks!

SWF output still gets all kinds of errors, but the JS output is pretty error 
free. I still have some fixing up to do before I can see how well it actually 
works, but at least the compiler is not complaining now.

> On Jun 1, 2017, at 4:45 AM, Josh Tynjala  wrote:
> 
> Try replacing the js-output-type compiler option with:
> 
> "targets": ["JSFlex"]
> 
> - Josh
> 
> On May 31, 2017 6:26 PM, "Harbs"  wrote:
> 
>> I’m using asconfig in VSCode to compile with these settings:
>>"config": "flex",
>>"compilerOptions": {
>>"debug": false,
>>"js-output-type": "flexjs",
>>"source-map": false,
>>"library-path": [
>>"lib"
>>],
>> 
>>> On Jun 1, 2017, at 1:04 AM, Justin Mclean 
>> wrote:
>>> 
>>> HI,
>>> 
 Am I missing something?
>>> 
>>> Perhaps try JSFlex in your pom.xml? I believe the
>> name changed from pre to post dual branch.
>>> 
>>> Justin
>>> 
>> 
>> 

Re: dual issues

[Harbs]

The examples I see seem to use COMPILE blocks.

I’m not sure how this translates to the app level. Is there a way to define a 
single method which overrides a SWF one and implements a new JS one (without 
using COMPILE blocks)? That seems to me like a pretty common use case for 
migrated apps.

> On Jun 1, 2017, at 2:18 AM, Alex Harui  wrote:
> 
> 
> 
> On 5/31/17, 2:38 PM, "Harbs"  > wrote:
> 
>> I just switched to dual and I’m getting lots of errors. These errors seem
>> to be exactly what I was afraid of, and I’m not sure how to resolve
>> without being restricted by naming of properties and methods.
>> 
>> 1. I’m using a mask setter and getter for images it’s now giving override
>> errors.
>> 2. contains() is an incompatible override.
>> 3. scaleX and scaleY
>> 4. blendMode
>> 5. rotation
>> 6. filters
>> 7. mouseEnabled
>> etc….
>> 
>> I thought there was supposed to be something built into the compiler to
>> hide the flash-specific APIs and allow reuse of them.
> 
> Not just in the compiler, but in metadata.  Search the source for
> [SWFOverride].  I guess I don't understand why you want/need to change the
> type of scaleX/Y, blendMode, etc.  Wouldn't mouseEnabled always be a
> boolean?
> 
> SWFOverride is designed for properties like mask and methods like
> contains() that are defined as a flash.display.DisplayObject by Flash and
> we probably want to use UIBase instead.  SWFOverride will work because
> UIBase is a DisplayObject on Flash.  I did not anticipate a requirement
> that mouseEnabled would be something other than a boolean.  What types are
> you using for these other properties?  Or maybe you just need COMPILE::JS
> on mouseEnabled?
> 
> HTH,
> -Alex

Re: dual issues

[Justin Mclean]

Hi,

> I’m using asconfig in VSCode to compile with these settings:
>   "config": "flex",
>   "compilerOptions": {
>   "debug": false,
>   "js-output-type": "flexjs",
>   "source-map": false,
>   "library-path": [
>   "lib"
>   ],


I’ve not used VSCode but perhaps try “JSFlex" rather than “flexjs" in there or 
perhaps “targets": “JSFlex"?

Justin

Re: dual issues

[Josh Tynjala]

Try replacing the js-output-type compiler option with:

"targets": ["JSFlex"]

- Josh

On May 31, 2017 6:26 PM, "Harbs"  wrote:

> I’m using asconfig in VSCode to compile with these settings:
> "config": "flex",
> "compilerOptions": {
> "debug": false,
> "js-output-type": "flexjs",
> "source-map": false,
> "library-path": [
> "lib"
> ],
>
> > On Jun 1, 2017, at 1:04 AM, Justin Mclean 
> wrote:
> >
> > HI,
> >
> >> Am I missing something?
> >
> > Perhaps try JSFlex in your pom.xml? I believe the
> name changed from pre to post dual branch.
> >
> > Justin
> >
>
>

Re: dual issues

[Harbs]

In case I wasn’t clear, I’m not outputting SWF — only JS output.

> On Jun 1, 2017, at 4:26 AM, Harbs  wrote:
> 
> I’m using asconfig in VSCode to compile with these settings:
> "config": "flex",
> "compilerOptions": {
> "debug": false,
> "js-output-type": "flexjs",
> "source-map": false,
> "library-path": [
> "lib"
> ],
> 
>> On Jun 1, 2017, at 1:04 AM, Justin Mclean > > wrote:
>> 
>> HI,
>> 
>>> Am I missing something?
>> 
>> Perhaps try JSFlex in your pom.xml? I believe the name 
>> changed from pre to post dual branch.
>> 
>> Justin
>> 
> 

Re: dual issues

[Harbs]

I’m using asconfig in VSCode to compile with these settings:
"config": "flex",
"compilerOptions": {
"debug": false,
"js-output-type": "flexjs",
"source-map": false,
"library-path": [
"lib"
],

> On Jun 1, 2017, at 1:04 AM, Justin Mclean  wrote:
> 
> HI,
> 
>> Am I missing something?
> 
> Perhaps try JSFlex in your pom.xml? I believe the name 
> changed from pre to post dual branch.
> 
> Justin
> 

Re: dual issues

[Alex Harui]

On 5/31/17, 2:38 PM, "Harbs"  wrote:

>I just switched to dual and I’m getting lots of errors. These errors seem
>to be exactly what I was afraid of, and I’m not sure how to resolve
>without being restricted by naming of properties and methods.
>
>1. I’m using a mask setter and getter for images it’s now giving override
>errors.
>2. contains() is an incompatible override.
>3. scaleX and scaleY
>4. blendMode
>5. rotation
>6. filters
>7. mouseEnabled
>etc….
>
>I thought there was supposed to be something built into the compiler to
>hide the flash-specific APIs and allow reuse of them.

Not just in the compiler, but in metadata.  Search the source for
[SWFOverride].  I guess I don't understand why you want/need to change the
type of scaleX/Y, blendMode, etc.  Wouldn't mouseEnabled always be a
boolean?

SWFOverride is designed for properties like mask and methods like
contains() that are defined as a flash.display.DisplayObject by Flash and
we probably want to use UIBase instead.  SWFOverride will work because
UIBase is a DisplayObject on Flash.  I did not anticipate a requirement
that mouseEnabled would be something other than a boolean.  What types are
you using for these other properties?  Or maybe you just need COMPILE::JS
on mouseEnabled?

HTH,
-Alex

Re: git commit: [flex-asjs] [refs/heads/release0.8.0] - forgot to delete these two lines

[Alex Harui]

Not a CSS property name.

On 5/31/17, 2:49 PM, "Justin Mclean"  wrote:

>HI,
>
>What the reason for removing backgroundAlpha?
>
>Thanks,
>Justin

dual issues

[Harbs]

I just switched to dual and I’m getting lots of errors. These errors seem to be 
exactly what I was afraid of, and I’m not sure how to resolve without being 
restricted by naming of properties and methods.

1. I’m using a mask setter and getter for images it’s now giving override 
errors.
2. contains() is an incompatible override.
3. scaleX and scaleY
4. blendMode
5. rotation
6. filters
7. mouseEnabled
etc….

I thought there was supposed to be something built into the compiler to hide 
the flash-specific APIs and allow reuse of them.

Am I missing something?

Thanks,
Harbs

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

[OmPrakash Muppirala]

Josh is right.  There is no way to pass command-line args to an install
command.
What is there right now is the best way to pass args during an npm install.

Thanks,
Om

On Wed, May 31, 2017 at 9:35 AM, OmPrakash Muppirala 
wrote:

> I should have something in the next 12 hours or so.
>
> Thanks,
> Om
>
>
> On May 31, 2017 8:31 AM, "Alex Harui"  wrote:
>
> Hi Om,
>
> Command-line sounds great if you can do it.  Let us know when you are done
> with the NPM stuff so we can move forward with the release.
>
> Thanks,
> -Alex
>
> On 5/30/17, 7:15 PM, "Josh Tynjala"  wrote:
>
> >I could not find a way to parse extra command line arguments with an npm
> >install command. If you could figure that out, that would be better!
> >
> >- Josh
> >
> >On May 30, 2017 6:56 PM, "OmPrakash Muppirala" 
> >wrote:
> >
> >Awesome! I had this as a TODO.  I can at least help with testing this out
> >now.
> >
> >I can also push the bits to the npm registry when we go live with the
> >release.
> >
> >Also, what if we pass them as command line args? Do you mind if I make
> >this
> >change?
> >
> >Thanks,
> >Om
> >
> >
> >On May 30, 2017 11:47 AM, "Josh Tynjala"  wrote:
> >
> >I got the npm version of FlexJS 0.8.0 working with a couple of minor
> >fixes.
> >It looks good to go for the release!
> >
> >I also simplified how to test the npm version locally from the
> >flex-utilities repo to make it download nightly builds (previously, you
> >needed to manually change some JS code):
> >
> >cd flex-utilities
> >npm config set flexjs:flexjs_custom_url
> >https://na01.safelinks.protection.outlook.com/?url=http%3A%
> 2F%2Fapacheflex
> >build.cloudapp.net%3A8080%2Fjob%2Fflex-asjs_release_branch%
> 2F=02%7C01
> >%7C%7C8ea9163b8a4f40e1e30c08d4a7cafb9b%7Cfa7b1b5a7b34438794
> aed2c178decee1%
> >7C0%7C0%7C636317937627432987=ezcbLDOwjYz3oG3dO8RDtA71
> Xv%2FfKUgG77enA
> >Use3JY%3D=0
> >lastSuccessfulBuild/artifact/out/apache-flex-flexjs-0.8.0-bin.zip
> >npm config set flexjs:falcon_custom_url
> >https://na01.safelinks.protection.outlook.com/?url=http%3A%
> 2F%2Fapacheflex
> >build.cloudapp.net%3A8080%2Fjob%2Fflex-falcon%2520release%
> 2520branch%2F
> >ta=02%7C01%7C%7C8ea9163b8a4f40e1e30c08d4a7cafb9b%
> 7Cfa7b1b5a7b34438794aed2c
> >178decee1%7C0%7C0%7C636317937627432987=jiM4u89B6Ea%
> 2F4cRLi0VwSMc
> >%2FspYvxcIBFBtsjBw%3D=0
> >lastSuccessfulBuild/artifact/out/apache-flex-falconjx-0.8.0-bin.zip
> >npm install -g ./npm-flexjs/
> >
> >Those are the URLs to the latest builds from the release branches. It
> >could
> >be used with regular nightly builds from the develop branch and release
> >candidate builds too.
> >
> >When you're done, you should delete the configuration keys:
> >
> >npm config delete flexjs:flexjs_custom_url
> >npm config delete flexjs:falcon_custom_url
> >
> >- Josh
> >
> >On Fri, May 26, 2017 at 4:51 PM, Josh Tynjala 
> >wrote:
> >
> >> I can test installing FlexJS 0.8.0 with NPM early next week, if no one
> >> else finds the time. I don't remember the exact process of testing
> >>locally
> >> with a nightly build of FlexJS, but I think I figured it out pretty
> >>easily
> >> when I made some tweaks a while back.
> >>
> >> - Josh
> >>
> >> On Fri, May 26, 2017 at 2:43 PM, Alex Harui 
> >> wrote:
> >>
> >>> I'm still working on the TLF fix.  I saw Josh's commit about Node
> >support.
> >>> Does someone have time to test out our Node/NPM stuff?  It might need
> >some
> >>> tuning after this dual-compile feature.
> >>>
> >>> -Alex
> >>>
> >>> On 5/26/17, 8:29 AM, "Alex Harui"  wrote:
> >>>
> >>> >
> >>> >
> >>> >On 5/26/17, 8:07 AM, "piotrz"  wrote:
> >>> >
> >>> >>Alex,
> >>> >>
> >>> >>That is correct I have FALCON_HOME set up. I will try as fast as I
> >>>can
> >>> >>run
> >>> >>it once again, but there is possibility that will be on Sunday.
> >>> >>
> >>> >>Any chance to try by you also maven build with command line above ?
> >>>I'm
> >>> >>wondering if you also experience such issue as Santanu. Personally I
> >>> >>didn't
> >>> >>have it yesterday.
> >>> >
> >>> >I will try it when I get through this fix for the TLF branch.  For
> >>>me, I
> >>> >believe I've always had to separately use the Mavenizer to get
> >>>com.adobe
> >>> >artifacts.  I'm not sure if that's expected or not.  You might want to
> >>> >check the archives to see if there is any mention of how to get
> >com.adobe
> >>> >artifacts.  I think there maybe issues with not having recent versions
> >of
> >>> >Maven and/or whether to use settings-template.xml.
> >>> >
> >>> >I don't want to take the time to help you look into this right now.
> >>> >
> >>> >Thanks,
> >>> >-Alex
> >>> >
> >>>
> >>>
> >>
>
>
>

Re: [FlexJS] Accordion broken

[Harbs]

Yishay had some code to handle the cases where it’s not set via MXML which you 
removed.

I changed his code to simply intialize the document if it was not set by MXML 
like this:

//Needed if the layout is not declared using MXML
private function 
initializeDocument(contentView:ILayoutView):void
{
document = {};
for (var i:int = 0; i < contentView.numElements; i++)
{
var child:IStyleableObject = 
contentView.getElementAt(i) as IStyleableObject;
document[child.id] = child;
}
}

and in layout():
if(document == null)
initializeDocument(contentView);

An AccordionLayout might make sense though. And switching to selection rather 
than checking collapsed might make sense as well.

Thanks for working on this.

> On May 31, 2017, at 7:47 PM, Peter Ent  wrote:
> 
> I'm still working on this and ran into a couple of issues.
> 
> The flexible child layouts no longer provide a way to explicitly set a
> child; instead they rely in the child's id being used to retrieve the
> child from the document. Unfortunately, a layout that is not referenced in
> MXML will not get its document set.
> 
> Perhaps a better solution is to write "AccordionLayout" that will expand
> the child selected by the model, but I'm still looking at making use of
> what is already there.
> 
> —peter
> 
> 
> 
> On 5/30/17, 11:35 AM, "Harbs"  wrote:
> 
>> The reasons it’s broken is (at least) thee-fold:
>> 
>> 1. Panels contain content and need to be collapsed despite the fact that
>> content exists.
>> 2. The Collapse bead can only infer that it’s collapsed by the fact that
>> the size is the collapsed size — which only makes sense if the size is
>> set.
>> 3. The title must be measured to set the collapsed height correctly.
>> 
>>> On May 30, 2017, at 6:21 PM, Harbs  wrote:
>>> 
>>> Something like this:
>>> 
>>>   
>>>   
>>>   
>>>   
>>>   
>>>   
>>>   
>>>   
>>> 
>>> This is the markup of an Accordion which used to work, which doesn’t
>>> anymore.
>>> 
>>> 
>>>   
>>>   
>>> 
>>> 
>>> 
>>> 
>>>   
>>>   
>>>   
>>> 
>>> 
 On May 30, 2017, at 4:54 PM, Peter Ent  wrote:
 
 Hi,
 
 Do you have a quick example of how to use the FlexJS Accordion? The
 ASDoc
 on it is thin. The children of the Flex SDK Accordion were navigation
 components that supported things like title so each section could be
 labeled. I don't see an AccordionChild or something similar that can be
 used with Accordion. I took a guess and made Container a child of it,
 but
 it just blew up.
 
 Thanks,
 ‹peter
 
 On 5/30/17, 6:39 AM, "Harbs"  wrote:
 
> It seems like the new layouts totally broke Accordion.
> 
> Accordion relied on absolute sizing to handle expanding and
> collapsing of
> content. I tried to add a new layout which is basically a copy of the
> old
> OneFlexibleVerticalLayout and use that for accordion, but that does
> not
> seem to work either due to changes in containers (I think).
> 
> Peter, do you thin you could look into this?
> 
> Thanks,
> Harbs
 
>>> 
>> 
> 

Re: [FlexJS] Accordion broken

[Peter Ent]

I'm still working on this and ran into a couple of issues.

The flexible child layouts no longer provide a way to explicitly set a
child; instead they rely in the child's id being used to retrieve the
child from the document. Unfortunately, a layout that is not referenced in
MXML will not get its document set.

Perhaps a better solution is to write "AccordionLayout" that will expand
the child selected by the model, but I'm still looking at making use of
what is already there.

—peter



On 5/30/17, 11:35 AM, "Harbs"  wrote:

>The reasons it’s broken is (at least) thee-fold:
>
>1. Panels contain content and need to be collapsed despite the fact that
>content exists.
>2. The Collapse bead can only infer that it’s collapsed by the fact that
>the size is the collapsed size — which only makes sense if the size is
>set.
>3. The title must be measured to set the collapsed height correctly.
>
>> On May 30, 2017, at 6:21 PM, Harbs  wrote:
>> 
>> Something like this:
>> 
>>
>>
>>
>>
>>
>>
>>
>>
>> 
>> This is the markup of an Accordion which used to work, which doesn’t
>>anymore.
>> 
>>  
>>
>>
>>  
>>  
>>  
>>  
>>
>>
>>
>> 
>> 
>>> On May 30, 2017, at 4:54 PM, Peter Ent  wrote:
>>> 
>>> Hi,
>>> 
>>> Do you have a quick example of how to use the FlexJS Accordion? The
>>>ASDoc
>>> on it is thin. The children of the Flex SDK Accordion were navigation
>>> components that supported things like title so each section could be
>>> labeled. I don't see an AccordionChild or something similar that can be
>>> used with Accordion. I took a guess and made Container a child of it,
>>>but
>>> it just blew up.
>>> 
>>> Thanks,
>>> ‹peter
>>> 
>>> On 5/30/17, 6:39 AM, "Harbs"  wrote:
>>> 
 It seems like the new layouts totally broke Accordion.
 
 Accordion relied on absolute sizing to handle expanding and
collapsing of
 content. I tried to add a new layout which is basically a copy of the
old
 OneFlexibleVerticalLayout and use that for accordion, but that does
not
 seem to work either due to changes in containers (I think).
 
 Peter, do you thin you could look into this?
 
 Thanks,
 Harbs
>>> 
>> 
>

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

[OmPrakash Muppirala]

I should have something in the next 12 hours or so.

Thanks,
Om


On May 31, 2017 8:31 AM, "Alex Harui"  wrote:

Hi Om,

Command-line sounds great if you can do it.  Let us know when you are done
with the NPM stuff so we can move forward with the release.

Thanks,
-Alex

On 5/30/17, 7:15 PM, "Josh Tynjala"  wrote:

>I could not find a way to parse extra command line arguments with an npm
>install command. If you could figure that out, that would be better!
>
>- Josh
>
>On May 30, 2017 6:56 PM, "OmPrakash Muppirala" 
>wrote:
>
>Awesome! I had this as a TODO.  I can at least help with testing this out
>now.
>
>I can also push the bits to the npm registry when we go live with the
>release.
>
>Also, what if we pass them as command line args? Do you mind if I make
>this
>change?
>
>Thanks,
>Om
>
>
>On May 30, 2017 11:47 AM, "Josh Tynjala"  wrote:
>
>I got the npm version of FlexJS 0.8.0 working with a couple of minor
>fixes.
>It looks good to go for the release!
>
>I also simplified how to test the npm version locally from the
>flex-utilities repo to make it download nightly builds (previously, you
>needed to manually change some JS code):
>
>cd flex-utilities
>npm config set flexjs:flexjs_custom_url
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapacheflex
>build.cloudapp.net%3A8080%2Fjob%2Fflex-asjs_release_branch%2F=02%7C01
>%7C%7C8ea9163b8a4f40e1e30c08d4a7cafb9b%7Cfa7b1b5a7b34438794aed2c178decee1%
>7C0%7C0%7C636317937627432987=ezcbLDOwjYz3oG3dO8RDtA71Xv%2FfKUgG77enA
>Use3JY%3D=0
>lastSuccessfulBuild/artifact/out/apache-flex-flexjs-0.8.0-bin.zip
>npm config set flexjs:falcon_custom_url
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapacheflex
>build.cloudapp.net%3A8080%2Fjob%2Fflex-falcon%2520release%2520branch%2F
>ta=02%7C01%7C%7C8ea9163b8a4f40e1e30c08d4a7cafb9b%7Cfa7b1b5a7b34438794aed2c
>178decee1%7C0%7C0%7C636317937627432987=jiM4u89B6Ea%2F4cRLi0VwSMc
>%2FspYvxcIBFBtsjBw%3D=0
>lastSuccessfulBuild/artifact/out/apache-flex-falconjx-0.8.0-bin.zip
>npm install -g ./npm-flexjs/
>
>Those are the URLs to the latest builds from the release branches. It
>could
>be used with regular nightly builds from the develop branch and release
>candidate builds too.
>
>When you're done, you should delete the configuration keys:
>
>npm config delete flexjs:flexjs_custom_url
>npm config delete flexjs:falcon_custom_url
>
>- Josh
>
>On Fri, May 26, 2017 at 4:51 PM, Josh Tynjala 
>wrote:
>
>> I can test installing FlexJS 0.8.0 with NPM early next week, if no one
>> else finds the time. I don't remember the exact process of testing
>>locally
>> with a nightly build of FlexJS, but I think I figured it out pretty
>>easily
>> when I made some tweaks a while back.
>>
>> - Josh
>>
>> On Fri, May 26, 2017 at 2:43 PM, Alex Harui 
>> wrote:
>>
>>> I'm still working on the TLF fix.  I saw Josh's commit about Node
>support.
>>> Does someone have time to test out our Node/NPM stuff?  It might need
>some
>>> tuning after this dual-compile feature.
>>>
>>> -Alex
>>>
>>> On 5/26/17, 8:29 AM, "Alex Harui"  wrote:
>>>
>>> >
>>> >
>>> >On 5/26/17, 8:07 AM, "piotrz"  wrote:
>>> >
>>> >>Alex,
>>> >>
>>> >>That is correct I have FALCON_HOME set up. I will try as fast as I
>>>can
>>> >>run
>>> >>it once again, but there is possibility that will be on Sunday.
>>> >>
>>> >>Any chance to try by you also maven build with command line above ?
>>>I'm
>>> >>wondering if you also experience such issue as Santanu. Personally I
>>> >>didn't
>>> >>have it yesterday.
>>> >
>>> >I will try it when I get through this fix for the TLF branch.  For
>>>me, I
>>> >believe I've always had to separately use the Mavenizer to get
>>>com.adobe
>>> >artifacts.  I'm not sure if that's expected or not.  You might want to
>>> >check the archives to see if there is any mention of how to get
>com.adobe
>>> >artifacts.  I think there maybe issues with not having recent versions
>of
>>> >Maven and/or whether to use settings-template.xml.
>>> >
>>> >I don't want to take the time to help you look into this right now.
>>> >
>>> >Thanks,
>>> >-Alex
>>> >
>>>
>>>
>>

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

[Alex Harui]

Hi Om, 

Command-line sounds great if you can do it.  Let us know when you are done
with the NPM stuff so we can move forward with the release.

Thanks,
-Alex

On 5/30/17, 7:15 PM, "Josh Tynjala"  wrote:

>I could not find a way to parse extra command line arguments with an npm
>install command. If you could figure that out, that would be better!
>
>- Josh
>
>On May 30, 2017 6:56 PM, "OmPrakash Muppirala" 
>wrote:
>
>Awesome! I had this as a TODO.  I can at least help with testing this out
>now.
>
>I can also push the bits to the npm registry when we go live with the
>release.
>
>Also, what if we pass them as command line args? Do you mind if I make
>this
>change?
>
>Thanks,
>Om
>
>
>On May 30, 2017 11:47 AM, "Josh Tynjala"  wrote:
>
>I got the npm version of FlexJS 0.8.0 working with a couple of minor
>fixes.
>It looks good to go for the release!
>
>I also simplified how to test the npm version locally from the
>flex-utilities repo to make it download nightly builds (previously, you
>needed to manually change some JS code):
>
>cd flex-utilities
>npm config set flexjs:flexjs_custom_url
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapacheflex
>build.cloudapp.net%3A8080%2Fjob%2Fflex-asjs_release_branch%2F=02%7C01
>%7C%7C8ea9163b8a4f40e1e30c08d4a7cafb9b%7Cfa7b1b5a7b34438794aed2c178decee1%
>7C0%7C0%7C636317937627432987=ezcbLDOwjYz3oG3dO8RDtA71Xv%2FfKUgG77enA
>Use3JY%3D=0
>lastSuccessfulBuild/artifact/out/apache-flex-flexjs-0.8.0-bin.zip
>npm config set flexjs:falcon_custom_url
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapacheflex
>build.cloudapp.net%3A8080%2Fjob%2Fflex-falcon%2520release%2520branch%2F
>ta=02%7C01%7C%7C8ea9163b8a4f40e1e30c08d4a7cafb9b%7Cfa7b1b5a7b34438794aed2c
>178decee1%7C0%7C0%7C636317937627432987=jiM4u89B6Ea%2F4cRLi0VwSMc
>%2FspYvxcIBFBtsjBw%3D=0
>lastSuccessfulBuild/artifact/out/apache-flex-falconjx-0.8.0-bin.zip
>npm install -g ./npm-flexjs/
>
>Those are the URLs to the latest builds from the release branches. It
>could
>be used with regular nightly builds from the develop branch and release
>candidate builds too.
>
>When you're done, you should delete the configuration keys:
>
>npm config delete flexjs:flexjs_custom_url
>npm config delete flexjs:falcon_custom_url
>
>- Josh
>
>On Fri, May 26, 2017 at 4:51 PM, Josh Tynjala 
>wrote:
>
>> I can test installing FlexJS 0.8.0 with NPM early next week, if no one
>> else finds the time. I don't remember the exact process of testing
>>locally
>> with a nightly build of FlexJS, but I think I figured it out pretty
>>easily
>> when I made some tweaks a while back.
>>
>> - Josh
>>
>> On Fri, May 26, 2017 at 2:43 PM, Alex Harui 
>> wrote:
>>
>>> I'm still working on the TLF fix.  I saw Josh's commit about Node
>support.
>>> Does someone have time to test out our Node/NPM stuff?  It might need
>some
>>> tuning after this dual-compile feature.
>>>
>>> -Alex
>>>
>>> On 5/26/17, 8:29 AM, "Alex Harui"  wrote:
>>>
>>> >
>>> >
>>> >On 5/26/17, 8:07 AM, "piotrz"  wrote:
>>> >
>>> >>Alex,
>>> >>
>>> >>That is correct I have FALCON_HOME set up. I will try as fast as I
>>>can
>>> >>run
>>> >>it once again, but there is possibility that will be on Sunday.
>>> >>
>>> >>Any chance to try by you also maven build with command line above ?
>>>I'm
>>> >>wondering if you also experience such issue as Santanu. Personally I
>>> >>didn't
>>> >>have it yesterday.
>>> >
>>> >I will try it when I get through this fix for the TLF branch.  For
>>>me, I
>>> >believe I've always had to separately use the Mavenizer to get
>>>com.adobe
>>> >artifacts.  I'm not sure if that's expected or not.  You might want to
>>> >check the archives to see if there is any mention of how to get
>com.adobe
>>> >artifacts.  I think there maybe issues with not having recent versions
>of
>>> >Maven and/or whether to use settings-template.xml.
>>> >
>>> >I don't want to take the time to help you look into this right now.
>>> >
>>> >Thanks,
>>> >-Alex
>>> >
>>>
>>>
>>