Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

Maybe I don't understand your proposal. Currently I think you can say that there are exceptions for "src" and "src/main/flex". AIUI, your proposal is that only "src/main/flex" would be handled differently. -Alex On 6/1/17, 12:13 PM, "Josh Tynjala" wrote: >Why would you

Re: [FlexJS] Accordion broken

I've checked in my changes to the Accordion components. It still is not working correctly and I cannot figure out what is happening. The used as the data to the Accordion are being placed as children of AccordionItemRenderers which are themselves Panels. So there are two TitleBars present per

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

Why would you need to stop and reconfigure all of those projects? With the change that I suggested, all of your projects that use "src" would continue to work just fine with no changes required. Yes, I'm perfectly happy making any changes after this release. - Josh On Thu, Jun 1, 2017 at 12:05

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

Believe me, I am not worried about perfection here. I am saying that if we make changes, we should allow the set of patterns to be configurable so we don't have to change the compiler to add new patterns. I already have a large set of projects with only "src" and I would prefer not to have to

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

If there are other nested source directory structures recommended as standard practice by opinionated tools, similar to how Maven use "src/main/flex", then sure, let's add them as we become aware of them. "srcx/main/flex" would indeed not be solved by my recommended change. However, "source",

Re: [FlexJS] Accordion broken

Harbs wrote > \2. The Collapse bead can only infer that it’s collapsed by the fact that > the size is the collapsed size — which only makes sense if the size is > set. Shouldn't .height return the measured height, regardless of whether it was explicitly set? -- View this message in context:

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

If we allow one exception, why not more than one? What if we add an "outputFolderExceptions" list and default it to just contain "src/main/flex". Then I could add "src" in my SDK installs to get what I want. Still not sure how it solves the original problem though. If someone has a

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

If we do as I suggest, there would no longer be a list of patterns. I want to allow *any* folder name. That's what I mean by generalizing. Just automatically put the "bin" directory relative to the parent directory of the main source file. (with one exception: Maven-style project structures with

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

I just want to optimize for a couple of common cases in order to save me and maybe other folks some time. If for some reason I need to compile a Flash Builder project from the command-line or Ant or Java debugger, I don't have to remember to set the -output parameter. I used to get FB projects

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

I'm not sure that I understand why you mentioned changing Flash Builder's default source path. That seems mostly tangential here. I'm saying that the compiler shouldn't care whether it's named "src", "source", or "whatever-i-want-to-call-it". It should simply default to putting "bin" in the

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

I think "src" is for Flash Builder. I don't know what it would take to get FB to default to something else. I know I have lots of projects with just a "src" folder. I agree it is confusing. We could output a warning or error if you haven't specified -output, -js-output and don't have "src" or

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

I think I had some trouble trying to get -output to accept a directory for a JS-only project, and that's when I figured out that -js-output exists. Maybe I was doing something wrong at the time. Or maybe it didn't quite work properly yet. Although, I still think it's confusing to those who don't

Re: [4/7] git commit: [flex-asjs] [refs/heads/develop] - use === and !== rather than == and !=

The same if() logic applies in ActionScript as well. I've been caught by this one before: If (“0”) is true If (0) is false -Alex On 6/1/17, 12:44 AM, "piotrz" wrote: >Ahh So much love to JS :) > > > >- >Apache Flex PMC >piotrzarzyck...@gmail.com >-- >View

Re: [FlexJS] Accordion broken

With some guidance from Alex, I have the Accordion "working". The problem now is that it appears as a Panel-in-Panel for each item. For example, with two Panels in the dataProvider, there are two bars and whichever is "open" or "selected" shows the Panel from the dataProvider along with its title

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

And if you just use -output and not -js-output the bin folder will be where you specified -output, and if you specify -output=somefolder\somefile.swf the output will be in somefolder\bin. The logic is trying to say: 1) If you specify -output as a SWF, we will use the parent folder of the SWF 2)

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

In that case, the SWF will use the -output option: mxmlc -output=path/to/MyProject.swf -js-output=. source/MyProject.as - Josh On Thu, Jun 1, 2017 at 7:30 AM, piotrz wrote: > Ahh..Ok now it is clear. What about if we have > -compiler.targets=JSFLEX,SWF - > So

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

Ahh..Ok now it is clear. What about if we have -compiler.targets=JSFLEX,SWF - So -js-output will be also the place where SWF file will landed? - If yes in that case this param could have different name. Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

I'm not sure if I was clear, but the -js-output option already exists, and it may be used today. - Josh On Thu, Jun 1, 2017 at 6:51 AM, piotrz wrote: > Hi Santanu, Josh, > > +1 for having option -js-output=. to configure this one. If those changes > need to be done

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

Even if the src/main/flex is the default for maven flex project, it should already be configurable … same as the output directory. Chris Am 01.06.17, 15:30 schrieb "Josh Tynjala" : I ran into this issue too because I frequently use "source" instead of "src".

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

Hi Santanu, Josh, +1 for having option -js-output=. to configure this one. If those changes need to be done on compiler sight maybe jira should be raised ? Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

I ran into this issue too because I frequently use "source" instead of "src". It is indeed true that "src" is hard coded, along with "src/main/flex" (for Maven). I wonder if it would be better to simply produce bin in the current working directory by default, instead of having these two hard

Re: dual issues

When they're defined in the *-config.xml files, they'll be picked up automatically without any special code in VSCode. However, now that you mention it, I need to allow app developers to customize these in asconfig.json too. - Josh On Jun 1, 2017 12:04 AM, "Alex Harui"

[FlexJS] Why FlexJS compiler statically looks for 'src' folder

Hello, I'm using current release branch 0.8.0 FlexJS SDK. I noticed running FlexJS project compilation always produce me 'bin' folder to somewhere unexpected when I have source folder named anything but 'src'. I have my project's source folder in project root named "*srcx*" and contains on

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

Thanks Alex! We are blue again [1] :) [1] https://builds.apache.org/view/E-G/view/Flex/job/FlexJS%20Pipeline/job/release0.8.0/19/ Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [4/7] git commit: [flex-asjs] [refs/heads/develop] - use === and !== rather than == and !=

Ahh So much love to JS :) - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/Re-4-7-git-commit-flex-asjs-refs-heads-develop-use-and-rather-than-and-tp61973p61989.html Sent from the Apache Flex Development

Re: dual issues

Hi Harbs, Great news! This approach us to release! Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/dual-issues-tp61955p61988.html Sent from the Apache Flex Development mailing list archive at

Re: dual issues

My bad. I accidentally overwrote my copy of BasicJS.swc. After fixing some issues, I got my app to run using the latest dual changes. All in all, switching to dual went a lot better than I expected. Great work, Alex! I think the switch to the dual approach was the right one. There’s still

Re: [4/7] git commit: [flex-asjs] [refs/heads/develop] - use === and !== rather than == and !=

HI, > if(restrict) it's a good thing. Not really a good thing in general as for instance: if(“”) is false if(“0”) is true if(NaN) is false > Thinking about what to do with null/undefined - It seems to be resolution - > isn't it? It casts a much wider net than just null and undefined. > Maybe

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

No worries, I was just about to push it when your email came through. Hopefully it will fix it. I'm at the end of my day so won't have any more time to spend on it. -Alex On 5/31/17, 11:52 PM, "piotrz" wrote: >Ahh! And I didn't notice that! Damn! :) > >Thank you! >

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

Hi Alex, I will look into this jenkins job to see why we do not get from that emails. Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/LAST-CALL-Release-FlexJS-FalconJX-0-8-0-tp61275p61984.html

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

Ahh! And I didn't notice that! Damn! :) Thank you! - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/LAST-CALL-Release-FlexJS-FalconJX-0-8-0-tp61275p61983.html Sent from the Apache Flex Development mailing

Re: [4/7] git commit: [flex-asjs] [refs/heads/develop] - use === and !== rather than == and !=

If I correct understand your links making if(restrict) it's a good thing. I don't understand this one "get messy fast" ? :) Thinking about what to do with null/undefined - It seems to be resolution - isn't it? Maybe not exactly for the case, but in general? Thoughts? Piotr - Apache

Re: dual issues

Josh, there are new compiler options like js-external-library-path, js-library-path, swf-library-path, swf-external-library-path. Does your VSCode integration handle these? -Alex On 5/31/17, 8:42 PM, "Josh Tynjala" wrote: >As I understand it, the compiler should just

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

Hi Piotr, It might be time for you to learn how to tweak the builds so they send emails on failure. We could probably use more folks who know how to do it. -Alex On 5/31/17, 11:52 PM, "Alex Harui" wrote: >I just saw that and pushed a fix. > >On 5/31/17, 10:45 PM,

Re: [4/7] git commit: [flex-asjs] [refs/heads/develop] - use === and !== rather than == and !=

Hi, > if (restrict) {} Style best to be avoided IMO. Lots of things are truthy / falsy in JS. [1] For instance empty string is false and so is NaN and it gets messy fast. [2] Thanks, Justin 1. https://developer.mozilla.org/en-US/docs/Glossary/Falsy 2.

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

I just saw that and pushed a fix. On 5/31/17, 10:45 PM, "piotrz" wrote: >It's complaining in SWF sight on missing Geolocation class [1] - This is >my >local build SWF only. I've checked couple of things but didn't find root >cause. >

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

Hi, > What will happen if some of those values will be null ? For example > styleable.style ? Styleable could be I guess but there wasn’t a null check for it before. Styable.style is unlikely to be null. All test still pass and I’ve tested this with several applications and it never has a

Re: [4/7] git commit: [flex-asjs] [refs/heads/develop] - use === and !== rather than == and !=

Understand. :) I'm wondering whether all cases are not resolves something like that: if (restrict) {} Just thinking loud, cause I'm fine with your changes here. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [4/7] git commit: [flex-asjs] [refs/heads/develop] - use === and !== rather than == and !=

Hi, > What will happen if "restrict" will be undefined ? A null restrict according to the comment mean any characters means nothing is restricted same as an empty string and that make sense. Undefined is well undefined :-) having an undefined restrict doesn’t really make any sense so I don’t

Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome

Hi Justin What will happen if some of those values will be null ? For example styleable.style ? Piotr 2017-06-01 7:58 GMT+02:00 : > make getValue a lot faster - 30ms down to 5ms in a complex app for JS in > Chrome > > > Project:

Re: [4/7] git commit: [flex-asjs] [refs/heads/develop] - use === and !== rather than == and !=

Hi Justin, What will happen if "restrict" will be undefined ? Piotr 2017-06-01 7:58 GMT+02:00 : > use === and !== rather than == and != > > > Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo > Commit:

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

It's complaining in SWF sight on missing Geolocation class [1] - This is my local build SWF only. I've checked couple of things but didn't find root cause. D:\flex_sdk\Sources\flex-asjs\examples\flexjs\MobileMap\src\main\flex\MobileMap.mxml(35): col: 30 Error: Type was not found or was not a