Re: git commit: [flex-asjs] [refs/heads/develop] - Add FileUploaderWithResponseData

See upthread my response to Pitor > I was thinking the same thing but it’s complicated to make it into a bead. > It would have to catch the ‘complete’ event and record the response data > before anyone else does. Since we don’t have event listener priorities I > don’t know how to do that. I hope

Re: [FalconJX] Debugging minified code

Try using -js-compiler-option. It should pass along the various options in the article to GCC. I haven't had to debug anything really big, but I often delete the source map, add line breaks to the area of code that is failing and step through it. Painful for sure, but often successful. HTH,

Re: [1/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35337 place tool tip anchor point in the centre rather than the bottom right

Yes, I think we need more variants. Maybe the default tooltip bead should be slightly fatter and have x/y offsets or some other way to dictate the relative position. There is no one right answer. But changing code that is being used in the examples is not a good practice. Framework developers

Re: git commit: [flex-asjs] [refs/heads/develop] - Add FileUploaderWithResponseData

What problem are you referring to? -Alex On 7/11/17, 7:03 PM, "yishayw" wrote: >Since this type of problem has been bugging me for a while (see also >FileBrowserWithFilter which raises the same question) I started reading >about this. To me it seems that we may need

Re: git commit: [flex-asjs] [refs/heads/develop] - Uploads are assumed to be POST

Reflection support was opt-in. Hopefully it still is. As in, if your app doesn't call any code that uses the reflection data structures they are not in the minified output. DataBinding in general requires exports. Any use of bracket access does as well. But yes, I believe a smarter compiler

RE: git commit: [flex-asjs] [refs/heads/develop] - Add FileUploaderWithResponseData

Since this type of problem has been bugging me for a while (see also FileBrowserWithFilter which raises the same question) I started reading about this. To me it seems that we may need aspects [1]. The JS implementation is supposed to be easy, but AS3 less so [2], though work has been done [3] on

Re: [FlexJS]MouseEvent.ROLL_OVER (was Re: [2/5] git commit...)

Hi, > Maybe I'm not understanding the scenario. I assumed that the problem > Justin is trying to fix is that you roll over a component, the component > shows a tooltip, but the tooltip appears under the mouse so you get a > rollout of the component and rollover the tooltip. The rollout of the >

Re: git commit: [flex-asjs] [refs/heads/develop] - Uploads are assumed to be POST

I'll try those things, I have not tried any of those options so far. Future need to support modules has been mentioned as a reason for keeping @export before. Another is to support reflection (in its current form). Reflection support probably needs to be opt-in, I think this has been discussed

Re: [1/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35337 place tool tip anchor point in the centre rather than the bottom right

Hi, > Why are you assuming that this behavior is wrong? Because if you have two components side by side and mouse over the first one the tool tip appears below the second one. If you have something on the right of the screen and roll over it you can’t see any tooltip. If you have something at

[FalconJX] Debugging minified code

One of the difficult tasks is trying to figure out what’s going wrong in minified code. I found an article on tips for that.[1] There are a few Closure options to make the minified code more legible. Is there a way to have Falcon use those options when sending the code to Closure? Thanks,

Re: [FlexJS]Runtime type checking and PAYG

Yeah. The check I was going to do is actually pretty simple: if(bytes && typeof bytes.byteLength != "number") throw new TypeError("BinaryData can only be initialized with ArrayBuffer”); ba = bytes ? bytes as ArrayBuffer : new ArrayBuffer(0); It’s not 100% foolproof, but if someone wants to

Re: [FlexJS]Runtime type checking and PAYG

In application development I would normally do this type of thing inside CONFIG::dev blocks, or similar, so having the possibility, as described, to exclude development-only code (extra type checking, null checks etc) would definitely also be helpful PAYG-wise from within the framework. The

Re: [FlexJS]Runtime type checking and PAYG

oops, that last idea won't work so well with @flexjsignorecoercion ArrayBuffer above it :) On Wed, Jul 12, 2017 at 9:54 AM, Greg Dove wrote: > > In application development I would normally do this type of thing inside > CONFIG::dev > blocks, or similar, so having the

Re: git commit: [flex-asjs] [refs/heads/develop] - Uploads are assumed to be POST

Hi Greg, There probably is too much use of @export. @const is probably more correct than @export — as long as we are sure that there’s no use of bracket notation anywhere. I’d be interested in hearing your findings. Personally, I’m not sure there’s a lot of value to be using @export at all

Re: [FlexJS]Runtime type checking and PAYG

Sounds interesting. I’m not sure I understand how this would work. I am willing to explore this with a bit of direction. I don’t see a debug flag listed here: https://github.com/google/closure-compiler/wiki/Annotating-JavaScript-for-the-Closure-Compiler

Re: [FlexJS]Runtime type checking and PAYG

Ah. This is helpful.[1] Basically, we could use @define or maybe goog.DEBUG. I’m not clear on whether goog.DEBUG code is removed if goog.DEBUG is false. [1]https://stackoverflow.com/questions/11402218/removing-debug-code-from-inside-a-function-using-closure-compiler-simple-optimis

Re: [FlexJS]Runtime type checking and PAYG

I've mentioned the notion of debug-mode beads on the mailing list a couple of times. It would be great to see this idea explored more. By definition, now that you've debugged your code, any type-checking code path becomes unused in production, which is what we don't want. But adding code paths

Re: [FlexJS] Question about Events/possible bugs

Thanks for the clarification, and for your fixes Harbs, I will make the other changes to add the import to cover js build scope for ApplicationBase and the two layout beads today. On Tue, Jul 11, 2017 at 4:40 AM, Josh Tynjala wrote: > That sounds reasonable. > > - Josh

Re: git commit: [flex-asjs] [refs/heads/develop] - Uploads are assumed to be POST

Guys, we certainly have been here before. >From a js release 'size' perspective, I don't think it matters whether we use constants or liteterals, I think the main difference is that if the static const exists it will also be included in the release output as I expect it has an @export annotation.

[FlexJS]Runtime type checking and PAYG

I just wasted over an hour because I was initializing a BinaryData with a string instead of an ArrayBuffer. I would like to add a typecheck to the bytes argument in the BinaryData constructor to throw an error if something other than an ArrayBuffer is provided. We cannot use strict typing to

Re: [1/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35337 place tool tip anchor point in the centre rather than the bottom right

Why are you assuming that this behavior is wrong? Don’t you think a functional change should require discussion? Thanks, Harbs > On Jul 11, 2017, at 8:40 AM, jmcl...@apache.org wrote: > > Repository: flex-asjs > Updated Branches: > refs/heads/develop e93c11d7c -> 1d73de00b > > > FLEX-35337

RE: [FlexJS] Name space question

Hi Alex, Thank you for your help; the change added to POM worked. Since my Flex 3 program uses TitleWindow, PopUpManager, Panel, Canvas, SearchButton, etc., I am trying to learn these then convert the original Flex 3 source files one by one. Best Regards, Allen -Original Message- From:

Re: [FlexJS] Name space question

Hi Piotr, Flat borrows lots of components from the Basic package. So it may not have Panel code in the source folder, but it can still have a Panel. Allen probably needs to add the Flat artifact to his pom.xml. That said, I don't think Flat is fully implemented on all components in its

RE: [FlexJS] Name space question

Hi Piotr, After checking through the flat module, I didn't find something equivalent to Panel. Checking through this is not a very elegant way, but it is a lot more direct. Thanks, Allen -Original Message- From: piotrz [mailto:piotrzarzyck...@gmail.com] Sent: Tuesday, July 11, 2017

Re: [FlexJS]MouseEvent.ROLL_OVER (was Re: [2/5] git commit...)

Hi Piotr, Maybe I'm not understanding the scenario. I assumed that the problem Justin is trying to fix is that you roll over a component, the component shows a tooltip, but the tooltip appears under the mouse so you get a rollout of the component and rollover the tooltip. The rollout of the

Re: Flash Builder desktop debugging issue

Thanks a lot for your help. I have created a new project and the same problem arises so it has nothing to do with compiler options. I created a project DebugTest and in creationComplete I've put two traces and a breakpoint. The debugger does not connect and shows: Process terminated without

Re: git commit: [flex-asjs] [refs/heads/develop] - Uploads are assumed to be POST

+1. I also think that we have bigger fish to fry first. My point was not to force one way or the other. Rather that the way it currently stands there’s a valid reason to use string literals. I was not suggesting changing anything. Thanks, Harbs > On Jul 11, 2017, at 6:33 PM, Josh Tynjala

Re: [FlexJS] Name space question

Hi Allen, The case is that maybe in Flat module there is no equivalent to Panel from Basic module. If I would like to use something to my application and I'm not sure whether it exists I'm checking it directly in module folder. [1] That's probably ugly way, but we don't have ASDoc app online as

Re: [FlexJS]MouseEvent.ROLL_OVER (was Re: [2/5] git commit...)

pointer-events:none; Definitely the right way to go. > On Jul 11, 2017, at 6:01 PM, piotrz wrote: > > Alex, > > What do you mean by Mouse "transparent" ? We still need to use some event > mouse (enter/leave) where after roll over on the element tooltip should be >

Re: [FlexJS]MouseEvent.ROLL_OVER (was Re: [2/5] git commit...)

To be clear: That css should be applied to the ToolTip element. > On Jul 11, 2017, at 6:54 PM, Harbs wrote: > > pointer-events:none; > > Definitely the right way to go. > >> On Jul 11, 2017, at 6:01 PM, piotrz wrote: >> >> Alex, >> >> What

Re: [FlexJS]MouseEvent.ROLL_OVER (was Re: [2/5] git commit...)

That should have been MOUSE_ENTER rather than MOUSE_OVER. > On Jul 11, 2017, at 6:58 PM, Harbs wrote: > > It’s been supported by every browser since 2014. I think we should switch to > that. > > I was pondering whether we should standardize on ROLL_OVER or MOUSE_OVER. I

Re: [FlexJS]MouseEvent.ROLL_OVER (was Re: [2/5] git commit...)

It’s been supported by every browser since 2014. I think we should switch to that. I was pondering whether we should standardize on ROLL_OVER or MOUSE_OVER. I was thinking that we could have both. > On Jul 11, 2017, at 6:14 PM, Alex Harui wrote: > > At one point in

RE: [FlexJS] Name space question

Hi Alex, I am using Maven. I am trying to read up the document about Maven POM; but so far still have not found an example that looks applicable yet. Regards, Allen -Original Message- From: Alex Harui [mailto:aha...@adobe.com.INVALID] Sent: Tuesday, July 11, 2017 1:25 AM To:

Re: [FlexJS]MouseEvent.ROLL_OVER (was Re: [2/5] git commit...)

Alex, What do you mean by Mouse "transparent" ? We still need to use some event mouse (enter/leave) where after roll over on the element tooltip should be shown. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: Flash Builder desktop debugging issue

Hi Fréderic, The actual debugger is the same in Flash Builder. Flash Builder has a built-in debugger that tries to connect to a debugger Flash Player in the browser, or to the Air Debug Launcher (ADL). When you Run/Debug a Desktop app in Flash Builder, I think it should always launch ADL. I

Re: git commit: [flex-asjs] [refs/heads/develop] - Uploads are assumed to be POST

That sounds like the proper way to handle this! We should be able to reference constants in our ActionScript so that we can get compile-time errors from typos, while the compiler makes sure that generated JavaScript can be properly minified. - Josh On Tue, Jul 11, 2017 at 8:20 AM, Alex Harui

Re: Flash Builder desktop debugging issue

Inside the your SDK, the adl executable is used to debug AIR apps. (adl = AIR debug launcher) If nothing in your SDK changed, then it's probably related to compiler arguments or something related to building the SWF. - Josh On Tue, Jul 11, 2017 at 8:11 AM, Fréderic Cox

Re: git commit: [flex-asjs] [refs/heads/develop] - Uploads are assumed to be POST

AIUI, there is a cost in the minified JS to using constants. However, there is a cost to screwing up the typing of a string literal as well. The best answer for now, IMO, is to not care whether folks use constants or string literals. There are much bigger fish to fry. I don't want to see

Re: [FlexJS]MouseEvent.ROLL_OVER (was Re: [2/5] git commit...)

At one point in time, mouseenter was only supported by IE. If we agree it is safe to use on all of our target browsers, we can switch to using it. I don't think it will solve the flicker problem. I think the tooltips need to be "mouse transparent". My 2 cents, -Alex On 7/11/17, 4:32 AM,

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

The browser does not support RollOver/RollOut so we are running code to emulate it, so wouldn't worry about the performance. The browser's implementation is likely faster than our JS implementation.Back when I wrote this code, it wasn't clear that we could use mouseEnter/mouseLeave. If folks

Re: Flash Builder desktop debugging issue

Thanks for the replies. The problem is related to AIR debugging on desktop. I did not change my Apache Flex SDK so I really can't understand what caused the problem. Which debugger is used for AIR and where is it located? On Tue, Jul 11, 2017 at 3:41 PM, Harbs wrote: >

Re: Flash Builder desktop debugging issue

Same for me. > On Jul 11, 2017, at 4:18 PM, Jeffry Houser wrote: > > To debug a browser based applications, I use Firefox. I couldn't get a > debugger to work in any other browser.

Re: Flash Builder desktop debugging issue

As a point of clarification, are you trying to debug a desktop AIR Application or a Browser based application? You mentioned you downloaded debug players for browsers, but that you're trying to debug an AIR Desktop application. The two things should be completely unrelated, so I'm not

Re: [FlexJS]MouseEvent.ROLL_OVER (was Re: [2/5] git commit...)

My point with tooltip is that you probably don’t need bubbling for tooltips and it causes more events than are needed. There’s use cases for both mouseover and mouseenter. Resolving Justin’s issues using mouseenter would require a couple of things: 1, We would need mouseeenter (and mouseleave)

Re: Flash Builder desktop debugging issue

If you're having trouble with AIR, the Flash Player version installed shouldn't matter. Have you double checked your compiler options? You should make sure your project isn't setting -debug=false somehow. I forgot that I had done that once! - Josh On Jul 11, 2017 4:48 AM, "Fréderic Cox"

Re: git commit: [flex-asjs] [refs/heads/develop] - Uploads are assumed to be POST

Here’s what is output in the minimized code: function

Flash Builder desktop debugging issue

Hi, I have a problem since a few days that is driving me absolutely nuts. Flash Builder 4.7 is unable to connect to the debugger. It works for web projects but not for AIR desktop projects. I have tried numerous things like cleaning workspace, restarting FB, .. nothing works. I have downloaded

Re: git commit: [flex-asjs] [refs/heads/develop] - Uploads are assumed to be POST

Hi, > As it stands now, use of constants result in more JS code after compiled. Debug yes but not optimised / release. > It’s possible that this can be optimized, but currently the most efficient JS > code is produced if using string literals rather than constants. (The Google > compiler

CSS compiler issues

I just created a couple of JIRAs on compiler issues that have been bugging me for a while.[1][2] Neither of these are super-important, but it would be nice if it worked better. Harbs [1]https://issues.apache.org/jira/browse/FLEX-35340

Re: [FlexJS]MouseEvent.ROLL_OVER (was Re: [2/5] git commit...)

Ahh..Yes. Maybe let's live it as is. Maybe if you will use in your app tooltips more extensively we will see. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [FlexJS]MouseEvent.ROLL_OVER (was Re: [2/5] git commit...)

mouseover is needed if you need bubbling. That’s sometimes the correct behavior. > On Jul 11, 2017, at 1:19 PM, piotrz wrote: > > It seems to. MouseOver is launching really often - Maybe Enter/Leave would be > really better. > Need test to see whether we have same

Re: [FlexJS]MouseEvent.ROLL_OVER (was Re: [2/5] git commit...)

It seems to. MouseOver is launching really often - Maybe Enter/Leave would be really better. Need test to see whether we have same behavior having Enter/Leave as we have with MouseOver currently. Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [FlexJS]MouseEvent.ROLL_OVER (was Re: [2/5] git commit...)

Here is an example of what happens using rollOver and rollOut in Flash.[1] It seems like the same as enter/leave in HTML. [1]http://www.zedia.net/2008/difference-between-mouseeventroll_over-and-mouseeventmouse_over-in-as3/

RE: git commit: [flex-asjs] [refs/heads/develop] - Uploads are assumed to be POST

Normally I would agree, but I was trying to be strict about PAYG in these commits. Let’s see what the others say. From: piotrz Sent: Tuesday, July 11, 2017 12:05 PM To: dev@flex.apache.org Subject: RE: git commit: [flex-asjs]

Re: git commit: [flex-asjs] [refs/heads/develop] - Uploads are assumed to be POST

Thanks for explanation. I will try to be careful in usage. I think this natural move to use constant is more from AS3 world than JS :) Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: git commit: [flex-asjs] [refs/heads/develop] - Uploads are assumed to be POST

This is worthy of a discussion. As it stands now, use of constants result in more JS code after compiled. It’s possible that this can be optimized, but currently the most efficient JS code is produced if using string literals rather than constants. (The Google compiler created variables for

Re: [FlexJS]MouseEvent.ROLL_OVER (was Re: [2/5] git commit...)

Harbs, I have found following examples [1][2][3]. Maybe it will help us. [1] https://siongui.github.io/2012/08/07/javascript-compare-mouseenter-mouseleave-mouseover-mouseout/ [2] https://siongui.github.io/code/javascript-mouseenter-mouseleave/mouseenterleave.html [3]

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

Ok! Thanks! - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/Re-2-5-git-commit-flex-asjs-refs-heads-develop-FLEX-35338-stop-cursor-from-spinning-CPU-from-spiking-tp63061p63079.html Sent from the Apache Flex

RE: git commit: [flex-asjs] [refs/heads/develop] - Uploads are assumed to be POST

I just think that we should use const whenever we can, but won't fight for that if no one think similar. :) If I found such code around my interest my natural move would be change it :) Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

Hi, > Even if it's working now, Harbs did research and find out that MouseEnter is > a better for that You do understand that it’s still using the same event as before I didn’t change that. > - For what element did you use tooltip ? Does it matter ? Probably not but I was using an image. > -

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

Maybe worth to check how it is handled in MDL. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

RE: git commit: [flex-asjs] [refs/heads/develop] - Uploads are assumed to be POST

I was trying to save an extra import. Will wait for more thoughts on this. From: Piotr Zarzycki Sent: Tuesday, July 11, 2017 11:15 AM To: dev@flex.apache.org Subject: Re: git commit: [flex-asjs] [refs/heads/develop] - Uploads are

[FlexJS]MouseEvent.ROLL_OVER (was Re: [2/5] git commit...)

I’m breaking this off into its own thread because it deserves a separate discussion. After looking into how ROLL_OVER/ROLL_OUT events work, I see that it’s being handled pretty oddly. MouseEvent has a “installRollOverMixin” function which adds a mouseover event to window and fires ROLL_OVER

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

Hi, Even if it's working now, Harbs did research and find out that MouseEnter is a better for that, so I will spent my time to test your scenario. Maybe tomorrow. Before that couple of questions: - For what element did you use tooltip ? Does it matter ? - " having the tooltip smaller than the

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

Thanks. I just looked at the code to see why that would not work, and I see that the tool tip is being added to the “PopUpHost” rather than the element. I’m not sure whether that’s the best way to handle it. One the one hand, being that the tool tip is a higher level element, we’re getting

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

Hi, > Did you try mouseenter? (See my other responses) Yes and no it didn’t but perhaps you can get it to work that way. Feel free to do so. If you do make any changes suggested test cases to test for include: - mousing over the tooltip itself - having the tooltip smaller than the object it

Re: git commit: [flex-asjs] [refs/heads/develop] - Uploads are assumed to be POST

Hi Yishay, I think you could use constant here -> HTTPConstants.POST Thanks, Piotr 2017-07-11 10:09 GMT+02:00 : > Repository: flex-asjs > Updated Branches: > refs/heads/develop cc098932c -> 3b5053f91 > > > Uploads are assumed to be POST > > > Project:

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

No. I’m wrong. First of all, it’s mouseenter rather than rollover, and it seems like it’s fired more than mouseover.[1] https://developer.mozilla.org/en-US/docs/Web/Events/mouseenter That does beg the question though: Are the

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

I can’t make up my mind… ;-) I’m not sure why the MDN article says the mouseenter can have more CPU problems. It seems like mouseover should be dispatched more because it bubbles up from all sub-elements.[2] It seems like mouseover is identical to mouseOver in Flash and mouseenter is identical

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

Did you try mouseenter? (See my other responses) It seems like that should solve the problem. > On Jul 11, 2017, at 11:01 AM, Justin Mclean wrote: > > Hi, > > I not sure how this could be consider "just in case" when previous the > tooltip didn’t work and had an

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

Hi, I not sure how this could be consider "just in case" when previous the tooltip didn’t work and had an infinite loop? Before it was incorrectly destroying and recreating the tooltip endlessly when you were still inside the UI element. You got a horrible flickering / strobing as it created

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

Shouldn’t the event be triggered by rollover rather than mouseover? That seems like the issue to me… > On Jul 11, 2017, at 10:13 AM, Alex Harui wrote: > > This seems like "just-in-case" code. I could see that it might be needed > in a different bead for Express though. > >

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

Hi Justin, Are you saying a rollOut is being dispatched when you haven't rolled out of the tooltip? WOuldn't that be a problem in the rollout logic? -Alex On 7/10/17, 11:14 PM, "Justin Mclean" wrote: >Hi, > >And my last check has fixed the issue so should be all good. >

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

This seems like "just-in-case" code. I could see that it might be needed in a different bead for Express though. Without this change, is there an infinite loop somewhere? Thanks, -Alex On 7/10/17, 10:40 PM, "jmcl...@apache.org" wrote: >FLEX-35338 stop cursor from spinning

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

Hi, And my last check has fixed the issue so should be all good. Thanks, Justin

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

Hi, JFYI still work in progress the calculations around outside need a little bit more work as I’m reasonably sure it need to take into account the x, y co-ords and check left and top boundaries as well. I’ll get to that later today / tomorrow. Thanks, Justin