Re: [FlexJS] ASF SonarQube available (Beta-Testing)

2016-12-27 Thread Alex Harui
On 12/27/16, 10:51 PM, "Yishay Weiss" wrote: >Nice stuff, Chris. > > > >All the bugs in the framework seem to be about failing to override the >clone() method in Event. If I understand correctly, this is mainly to >preserve state in case an event is re-dispatched. Is

RE: [FlexJS] ASF SonarQube available (Beta-Testing)

2016-12-27 Thread Yishay Weiss
ahead and fix these bugs? From: Christofer Dutz<mailto:christofer.d...@c-ware.de> Sent: Tuesday, December 27, 2016 9:50 PM To: dev@flex.apache.org<mailto:dev@flex.apache.org> Subject: Re: [FlexJS] ASF SonarQube available (Beta-Testing) Ok … stats are online: Compiler: https://build

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

2016-12-27 Thread Carlos Rovira
Thanks Chris for the effort on making this! :) 2016-12-27 20:50 GMT+01:00 Christofer Dutz : > Ok … stats are online: > > Compiler: https://builds.apache.org/analysis/dashboard/index/2461 > Typedefs: https://builds.apache.org/analysis/dashboard/index/20905 > Framework:

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

2016-12-27 Thread Christofer Dutz
Ok … stats are online: Compiler: https://builds.apache.org/analysis/dashboard/index/2461 Typedefs: https://builds.apache.org/analysis/dashboard/index/20905 Framework: https://builds.apache.org/analysis/dashboard/index/20942 Happy reading, Chris Am 27.12.16, 09:02 schrieb "Alex Harui"

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

2016-12-27 Thread Alex Harui
On 12/26/16, 11:50 AM, "Josh Tynjala" wrote: >I suspect that a big chunk of the duplicate code is related to the Basic >and HTML projects. As I understand it, HTML was forked from Basic to try a >different architecture approach, but a big portion of the code is still >the

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

2016-12-26 Thread Josh Tynjala
I suspect that a big chunk of the duplicate code is related to the Basic and HTML projects. As I understand it, HTML was forked from Basic to try a different architecture approach, but a big portion of the code is still the same. - Josh On Mon, Dec 26, 2016 at 8:39 AM, Christofer Dutz

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

2016-12-26 Thread piotrz
Thanks Chris. :) That's what I was intrested how much code duplication we have. :) Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-ASF-SonarQube-available-Beta-Testing-tp57320p57572.html Sent

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

2016-12-26 Thread Christofer Dutz
Ok … so the results aren’t that bad at all … Typedefs: 1 Bug 1 Vulnerability 308 Code Smells Framework: 17 Bugs 86 Vulnerabilities 8500 Code Smells (A lot is probably related to the conditional compilation) 35% of duplicated code 35% of duplicated code seems to indicate we could reuse quite a

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

2016-12-26 Thread piotrz
Thank you. Looking forward to the results. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-ASF-SonarQube-available-Beta-Testing-tp57320p57570.html Sent from the Apache Flex Development mailing

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

2016-12-26 Thread Christofer Dutz
I’ll set this up locally and give it a spin. I wouldn’t be surprised, if the result would be “catastrophic” because of all of the conditional compilation … I know that sonar doesn’t like this. So I’ll try to setup a build and settings for ActionScript on my local SonarQube first. Chris Am

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

2016-12-26 Thread piotrz
Chris, I think it's worth to try with putting into analysis also ActionScript code. Who should we eventually ask for installing ActionScript plugin? Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

2016-12-19 Thread Christofer Dutz
Yup ... currently only C#, Java and JavaScript rules are installed. Chris Am 19.12.16, 10:26 schrieb "Christofer Dutz" : Well In general it would be possible. SonarQube generally is able to scan ActionScript ... I didn’t add anything, because I would bet

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

2016-12-19 Thread Christofer Dutz
Well In general it would be possible. SonarQube generally is able to scan ActionScript ... I didn’t add anything, because I would bet a lot on the fact that the results would be so bad that we can’t do much with it. Because of all the huge amount of conditional compilation, which is regarded

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

2016-12-19 Thread piotrz
Hi Chris, Do you think that would be possible run anlysis also for ActionScript part of framework? Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

2016-12-19 Thread Christofer Dutz
Ok ... so now I brought in all the Maven built parts: SDK Converter aka Mavnizer: https://builds.apache.org/analysis/overview?id=14055 BlazeDS: https://builds.apache.org/analysis/overview?id=11879 FlexJS: https://builds.apache.org/analysis/overview?id=2461 Chris Am 16.12.16, 19:23 schrieb

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

2016-12-16 Thread Alex Harui
Nice! On 12/16/16, 4:03 AM, "carlos.rov...@gmail.com on behalf of Carlos Rovira" wrote: >Wow! That's dawn cool! :)) > >2016-12-16 12:57 GMT+01:00 Christofer Dutz : > >> Ok .. >> >> so we managed to

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

2016-12-16 Thread Carlos Rovira
Wow! That's dawn cool! :)) 2016-12-16 12:57 GMT+01:00 Christofer Dutz : > Ok .. > > so we managed to get the analyis running from Maven (includes code > coverage) > The link to this is: > > https://builds.apache.org/analysis/overview?id=2461 > > Chris > > Am 16.12.16,

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

2016-12-16 Thread Christofer Dutz
Ok .. so we managed to get the analyis running from Maven (includes code coverage) The link to this is: https://builds.apache.org/analysis/overview?id=2461 Chris Am 16.12.16, 11:48 schrieb "Christofer Dutz" : Hi, even if not officially communicated