Re: SourceEvent Task Failure Handling

2022-03-02 Thread Qingsheng Ren
Hi Mason, Unfortunately from SplitEnumerator’s aspect, events will be lost if they are not delivered to the SourceReader. On OperatorCoordinator level, if an OperatorEvent is not delivered successfully, the coordinator will trigger a subtask failover, then OperatorCoordinator#subtaskReset

Re: Re: [VOTE] Release 1.14.4, release candidate #1

2022-03-02 Thread Yun Gao
+1 (binding) - Checked the signatures of the release artifacts - Checked the WordCount example run successfully with the binary distributions for both of scala 2.11/2.12 - Verified the source compiled to binary successfully (withouth running the tests) - Reviewed the flink-web PR - Reviewed the

[jira] [Created] (FLINK-26458) Rename Accumulator to MergeFunction

2022-03-02 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-26458: Summary: Rename Accumulator to MergeFunction Key: FLINK-26458 URL: https://issues.apache.org/jira/browse/FLINK-26458 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-26457) Introduce Join Accumulator for Wide table

2022-03-02 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-26457: Summary: Introduce Join Accumulator for Wide table Key: FLINK-26457 URL: https://issues.apache.org/jira/browse/FLINK-26457 Project: Flink Issue Type:

Re: [DISCUSS] Manual savepoint triggering in flink-kubernetes-operator

2022-03-02 Thread Yang Wang
I agree that we could start with the annotation approach and collect the feedback at the same time. Best, Yang Őrhidi Mátyás 于2022年3月2日周三 20:06写道: > Thank you for your feedback! > > The annotation on the > > @ControllerConfiguration(generationAwareEventProcessing = false) >

Re: [DISCUSS] Enable scala formatting check

2022-03-02 Thread Shuo Cheng
+1, a lot of convenience will be brought then.  On Wed, Mar 2, 2022 at 7:29 PM Leonard Xu wrote: > +1 from my side, thanks for driving this improvement. > > Best, > Leonard > > > 2022年3月2日 下午7:13,Jiangang Liu 写道: > > > > +1 for the feature. Good style management can help the developer a lot.

Re: Change of focus

2022-03-02 Thread Shuo Cheng
Thanks for your efforts, Till. Good Luck! On Thu, Mar 3, 2022 at 12:00 AM Peter Huang wrote: > Hi Till, > > Thank you Till for monitoring and reviewing yarn related PRs. Good luck in > your next chapter! > > Best Regards > Peter Huang > > On Wed, Mar 2, 2022 at 3:34 AM Yu Li wrote: > > >

[jira] [Created] (FLINK-26456) StreamExecutionEnvironmentTests::test_add_python_file failed with ModuleNotFoundError

2022-03-02 Thread Huang Xingbo (Jira)
Huang Xingbo created FLINK-26456: Summary: StreamExecutionEnvironmentTests::test_add_python_file failed with ModuleNotFoundError Key: FLINK-26456 URL: https://issues.apache.org/jira/browse/FLINK-26456

[jira] [Created] (FLINK-26455) [Changelog] Materialization interleaved with task cancellation can fail the job

2022-03-02 Thread Roman Khachatryan (Jira)
Roman Khachatryan created FLINK-26455: - Summary: [Changelog] Materialization interleaved with task cancellation can fail the job Key: FLINK-26455 URL: https://issues.apache.org/jira/browse/FLINK-26455

Re: Help with pom dependencies for Flink with Table

2022-03-02 Thread Jing Ge
Hi Adesh, have you tried building your project with a clean classpath, i.e. mvn clean ...? Additionally, you could also try deleting org/apache/flink from your local .m2 repository to have an even cleaner repo. It looks like a BulkReaderFormatFactory from the current master branch [1] has been

[jira] [Created] (FLINK-26454) Improve operator logging

2022-03-02 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-26454: -- Summary: Improve operator logging Key: FLINK-26454 URL: https://issues.apache.org/jira/browse/FLINK-26454 Project: Flink Issue Type: Sub-task

Help with pom dependencies for Flink with Table

2022-03-02 Thread Adesh Dsilva
Hi I am struggling to run my test Flink project with Table API I am trying to run a simple piece of code: final StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment(); env.setRuntimeMode(RuntimeExecutionMode.BATCH); StreamTableEnvironment tableEnv =

[jira] [Created] (FLINK-26453) execution.allow-client-job-configurations not checked for executeAsync

2022-03-02 Thread Marios Trivyzas (Jira)
Marios Trivyzas created FLINK-26453: --- Summary: execution.allow-client-job-configurations not checked for executeAsync Key: FLINK-26453 URL: https://issues.apache.org/jira/browse/FLINK-26453

Re: Change of focus

2022-03-02 Thread Peter Huang
Hi Till, Thank you Till for monitoring and reviewing yarn related PRs. Good luck in your next chapter! Best Regards Peter Huang On Wed, Mar 2, 2022 at 3:34 AM Yu Li wrote: > Thanks for everything, Till! You are such a great mentor and workmate, and > we will definitely miss you... > > Wish

[jira] [Created] (FLINK-26452) Flink deploy on k8s when kubeconfig server is hostname not ip

2022-03-02 Thread hjw (Jira)
hjw created FLINK-26452: --- Summary: Flink deploy on k8s when kubeconfig server is hostname not ip Key: FLINK-26452 URL: https://issues.apache.org/jira/browse/FLINK-26452 Project: Flink Issue Type:

[jira] [Created] (FLINK-26451) Test GCS FileSystem w/ RecoverableWriter manually

2022-03-02 Thread Galen Warren (Jira)
Galen Warren created FLINK-26451: Summary: Test GCS FileSystem w/ RecoverableWriter manually Key: FLINK-26451 URL: https://issues.apache.org/jira/browse/FLINK-26451 Project: Flink Issue

[jira] [Created] (FLINK-26450) FileStateHandle.discardState does not process return value

2022-03-02 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-26450: - Summary: FileStateHandle.discardState does not process return value Key: FLINK-26450 URL: https://issues.apache.org/jira/browse/FLINK-26450 Project: Flink

[jira] [Created] (FLINK-26449) Enable tests in KafkaSourceLegacyITCase for test stability issues

2022-03-02 Thread Jing Ge (Jira)
Jing Ge created FLINK-26449: --- Summary: Enable tests in KafkaSourceLegacyITCase for test stability issues Key: FLINK-26449 URL: https://issues.apache.org/jira/browse/FLINK-26449 Project: Flink

[jira] [Created] (FLINK-26448) Disable tests in KafkaSourceLegacyITCase for test stability issues

2022-03-02 Thread Jing Ge (Jira)
Jing Ge created FLINK-26448: --- Summary: Disable tests in KafkaSourceLegacyITCase for test stability issues Key: FLINK-26448 URL: https://issues.apache.org/jira/browse/FLINK-26448 Project: Flink

Re: [DISCUSS] Manual savepoint triggering in flink-kubernetes-operator

2022-03-02 Thread Őrhidi Mátyás
Thank you for your feedback! The annotation on the @ControllerConfiguration(generationAwareEventProcessing = false) FlinkDeploymentController already enables the event triggering based on metadata changes. It was set earlier to support some failure scenarios. (It can be used for example to

Re: [DISCUSS] Manual savepoint triggering in flink-kubernetes-operator

2022-03-02 Thread Yang Wang
I also like the annotation approach since it is more natural. But I am not sure about whether the meta data change will trigger an event in java-operator-sdk. Best, Yang Gyula Fóra 于2022年3月2日周三 16:29写道: > Thanks Matyas, > > From a user perspective I think the annotation is pretty nice and

[jira] [Created] (FLINK-26447) Clean up webhook jar and dependency management

2022-03-02 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-26447: -- Summary: Clean up webhook jar and dependency management Key: FLINK-26447 URL: https://issues.apache.org/jira/browse/FLINK-26447 Project: Flink Issue Type:

Re: [DISCUSS] Enable scala formatting check

2022-03-02 Thread Leonard Xu
+1 from my side, thanks for driving this improvement. Best, Leonard > 2022年3月2日 下午7:13,Jiangang Liu 写道: > > +1 for the feature. Good style management can help the developer a lot. > > Marios Trivyzas 于2022年3月2日周三 18:19写道: > >> +1 from me as well, Having a unified auto-formatter for scala

Re: [DISCUSS] Enable scala formatting check

2022-03-02 Thread Jiangang Liu
+1 for the feature. Good style management can help the developer a lot. Marios Trivyzas 于2022年3月2日周三 18:19写道: > +1 from me as well, Having a unified auto-formatter for scala would be > great. > Currently we don't have consistency in our code base, and this makes it > more difficult > to read

Re: [DISCUSS] Enable scala formatting check

2022-03-02 Thread Ryan Skraba
+1 for me -- I've used spotless and scalafmt together in the past, and especially appreciated how consistent it is between using on the command line and in the IDE. All my best, Ryan On Wed, Mar 2, 2022 at 11:19 AM Marios Trivyzas wrote: > +1 from me as well, Having a unified auto-formatter

[jira] [Created] (FLINK-26446) Update Feature Radar in Apache Flink Roadmap

2022-03-02 Thread Konstantin Knauf (Jira)
Konstantin Knauf created FLINK-26446: Summary: Update Feature Radar in Apache Flink Roadmap Key: FLINK-26446 URL: https://issues.apache.org/jira/browse/FLINK-26446 Project: Flink Issue

Re: [DISCUSS] Enable scala formatting check

2022-03-02 Thread Marios Trivyzas
+1 from me as well, Having a unified auto-formatter for scala would be great. Currently we don't have consistency in our code base, and this makes it more difficult to read and work on the scala code. Best, Marios On Wed, Mar 2, 2022 at 11:41 AM wenlong.lwl wrote: > +1, currently the

Re: [DISCUSS] Enable scala formatting check

2022-03-02 Thread wenlong.lwl
+1, currently the scalastyle does not work well actually, there are a lot of style differences in different files. It would be great if the code can be auto formatted. Best, Wenlong On Wed, 2 Mar 2022 at 16:34, Jingsong Li wrote: > +1. > > Thanks for driving. > > I wrote some scala code, the

Re: [VOTE] Release 1.14.4, release candidate #1

2022-03-02 Thread Yun Tang
+1 non-binding - Checked the signatures for pending release artifacts. - Download the pre-built flink-dist of both scala_2.11 and scala_2.12 versions and run them locally with the StateMachine example. - Reviewed the flink-web PR Best Yun Tang From: Seth Wiesman

Re: Change of focus

2022-03-02 Thread Yu Li
Thanks for everything, Till! You are such a great mentor and workmate, and we will definitely miss you... Wish you all the best for the new adventure, and be sure to let me know when you plan to visit Beijing someday in the future! Best Regards, Yu On Wed, 2 Mar 2022 at 16:09, Jingsong Li

re: [DISCUSS] Enable scala formatting check

2022-03-02 Thread ??????
+1 I still remember my first pr. Lack of experience, I had to pay attention to Scala code format and corrected the format manually, which made me a littleembarrassed(though I'm a big fan of Scala). I think this proposal will lighten the burden of writing Scala code. Shouwei Liu

Re: [DISCUSS] Manual savepoint triggering in flink-kubernetes-operator

2022-03-02 Thread Gyula Fóra
Thanks Matyas, >From a user perspective I think the annotation is pretty nice and user friendly so I personally prefer that approach. You said: "It seems, the java-operator-sdk handles the changes of the .metadata and .spec fields of custom resources differently." What implications does this

Re: [DISCUSS] Enable scala formatting check

2022-03-02 Thread Jingsong Li
+1. Thanks for driving. I wrote some scala code, the style of our flink's scala is messy. We can do better. Best, Jingsong On Wed, Mar 2, 2022 at 4:19 PM Yun Tang wrote: > > +1 > > I also noticed that the project of scalafmt [1] is much more active than > scalatyle [2], which has no release

Re: [DISCUSS] Enable scala formatting check

2022-03-02 Thread Yun Tang
+1 I also noticed that the project of scalafmt [1] is much more active than scalatyle [2], which has no release in the past 4 years. [1] https://github.com/scalameta/scalafmt/releases [2] https://github.com/scalastyle/scalastyle/tags Best Yun Tang From:

Re: Change of focus

2022-03-02 Thread Jingsong Li
Hi Till, Good luck with the next chapter, and thanks for all of your efforts. Best, Jingsong On Wed, Mar 2, 2022 at 2:57 PM Yufei Zhang wrote: > > Hi Till, > > Thank you Till, and good luck in your next chapter :) > > Cheers, > Yufei > > On Mon, Feb 28, 2022 at 6:59 PM Till Rohrmann wrote: >

Re: [DISCUSS] Enable scala formatting check

2022-03-02 Thread Konstantin Knauf
+1 I've never written any Scala in Flink, but this makes a lot of sense to me. Converging on a smaller set of tools and simplifying the build is always a good idea and the Community already concluded before that spotless is generally a good approach. On Tue, Mar 1, 2022 at 5:52 PM Francesco