[jira] [Created] (FLINK-38201) SinkUpsertMaterializer should not be inserted for retract sinks

2025-08-06 Thread Timo Walther (Jira)
Timo Walther created FLINK-38201: Summary: SinkUpsertMaterializer should not be inserted for retract sinks Key: FLINK-38201 URL: https://issues.apache.org/jira/browse/FLINK-38201 Project: Flink

Re: [VOTE] FLIP-539: Support WITH Clause in CREATE FUNCTION Statement in Flink SQL

2025-08-05 Thread Timo Walther
+1 (binding) Cheers, Timo On 04.08.25 14:03, Jacky Lau wrote: +1 (non-binding) Best regards, Jacky Hao Li 于2025年8月2日周六 08:47写道: +1 (non-binding) Thanks, Hao On Fri, Aug 1, 2025 at 5:33 PM Sergey Nuyanzin wrote: +1 (binding) On Fri, Aug 1, 2025 at 5:18 PM Ramin Gharib wrote: Hi Da

Re: [VOTE] FLIP-529: Connections in Flink SQL and TableAPI

2025-08-01 Thread Timo Walther
+1 (binding) Thanks, Timo On 01.08.25 07:05, Lincoln Lee wrote: +1 (binding) Best, Lincoln Lee Leonard Xu 于2025年8月1日周五 10:07写道: +1 (binding) Best, Leonard 2025 8月 1 07:38,Mayank Juneja 写道: +1 (non binding) *Mayank Juneja* Product Manager | Data Streaming and AI On Thu, Jul 31, 2

Re: [DISCUSS] FLIP-529 Connections in Flink SQL and Table API

2025-07-31 Thread Timo Walther
Factory? I think connection is like CatalogTable. It should hold the basic information and all information in the connection should be stored into secret store. Best, Shengkai Timo Walther 于2025年7月22日周二 22:04写道: Hi Mayank, Thanks for updating the FLIP and clearly documenting our discussio

Re: [DISCUSS] FLIP-539: Support WITH Clause in CREATE FUNCTION Statement in Flink SQL

2025-07-29 Thread Timo Walther
Maybe not in the first version but eventually nothing in the design blocks us for supporting this. The SecretStore would need to be available in the FunctionDefinitionFactory for this. Cheers, Timo On 29.07.25 15:08, Ryan van Huuksloot wrote: Overall the FLIP looks good to me. Would the prop

Re: [DISCUSS] FLIP-539: Support WITH Clause in CREATE FUNCTION Statement in Flink SQL

2025-07-28 Thread Timo Walther
Hi Dawid, thanks for proposing this FLIP. Overall it fits into existing concepts and completes the syntax. +1 for this Cheers, Timo On 28.07.25 15:31, Dawid Wysakowicz wrote: Hi, I'd like to start a discussion of FLIP-539: Support WITH Clause in CREATE FUNCTION Statement in Flink SQL [1].

Re: [DISCUSS] FLIP-529 Connections in Flink SQL and Table API

2025-07-22 Thread Timo Walther
looks well, +1 from my side. Could you draft(update) current FLIP docs thus we can have some specific discussions later? Best, Leonard 2025 6月 26 15:06,Timo Walther 写道: Hi everyone, sorry for the late reply, feature freeze kept me busy. Mayank, Hao and I synced offline and came up we

[jira] [Created] (FLINK-38103) DataTypeFactory cannot restore inline structured types

2025-07-14 Thread Timo Walther (Jira)
Timo Walther created FLINK-38103: Summary: DataTypeFactory cannot restore inline structured types Key: FLINK-38103 URL: https://issues.apache.org/jira/browse/FLINK-38103 Project: Flink Issue

[jira] [Created] (FLINK-38090) TableResult.collect() returns incorrect SQL inline structured types

2025-07-11 Thread Timo Walther (Jira)
Timo Walther created FLINK-38090: Summary: TableResult.collect() returns incorrect SQL inline structured types Key: FLINK-38090 URL: https://issues.apache.org/jira/browse/FLINK-38090 Project: Flink

Re: [DISCUSS] FLIP-529 Connections in Flink SQL and Table API

2025-06-26 Thread Timo Walther
25 04:01, Leonard Xu wrote: Thanks Timo for joining this thread. I agree that this feature is needed by the community; the current disagreement is only about the implementation method or solution. Your thoughts looks generally good to me, looking forward to your proposal. Best, Leonard 2025 6月 6 22

Re: [DISCUSS] FLIP-440: Annotation naming for PTFs

2025-06-23 Thread Timo Walther
s feedback quickly. Kind regards, Gustavo de Morais On Thu, 19 Jun 2025 at 15:51, Timo Walther wrote: Hi everyone, I'm currently polishing FLIP-440, I would like to apply some last minute changes before the first release of PTFs for Flink 2.1. I've already collected initial

[DISCUSS] FLIP-440: Annotation naming for PTFs

2025-06-19 Thread Timo Walther
Hi everyone, I'm currently polishing FLIP-440, I would like to apply some last minute changes before the first release of PTFs for Flink 2.1. I've already collected initial user feedback and it seems that the name for annotations of table arguments is not precise enough. As always, naming is

[jira] [Created] (FLINK-37974) Avoid confusion when declaring table arguments

2025-06-19 Thread Timo Walther (Jira)
Timo Walther created FLINK-37974: Summary: Avoid confusion when declaring table arguments Key: FLINK-37974 URL: https://issues.apache.org/jira/browse/FLINK-37974 Project: Flink Issue Type

[jira] [Created] (FLINK-37956) Update SQL gateway for inline structured types

2025-06-15 Thread Timo Walther (Jira)
Timo Walther created FLINK-37956: Summary: Update SQL gateway for inline structured types Key: FLINK-37956 URL: https://issues.apache.org/jira/browse/FLINK-37956 Project: Flink Issue Type

Re: [DISCUSS] FLIP-529 Connections in Flink SQL and Table API

2025-06-06 Thread Timo Walther
Hi everyone, thanks for this healthy discussion. Looking at high number of participants, it looks like we definitely want this feature. We just need to figure out the "how". This reminds me very much of the discussion we had for CREATE FUNCTION. There, we discussed whether functions should b

Re: [VOTE] FLIP-526: Model ML_PREDICT, ML_EVALUATE Table API

2025-05-28 Thread Timo Walther
+1 (binding) We should still check whether changes to QueryOperationVisitor are necessary but this is internal API and should not the FLIP. The public API looks correct to me. Cheers, Timo On 12.05.25 18:50, Hao Li wrote: Hi everyone, I'd like to start a vote on FLIP-526: Model ML_PREDICT

[jira] [Created] (FLINK-37862) Implement data type improvements for StructuredType

2025-05-28 Thread Timo Walther (Jira)
Timo Walther created FLINK-37862: Summary: Implement data type improvements for StructuredType Key: FLINK-37862 URL: https://issues.apache.org/jira/browse/FLINK-37862 Project: Flink Issue

[jira] [Created] (FLINK-37861) FLIP-520: Simplify StructuredType handling

2025-05-28 Thread Timo Walther (Jira)
Timo Walther created FLINK-37861: Summary: FLIP-520: Simplify StructuredType handling Key: FLINK-37861 URL: https://issues.apache.org/jira/browse/FLINK-37861 Project: Flink Issue Type: New

Re: [VOTE] FLIP-313: Add support of User Defined AsyncTableFunction

2025-05-27 Thread Timo Walther
d the hint based options? And why? BTW, I feel that we can do better in dealing with similar FLIPs from different contributors as well as FLIPs dormant for long. I'll start a separate discussion on that rather than derail this thread. Thanks, Jiangjie (Becket) Qin On Mon, May 26, 2025 at

Re: [VOTE] FLIP-313: Add support of User Defined AsyncTableFunction

2025-05-26 Thread Timo Walther
-1 This FLIP has been subsumed by FLIP-498: AsyncTableFunction for async table function support [1]. In the discussion for FLIP-498, we decided to discard FLIP-313 as it has been abandoned for a while. I hope this is ok for everyone. @Alan might give some timeline when this feature will land

Re: [DISCUSS] FLIP-526: Model ML_PREDICT, ML_EVALUATE Table API

2025-05-12 Thread Timo Walther
e end, most stuff should be reusable from the PTF work. Cheers, Timo On 12.05.25 16:46, Timo Walther wrote: +1 to continue to voting. Thanks, Timo On 11.05.25 18:47, Hao Li wrote: Hi all, If there are no more discussions. I will start voting tomorrow. Thanks, Hao On Thu, May 8, 2025 at 10:

Re: [DISCUSS] FLIP-526: Model ML_PREDICT, ML_EVALUATE Table API

2025-05-12 Thread Timo Walther
+1 to continue to voting. Thanks, Timo On 11.05.25 18:47, Hao Li wrote: Hi all, If there are no more discussions. I will start voting tomorrow. Thanks, Hao On Thu, May 8, 2025 at 10:38 AM Hao Li wrote: Hi Ron, whether the predict or evaluate introduced in this FLIP can be serialized to

Re: [VOTE] FLIP-516: Multi-Way Join Operator

2025-05-12 Thread Timo Walther
+1 (binding) Regards, Timo On 12.05.25 07:58, Ron Liu wrote: +1 (binding) Best, Ron Hao Li 于2025年5月10日周六 02:35写道: +1 (non-binding) Thanks, Hao On Fri, May 9, 2025 at 3:41 AM Arvid Heise wrote: +1 (binding) Cheers On Wed, May 7, 2025 at 6:37 PM Gustavo de Morais Hi everyone, I'd l

Re: [RESULT][VOTE] FLIP-525: Model ML_PREDICT, ML_EVALUATE Implementation Design

2025-05-12 Thread Timo Walther
Hi Hao, please note that 72 hours in VOTE threads refers to business days so excluding weekends. This vote should be open for at least 1 more day. Regards, Timo On 11.05.25 18:19, Hao Li wrote: Hi Dev, I'm happy to announce that FLIP-525: Model ML_PREDICT, ML_EVALUATE Implementation Desig

[RESULT][VOTE] FLIP-520: Simplify StructuredType handling

2025-05-12 Thread Timo Walther
Hi everyone, I'm happy to announce that FLIP-520: Simplify StructuredType handling [1] has been accepted. There were 6 approving votes, 3 of which were binding: - Sergey Nuyanzin (binding) - Ferenc Csaky (binding) - Ron Liu (binding) - Hao Li (non-binding) - Gustavo de Morais (non-binding) -

Re: [VOTE] FLIP-520: Simplify StructuredType handling

2025-05-12 Thread Timo Walther
Thanks everyone. We have enough votes. I will close the vote now and announce the result in a separate email. Cheers, Timo On 06.05.25 14:49, Ramin Gharib wrote: +1 (non-binding) Thanks for driving this! Best, Ramin On Tue, May 6, 2025 at 12:04 PM Timo Walther wrote: Hi everyone, I&#

Re: [VOTE] FLIP-521: Integrating Variant Type into Flink: Enabling Efficient Semi-Structured Data Processing

2025-05-07 Thread Timo Walther
+1 (binding) Thanks for working on this! Best, Timo On 07.05.25 11:08, Xuannan Su wrote: Hi everyone, I'd like to start a vote on FLIP-521: Integrating Variant Type into Flink: Enabling Efficient Semi-Structured Data Processing[1], which has been discussed in this thread[2]. The vote will be

[jira] [Created] (FLINK-37763) Support multiple tables with set semantics

2025-05-06 Thread Timo Walther (Jira)
Timo Walther created FLINK-37763: Summary: Support multiple tables with set semantics Key: FLINK-37763 URL: https://issues.apache.org/jira/browse/FLINK-37763 Project: Flink Issue Type: Sub

[VOTE] FLIP-520: Simplify StructuredType handling

2025-05-06 Thread Timo Walther
Hi everyone, I'd like to start a vote on FLIP-520: Simplify StructuredType handling [1] which has been discussed in this thread [2]. The vote will be open for at least 72 hours unless there is an objection or not enough votes. [1] https://cwiki.apache.org/confluence/display/FLINK/FLIP-520%

Re: [DISCUSS] FLIP-520: Simplify StructuredType handling

2025-05-05 Thread Timo Walther
Hi everyone, if there are no objections, I would start a voting thread by tomorrow. Thanks, Timo On 29.04.25 11:46, Timo Walther wrote: Hi Hao, thanks for your feedback. Currently, the Python API does not support structured types at all. So this might require another FLIP in the future

Re: [DISCUSS] FLIP-521: Integrating Variant Type into Flink: Enabling Efficient Semi-Structured Data Processing

2025-05-05 Thread Timo Walther
Hi Xuannan, thank you for updating the FLIP and addressing my comments. The FLIP is in a very good shape now, +1 for voting. I just found some last remaining items that would be good to be addressed in the FLIP. But not blocker for the voting process: > isScalar() I thought about the naming

Re: [DISCUSS] FLIP-527 Support EXPLAIN EXECUTE STATEMENT SET Syntax in Flink SQL

2025-04-30 Thread Timo Walther
Hi Ramin, it was a mistake to support the EXPLAIN STATEMENT SET syntax in the first place. We support `EXPLAIN SELECT` and `EXPLAIN CREATE TABLE`, so EXPLAIN + verb, we should have done the same for `EXECUTE`. +1 for the proposal. Cheers, Timo On 30.04.25 11:55, Gustavo de Morais wrote: I

Re: [DISCUSS] FLIP-520: Simplify StructuredType handling

2025-04-29 Thread Timo Walther
cy between STRUCT and ROW but tbh I have more issues with ROW than with STRUCT. (What is even the meaning of a nested ROW?) So +1 with your proposal and maybe we can deprecate ROW at some later point in time. Best, Arvid On Thu, Apr 24, 2025 at 11:57 AM Timo Walther wrote: Hi Arvid, Hi Hao,

[jira] [Created] (FLINK-37745) ChangelogModeJsonSerializer doesn't handle partial deletes

2025-04-28 Thread Timo Walther (Jira)
Timo Walther created FLINK-37745: Summary: ChangelogModeJsonSerializer doesn't handle partial deletes Key: FLINK-37745 URL: https://issues.apache.org/jira/browse/FLINK-37745 Project:

Re: [DISCUSS] FLIP-521: Integrating Variant Type into Flink: Enabling Efficient Semi-Structured Data Processing

2025-04-25 Thread Timo Walther
forward to the detailed design of the subsequent shredding optimizations. Best, Lincoln Lee Timo Walther 于2025年4月22日周二 16:51写道: +1 for this feature. Having a VARIANT type makes a lot of sense and together with an OBJECT type will make semi-structured data processing in Flink easier. Currently,

Re: [DISCUSS] FLIP-520: Simplify StructuredType handling

2025-04-24 Thread Timo Walther
hat wants to collect results (in your last example what is t.execute().collect(); returning? How does that work in the multi-user setup sketched above? Wouldn't it be easier that the consumer explicitly gives us the POJO type that it expects?) * Any DataStream conversion * Any UDF However, at t

Re: [DISCUSS] FLIP-520: Simplify StructuredType handling

2025-04-22 Thread Timo Walther
lse with different fields and then in Table api, it's not compatible. Hao On Tue, Apr 22, 2025 at 9:39 AM Timo Walther wrote: Hi Arvid, Hi Sergey, thanks for your feedback. I updated the FLIP accordingly but let me answer your questions here as well: > Are we going to enforce that th

Re: [DISCUSS] FLIP-520: Simplify StructuredType handling

2025-04-22 Thread Timo Walther
n do I understand it correct that after this FLIP we can execute of `typeof` against result of `OBJECT_OF` for instance SELECT typeof(OBJECT_OF( 'com.example.User', 'name', 'Bob', 'age', 42 )); should return `STRUCTURED<'com.example.User',

Re: [DISCUSS] FLIP-520: Simplify StructuredType handling

2025-04-22 Thread Timo Walther
rais wrote: Thanks for the small but important changes proposed. IMO, these are essential for dealing with these directly in SQL. On 2025/04/10 05:54:58 Timo Walther wrote: Hi everyone, I would like to start a discussion about FLIP-520: Simplify StructuredType handling [1]. Flink SQL alread

Re: [DISCUSS] FLIP-520: Simplify StructuredType handling

2025-04-22 Thread Timo Walther
Hi everyone, I would like to ask again for feedback on this FLIP. It is a rather small change but with big impact on usability for structured data. Are there any objections? Otherwise I would like to continue with voting soon. Thanks, Timo On 10.04.25 07:54, Timo Walther wrote: Hi

Re: [DISCUSS] FLIP-521: Integrating Variant Type into Flink: Enabling Efficient Semi-Structured Data Processing

2025-04-22 Thread Timo Walther
+1 for this feature. Having a VARIANT type makes a lot of sense and together with an OBJECT type will make semi-structured data processing in Flink easier. Currently, I'm catching up with notifications after the easter holidays, but happy to give some feedback by tomorrow or Thursday as well.

Re: [DISCUSS] FLIP-517: Better Handling of Dynamic Table Primitives with PTFs

2025-04-16 Thread Timo Walther
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalLookupJoin.scala#L41 [3] https://github.com/apache/flink/blob/master/flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/LookupTableSource.java#L

[jira] [Created] (FLINK-37671) ChangelogMode.toString returns invalid string for partial deletes

2025-04-14 Thread Timo Walther (Jira)
Timo Walther created FLINK-37671: Summary: ChangelogMode.toString returns invalid string for partial deletes Key: FLINK-37671 URL: https://issues.apache.org/jira/browse/FLINK-37671 Project: Flink

[jira] [Created] (FLINK-37651) Simplify StaticArgument builders for easier type inference

2025-04-10 Thread Timo Walther (Jira)
Timo Walther created FLINK-37651: Summary: Simplify StaticArgument builders for easier type inference Key: FLINK-37651 URL: https://issues.apache.org/jira/browse/FLINK-37651 Project: Flink

[DISCUSS] FLIP-520: Simplify StructuredType handling

2025-04-09 Thread Timo Walther
Hi everyone, I would like to start a discussion about FLIP-520: Simplify StructuredType handling [1]. Flink SQL already supports structured types in the engine, serializers, UDFs, and connector interfaces. However, currently only Table API was able to make use of them. While UDFs can take ob

[jira] [Created] (FLINK-37632) Add ChangelogFunction interface

2025-04-08 Thread Timo Walther (Jira)
Timo Walther created FLINK-37632: Summary: Add ChangelogFunction interface Key: FLINK-37632 URL: https://issues.apache.org/jira/browse/FLINK-37632 Project: Flink Issue Type: Sub-task

Re: Process table function scan operation in batch mode is not supported

2025-04-05 Thread Timo Walther
Hi Gabor, great that you already try out PTFs. I'm in the process of writing documentation for it. Including a list of limitations. Please note that PTF won't be support in batch mode in the first phase. For stateful PTFs we would need to use a batch state backend and also other code paths a

[jira] [Created] (FLINK-37599) Consider on_time argument for column expansion

2025-04-01 Thread Timo Walther (Jira)
Timo Walther created FLINK-37599: Summary: Consider on_time argument for column expansion Key: FLINK-37599 URL: https://issues.apache.org/jira/browse/FLINK-37599 Project: Flink Issue Type

[jira] [Created] (FLINK-37598) Support ListView and MapView in PTFs

2025-04-01 Thread Timo Walther (Jira)
Timo Walther created FLINK-37598: Summary: Support ListView and MapView in PTFs Key: FLINK-37598 URL: https://issues.apache.org/jira/browse/FLINK-37598 Project: Flink Issue Type: Sub-task

Re: Process table function scan operation in batch mode is not supported

2025-03-28 Thread Timo Walther
operations on it as well. Cheers, Gyula On Fri, Mar 28, 2025 at 7:39 AM Timo Walther wrote: Hi Gabor, great that you already try out PTFs. I'm in the process of writing documentation for it. Including a list of limitations. Please note that PTF won't be support in batch mode in th

[jira] [Created] (FLINK-37547) Add initial document for PTFs

2025-03-24 Thread Timo Walther (Jira)
Timo Walther created FLINK-37547: Summary: Add initial document for PTFs Key: FLINK-37547 URL: https://issues.apache.org/jira/browse/FLINK-37547 Project: Flink Issue Type: Sub-task

[DISCUSS] FLIP-517: Better Handling of Dynamic Table Primitives with PTFs

2025-03-21 Thread Timo Walther
Hi everyone, I would like to start a discussion about FLIP-517: Better Handling of Dynamic Table Primitives with PTFs [1]. In the past months, I have spent a significant amount of time with SQL semantics and the SQL standard around PTFs, when designing and implementing FLIP-440 [2]. For thos

Re: [VOTE] FLIP-507: Add Model DDL methods in TABLE API

2025-03-19 Thread Timo Walther
, Yash Anand On Tue, Mar 11, 2025 at 5:55 AM Timo Walther wrote: Hi Yash, thanks for updating the FLIP. Here is more feedback from my side: Add `option(ConfigOption configOption, T value)` similar to `TableDescriptor`. Use `comment()` instead of `setComment` to be in sync with `TableDescriptor

Re: [VOTE] FLIP-507: Add Model DDL methods in TABLE API

2025-03-15 Thread Timo Walther
Hi Yash, could you provide the full API of the ModelDescriptor in the FLIP? Thanks, Timo On 10.03.25 16:55, Mingge Deng wrote: Thanks Yash! +1 (binding) Best, Mingge On Mon, Mar 10, 2025 at 8:51 AM Dawid Wysakowicz wrote: +1 (binding) Best, Dawid On Wed, 19 Feb 2025 at 18:37, Hao Li

[jira] [Created] (FLINK-37466) A helper function for DEFAULT in Table API

2025-03-12 Thread Timo Walther (Jira)
Timo Walther created FLINK-37466: Summary: A helper function for DEFAULT in Table API Key: FLINK-37466 URL: https://issues.apache.org/jira/browse/FLINK-37466 Project: Flink Issue Type: Sub

[jira] [Created] (FLINK-37446) Support asArgument in Table API

2025-03-11 Thread Timo Walther (Jira)
Timo Walther created FLINK-37446: Summary: Support asArgument in Table API Key: FLINK-37446 URL: https://issues.apache.org/jira/browse/FLINK-37446 Project: Flink Issue Type: Sub-task

Re: FLIP-510: Drop ChangelogNormalize for operations which don't need it

2025-03-11 Thread Timo Walther
Hi Dawid, thanks for this proposal. This is a very nice improvement to the SQL engine. Changelog normalize is a very state-intensive operation. Any possibility to avoid it should be implemented. Updating ChangelogMode is an elegant solution and avoid updating the RowKind. When we introduced

Re: [VOTE] FLIP-510: Drop ChangelogNormalize for operations which don't need it

2025-03-11 Thread Timo Walther
+1 (binding) Thanks for working on this! Timo On 11.03.25 11:05, Dawid Wysakowicz wrote: Hi everyone, I'd like to start a vote on FLIP-510: Drop ChangelogNormalize for operations which don't need it[1] which has been discussed in this thread [2]. The vote will be open for at least 72 hours u

Re: [VOTE] FLIP-507: Add Model DDL methods in TABLE API

2025-03-11 Thread Timo Walther
est, Leonard [1] https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=334760466 2025年3月11日 01:19,Yash Anand 写道: Hi Timo, Thanks for pointing that out. I have added the full API of the ModelDescriptor in the FLIP. Thanks, Yash Anand On Mon, Mar 10, 2025 at 11:27 AM Timo Walther wr

[jira] [Created] (FLINK-37457) Support asArgument in Python Table API

2025-03-11 Thread Timo Walther (Jira)
Timo Walther created FLINK-37457: Summary: Support asArgument in Python Table API Key: FLINK-37457 URL: https://issues.apache.org/jira/browse/FLINK-37457 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-37423) Add support for PTFs in Table API

2025-03-05 Thread Timo Walther (Jira)
Timo Walther created FLINK-37423: Summary: Add support for PTFs in Table API Key: FLINK-37423 URL: https://issues.apache.org/jira/browse/FLINK-37423 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-37402) SQL testing sources produce incorrect watermarks

2025-02-27 Thread Timo Walther (Jira)
Timo Walther created FLINK-37402: Summary: SQL testing sources produce incorrect watermarks Key: FLINK-37402 URL: https://issues.apache.org/jira/browse/FLINK-37402 Project: Flink Issue Type

Re: [DISCUSSION] Upgrade to Kryo 5 for Flink 2.0

2025-02-24 Thread Timo Walther
Hi Gyula, thanks for bringing this up. I agree that we should use one of the most recent Kryo versions for Flink 2.0. Otherwise the community will suffer again from incompatibilities and needs to wait for another major Flink version. Thanks for starting this discussion. We should do it for 2.0

Re: [VOTE] FLIP-491: BundledAggregateFunction for batched aggregation

2025-02-24 Thread Timo Walther
+1 (binding) Thanks for working on this FLIP. Best regards, Timo On 14.02.25 22:32, Alan Sheinberg wrote: Hi everyone, I'd like to start a vote on FLIP-491 [1]. It proposes adding BundledAggregateFunction as an interface that aggregate function UDFs can implement. The interface exposes a batc

Re: [DISCUSS] Adding API stability annotations (@Experimental, @PublicEvolving) to PyFlink APIs

2025-02-20 Thread Timo Walther
Hi Mika, thanks for bringing this up! I was actually quite surprised that we don't use any kind of marking in our interfaces in the Python API yet. Your proposal makes total sense. We should reuse the same annotation categories that we use and agreed on in Java. Since the Python Table API is

Re: [VOTE] Release flink-shaded 20.0, release candidate #1

2025-02-19 Thread Timo Walther
+1 (binding) I went through the commit and checked for suspicious changes. Could not found any. Thanks, Timo On 18.02.25 18:52, Sergey Nuyanzin wrote: Hi everyone, Please review and vote on the release candidate #1 for the version 20.0, as follows: [ ] +1, Approve the release [ ] -1, Do not

Re: [DISCUSS] FLIP-491: BundledAggregateFunction for batched aggregation

2025-02-13 Thread Timo Walther
you clarify what the table.exec.agg-bundled.size parameter refers to? * Number of keys? Total number of rows? Number of rows per key? * It would be nice to add the keys in the example * How do the bundled agg functions interact with checkpointing? * Are bundles sent out when a checkpoint

Re: [VOTE] FLIP-508: Add support for Smile format for Compiled plans

2025-02-13 Thread Timo Walther
+1 (binding) Thanks, Timo On 13.02.25 11:51, Sergey Nuyanzin wrote: Hi everyone, I'd like to start a vote on FLIP-508: Add support for Smile format for Compiled plans [1] which has been discussed in this thread [2]. The vote will be open for at least 72 hours unless there is an objection or

[jira] [Created] (FLINK-37302) Support timers in PTFs

2025-02-11 Thread Timo Walther (Jira)
Timo Walther created FLINK-37302: Summary: Support timers in PTFs Key: FLINK-37302 URL: https://issues.apache.org/jira/browse/FLINK-37302 Project: Flink Issue Type: Sub-task

Re: [DISCUSS] FLIP-508: Add support for Smile format for Compiled plans

2025-02-07 Thread Timo Walther
Hi Gyula, Sergey and I spent a significant amount of time in researching different formats. When we introduced CompiledPlan, the question whether we want to use a binary format for performance and efficiency reasons immediately came up, but we decided to postpone this discussion. Back then

[jira] [Created] (FLINK-37269) Add new DESCRIPTOR data type

2025-02-06 Thread Timo Walther (Jira)
Timo Walther created FLINK-37269: Summary: Add new DESCRIPTOR data type Key: FLINK-37269 URL: https://issues.apache.org/jira/browse/FLINK-37269 Project: Flink Issue Type: Sub-task

Re: [VOTE] FLIP-498: AsyncTableFunction for async table function support

2025-01-28 Thread Timo Walther
+1 (binding) Thanks, Timo On 28.01.25 11:56, Fabian Hüske wrote: +1 (binding) for this FLIP. Thank you, Fabian On Tue, Jan 28, 2025 at 2:36 AM Natea Eshetu Beshada wrote: +1 (non-binding) On Mon, Jan 27, 2025 at 3:02 PM Alan Sheinberg wrote: Hi everyone, I'd like to start a vote on F

[jira] [Created] (FLINK-37219) Support value state in PTFs

2025-01-24 Thread Timo Walther (Jira)
Timo Walther created FLINK-37219: Summary: Support value state in PTFs Key: FLINK-37219 URL: https://issues.apache.org/jira/browse/FLINK-37219 Project: Flink Issue Type: Sub-task

Re: [VOTE] FLIP-502: QueryOperation SQL Serialization customization

2025-01-24 Thread Timo Walther
+1 (binding) Thanks for completing this effort. Cheers, Timo On 23.01.25 22:39, Sergey Nuyanzin wrote: +1 (binding) Thanks for driving this. On Thu, Jan 23, 2025, 11:57 Dawid Wysakowicz wrote: Hi, all. I'd like to start a vote on FLIP-502: QueryOperation SQL Serialization customization [1

[jira] [Created] (FLINK-37211) Fix field resolution for PARTITION BY/ORDER BY

2025-01-23 Thread Timo Walther (Jira)
Timo Walther created FLINK-37211: Summary: Fix field resolution for PARTITION BY/ORDER BY Key: FLINK-37211 URL: https://issues.apache.org/jira/browse/FLINK-37211 Project: Flink Issue Type

[jira] [Created] (FLINK-37180) Implement StreamOperator for PTF

2025-01-20 Thread Timo Walther (Jira)
Timo Walther created FLINK-37180: Summary: Implement StreamOperator for PTF Key: FLINK-37180 URL: https://issues.apache.org/jira/browse/FLINK-37180 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-37167) Fix operand reordering in SqlValidatorImpl for tableCharacteristics

2025-01-17 Thread Timo Walther (Jira)
Timo Walther created FLINK-37167: Summary: Fix operand reordering in SqlValidatorImpl for tableCharacteristics Key: FLINK-37167 URL: https://issues.apache.org/jira/browse/FLINK-37167 Project: Flink

Re: [DISCUSS] FLIP-502: QueryOperation SQL Serialization customization

2025-01-15 Thread Timo Walther
Thanks for the update Dawid. From my point of view, the FLIP is ready for voting. Unless somebody else has any objections? Cheers, Timo On 15.01.25 10:20, Dawid Wysakowicz wrote: Sure, I updated the FLIP On Mon, 13 Jan 2025 at 15:20, Timo Walther wrote: Hi Dawid, thanks for proposing

Re: [DISCUSS] FLIP-498: AsyncTableFunction for async table function support

2025-01-14 Thread Timo Walther
Hi Alan, thanks for giving us some context. It looks like FLIP-313 has not seen any progress for 2 years. We can still revive FLIP-313 for the hint discussion but start with config options. It makes sense that there is consistency between AsycScalarFunction and AsyncTableFunction with respect

Re: [DISCUSS] FLIP-498: AsyncTableFunction for async table function support

2025-01-13 Thread Timo Walther
Hi Alan, thanks for proposing this FLIP. I agree that AsyncTableFunction is very similar to AsyncScalarFunction and luckily, the Python component has laid the foundation for this proposal. Nothing to add from my side. +1 for voting. Regards, Timo On 02.01.25 20:47, Alan Sheinberg wrote: I

Re: [DISCUSS] FLIP-491: BundledAggregateFunction for batched aggregation

2025-01-13 Thread Timo Walther
Hi Alan, thanks for sharing this FLIP with us. Sorry for the late reply. I think the FLIP is already in a very good shape. I like the approach that the BundledAggregateFunction is rather a separate interface that can be implemented by advanced users. This matches with the existing Specialize

Re: [DISCUSS] FLIP-502: QueryOperation SQL Serialization customization

2025-01-13 Thread Timo Walther
Hi Dawid, thanks for proposing this FLIP. It nicely completes the serialization effort started with FLIP-393. I know naming is difficult, but could we shorten and simplify the signatures further? My suggestion would be: OperationSerializationContext -> SqlSerializationContext ExpressionSerial

[jira] [Created] (FLINK-37076) Support PTF skeleton in planner

2025-01-08 Thread Timo Walther (Jira)
Timo Walther created FLINK-37076: Summary: Support PTF skeleton in planner Key: FLINK-37076 URL: https://issues.apache.org/jira/browse/FLINK-37076 Project: Flink Issue Type: Sub-task

Re: [DISCUSS] FLIP-500: Support Join Extension in DataStream V2 API

2025-01-07 Thread Timo Walther
Hi Huang, I agree with Fabian that we should be careful with adding features to DataStream API V2. Providing it as an extension rather than a base API is definitely a good direction. Prepared built-in functions and algorithms should rather go into a lib module. Nevertheless, the DataStream A

Re: [DISCUSS] FLIP-494: Add missing createTable/createView methods to TableEnvironment

2024-12-19 Thread Timo Walther
Hi Sergey, thanks for working on this. The FLIP is a nice continuation of started efforts. The example of createTable doesn't use the flag. Otherwise +1 to vote, as it is not very controversial. Cheers, Timo On 18.12.24 09:35, Sergey Nuyanzin wrote: Hi Ron, good catch, I fixed it thanks O

[jira] [Created] (FLINK-36937) Integrate PTF TypeInference into Table API

2024-12-19 Thread Timo Walther (Jira)
Timo Walther created FLINK-36937: Summary: Integrate PTF TypeInference into Table API Key: FLINK-36937 URL: https://issues.apache.org/jira/browse/FLINK-36937 Project: Flink Issue Type: Sub

Re: [VOTE] FLIP-489: Add missing dropTable/dropView methods to TableEnvironment

2024-12-13 Thread Timo Walther
+1 (binding) Thanks, Timo On 13.12.24 01:37, Jim Hughes wrote: Hi Sergey, +1 (non-binding) Cheers, Jim On Thu, Dec 12, 2024 at 2:51 PM Sergey Nuyanzin wrote: Hi everyone, I'd like to start a vote on FLIP-489: Add missing dropTable/dropView methods to TableEnvironment [1] which has been

Re: [DISCUSS] FLIP-489: Add missing dropTable/dropView methods to TableEnvironment

2024-12-12 Thread Timo Walther
+1 This FLIP is straightforward. No discussion necessary. Thanks, Timo On 12.12.24 09:49, Sergey Nuyanzin wrote: Thanks for the feedback Jim Since there is no more feedback I will start voting soon On Tue, Dec 10, 2024 at 12:23 AM Sergey Nuyanzin wrote: While reading it was surprised that

[jira] [Created] (FLINK-36789) Update FunctionHint and ArgumentHint with StaticArguments

2024-11-25 Thread Timo Walther (Jira)
Timo Walther created FLINK-36789: Summary: Update FunctionHint and ArgumentHint with StaticArguments Key: FLINK-36789 URL: https://issues.apache.org/jira/browse/FLINK-36789 Project: Flink

[RESULT][VOTE] FLIP-440: User-defined SQL operators / ProcessTableFunction (PTF)

2024-11-14 Thread Timo Walther
nding) - Shengkai Fang (binding) - Fabian Hüske (binding) - Dawid Wysakowicz (binding) - Stefan Richter (binding) - David Radley (non-binding) - Martijn Visser (binding) - Timo Walther (binding) There are no disapproving votes. Thanks everyone! Best, Timo [1] https://cwiki.apache.org/confluence/

Re: [VOTE] FLIP-440: User-defined SQL operators / ProcessTableFunction (PTF)

2024-11-14 Thread Timo Walther
the vote supposed to happen in a new thread? Cheers, Jim On Mon, Nov 11, 2024 at 9:46 AM Konstantin Knauf wrote: +1 (binding) Am Mo., 11. Nov. 2024 um 15:20 Uhr schrieb Sergey Nuyanzin < snuyan...@apache.org>: Thanks for this great improvement +1 (binding) On 2024/11/11 13:42:

[jira] [Created] (FLINK-36707) Integrate PTF TypeInference into Calcite validator

2024-11-13 Thread Timo Walther (Jira)
Timo Walther created FLINK-36707: Summary: Integrate PTF TypeInference into Calcite validator Key: FLINK-36707 URL: https://issues.apache.org/jira/browse/FLINK-36707 Project: Flink Issue

[jira] [Created] (FLINK-36706) Update TypeInferenceExtractor for PTFs

2024-11-13 Thread Timo Walther (Jira)
Timo Walther created FLINK-36706: Summary: Update TypeInferenceExtractor for PTFs Key: FLINK-36706 URL: https://issues.apache.org/jira/browse/FLINK-36706 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-36704) Update TypeInference with StaticArgument and StateTypeStrategy

2024-11-13 Thread Timo Walther (Jira)
Timo Walther created FLINK-36704: Summary: Update TypeInference with StaticArgument and StateTypeStrategy Key: FLINK-36704 URL: https://issues.apache.org/jira/browse/FLINK-36704 Project: Flink

[jira] [Created] (FLINK-36705) Add ProcessTableFunction class and annotations

2024-11-13 Thread Timo Walther (Jira)
Timo Walther created FLINK-36705: Summary: Add ProcessTableFunction class and annotations Key: FLINK-36705 URL: https://issues.apache.org/jira/browse/FLINK-36705 Project: Flink Issue Type

[jira] [Created] (FLINK-36703) FLIP-440: User-defined SQL operators / ProcessTableFunction (PTF)

2024-11-13 Thread Timo Walther (Jira)
Timo Walther created FLINK-36703: Summary: FLIP-440: User-defined SQL operators / ProcessTableFunction (PTF) Key: FLINK-36703 URL: https://issues.apache.org/jira/browse/FLINK-36703 Project: Flink

[VOTE] FLIP-440: User-defined SQL operators / ProcessTableFunction (PTF)

2024-11-11 Thread Timo Walther
Hi everyone, I'd like to start a vote on FLIP-440: User-defined SQL operators / ProcessTableFunction (PTF) [1] which has been discussed in this thread [2]. The vote will be open for at least 72 hours unless there is an objection or not enough votes. [1] https://cwiki.apache.org/confluence/

Re: [DISCUSS] FLIP-440: User-defined SQL operators / ProcessTableFunction (PTF)

2024-11-11 Thread Timo Walther
Nov 8, 2024 at 6:03 PM Timo Walther wrote: Hi David, happy to answer your questions as well: > 1. I wonder what class of scenarios that PTF’s do not do well in and > that DataStream API would be preferable/required? Assuming we have PTF > Map and List support. DataStream API supp

Re: [DISCUSS] FLIP-440: User-defined SQL operators / ProcessTableFunction (PTF)

2024-11-08 Thread Timo Walther
taStream API windows, the rowtime of a watermark fired operator is always T = W - 1. Because it needs to be smaller than the current watermark. > 2., 3. ,4. I reworked/removed the affected sections. Cheers, Timo On 08.11.24 17:47, Timo Walther wrote: Hi Fabian, thanks for this massiv

Re: [DISCUSS] FLIP-440: User-defined SQL operators / ProcessTableFunction (PTF)

2024-11-08 Thread Timo Walther
query which might not be uncommon (UNION ALL multiple PTF branches). Sure, users could just set the uid but do we want to fail a query for that? Finally, I found a few minor mistakes that you might want to fix: 1. "Public Interfaces", "ProcessTableFunction", "The collec

  1   2   3   4   5   6   7   8   9   10   >