Re:Re: [DISCUSS][2.0] FLIP-382: Unify the Provision of Diverse Metadata for Context-like APIs

2023-12-13 Thread Wencong Liu
Hi Lijie, Thank you for the response and for supporting the proposal. Regarding your suggestions: 1. While the getTaskNameWithIndexAndAttemptNumber may seem redundant initially, this concatenated string, for example "MyTask (3/6)#1", serves as an identifier used to denote a specific Task across

Re: [DISCUSS][2.0] FLIP-382: Unify the Provision of Diverse Metadata for Context-like APIs

2023-12-11 Thread weijie guo
Hi Wencong, Thanks for driving this! This is valuable refactoring from my side, so I'm +1 for this proposal. Best regards, Weijie Lijie Wang 于2023年12月12日周二 14:58写道: > Hi Wencong > > Thanks for driving the discussion, +1 for the proposal. I left two minor > questions/suggestions: > > 1. Is

Re: [DISCUSS][2.0] FLIP-382: Unify the Provision of Diverse Metadata for Context-like APIs

2023-12-11 Thread Lijie Wang
Hi Wencong Thanks for driving the discussion, +1 for the proposal. I left two minor questions/suggestions: 1. Is the getTaskNameWithIndexAndAttemptNumber method a bit redundant? It can be replaced by getTaskName + getTaskIndex + getAttemptNumber. 2. I think it would be better if we can

[DISCUSS][2.0] FLIP-382: Unify the Provision of Diverse Metadata for Context-like APIs

2023-11-29 Thread Wencong Liu
Hi devs, I would like to start a discussion on FLIP-382: Unify the Provision of Diverse Metadata for Context-like APIs [1]. In the Flink project, the context-like APIs are interfaces annotated by @Public and supply runtime metadata and functionalities to its modules and components.