INFO output usually not enough for debugging.
In some cases it may be sufficient, but if you go beyond that then the
dev still has to know to look into one specific module,
bringing us back to square one.
I do think though that a dedicated module for sharing these resources
would actually be
I also like the idea of getting rid of all those copies of the same file
across our codebase.
How about setting the log level in the log4j config file in
flink-test-utils-junit/src/main/resources to INFO, and using a separate
log4j config for local maven runs? (we pass a different log4j file in
Nope, it wouldn't work to have it in the root of the project; in a
practical sense IntelliJ can only really handle them in the standard
location.
Ironically, the PR currently only works in IntelliJ, because when you
build the jar with maven we exclude all log4j files via the
shade-plugin.
Actually, I would first have to double-check whether this would work
within IntelliJ...
On 06/04/2020 20:40, Chesnay Schepler wrote:
We can also move the file to the root of the project, which should
make it easier to discover.
flink-test-utils-junit would then just be a distribution vehicle
We can also move the file to the root of the project, which should make
it easier to discover.
flink-test-utils-junit would then just be a distribution vehicle that
few would have to know about.
On 06/04/2020 13:31, Till Rohrmann wrote:
Hi Chesnay,
thanks for kicking this discussion off. I
Hi Chesnay,
thanks for kicking this discussion off. I agree that deduplicating code is
in general a good idea.
The main benefit seems to be that all modules inherit a
log4j2-test.properties file and that this file allows to control the
logging output for several modules.
The main drawback I see
Hello,
I discovered a handy trick that would allow us to share a single
log4j2-test.properties across all modules.
https://github.com/apache/flink/pull/11634
The file would exist in flink-test-utils-junit/src/main/resources, and
be used for all modules except the kafka connectors and
