Re: [DISCUSS] FLIP-268: Rack Awareness for Kafka Sources

2022-11-15 Thread Dong Lin
Hi Jeremy, Thanks for creating the FLIP! I think this is a pretty useful feature for users to save operation costs. It would be great to have this feature in Flink. I have a couple of questions below: 1) Could you update the FLIP to specify the concrete signature of the setRackId(..) method

Re: [DISCUSS] FLIP-268: Rack Awareness for Kafka Sources

2022-11-13 Thread Hang Ruan
Hi Jeremy, Thanks for the proposal. I think we should add some descriptions about how we plan to pass this configuration in Flink SQL. Maybe we need a new interface which is passed to the Kafka source like the serializer/deserializer. Best, Hang

Re: [DISCUSS] FLIP-268: Rack Awareness for Kafka Sources

2022-11-11 Thread Jeremy DeGroot
Yanfei, You caught a mistake on my part. I referenced the wrong KIP. That one is for Kafka Streams, KIP-36 is the one for the regular client. I'll update the referenced FLIP and its JIRA. This feature is already available in our client, my team at work implemented it against the old Kafka

Re: [DISCUSS] FLIP-268: Rack Awareness for Kafka Sources

2022-11-10 Thread Martijn Visser
Hi Yanfei, The version for Kafka Clients has been upgraded to 3.2.3 since 1.16 via FLINK-29513 [1] Best regards, Martijn [1] https://issues.apache.org/jira/browse/FLINK-29513 On Fri, Nov 11, 2022 at 4:11 AM Yanfei Lei wrote: > Hi Jeremy, > > Thanks for the proposal. > I'm curious if this

Re: [DISCUSS] FLIP-268: Rack Awareness for Kafka Sources

2022-11-10 Thread Yanfei Lei
Hi Jeremy, Thanks for the proposal. I'm curious if this feature can adapt to the current kafka-client version in the connector. The rack awareness feature requires a version>=3.2.0 to use, while the kafka-client version of Kafka connector is 2.8.1. Will we upgrade the Kafka-client version first?

[DISCUSS] FLIP-268: Rack Awareness for Kafka Sources

2022-11-10 Thread Jeremy DeGroot
Kafak has a rack awareness feature that allows brokers and consumers to communicate about the rack (or AWS Availability Zone) they're located in. Reading from a local broker can save money in bandwidth and improve latency for your consumers. This improvement proposes that a Kafka Consumer could