Re: [Discuss] FLIP-13 Side Outputs in Flink

2016-12-09 Thread Chen Qin
Dear Flink community members, Please review and comment on https://github.com/apache/flink/pull/2982. Thanks, Chen -- View this message in context: http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/Discuss-FLIP-13-Side-Outputs-in-Flink-tp14204p14938.html Sent from the Apache

Re: [Discuss] FLIP-13 Side Outputs in Flink

2016-11-03 Thread Chen Qin
Adding another abstract method to Collector interface is also considerably easier from API backward compatibility point of view. The cost could be either 1) many class with empty implementation of * void collect(OutputTag tag, S value) *method 2) split streamrecord related classes that

Re: [Discuss] FLIP-13 Side Outputs in Flink

2016-11-02 Thread Chen Qin
Hi Fabian Thanks for your feedback. sorry for late reply. Some of comments inline. Will update FLIP-13 wiki reflect your comments. - Will multiple side outputs of the same type be supported? > It wasn't implemented in prototype. But should be easy to support, we have unique id in stream

Re: [Discuss] FLIP-13 Side Outputs in Flink

2016-10-27 Thread Fabian Hueske
Hi CPC, I agree, support for side outputs would be nice for DataSet as well. However, this is not easily possible because it would require an extensive rewrite of the DataSet optimizer. IMO, that's out of scope for this proposal. Cheers, Fabian 2016-10-27 0:29 GMT+02:00 CPC :

Re: [Discuss] FLIP-13 Side Outputs in Flink

2016-10-26 Thread CPC
Is it just related to stream api? This feature could be really useful for etl scenarios with dataset api as well. On Oct 26, 2016 22:29, "Fabian Hueske" wrote: > Hi Chen, > > thanks for this interesting proposal. I think side output would be a very > valuable feature to have!

Re: [Discuss] FLIP-13 Side Outputs in Flink

2016-10-26 Thread Fabian Hueske
Hi Chen, thanks for this interesting proposal. I think side output would be a very valuable feature to have! I went of the FLIP and have a few questions. - Will multiple side outputs of the same type be supported? - If I got it right, the FLIP proposes to change the signatures of many

[Discuss] FLIP-13 Side Outputs in Flink

2016-10-25 Thread Chen Qin
Hey folks, Please give feedback on FLIP-13! https://cwiki.apache.org/confluence/display/FLINK/FLIP-13+Side+Outputs+in+Flink JIRA task link to google doc https://issues.apache.org/jira/browse/FLINK-4460 Thanks, Chen Qin