Re: [VOTE] FLIP-79: Flink Function DDL Support (1.10 Release Feature Only)

2019-11-21 Thread Aljoscha Krettek
Hi, I agree with Dawid that we should either fully accept FLIPs or don’t accept them and split them off into smaller parts when necessary. This happened for the configuration FLIP-54 [1], where we couldn’t find consensus on the bigger issue and then created FLIP-77 [2]. This makes it clear what

Re: [VOTE] FLIP-79: Flink Function DDL Support (1.10 Release Feature Only)

2019-11-20 Thread Bowen Li
Hi Dawid, In general, I agree we should keep separate FLIPs when possible, if they each have some good scope and are decoupled. This one might hardly qualify for a FLIP because the scope is quite small and straight forward, and can be an overkill for FLIP itself. It's also a bit special as the MVP

Re: [VOTE] FLIP-79: Flink Function DDL Support (1.10 Release Feature Only)

2019-11-19 Thread Dawid Wysakowicz
Hi, Thank you for your answers and updating the WIKI. @Bowen Thank you for updating the wiki page and stepping up for shepherding the FLIP. Just wanted to raise a slight concern if it is possible to accept a FLIP partially according to our FLIP process. From what I know so far we were rather spl

Re: [VOTE] FLIP-79: Flink Function DDL Support (1.10 Release Feature Only)

2019-11-18 Thread Bowen Li
Hi Dawid, As title of this thread says, only features related to 1.10 release (MVP) is accepted, and the other part is still under discussion. I updated the FLIP's status field to reflect that. Also added it to https://cwiki.apache.org/confluence/display/FLINK/Flink+Improvement+Proposals I will h

Re: [VOTE] FLIP-79: Flink Function DDL Support (1.10 Release Feature Only)

2019-11-18 Thread Peter Huang
Hi David, Sorry for my misbehavior. FLINK-7151 should be the parent tickets of the function DDL effort. I recently created several tickets of it, currently including https://issues.apache.org/jira/browse/FLINK-14055 https://issues.apache.org/jira/browse/FLINK-14711 https://issues.apache.org/jira/b

Re: [VOTE] FLIP-79: Flink Function DDL Support (1.10 Release Feature Only)

2019-11-18 Thread Dawid Wysakowicz
Hey, I've just realized this FLIP was accepted but it was not reflected in the wiki page. Moreover I could not find a single jira issue that would link to the FLIP. I've seen though a few other issues and PRs being opened regarding this FLIP (FLINK-7151?, FLINK-14837, FLINK-14055). I was also a b

Re: [VOTE] FLIP-79: Flink Function DDL Support (1.10 Release Feature Only)

2019-11-11 Thread Yu Li
Thanks Bowen and Peter! Great to know. Best Regards, Yu On Tue, 12 Nov 2019 at 13:38, Peter Huang wrote: > Thank you in advance. Once the PR is done from my side, I will @ you and > yu for review. > > On Mon, Nov 11, 2019 at 9:15 PM Bowen Li wrote: > >> Thanks Peter! I assigned the ticket to

Re: [VOTE] FLIP-79: Flink Function DDL Support (1.10 Release Feature Only)

2019-11-11 Thread Peter Huang
Thank you in advance. Once the PR is done from my side, I will @ you and yu for review. On Mon, Nov 11, 2019 at 9:15 PM Bowen Li wrote: > Thanks Peter! I assigned the ticket to you, and I can help with reviewing > and merging PRs of this FLIP. > > Ccing 1.10 release manager Yu that we are on tra

Re: [VOTE] FLIP-79: Flink Function DDL Support (1.10 Release Feature Only)

2019-11-11 Thread Bowen Li
Thanks Peter! I assigned the ticket to you, and I can help with reviewing and merging PRs of this FLIP. Ccing 1.10 release manager Yu that we are on track of FLIP-79. Cheers, Bowen On Mon, Nov 11, 2019 at 9:03 PM Peter Huang wrote: > Thanks, everyone for joining the discussion and giving feedb

Re: [VOTE] FLIP-79: Flink Function DDL Support (1.10 Release Feature Only)

2019-11-11 Thread Peter Huang
Thanks, everyone for joining the discussion and giving feedback!. The voting time for FLIP-79 has passed. I'm closing the vote now. There were seven +1 votes, 3 of which are binding: - Bowen Li (binding) - Kurt Yong (binding) - Shuyi Chen (binding) - Terry Wang (non-binding) - Xuefu Zhang (non-bi

Re: [VOTE] FLIP-79: Flink Function DDL Support (1.10 Release Feature Only)

2019-11-11 Thread Jingsong Li
+1 (non-binding) Best, Jingsong Lee On Tue, Nov 12, 2019 at 9:49 AM vino yang wrote: > +1 (non-binding) > > Best, > Vino > > Xuefu Z 于2019年11月12日周二 上午3:27写道: > > > +1 (non-binding) > > > > On Mon, Nov 11, 2019 at 9:54 AM Shuyi Chen wrote: > > > > > +1 (binding) > > > > > > On Sat, Nov 9, 2019

Re: [VOTE] FLIP-79: Flink Function DDL Support (1.10 Release Feature Only)

2019-11-11 Thread vino yang
+1 (non-binding) Best, Vino Xuefu Z 于2019年11月12日周二 上午3:27写道: > +1 (non-binding) > > On Mon, Nov 11, 2019 at 9:54 AM Shuyi Chen wrote: > > > +1 (binding) > > > > On Sat, Nov 9, 2019 at 11:17 PM Kurt Young wrote: > > > > > +1 (binding) > > > > > > Best, > > > Kurt > > > > > > > > > On Sun, Nov

Re: [VOTE] FLIP-79: Flink Function DDL Support (1.10 Release Feature Only)

2019-11-11 Thread Xuefu Z
+1 (non-binding) On Mon, Nov 11, 2019 at 9:54 AM Shuyi Chen wrote: > +1 (binding) > > On Sat, Nov 9, 2019 at 11:17 PM Kurt Young wrote: > > > +1 (binding) > > > > Best, > > Kurt > > > > > > On Sun, Nov 10, 2019 at 12:25 PM Peter Huang > > > wrote: > > > > > Hi Yu, > > > > > > Thanks for your r

Re: [VOTE] FLIP-79: Flink Function DDL Support (1.10 Release Feature Only)

2019-11-11 Thread Shuyi Chen
+1 (binding) On Sat, Nov 9, 2019 at 11:17 PM Kurt Young wrote: > +1 (binding) > > Best, > Kurt > > > On Sun, Nov 10, 2019 at 12:25 PM Peter Huang > wrote: > > > Hi Yu, > > > > Thanks for your reminder about the timeline of delivering the basic > > function DDL in release 1.10. > > As I replied

Re: [VOTE] FLIP-79: Flink Function DDL Support (1.10 Release Feature Only)

2019-11-09 Thread Kurt Young
+1 (binding) Best, Kurt On Sun, Nov 10, 2019 at 12:25 PM Peter Huang wrote: > Hi Yu, > > Thanks for your reminder about the timeline of delivering the basic > function DDL in release 1.10. > As I replied to Xuefu, the "CREATE FUNCTION" and "DROP FUNCTION" can > relatively easy achieve by revis

Re: [VOTE] FLIP-79: Flink Function DDL Support (1.10 Release Feature Only)

2019-11-09 Thread Peter Huang
Hi Yu, Thanks for your reminder about the timeline of delivering the basic function DDL in release 1.10. As I replied to Xuefu, the "CREATE FUNCTION" and "DROP FUNCTION" can relatively easy achieve by revising the existing PR. Definitely, I probably need to start to work on a basic version of PR f

Re: [VOTE] FLIP-79: Flink Function DDL Support (1.10 Release Feature Only)

2019-11-09 Thread Peter Huang
Hi Xuefu, Thanks for the feedback. I think JVM is used as we don't need to distinguish scala/java based function for now. But as DDL is an important interface for Flink users. I think we should make it extendable for the future. As you said, It is JAVA and SCALA are in the LANGUAGE level rather t

Re: [VOTE] FLIP-79: Flink Function DDL Support (1.10 Release Feature Only)

2019-11-09 Thread Yu Li
Thanks for driving this Peter! I agree it would be great if we could include this feature in 1.10. However, FWIW, since we are following the time-based release policy [1] and 1.10 release is approaching its feature freeze (planned to be at the end of November) [2], I'm a little bit concerned about

Re: [VOTE] FLIP-79: Flink Function DDL Support (1.10 Release Feature Only)

2019-11-08 Thread Xuefu Z
Hi Peter, Thanks for driving this. I'm all-in for this. However, as I read the latest FLIP, I have a couple of questions/comments: 1. It seems that "JVM" is proposed as a language type in parallel to python. I'm not sure that's very intuitive. JVM stands for "java virtual machine", so the languag

Re: [VOTE] FLIP-79: Flink Function DDL Support (1.10 Release Feature Only)

2019-11-08 Thread Bowen Li
Peter and I went thru the details and defined scope/plan for 1.10 offline in the last few days. +1 (binding) from my side. On Fri, Nov 8, 2019 at 12:55 AM Terry Wang wrote: > Thanks Peter driving on this. LGTM for 1.10 release feature. > > +1 from my side. (non-binding) > > Best, > Terry Wang >

Re: [VOTE] FLIP-79: Flink Function DDL Support (1.10 Release Feature Only)

2019-11-08 Thread Terry Wang
Thanks Peter driving on this. LGTM for 1.10 release feature. +1 from my side. (non-binding) Best, Terry Wang > 2019年11月8日 13:20,Peter Huang 写道: > > Dear All, > > I would like to start the vote for 1.10 release features in FLIP-79 [1] > which is discussed and research consensus in the discus

[VOTE] FLIP-79: Flink Function DDL Support (1.10 Release Feature Only)

2019-11-07 Thread Peter Huang
Dear All, I would like to start the vote for 1.10 release features in FLIP-79 [1] which is discussed and research consensus in the discussion thread [2]. For the advanced feature, such as loading function from remote resources, support scala/python function, we will have the further discussion aft