[CANCEL][VOTE] Release 1.8.0, release candidate #2

Hi, I’m hereby canceling the vote for RC2 of Flink 1.8.0 because of various issues mentioned in the vote thread. Best, Aljoscha > On 19. Mar 2019, at 11:48, Stephan Ewen wrote: > > @Gordon The tupleByKey and benchmarkCount are most likely not caused by > serializers, more probably by a

Re: [VOTE] Release 1.8.0, release candidate #2

@Gordon The tupleByKey and benchmarkCount are most likely not caused by serializers, more probably by a network stack change. I would look at the AvroSerializer issue independent of those benchmarks. On Tue, Mar 19, 2019 at 8:23 AM Piotr Nowojski wrote: > Hi all, > > Regarding the regression

Re: [VOTE] Release 1.8.0, release candidate #2

Hi all, Regarding the regression from mid February looks like happened in this commit range 3d39cb0..a9eb6d7 I'm investigating the regression from January 29th. It happened in the commit range 35fa2b7..81acd0a (I think I managed to reproduce the results locally for it) Piotrek wt., 19 mar 2019

Re: [VOTE] Release 1.8.0, release candidate #2

Hi Chesnay, thanks for sharing your long term plan about `flink-shaded-hadoop`! Got your points. I also think we need the JIRA for that, at the follows right time. Best Regards, Jincheng Chesnay Schepler 于2019年3月18日周一 下午8:13写道： > Long term plan _is_ to move flink-shaded-hadoop to flink-shaded,

Re: [VOTE] Release 1.8.0, release candidate #2

Hi Alijoscha, I have merged the following issues found in RC1 and RC2 into the release-1.8 branch. - Add `frocksdbjni` dependency in NOTICE - FLINK-11950 - Improve end-to-end test - FLINK-11892 - Deprecated Window API - FLINK-11918 Currently, I am performing functional testing of YARN cluster

Re: [VOTE] Release 1.8.0, release candidate #2

I tested RC2 with the following items: - Maven Central Repository contains all artifacts - Built the source with Maven (ensured all source files have Apache headers) - Checked checksums and GPG files (for instance, flink-core-1.8.0.jar) that match the corresponding release files - Verified that

Re: [VOTE] Release 1.8.0, release candidate #2

Hi, The regressions in the benchmark were also brought up earlier in this thread by Yu. >From the previous investigations, these are the commits that touched relevant serializers (TupleSerializer, AvroSerializer, RowSerializer) around Jan / Feb: TupleSerializer - 73e4d0ecfd (Thu Feb 14 11:56:51

Re: [VOTE] Release 1.8.0, release candidate #2

Piotr and me discovered a possible issue in the benchmarks. Looking at the time graphs, there seems to be one issue coming around end of January. It increased network throughput, but decreased overall performance and added more variation in time (possibly through GC). Check the trend in these

Re: [VOTE] Release 1.8.0, release candidate #2

Watching the benchmark data for days and indeed it's normalized for the time being. However, the result seems to be unstable. I also tried the benchmark locally and observed obvious wave even with the same commit... I guess we may need to improve it such as increasing the RECORDS_PER_INVOCATION

Re: [VOTE] Release 1.8.0, release candidate #2

@Aljoscha I see, thanks for the quick response! Best Regards, Yu On Mon, 18 Mar 2019 at 19:11, Aljoscha Krettek wrote: > @Yu Thanks for the pointer. This is because I didn’t yet update the > buildbot configuration for the new release. It’s a point that is very low > in the release guide but I

Re: [VOTE] Release 1.8.0, release candidate #2

Long term plan _is_ to move flink-shaded-hadoop to flink-shaded, I believe there's even a JIRA for that. Until that is in place they _must_ have retain the flink version as otherwise we'd be unable to change them in follow-up releases without changing the version scheme again. And even

Re: [VOTE] Release 1.8.0, release candidate #2

Additionally, which I fortunately did not realize earlier, we must also remove the "org.rocksdb:rocksdbjni" entry from the NOTICE files. (i.e. replace them with frocksdb) On 15.03.2019 15:35, Chesnay Schepler wrote: -1 Missing dependencies in NOTICE file of flink-dist (and by extension the

Re: [VOTE] Release 1.8.0, release candidate #2

Hi Chesnay, The artifacts to be released do not have a SNAPSHOT suffix: > > https://repository.apache.org/content/repositories/orgapacheflink-1213/org/apache/flink/flink-shaded-hadoop2-uber/ Thank you for providing this link. It's very useful for contributors who want to check the RC on YARN.

Re: [VOTE] Release 1.8.0, release candidate #2

@Yu Thanks for the pointer. This is because I didn’t yet update the buildbot configuration for the new release. It’s a point that is very low in the release guide but I think I’ll do that now. > On 18. Mar 2019, at 09:37, Yu Li wrote: > > One supplement for point #2: there's a Note on the doc

Re: [VOTE] Release 1.8.0, release candidate #2

One supplement for point #2: there's a Note on the doc for the error, but I'm wondering why we don't directly remove the -DarchetypeCatalog option in the command and tell users to specify the catalog in settings.xml if they prefer to. I mean, user tends to try the command first before checking the

Re: [VOTE] Release 1.8.0, release candidate #2

Issues observed when checking quick start: 1. The versions on the document are still "1.9-SNAPSHOT" instead of "1.8.0" 2. The "Use Maven archetypes" command failed with below error: [ERROR]

Re: [VOTE] Release 1.8.0, release candidate #2

We release SNAPSHOT artifacts for all module, see https://repository.apache.org/content/groups/public/org/apache/flink/flink-core/ . The artifacts to be released do not have a SNAPSHOT suffix:

Re: [VOTE] Release 1.8.0, release candidate #2

-1 Currently, we have released the Hadoop-related JRA as a snapshot version(such as flink-shaded-hadoop2-uber/2.4.1-1.8-SNAPSHOT ), I think we should release a stable version. When testing the

Re: [VOTE] Release 1.8.0, release candidate #2

-1 Missing dependencies in NOTICE file of flink-dist (and by extension the binary distribution). * com.data-artisans:frocksdbjni:jar:5.17.2-artisans-1.0 On 14.03.2019 13:42, Aljoscha Krettek wrote: Hi everyone, Please review and vote on the release candidate 2 for Flink 1.8.0, as follows: [

Re: [VOTE] Release 1.8.0, release candidate #2

I went over the release notes and made quite a few modifications. The website PR will need an update. On 14.03.2019 13:42, Aljoscha Krettek wrote: Hi everyone, Please review and vote on the release candidate 2 for Flink 1.8.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the

Re: [VOTE] Release 1.8.0, release candidate #2

The regressions is already normalizing again. I'd observer it further before doing anything. The same applies to the benchmarkCount which tanked even more in that same run. On 15.03.2019 06:02, Tzu-Li (Gordon) Tai wrote: @Yu Thanks for reporting that Yu, great that this was noticed. The

Re: [VOTE] Release 1.8.0, release candidate #2

@Yu Thanks for reporting that Yu, great that this was noticed. The serializerAvro case seems to only be testing on-wire serialization. I checked the changes to the `AvroSerializer`, and it seems like FLINK-11436 [1] with commit 479ebd59 was the only change that may have affected that. That commit

Re: [VOTE] Release 1.8.0, release candidate #2

Hi Aljoscha and all, >From our performance benchmark web site ( http://codespeed.dak8s.net:8000/changes/) I observed a noticeable regression (-6.92%) on the serializerAvro case comparing the latest 100 revisions, which may need some attention. Thanks. Best Regards, Yu On Thu, 14 Mar 2019 at

[VOTE] Release 1.8.0, release candidate #2

Hi everyone, Please review and vote on the release candidate 2 for Flink 1.8.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * JIRA release notes [1], * the