Re: Adding flink-scala as a dependency to flink-streaming-core

2015-06-20 Thread Robert Metzger
I like option 1 the most (move to flink-core), however, it would scatter the type extractor / type information classes accross multiple projects. Why are we not moving the entire type extractor system into flink-core? There were some thoughts in the past to restructure the maven module layout:

Adding flink-scala as a dependency to flink-streaming-core

2015-06-10 Thread Gábor Gévay
Hello, I would like to ask if it would be OK if I added flink-scala as a dependency to flink-streaming-core. An alternative would be to move the Scala typeutils to flink-core (to where the Java typeutils are). Why I need this: While I am implementing the fast median calculation for windows as

Re: Adding flink-scala as a dependency to flink-streaming-core

2015-06-10 Thread Aljoscha Krettek
If they can be easily converted to Java code, that would be a good solution. On Wed, 10 Jun 2015 at 15:56 Gábor Gévay gga...@gmail.com wrote: it does not feel right to add an API package to a core package Yes, that makes sense. I just tried removing the flink-java dependency from

Re: Adding flink-scala as a dependency to flink-streaming-core

2015-06-10 Thread Till Rohrmann
Btw: I noticed that all streaming modules depend on flink-core, flink-runtime, flink-clients and flink-java. Is there a particular reason why the streaming connectors depend on flink-clients and flink-java? On Wed, Jun 10, 2015 at 3:41 PM Till Rohrmann trohrm...@apache.org wrote: I see the

Re: Adding flink-scala as a dependency to flink-streaming-core

2015-06-10 Thread Gábor Gévay
it does not feel right to add an API package to a core package Yes, that makes sense. I just tried removing the flink-java dependency from flink-streaming to see what needs it, and it builds fine without it :) What do you think about the second option? (to move the Scala typeutils (or just

Re: Adding flink-scala as a dependency to flink-streaming-core

2015-06-10 Thread Gábor Gévay
I see four options to solve this without adding the dependency: 1. Move CaseClassTypeInfo and CaseClassComparator to flink-core. Till said that we want to avoid mixed Scala and Java modules, which rules this out. 2. Create a new toplevel maven project scala-core, and move things there. 3. Hacky