Re: Re: [VOTE] FLIP-417: Expose JobManagerOperatorMetrics via REST API

2024-02-14 Thread Mason Chen
Thanks Alex, added the clarification to the FLIP doc. It will return a kv pairs of id to value following the conventions of other metric endpoints, by extending `AbstractMetricsHandler`. On Wed, Feb 14, 2024 at 9:38 AM Maximilian Michels wrote: > No objections. > > -Max > > On Wed, Feb 14, 2024

Re: Re: [VOTE] FLIP-417: Expose JobManagerOperatorMetrics via REST API

2024-02-14 Thread Maximilian Michels
No objections. -Max On Wed, Feb 14, 2024 at 1:49 PM Alexander Fedulov wrote: > > Hi Mason, > > the adjustments of not requiring the operator ID make sense to me since > this is the more prevalent expected usage pattern. I guess one small > clarification that might be needed is the mention of

Re: Re: [VOTE] FLIP-417: Expose JobManagerOperatorMetrics via REST API

2024-02-14 Thread Alexander Fedulov
Hi Mason, the adjustments of not requiring the operator ID make sense to me since this is the more prevalent expected usage pattern. I guess one small clarification that might be needed is the mention of the return data type. I assume since there are potentially multiple coordinators that can

Re: Re: [VOTE] FLIP-417: Expose JobManagerOperatorMetrics via REST API

2024-02-13 Thread Mason Chen
Hi voters and devs, I'm inclined to close the voting thread with the additional minor details to the FLIP. Please chime in if there are any objections! Best, Mason On Wed, Feb 7, 2024 at 11:49 AM Mason Chen wrote: > Hi Voters, > > JFYI, I have modified the proposed REST API path and added

Re: Re: [VOTE] FLIP-417: Expose JobManagerOperatorMetrics via REST API

2024-02-07 Thread Mason Chen
Hi Voters, JFYI, I have modified the proposed REST API path and added changes to the metric scope configuration--you can find the reasoning and discussion in the `[DISCUSS]` thread and FLIP doc. Please let me know if there are any concerns. Best, Mason On Mon, Jan 29, 2024 at 5:32 AM Thomas

Re: Re: [VOTE] FLIP-417: Expose JobManagerOperatorMetrics via REST API

2024-01-29 Thread Thomas Weise
+1 (binding) On Mon, Jan 29, 2024 at 5:45 AM Maximilian Michels wrote: > +1 (binding) > > On Fri, Jan 26, 2024 at 6:03 AM Rui Fan <1996fan...@gmail.com> wrote: > > > > +1(binding) > > > > Best, > > Rui > > > > On Fri, Jan 26, 2024 at 11:55 AM Xuyang wrote: > > > > > +1 (non-binding) > > > > >

Re: Re: [VOTE] FLIP-417: Expose JobManagerOperatorMetrics via REST API

2024-01-29 Thread Maximilian Michels
+1 (binding) On Fri, Jan 26, 2024 at 6:03 AM Rui Fan <1996fan...@gmail.com> wrote: > > +1(binding) > > Best, > Rui > > On Fri, Jan 26, 2024 at 11:55 AM Xuyang wrote: > > > +1 (non-binding) > > > > > > -- > > > > Best! > > Xuyang > > > > > > > > > > > > 在 2024-01-26 10:12:34,"Hang Ruan"

Re: Re: [VOTE] FLIP-417: Expose JobManagerOperatorMetrics via REST API

2024-01-25 Thread Rui Fan
+1(binding) Best, Rui On Fri, Jan 26, 2024 at 11:55 AM Xuyang wrote: > +1 (non-binding) > > > -- > > Best! > Xuyang > > > > > > 在 2024-01-26 10:12:34,"Hang Ruan" 写道: > >Thanks for the FLIP. > > > >+1 (non-binding) > > > >Best, > >Hang > > > >Mason Chen 于2024年1月26日周五 04:51写道: > > > >>

Re: [VOTE] FLIP-417: Expose JobManagerOperatorMetrics via REST API

2024-01-25 Thread Hang Ruan
Thanks for the FLIP. +1 (non-binding) Best, Hang Mason Chen 于2024年1月26日周五 04:51写道: > Hi Devs, > > I would like to start a vote on FLIP-417: Expose JobManagerOperatorMetrics > via REST API [1] which has been discussed in this thread [2]. > > The vote will be open for at least 72 hours unless