Re: Flink-Metrics Prometheus - Native Histograms / Native Counters

Sounds good - I haven't looked too much into the comparison of the old and new client. Opened a ticket: https://issues.apache.org/jira/browse/FLINK-32508 I may have some time to support this ticket in 2 weeks but anyone can feel free to start working on it. Thanks, Ryan van Huuksloot Sr.

Re: Flink-Metrics Prometheus - Native Histograms / Native Counters

Hi Ryan, If I look at the changelog for the simpleclient 0.10 [1], they've switched their data model. So if you upgrade to the later version, the data model for existing Flink Prometheus users would be broken IIRC. That's why I think option 1 is more clean: it provides the option to the user to

Re: Flink-Metrics Prometheus - Native Histograms / Native Counters

I'd have to check but the original plan is to upgrade the client but keep the flink-metrics-prometheus implementation the same. This should keep the metrics collection consistent even with the client upgrade - this would need to be verified. But if that is the worry then we could create a new

Re: Flink-Metrics Prometheus - Native Histograms / Native Counters

Hi Patrick, Yeah, but you would need the latest version of the client, which would break the implementation for the current, outdated one, wouldn't it? Best regards, Martijn On Fri, Jun 30, 2023 at 3:35 PM Ryan van Huuksloot wrote: > Hi Martijn, > > Option 2 and 3 would use a single client.

Re: Flink-Metrics Prometheus - Native Histograms / Native Counters

Hi Martijn, Option 2 and 3 would use a single client. It would just register the metrics differently. Does that make sense? Does that change your perspective? Thanks, Ryan van Huuksloot Sr. Production Engineer | Streaming Platform [image: Shopify]

Re: Flink-Metrics Prometheus - Native Histograms / Native Counters

Hi Ryan, I think option 2 and option 3 won't work, because there can be only one version of the client. I don't think we should make a clean break on metrics in a minor version, but only in major. All in all, I think option 1 would be the best. We could deprecate the existing one and remove it

Re: Flink-Metrics Prometheus - Native Histograms / Native Counters

Hi Martijn, Our team shared the same concern. We've considered a few options: *1. Add a new package such as `flink-metrics-prometheus-native` and eventually deprecate the original.* *Pros:* - Supports backward compatibility. *Cons:* - Two packages to maintain in the interim. - Not consistent

Re: Flink-Metrics Prometheus - Native Histograms / Native Counters

Hi Ryan, I think there definitely is an interest in the flink-metrics-prometheus, but I do see some challenges as well. Given that the Prometheus simpleclient doesn't yet have a major version, there are breaking changes happening in that. If we would update this, it can/probably breaks the

Re: Flink-Metrics Prometheus - Native Histograms / Native Counters

Following up, any interest in flink-metrics-prometheus? It is quite a stale package. I would be interested in contributing - time permitting. Ryan van Huuksloot Sr. Production Engineer | Streaming Platform [image: Shopify] On

Re: Flink Metrics

ache.org > *Sent:* Monday, October 17, 2016 12:52 AM > *Subject:* Re: Flink Metrics > > Hi Govind, > > I think the DropwizardMeterWrapper implementation is just a reference > implementation where it was decided to report the minute rate. You can > define your own

Re: Flink Metrics

ubject: Re: Flink Metrics Hi Govind, I think the DropwizardMeterWrapper implementation is just a reference implementation where it was decided to report the minute rate. You can define your own meter class which allows to configure the rate interval accordingly. Concerning Timers, I think nobody

Re: Flink Metrics

Hi Govind, I think the DropwizardMeterWrapper implementation is just a reference implementation where it was decided to report the minute rate. You can define your own meter class which allows to configure the rate interval accordingly. Concerning Timers, I think nobody requested this metric so