Re: [DISCUSS] Code style / checkstyle

I agree with adopting a custom codestyle/checkstyle for flink, but as I understood correctly most people agree there is no point of providing an unenforced code style. 2017-02-27 22:04 GMT+01:00 Greg Hogan : > There was also … > > - create a flink style (for example, leaving

Re: [DISCUSS] Code style / checkstyle

There was also … - create a flink style (for example, leaving indentation as +1 tab rather than +2 spaces as in google's style) - create a flink style but optional and unenforced (but recommended for new contributions) Flink currently has a reasonably consistent code style. I expect that

Re: [DISCUSS] Code style / checkstyle

So to sum up all the comments so far we have two alternatives. We either: 1) introduce unified checkstyle (with enforcing) and corresponding code style, both based on some established ones like google code style for java [1] and scalastyle for scala

Re: [DISCUSS] Side Outputs and Split/Select

Aljoscha, Ahh, that is much better. As long as it's explicitly referring to late data I think it's fine. I also like the second variant where a user doesn't have to explicitly create the OutputTag. On Mon, Feb 27, 2017 at 8:45 AM, Aljoscha Krettek wrote: > @Jamie I

[jira] [Created] (FLINK-5931) Make Flink highly available even if defaultFS is unavailable

Haohui Mai created FLINK-5931: - Summary: Make Flink highly available even if defaultFS is unavailable Key: FLINK-5931 URL: https://issues.apache.org/jira/browse/FLINK-5931 Project: Flink Issue

Re: [DISCUSS] Code style / checkstyle

+1 to provide and enforcing a unified code style for both java and scala. Unification should apply when it makes sense like comments though. Eventually code base should be re-factored. I would vote for the one at a time module fix apporoach. Style guide should be part of any PR review. We could

Re: [DISCUSS] Code style / checkstyle

I agree, reformatting 90% of the code base is tough. There are two main issues: (1) Incompatible merges. This is hard, especially for the folks that have to merge the pull requests ;-) (2) Author history: This is less of an issue, I think. "git log " and "git show -- " will still work and

Re: [DISCUSS] Side Outputs and Split/Select

I like this proposal! - The side output API seems more powerful, because it allows different output types. - It would be nice to eventually have only one construct, because multiple variants for the same thing tend to confuse users. - One can probably implement split/select with side

Re: [DISCUSS] Flink ML roadmap

Hello all, I’m new to this mailing list and I wanted to introduce myself. My name is Philipp Zehnder and I’m a Masters Student in Computer Science at the Karlsruhe Institute of Technology in Germany currently writing on my master’s thesis with the main goal to integrate reusable machine

Re: Flink with Yarn on MapR

While it is difficult to pinpoint exactly what is wrong without Yarn logs, there are a couple of things that I want you to ensure: 1. Is the YARN_CONF_DIR environment variable set? 2. Is the "yarn.nodemanager.resource.cpu-vcores" property set in yarn-site.xml? Let me know if these two things are

Re: Flink with Yarn on MapR

While it is difficult to pinpoint exactly what is wrong without Yarn logs, there are a couple of things that I want you to ensure: 1. Is the YARN_CONF_DIR environment variable set? 2. Is the "yarn.nodemanager.resource.cpu-vcores" property set in yarn-site.xml? Let me know if these two things are

[jira] [Created] (FLINK-5930) Allow Access to Job Id from Runtime Context

Seth Wiesman created FLINK-5930: --- Summary: Allow Access to Job Id from Runtime Context Key: FLINK-5930 URL: https://issues.apache.org/jira/browse/FLINK-5930 Project: Flink Issue Type:

Re: [DISCUSS] Side Outputs and Split/Select

I'm curious to know what people think about the OutputTag API for the general side-output implementation? One thing that might easily go overlooked is that I changed ProcessFunction from an interface to an abstract class. So that I could provide a default onTime() method. This also would require

Re: [DISCUSS] Side Outputs and Split/Select

@Jamie I must have mistyped my last API proposal. This piece of code: WindowedOperator windowedResult = input .keyBy(...) .window(...) .apply(...) DataStream lateData = windowedResult.getSideOutput(); should actually have been: WindowedOperator windowedResult = input .keyBy(...)

[jira] [Created] (FLINK-5929) Allow Access to Per-Window State in ProcessWindowFunction

Aljoscha Krettek created FLINK-5929: --- Summary: Allow Access to Per-Window State in ProcessWindowFunction Key: FLINK-5929 URL: https://issues.apache.org/jira/browse/FLINK-5929 Project: Flink

Re: ElasticsearchSink Exception

+Tzu-Li (Gordon) Tai Do you have any idea what could be causing this? I'm asking because you recently worked on the Elasticsearch connectors, right? On Sun, 26 Feb 2017 at 04:26 Govindarajan Srinivasaraghavan < govindragh...@gmail.com> wrote: > Thanks Flavio. I tried with

Re: [DISCUSS] Per-key event time

This is indeed an interesting topic, thanks for starting the discussion, Jamie! I now thought about this for a while, since more and more people seem to be asking about it lately. First, I thought that per-key watermark handling would not be necessary because it can be done locally (as Paris

Re: [DISCUSS] Code style / checkstyle

Just for a bit of context, this is the output of running cloc on the Flink codebase: --- Language files blankcomment code

[jira] [Created] (FLINK-5928) Externalized checkpoints overwritting each other

Ufuk Celebi created FLINK-5928: -- Summary: Externalized checkpoints overwritting each other Key: FLINK-5928 URL: https://issues.apache.org/jira/browse/FLINK-5928 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-5927) Remove old Aggregate interface and built-in functions

Shaoxuan Wang created FLINK-5927: Summary: Remove old Aggregate interface and built-in functions Key: FLINK-5927 URL: https://issues.apache.org/jira/browse/FLINK-5927 Project: Flink Issue

[jira] [Created] (FLINK-5926) Show state backend information in web UI

Ufuk Celebi created FLINK-5926: -- Summary: Show state backend information in web UI Key: FLINK-5926 URL: https://issues.apache.org/jira/browse/FLINK-5926 Project: Flink Issue Type: Improvement

Re: [DISCUSS] Code style / checkstyle

No, I think that's exactly what people mean when saying "losing the commit history". With the reformatting you would have to go manually through all past commits until you find the commit which changed a given line before the reformatting. Cheers, Till On Sun, Feb 26, 2017 at 6:32 PM, Alexander

[jira] [Created] (FLINK-5925) Clean up extracted RocksDB JNI library

Till Rohrmann created FLINK-5925: Summary: Clean up extracted RocksDB JNI library Key: FLINK-5925 URL: https://issues.apache.org/jira/browse/FLINK-5925 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-5923) Test instability in SavepointITCase testTriggerSavepointAndResume

Ufuk Celebi created FLINK-5923: -- Summary: Test instability in SavepointITCase testTriggerSavepointAndResume Key: FLINK-5923 URL: https://issues.apache.org/jira/browse/FLINK-5923 Project: Flink

[jira] [Created] (FLINK-5922) Remove FlinkAggregateJoinTransposeRule when upgrading to Calcite 1.12

Fabian Hueske created FLINK-5922: Summary: Remove FlinkAggregateJoinTransposeRule when upgrading to Calcite 1.12 Key: FLINK-5922 URL: https://issues.apache.org/jira/browse/FLINK-5922 Project: Flink