[jira] [Created] (FLINK-13563) TumblingGroupWindow should implement toString method

2019-08-02 Thread godfrey he (JIRA)
godfrey he created FLINK-13563: -- Summary: TumblingGroupWindow should implement toString method Key: FLINK-13563 URL: https://issues.apache.org/jira/browse/FLINK-13563 Project: Flink Issue Type:

[jira] [Created] (FLINK-13562) throws exception when FlinkRelMdColumnInterval meets two stage stream group aggregate

2019-08-02 Thread godfrey he (JIRA)
godfrey he created FLINK-13562: -- Summary: throws exception when FlinkRelMdColumnInterval meets two stage stream group aggregate Key: FLINK-13562 URL: https://issues.apache.org/jira/browse/FLINK-13562

Re: REST API / JarRunHandler: More flexibility for launching jobs

2019-08-02 Thread Thomas Weise
Thanks for looking into this. I see the "Jar run handler" as function that takes few parameters and returns a job ID. I think it would be nice if the handler doesn't hard code the function. Perhaps this could be accomplished by pushing the code into something like

[jira] [Created] (FLINK-13561) Verify and correct builtin time function's semantic for Blink planner

2019-08-02 Thread Jingsong Lee (JIRA)
Jingsong Lee created FLINK-13561: Summary: Verify and correct builtin time function's semantic for Blink planner Key: FLINK-13561 URL: https://issues.apache.org/jira/browse/FLINK-13561 Project: Flink

[jira] [Created] (FLINK-13560) Expose YARN ship files option flag for flink CLI run

2019-08-02 Thread Gyula Fora (JIRA)
Gyula Fora created FLINK-13560: -- Summary: Expose YARN ship files option flag for flink CLI run Key: FLINK-13560 URL: https://issues.apache.org/jira/browse/FLINK-13560 Project: Flink Issue Type:

[jira] [Created] (FLINK-13559) Expose YARN Dynamic configuration option flag for flink CLI run

2019-08-02 Thread Gyula Fora (JIRA)
Gyula Fora created FLINK-13559: -- Summary: Expose YARN Dynamic configuration option flag for flink CLI run Key: FLINK-13559 URL: https://issues.apache.org/jira/browse/FLINK-13559 Project: Flink

Re: instable checkpointing after migration to flink 1.8

2019-08-02 Thread Congxian Qiu
Hi Bekir Cloud you please also share the below information: - jobmanager.log - taskmanager.log(with debug info enabled) for the problematic subtask. - the DAG of your program (if can provide the skeleton program is better -- can send to me privately) For the subIndex, maybe we can use the deploy

Re: [DISCUSS][CODE STYLE] Usage of Java Optional

2019-08-02 Thread Yu Li
TL; DR: I second Timo that we should use Optional only as method return type for non-performance critical code. >From the example given on our AvroFactory [1] I also noticed that Jetbrains marks the OptionalUsedAsFieldOrParameterType inspection as a warning. It's relatively easy to understand why

[jira] [Created] (FLINK-13558) Include table examples in flink-dist

2019-08-02 Thread Dawid Wysakowicz (JIRA)
Dawid Wysakowicz created FLINK-13558: Summary: Include table examples in flink-dist Key: FLINK-13558 URL: https://issues.apache.org/jira/browse/FLINK-13558 Project: Flink Issue Type:

Re: [RESULT][VOTE] Migrate to sponsored Travis account

2019-08-02 Thread Chesnay Schepler
Update: Implemented and deployed. On 02/08/2019 12:11, Jark Wu wrote: Wow. That's great! Thanks Chesnay. On Fri, 2 Aug 2019 at 17:50, Chesnay Schepler > wrote: I'm currently modifying the cibot to do this automatically; should be finished until Monday.

Re: [DISCUSS][CODE STYLE] Usage of Java Optional

2019-08-02 Thread JingsongLee
Hi, First, Optional is just a wrapper, just like boxed value. So as long as it's not a field level operation, I think it is OK to performance. I think guava optional has a good summary to the uses. [1] > As a method return type, as an alternative to returning null to indicate that no value was

[jira] [Created] (FLINK-13557) Improve failover strategy documentation with explanation of concepts

2019-08-02 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-13557: - Summary: Improve failover strategy documentation with explanation of concepts Key: FLINK-13557 URL: https://issues.apache.org/jira/browse/FLINK-13557 Project:

Re: [DISCUSS][CODE STYLE] Usage of Java Optional

2019-08-02 Thread Timo Walther
Hi everyone, I would vote for using Optional only as method return type for non-performance critical code. Nothing more. No fields, no method parameters. Method parameters can be overloaded and internally a class can work with nulls and @Nullable. Optional is meant for API method return

[jira] [Created] (FLINK-13556) Python profile failed on Travis with setup problem

2019-08-02 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-13556: - Summary: Python profile failed on Travis with setup problem Key: FLINK-13556 URL: https://issues.apache.org/jira/browse/FLINK-13556 Project: Flink Issue

Re: [RESULT][VOTE] Migrate to sponsored Travis account

2019-08-02 Thread Jark Wu
Wow. That's great! Thanks Chesnay. On Fri, 2 Aug 2019 at 17:50, Chesnay Schepler wrote: > I'm currently modifying the cibot to do this automatically; should be > finished until Monday. > > On 02/08/2019 07:41, Jark Wu wrote: > > Hi Chesnay, > > > > Can we assign Flink Committers the permission

Re: [Question] What is the difference between Embedded and SingleLeaderElectionService?

2019-08-02 Thread Till Rohrmann
I think at the moment SingleLeaderElectionService is not really used since it is part of the YarnIntraNonHaMasterServices. The idea of these ha services was to offer a different ha implementation which slightly different guarantees. Concretely, the YarnIntraNonHaMasterServices handle operator and

Re: [RESULT][VOTE] Migrate to sponsored Travis account

2019-08-02 Thread Chesnay Schepler
I'm currently modifying the cibot to do this automatically; should be finished until Monday. On 02/08/2019 07:41, Jark Wu wrote: Hi Chesnay, Can we assign Flink Committers the permission of flink-ci/flink repo? Several times, when I pushed some new commits, the old build jobs are still in

[jira] [Created] (FLINK-13555) Failures of slot requests requiring unfulfillable managed memory should not be ignored.

2019-08-02 Thread Xintong Song (JIRA)
Xintong Song created FLINK-13555: Summary: Failures of slot requests requiring unfulfillable managed memory should not be ignored. Key: FLINK-13555 URL: https://issues.apache.org/jira/browse/FLINK-13555

[jira] [Created] (FLINK-13554) ResourceManager should have a timeout on starting new TaskExecutors.

2019-08-02 Thread Xintong Song (JIRA)
Xintong Song created FLINK-13554: Summary: ResourceManager should have a timeout on starting new TaskExecutors. Key: FLINK-13554 URL: https://issues.apache.org/jira/browse/FLINK-13554 Project: Flink

[jira] [Created] (FLINK-13553) KvStateServerHandlerTest.readInboundBlocking unstable on Travis

2019-08-02 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-13553: - Summary: KvStateServerHandlerTest.readInboundBlocking unstable on Travis Key: FLINK-13553 URL: https://issues.apache.org/jira/browse/FLINK-13553 Project: Flink

Re: [DISCUSS][CODE STYLE] Usage of Java Optional

2019-08-02 Thread Biao Liu
Hi Jark & Zili, I thought it means "Optional should not be used for class fields". However now I get a bit confused about the edited version. Anyway +1 to "Optional should not be used for class fields" Thanks, Biao /'bɪ.aʊ/ On Fri, Aug 2, 2019 at 5:00 PM Zili Chen wrote: > Hi Jark, > >

Re: [DISCUSS][CODE STYLE] Usage of Java Optional

2019-08-02 Thread Jark Wu
Hi Zili, Yes. I agree to use @Nullable/@Nonnull/SerializableOptional as the class field instead of Optional. On Fri, 2 Aug 2019 at 17:00, Zili Chen wrote: > Hi Jark, > > Follow your opinion, for class field, we can make > use of @Nullable/@Nonnull annotation or Flink's >

Re: [DISCUSS][CODE STYLE] Usage of Java Optional

2019-08-02 Thread Zili Chen
Hi Jark, Follow your opinion, for class field, we can make use of @Nullable/@Nonnull annotation or Flink's SerializableOptional. It would be sufficient. Best, tison. Jark Wu 于2019年8月2日周五 下午4:57写道: > Hi Andrey, > > I have some concern on point (3) "even class fields as e.g. optional config >

Re: [DISCUSS][CODE STYLE] Usage of Java Optional

2019-08-02 Thread Jark Wu
Hi Andrey, I have some concern on point (3) "even class fields as e.g. optional config options with implicit default values". Regarding to the Oracle's guide (4) "Optional should not be used for class fields". And IntelliJ IDEA also report warnings if a class field is Optional, because Optional

Re: [DISCUSS][CODE STYLE] Usage of Java Optional

2019-08-02 Thread Biao Liu
Hi Andrey, Thanks for working on this. +1 it's clear and acceptable for me. To Qi, IMO the most performance critical codes are "per record" code path. We should definitely avoid Optional there. For your concern, it's "per buffer" code path which seems to be acceptable with Optional. Just one

Re: [DISCUSS] CPU flame graph for a job vertex in web UI.

2019-08-02 Thread David Morávek
I've created FLINK-13550 to track the issue. Is there any committer who'd be willing to "shepherd this effort"? :) Thanks, D. On Fri, Aug 2, 2019 at 10:22 AM David Morávek wrote: > Hi Paul, for now I only plan to add the one based on java

Customize StreamingFileSink: Enable extending StreamingFileSink class

2019-08-02 Thread Kailash Dayanand
Hello, There were a few things which we missing in https://issues.apache.org/jira/browse/FLINK-12539, due to which it was not possible to extend the StreamingFileSink. To fix this I have created a follow-up PR but I am not sure if this is the best way to make these changes:

Re: [DISCUSS] CPU flame graph for a job vertex in web UI.

2019-08-02 Thread David Morávek
Hi Paul, for now I only plan to add the one based on java stack traces. On Fri, Aug 2, 2019 at 9:34 AM Paul Lam wrote: > Hi David, > > Thanks for the new feature! I think the flame graph would be a useful tool > to understand the state of job executions, and it looks good too. +1 for > this. >

Re: instable checkpointing after migration to flink 1.8

2019-08-02 Thread Bekir Oguz
Forgot to add the checkpoint details after it was complete. This is for that long running checkpoint with id 95632. > Op 2 aug. 2019, om 11:18 heeft Bekir Oguz het > volgende geschreven: > > Hi Congxian, > I was able to fetch the logs of the task manager (attached) and the > screenshots of

[jira] [Created] (FLINK-13552) Render vertex FlameGraph in web UI

2019-08-02 Thread David Moravek (JIRA)
David Moravek created FLINK-13552: - Summary: Render vertex FlameGraph in web UI Key: FLINK-13552 URL: https://issues.apache.org/jira/browse/FLINK-13552 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-13551) Add vertex FlameGraph REST endpoint

2019-08-02 Thread David Moravek (JIRA)
David Moravek created FLINK-13551: - Summary: Add vertex FlameGraph REST endpoint Key: FLINK-13551 URL: https://issues.apache.org/jira/browse/FLINK-13551 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-13550) Support for CPU FlameGraphs in new web UI

2019-08-02 Thread David Moravek (JIRA)
David Moravek created FLINK-13550: - Summary: Support for CPU FlameGraphs in new web UI Key: FLINK-13550 URL: https://issues.apache.org/jira/browse/FLINK-13550 Project: Flink Issue Type: New

[jira] [Created] (FLINK-13549) Unable to query Hive table with char or varchar columns

2019-08-02 Thread Rui Li (JIRA)
Rui Li created FLINK-13549: -- Summary: Unable to query Hive table with char or varchar columns Key: FLINK-13549 URL: https://issues.apache.org/jira/browse/FLINK-13549 Project: Flink Issue Type: Bug

Re: [DISCUSS][CODE STYLE] Breaking long function argument lists and chained method calls

2019-08-02 Thread Biao Liu
Hi Andrey, Thank you for bringing us this discussion. I would like to make some details clear. Correct me if I am wrong. The guide draft [1] says the line length is limited in 100 characters. From my understanding, this discussion suggests if there is more than 100 characters in one line (both

Re: [DISCUSS][CODE STYLE] Breaking long function argument lists and chained method calls

2019-08-02 Thread Chesnay Schepler
Just so everyone remembers: Any suggested code-style should be a) configurable in the IDE (otherwise we'll never be able to auto-format) b) be verifiable via checkstyle (otherwise we'll end up manually checking for code-style again) On 02/08/2019 03:20, SHI Xiaogang wrote: Hi Andrey, Thanks

[jira] [Created] (FLINK-13548) Support priority of the Flink YARN application

2019-08-02 Thread thy (JIRA)
thy created FLINK-13548: --- Summary: Support priority of the Flink YARN application Key: FLINK-13548 URL: https://issues.apache.org/jira/browse/FLINK-13548 Project: Flink Issue Type: Improvement

Re: [DISCUSS] CPU flame graph for a job vertex in web UI.

2019-08-02 Thread Paul Lam
Hi David, Thanks for the new feature! I think the flame graph would be a useful tool to understand the state of job executions, and it looks good too. +1 for this. And a minor question: do we plan to support multiple kinds of flame graphs? It would be great if we have both on-cpu and off-cpu

Re: [DISCUSS] CPU flame graph for a job vertex in web UI.

2019-08-02 Thread boshu Zheng
Big +1 for this helpful feature :) On 08/02/2019 13:54, Jark Wu wrote: Hi David, The demo looks charming! I think it will definitely help a lot when performance tuning. A big +1 for this. I cc-ed Yadong who's one of the main contributors of the new Web UI. Maybe he can give some help on the

[jira] [Created] (FLINK-13547) Verify and correct string function's semantic for Blink planner

2019-08-02 Thread Zhenghua Gao (JIRA)
Zhenghua Gao created FLINK-13547: Summary: Verify and correct string function's semantic for Blink planner Key: FLINK-13547 URL: https://issues.apache.org/jira/browse/FLINK-13547 Project: Flink

回复:contributor permission

2019-08-02 Thread Jeff Yang
Hi sss, The new JIRA workflow is in effect, and contributors don't have to go to dev to apply for contributor permissions. If you are interested in JIRA, you can reply directly to JIRA (of course, for complex issues, also to clarify the implementation). Then there will be a committer/pmc