Re: Re: Re: [VOTE] Accept Flink CDC into Apache Flink

2024-01-11 Thread godfrey he
+1 (binding) Thanks, Godfrey Zhu Zhu 于2024年1月12日周五 14:10写道: > > +1 (binding) > > Thanks, > Zhu > > Hangxiang Yu 于2024年1月11日周四 14:26写道: > > > +1 (non-binding) > > > > On Thu, Jan 11, 2024 at 11:19 AM Xuannan Su wrote: > > > > > +1 (non-binding) > > > > > > Best, > > > Xuannan > > > > > > On

[jira] [Created] (FLINK-31833) Support code-gen fusion for multiple operators

2023-04-18 Thread Godfrey He (Jira)
Godfrey He created FLINK-31833: -- Summary: Support code-gen fusion for multiple operators Key: FLINK-31833 URL: https://issues.apache.org/jira/browse/FLINK-31833 Project: Flink Issue Type: Sub

[jira] [Created] (FLINK-31767) Improve the implementation for "analyze table" execution

2023-04-11 Thread Godfrey He (Jira)
Godfrey He created FLINK-31767: -- Summary: Improve the implementation for "analyze table" execution Key: FLINK-31767 URL: https://issues.apache.org/jira/browse/FLINK-31767 Project: Flink

Re: [VOTE] FLIP-292: Enhance COMPILED PLAN to support operator-level state TTL configuration

2023-04-10 Thread godfrey he
+1 (binding) Best, Godfrey Jing Ge 于2023年4月10日周一 18:42写道: > > +1 (binding) > > Best Regards, > Jing > > On Mon, Apr 10, 2023 at 12:27 PM Lincoln Lee wrote: > > > +1 (binding) > > > > Best, > > Lincoln Lee > > > > > > Jane Chan 于2023年4月10日周一 18:06写道: > > > > > Hi developers, > > > > > > Thanks

Re: [External] [DISCUSS] FLIP-292: Support configuring state TTL at operator level for Table API & SQL programs

2023-04-03 Thread godfrey he
Hi Jane, Thanks for driving this FLIP. I think the compiled plan solution and the hint solution do not conflict, the two can exist at the same time. The compiled plan solution can address the need of advanced users and the platform users which all stateful operators' state TTL can be defined by

[ANNOUNCE] New Apache Flink Committer - Jing Ge

2023-02-13 Thread godfrey he
Hi everyone, On behalf of the PMC, I'm very happy to announce Jing Ge as a new Flink committer. Jing has been consistently contributing to the project for over 1 year. He authored more than 50 PRs and reviewed more than 40 PRs with mainly focus on connector, test, and document modules. He was

Re: [VOTE] FLIP-279 Unified the max display column width for SqlClient and Table APi in both Streaming and Batch execMode

2023-01-16 Thread godfrey he
+1 (binding) Best, Godfrey Shammon FY 于2023年1月12日周四 23:27写道: > > +1 (no-binding) > > > Best, > Shammon > > On Thu, Jan 12, 2023 at 8:11 PM Shengkai Fang wrote: > > > +1(binding) > > > > Best, > > Shengkai > > > > Jark Wu 于2023年1月12日周四 19:22写道: > > > > > +1 (binding) > > > Thank you for

Re: [VOTE] FLIP-280: Introduce EXPLAIN PLAN_ADVICE to provide SQL advice

2023-01-09 Thread godfrey he
+1 (binding) Best, Godfrey Jingsong Li 于2023年1月10日周二 09:56写道: > > +1 (binding) > > On Mon, Jan 9, 2023 at 6:19 PM Jane Chan wrote: > > > > Hi all, > > > > Thanks for all the feedback so far. > > Based on the discussion[1], we have come to a consensus, so I would like to > > start a vote on

Re: [DISCUSS] Adding a option for planner to decide which join reorder rule to choose

2023-01-08 Thread godfrey he
Hi Yunhong, Thanks for driving this discuss! This option looks good to me, and looking forward to contributing this rule back to Apache Calcite. Best, Godfrey yh z 于2023年1月5日周四 15:32写道: > > Hi Benchao, > > Thanks for your reply. > > Since our existing test results are based on multiple

Re: [DISCUSS] FLIP-280: Introduce a new explain mode to provide SQL advice

2023-01-02 Thread godfrey he
Thanks for driving this discussion. Do we really need to expose `PlanAnalyzerFactory` as public interface? I prefer we only expose ExplainDetail#ANALYZED_PHYSICAL_PLAN and the analyzed result. Which is enough for users and consistent with the results of `explain` method. The classes about plan

Re: [VOTE] FLIP-275: Support Remote SQL Client Based on SQL Gateway

2022-12-20 Thread godfrey he
+1 (binding) Best, Godfrey Hang Ruan 于2022年12月21日周三 15:21写道: > > +1 (non-binding) > > Best, > Hang > > Paul Lam 于2022年12月20日周二 17:36写道: > > > +1 (non-binding) > > > > Best, > > Paul Lam > > > > > 2022年12月20日 11:35,Shengkai Fang 写道: > > > > > > +1(binding) > > > > > > Best, > > > Shengkai > >

Re: [DISCUSS] Release Flink 1.16.1

2022-12-20 Thread godfrey he
Hi Martijn, Thank you for bringing this up. About Lincoln mentioned 3 commits, +1 to pick them into 1.16.1. AFAIK, several users have encountered this kind of data correctness problem so far, they are waiting a fix release as soon as possible. Best, Godfrey ConradJam 于2022年12月20日周二 15:08写道:

Re: [DISCUSS] FLIP-275: Support Remote SQL Client Based on SQL Gateway

2022-12-06 Thread godfrey he
ons > I agree, too. This part is moved to the ‘Future Work’. > > Best, > Yu Zelin > > > > 2022年12月5日 18:33,godfrey he 写道: > > > > Hi Zelin, > > > > Thanks for driving this discussion. > > > > I have a few comments, > > > >>

Re: [DISCUSS] FLIP-275: Support Remote SQL Client Based on SQL Gateway

2022-12-05 Thread godfrey he
Hi Zelin, Thanks for driving this discussion. I have a few comments, > Add RowFormat to ResultSet to indicate the format of rows. We should not require SqlGateway server to meet the display requirements of a CliClient. Because different CliClients may have different display style. The server

Re: [ANNOUNCE] New Apache Flink Committer - Matyas Orhidi

2022-11-21 Thread godfrey he
Congratulations, Matyas! Matthias Pohl 于2022年11月22日周二 13:40写道: > > Congratulations, Matyas :) > > On Tue, Nov 22, 2022 at 11:44 AM Xingbo Huang wrote: > > > Congrats Matyas! > > > > Best, > > Xingbo > > > > Yanfei Lei 于2022年11月22日周二 11:18写道: > > > > > Congrats Matyas!  > > > > > > Zheng Yu

[jira] [Created] (FLINK-29981) Improve WatermarkAssignerChangelogNormalizeTransposeRule

2022-11-10 Thread godfrey he (Jira)
godfrey he created FLINK-29981: -- Summary: Improve WatermarkAssignerChangelogNormalizeTransposeRule Key: FLINK-29981 URL: https://issues.apache.org/jira/browse/FLINK-29981 Project: Flink Issue

Re: Re: [VOTE] FLIP-263: Improve resolving schema compatibility

2022-10-28 Thread godfrey he
+1 (binding) Thanks for driving this! Best, Godfrey Yun Gao 于2022年10月28日周五 13:50写道: > > +1 (binding) > > Thanks Hangxiang for driving the FLIP. > > Best, > Yun Gao > > > > > --Original Mail -- > Sender:Zakelly Lan > Send Date:Fri Oct 28 12:27:01 2022 >

Re: [VOTE] Release 1.16.0, release candidate #2

2022-10-20 Thread godfrey he
+1 to make 1.16.0 released as soon as possible, it's been more than two months since feature freeze, 1.17 already starts kicking off. We can fix the critical bugs in 1.16.1. Best, Godfrey Xintong Song 于2022年10月21日周五 09:57写道: > > BTW, missing 1.16.0 is probably not that bad. From my experience,

Re: [DISCUSS] FLIP-263: Improve resolving schema compatibility

2022-10-20 Thread godfrey he
Hi Hangxiang, Dawid, I also prefer to add method into TypeSerializerSnapshot, which looks more natural. TypeSerializerSnapshot has `Version` concept, which also can be used for compatibility. ` TypeSerializerSnapshot { TypeSerializerSchemaCompatibility resolveSchemaCompatibility(

[jira] [Created] (FLINK-28939) Release Testing: Verify FLIP-241 ANALYZE TABLE

2022-08-11 Thread godfrey he (Jira)
godfrey he created FLINK-28939: -- Summary: Release Testing: Verify FLIP-241 ANALYZE TABLE Key: FLINK-28939 URL: https://issues.apache.org/jira/browse/FLINK-28939 Project: Flink Issue Type: Sub

[jira] [Created] (FLINK-28940) Release Testing: Verify FLIP-248 Dynamic Partition Prunning

2022-08-11 Thread godfrey he (Jira)
godfrey he created FLINK-28940: -- Summary: Release Testing: Verify FLIP-248 Dynamic Partition Prunning Key: FLINK-28940 URL: https://issues.apache.org/jira/browse/FLINK-28940 Project: Flink

[ANNOUNCE] Flink 1.16 Feature Freeze

2022-08-10 Thread godfrey he
Hi everyone, The deadline for merging new features for Flink 1.16 has passed. * From now on, only bug-fixes and documentation fixes / improvements are allowed to be merged into the master branch. * New features merged after this point can be reverted. If you need an exception to this rule,

[jira] [Created] (FLINK-28866) Use DDL instead of legacy method to register the test source in JoinITCase

2022-08-08 Thread godfrey he (Jira)
godfrey he created FLINK-28866: -- Summary: Use DDL instead of legacy method to register the test source in JoinITCase Key: FLINK-28866 URL: https://issues.apache.org/jira/browse/FLINK-28866 Project

[jira] [Created] (FLINK-28859) FAILED pyflink/datastream/connectors/tests/test_file_system.py::FileSinkCsvBulkWriterTests::test_csv_customize_quote_char_write

2022-08-07 Thread godfrey he (Jira)
godfrey he created FLINK-28859: -- Summary: FAILED pyflink/datastream/connectors/tests/test_file_system.py::FileSinkCsvBulkWriterTests::test_csv_customize_quote_char_write Key: FLINK-28859 URL: https

[jira] [Created] (FLINK-28858) Add document to describe join hints for batch sql

2022-08-07 Thread godfrey he (Jira)
godfrey he created FLINK-28858: -- Summary: Add document to describe join hints for batch sql Key: FLINK-28858 URL: https://issues.apache.org/jira/browse/FLINK-28858 Project: Flink Issue Type

[jira] [Created] (FLINK-28821) Adjust join cost for dpp query pattern which could help more plans use dpp

2022-08-04 Thread godfrey he (Jira)
godfrey he created FLINK-28821: -- Summary: Adjust join cost for dpp query pattern which could help more plans use dpp Key: FLINK-28821 URL: https://issues.apache.org/jira/browse/FLINK-28821 Project

[jira] [Created] (FLINK-28787) rename getUniqueKeys to getUpsertKeys in CommonPhysicalJoin

2022-08-03 Thread godfrey he (Jira)
godfrey he created FLINK-28787: -- Summary: rename getUniqueKeys to getUpsertKeys in CommonPhysicalJoin Key: FLINK-28787 URL: https://issues.apache.org/jira/browse/FLINK-28787 Project: Flink

[jira] [Created] (FLINK-28753) Improve FilterIntoJoinRule which could push some predicate to another side

2022-07-30 Thread godfrey he (Jira)
godfrey he created FLINK-28753: -- Summary: Improve FilterIntoJoinRule which could push some predicate to another side Key: FLINK-28753 URL: https://issues.apache.org/jira/browse/FLINK-28753 Project

[RESULT][VOTE] FLIP-248: Introduce dynamic partition pruning

2022-07-29 Thread godfrey he
Hi, everyone. FLIP-248: Introduce dynamic partition pruning[1] has been accepted. There are 4 binding votes, 1 non-binding votes[2]. - Jing Ge(non-binging) - Yun Gao(binding) - Jark Wu(binding) - Jingsong Li(binding) - Jing Zhang(binding) None against. Thanks again for every one who concerns

[jira] [Created] (FLINK-28726) CompileException: BoundedOverAggregateHelper must implement method AggsHandeFunction.setWindowSize(int)

2022-07-28 Thread godfrey he (Jira)
godfrey he created FLINK-28726: -- Summary: CompileException: BoundedOverAggregateHelper must implement method AggsHandeFunction.setWindowSize(int) Key: FLINK-28726 URL: https://issues.apache.org/jira/browse/FLINK

[jira] [Created] (FLINK-28711) Hive connector implements SupportsDynamicFiltering interface

2022-07-27 Thread godfrey he (Jira)
godfrey he created FLINK-28711: -- Summary: Hive connector implements SupportsDynamicFiltering interface Key: FLINK-28711 URL: https://issues.apache.org/jira/browse/FLINK-28711 Project: Flink

[jira] [Created] (FLINK-28710) Transform dpp ExecNode to StreamGraph

2022-07-27 Thread godfrey he (Jira)
godfrey he created FLINK-28710: -- Summary: Transform dpp ExecNode to StreamGraph Key: FLINK-28710 URL: https://issues.apache.org/jira/browse/FLINK-28710 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-28709) Implement dynamic filtering operators

2022-07-27 Thread godfrey he (Jira)
godfrey he created FLINK-28709: -- Summary: Implement dynamic filtering operators Key: FLINK-28709 URL: https://issues.apache.org/jira/browse/FLINK-28709 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-28708) Introduce planner rules to optimize dpp pattern

2022-07-27 Thread godfrey he (Jira)
godfrey he created FLINK-28708: -- Summary: Introduce planner rules to optimize dpp pattern Key: FLINK-28708 URL: https://issues.apache.org/jira/browse/FLINK-28708 Project: Flink Issue Type: Sub

[jira] [Created] (FLINK-28707) Introduce interface SupportsDynamicPartitionPruning

2022-07-27 Thread godfrey he (Jira)
godfrey he created FLINK-28707: -- Summary: Introduce interface SupportsDynamicPartitionPruning Key: FLINK-28707 URL: https://issues.apache.org/jira/browse/FLINK-28707 Project: Flink Issue Type

[jira] [Created] (FLINK-28706) FLIP-248: Introduce dynamic partition pruning

2022-07-27 Thread godfrey he (Jira)
godfrey he created FLINK-28706: -- Summary: FLIP-248: Introduce dynamic partition pruning Key: FLINK-28706 URL: https://issues.apache.org/jira/browse/FLINK-28706 Project: Flink Issue Type: New

[VOTE] FLIP-248: Introduce dynamic partition pruning

2022-07-26 Thread godfrey he
Hi everyone, Thanks for all the feedback so far. Based on the discussion[1] we seem to have consensus, so I would like to start a vote on FLIP-248 for which the FLIP has now also been updated[2]. The vote will last for at least 72 hours (Jul 29th 14:00 GMT) unless there is an objection or

Re: [DISCUSS] FLIP-248: Introduce dynamic partition pruning

2022-07-26 Thread godfrey he
Thanks for your confirmation. I will start the vote. Best, Godfrey Jing Zhang 于2022年7月26日周二 19:24写道: > > Hi, Godfrey > Thanks for updating the FLIP. > It looks good to me now. > > Best, > Jing Zhang > > godfrey he 于2022年7月26日周二 12:33写道: > > > Thank

Re: [DISCUSS] FLIP-248: Introduce dynamic partition pruning

2022-07-25 Thread godfrey he
--- > From:Jing Ge > Send Time:2022 Jul. 21 (Thu.) 18:56 > To:dev > Subject:Re: [DISCUSS] FLIP-248: Introduce dynamic partition pruning > > Hi, > > Thanks for the informative discussion! Looking forward to using dynamic > filtering provided by Flink. > >

Re: [VOTE] FLIP-247 Bulk fetch of table and column statistics for given partitions

2022-07-25 Thread godfrey he
+1 Best, Godfrey Jark Wu 于2022年7月25日周一 17:23写道: > > +1 (binding) > > Best, > Jark > > On Mon, 25 Jul 2022 at 15:10, Jing Ge wrote: > > > Hi all, > > > > Many thanks for all your feedback. Based on the discussion in [1], I'd like > > to start a vote on FLIP-247 [2]. > > > > The vote will last

Re: [DISCUSS] FLIP-248: Introduce dynamic partition pruning

2022-07-18 Thread godfrey he
mn. > > > > > > If the storage is sorted by a column, this means that the split > > > filtering on that column will be very good, so not only the partition > > > field, but also this column is worthy of being pushed down the > > > RuntimeFilter. > > &

Re: [DISCUSS] FLIP-247 Bulk fetch of table and column statistics for given partitions

2022-07-15 Thread godfrey he
Hi Jing, Thanks for the driving this, LGTM. Best, Godfrey Jingsong Li 于2022年7月15日周五 11:38写道: > > Thanks for starting this discussion. > > Have we considered introducing a listPartitionWithStats() in Catalog? > > Best, > Jingsong > > On Fri, Jul 15, 2022 at 10:08 AM Jark Wu wrote: > > > > Hi

[jira] [Created] (FLINK-28493) Add document to describe "ANALYZE TABLE" syntax

2022-07-11 Thread godfrey he (Jira)
godfrey he created FLINK-28493: -- Summary: Add document to describe "ANALYZE TABLE" syntax Key: FLINK-28493 URL: https://issues.apache.org/jira/browse/FLINK-28493 Project: Flink Issue

[jira] [Created] (FLINK-28492) Support "ANALYZE TABLE" execution

2022-07-11 Thread godfrey he (Jira)
godfrey he created FLINK-28492: -- Summary: Support "ANALYZE TABLE" execution Key: FLINK-28492 URL: https://issues.apache.org/jira/browse/FLINK-28492 Project: Flink Issue Type

[jira] [Created] (FLINK-28491) Introduce APPROX_COUNT_DISTINCT aggregate function for batch sql

2022-07-11 Thread godfrey he (Jira)
godfrey he created FLINK-28491: -- Summary: Introduce APPROX_COUNT_DISTINCT aggregate function for batch sql Key: FLINK-28491 URL: https://issues.apache.org/jira/browse/FLINK-28491 Project: Flink

[jira] [Created] (FLINK-28490) Introduce "ANALYZE TABLE" Syntax in sql parser

2022-07-11 Thread godfrey he (Jira)
godfrey he created FLINK-28490: -- Summary: Introduce "ANALYZE TABLE" Syntax in sql parser Key: FLINK-28490 URL: https://issues.apache.org/jira/browse/FLINK-28490 Project: Flink Issue

[jira] [Created] (FLINK-28489) FLIP-240: Introduce "ANALYZE TABLE" Syntax

2022-07-11 Thread godfrey he (Jira)
godfrey he created FLINK-28489: -- Summary: FLIP-240: Introduce "ANALYZE TABLE" Syntax Key: FLINK-28489 URL: https://issues.apache.org/jira/browse/FLINK-28489 Project: Flink Issue

Re: [VOTE] Creating benchmark channel in Apache Flink slack

2022-07-11 Thread godfrey he
+1, Thanks for driving this! Best, Godfrey Yuan Mei 于2022年7月11日周一 16:13写道: > > +1 (binding) & thanks for the efforts! > > Best > Yuan > > > > On Mon, Jul 11, 2022 at 2:08 PM Yun Gao > wrote: > > > +1 (binding) > > > > Thanks Anton for driving this! > > > > > > Best, > > Yun Gao > > > > > >

[DISCUSS] FLIP-248: Introduce dynamic partition pruning

2022-07-08 Thread godfrey he
Hi all, I would like to open a discussion on FLIP-248: Introduce dynamic partition pruning. Currently, Flink supports static partition pruning: the conditions in the WHERE clause are analyzed to determine in advance which partitions can be safely skipped in the optimization phase. Another

Re: Re: [VOTE] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-07-06 Thread godfrey he
+1, thanks for driving this Best, Godfrey Mang Zhang 于2022年7月5日周二 11:56写道: > > Hi everyone, > I'm sorry to bother you all, but since FLIP-218[1] has been updated, I'm > going to relaunch VOTE. > The main contents of the modification are: > 1. remove rtas from option name > 2. no longer

Re: [DISCUSS] Support partition pruning for streaming reading

2022-07-03 Thread godfrey he
Hi zoucao, Look forward your FLIP. >For Batch reading, the 'remainingPartitions' will be seen as the partitions >needed to consume, for streaming reading, we use the >'partitionPruningFunction' to ignore the unneeded partitions. There should be for bounded source(maybe batch or streaming),

[RESULT][VOTE] FLIP-240: Introduce "ANALYZE TABLE" Syntax

2022-06-29 Thread godfrey he
Hi, everyone. FLIP-240: Introduce "ANALYZE TABLE" Syntax[1] has been accepted. There are 3 binding votes, 2 non-binding votes[2]. - Jingsong Li(binding) - Shengkai Fang(binding) - Roc Marshal(non-binding) - Leonard Xu(binding) - yuxia(non-binding) None against. Thanks again for every one who

[VOTE] FLIP-240: Introduce "ANALYZE TABLE" Syntax

2022-06-24 Thread godfrey he
Hi everyone, Thanks for all the feedback so far. Based on the discussion[1] we seem to have consensus, so I would like to start a vote on FLIP-240 for which the FLIP has now also been updated[2]. The vote will last for at least 72 hours (Jun 29th 14:00 GMT, excluding weekend days) unless there

Re: Re: [ANNOUNCE] New Apache Flink Committers: Qingsheng Ren, Shengkai Fang

2022-06-24 Thread godfrey he
Congrats, Shengkai and Qingsheng! Best, Godfrey Yu Li 于2022年6月22日周三 23:55写道: > > Congrats and welcome, Qingsheng and Shengkai! > > Best Regards, > Yu > > > On Wed, 22 Jun 2022 at 17:43, Jiangang Liu > wrote: > > > Congratulations! > > > > Best, > > Jiangang Liu > > > > Mason Chen

Re: Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-06-24 Thread godfrey he
Hi all, Sorry for the late reply. >table.cor-table-as-select.atomicity-enabled Regarding `cor`, this abbreviation is not commonly used. >Create Table As Select(CTAS) feature depends on the serializability of the >catalog. To quickly see if the catalog supports CTAS, we need to try to

Re: Re: [DISCUSS] FLIP-240: Introduce "ANALYZE TABLE" Syntax

2022-06-23 Thread godfrey he
Hi, everyone. Thanks for all the inputs. If there is no feedback any more, I will start the vote tomorrow. Best, Godfrey Jing Ge 于2022年6月22日周三 15:50写道: > > sounds good to me. Thanks! > > Best regards, > Jing > > On Fri, Jun 17, 2022 at 5:37 AM godfrey he wrote: > >

Re: Re: [DISCUSS] FLIP-240: Introduce "ANALYZE TABLE" Syntax

2022-06-16 Thread godfrey he
LE > > script. In this case, I would suggest using FOR ALL PARTITIONS explicitly > > just like FOR ALL COLUMNS. > > > > Best regards, > > Jing > > > > > > On Wed, Jun 15, 2022 at 10:16 AM godfrey he wrote: > > > > > Hi Jark, > >

Re: Re: [DISCUSS] FLIP-240: Introduce "ANALYZE TABLE" Syntax

2022-06-16 Thread godfrey he
itly > just like FOR ALL COLUMNS. > > Best regards, > Jing > > > On Wed, Jun 15, 2022 at 10:16 AM godfrey he wrote: > > > Hi Jark, > > > > Thanks for the inputs. > > > > >Do we need to provide DESC EXTENDED statement like Spark[1] > > to &g

Re: [VOTE] FLIP-222: Support full job lifecycle statements in SQL client

2022-06-16 Thread godfrey he
+1 Best, Godfrey Martijn Visser 于2022年6月13日周一 20:25写道: > > +1 (binding) > > Op ma 13 jun. 2022 om 13:52 schreef Jark Wu : > > > +1 (binding) > > > > nit: the stop job syntax should be > > STOP JOB '' [WITH SAVEPOINT] [WITH DRAIN] > > which means savepoint and drain can be enabled at the same

[jira] [Created] (FLINK-28075) get statistics for partitioned table even without partition pruning

2022-06-15 Thread godfrey he (Jira)
godfrey he created FLINK-28075: -- Summary: get statistics for partitioned table even without partition pruning Key: FLINK-28075 URL: https://issues.apache.org/jira/browse/FLINK-28075 Project: Flink

[jira] [Created] (FLINK-28074) display

2022-06-15 Thread godfrey he (Jira)
godfrey he created FLINK-28074: -- Summary: display Key: FLINK-28074 URL: https://issues.apache.org/jira/browse/FLINK-28074 Project: Flink Issue Type: New Feature Reporter: godfrey he

Re: Re: [DISCUSS] FLIP-240: Introduce "ANALYZE TABLE" Syntax

2022-06-15 Thread godfrey he
gt; > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > At 2022-06-13 22:44:24, "cao zou" wrote: > > > >Hi godfrey, thanks for your det

Re: [ANNOUNCE] New Apache Flink PMC Member - Jingsong Lee

2022-06-13 Thread godfrey he
Congratulations, Jingsong! Best, Godfrey Shuo Cheng 于2022年6月13日周一 16:43写道: > > Congratulations, Jingsong! > > On 6/13/22, Paul Lam wrote: > > Congrats, Jingsong! Well deserved! > > > > Best, > > Paul Lam > > > >> 2022年6月13日 16:31,Lincoln Lee 写道: > >> > >> Congratulations, Jingsong! > >> > >>

Re: [DISCUSS] FLIP-240: Introduce "ANALYZE TABLE" Syntax

2022-06-13 Thread godfrey he
on I'm OK with doing > that here in principle. However, I wonder what will happen in the > streaming / unbounded case. Do you plan to throw an error? Or do we > complete the command as successful but without doing anything? > > > Best > Ingo > > On 13.06.22 05:50, godfrey

Re: [DISCUSS] FLIP-240: Introduce "ANALYZE TABLE" Syntax

2022-06-12 Thread godfrey he
ative? > I could imagine that for many connectors, statistics could be > implemented in a less expensive way by leveraging the underlying system > (e.g. a JDBC connector can get a row count estimate without performing a > SELECT COUNT(1)). > > > Best > Ingo > > > O

Re: [DISCUSS] FLIP-240: Introduce "ANALYZE TABLE" Syntax

2022-06-12 Thread godfrey he
LYZE TABLE' > from the user side? > > nit: There maybe exists a mistake in Examples#partition table > the partition info should be > > Partition1: (ds='2022-06-01', hr=1) > > Partition2: (ds='2022-06-01', hr=2) > > Partition3: (ds='2022-06-02', hr=1) > > Partition4: (d

[DISCUSS] FLIP-240: Introduce "ANALYZE TABLE" Syntax

2022-06-10 Thread godfrey he
Hi all, I would like to open a discussion on FLIP-240: Introduce "ANALYZE TABLE" Syntax. As FLIP-231 mentioned, statistics are one of the most important inputs to the optimizer. Accurate and complete statistics allows the optimizer to be more powerful. "ANALYZE TABLE" syntax is a very common

[jira] [Created] (FLINK-27990) Parquet format supports reporting statistics

2022-06-09 Thread godfrey he (Jira)
godfrey he created FLINK-27990: -- Summary: Parquet format supports reporting statistics Key: FLINK-27990 URL: https://issues.apache.org/jira/browse/FLINK-27990 Project: Flink Issue Type: Sub

[jira] [Created] (FLINK-27991) ORC format supports reporting statistics

2022-06-09 Thread godfrey he (Jira)
godfrey he created FLINK-27991: -- Summary: ORC format supports reporting statistics Key: FLINK-27991 URL: https://issues.apache.org/jira/browse/FLINK-27991 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-27989) CSV format supports reporting statistics

2022-06-09 Thread godfrey he (Jira)
godfrey he created FLINK-27989: -- Summary: CSV format supports reporting statistics Key: FLINK-27989 URL: https://issues.apache.org/jira/browse/FLINK-27989 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-27988) Let HiveTableSource extend from SupportsStatisticReport

2022-06-09 Thread godfrey he (Jira)
godfrey he created FLINK-27988: -- Summary: Let HiveTableSource extend from SupportsStatisticReport Key: FLINK-27988 URL: https://issues.apache.org/jira/browse/FLINK-27988 Project: Flink Issue

[jira] [Created] (FLINK-27987) Let FileSystemTableSource extend from SupportsStatisticReport

2022-06-09 Thread godfrey he (Jira)
godfrey he created FLINK-27987: -- Summary: Let FileSystemTableSource extend from SupportsStatisticReport Key: FLINK-27987 URL: https://issues.apache.org/jira/browse/FLINK-27987 Project: Flink

[jira] [Created] (FLINK-27985) Introduce FlinkRecomputeStatisticsProgram to compute statistics after filter push and partition pruning

2022-06-09 Thread godfrey he (Jira)
godfrey he created FLINK-27985: -- Summary: Introduce FlinkRecomputeStatisticsProgram to compute statistics after filter push and partition pruning Key: FLINK-27985 URL: https://issues.apache.org/jira/browse/FLINK

[jira] [Created] (FLINK-27984) Introduce FileBasedStatisticsReportableDecodingFormat interface

2022-06-09 Thread godfrey he (Jira)
godfrey he created FLINK-27984: -- Summary: Introduce FileBasedStatisticsReportableDecodingFormat interface Key: FLINK-27984 URL: https://issues.apache.org/jira/browse/FLINK-27984 Project: Flink

[jira] [Created] (FLINK-27983) Introduce SupportsStatisticsReport interface

2022-06-09 Thread godfrey he (Jira)
godfrey he created FLINK-27983: -- Summary: Introduce SupportsStatisticsReport interface Key: FLINK-27983 URL: https://issues.apache.org/jira/browse/FLINK-27983 Project: Flink Issue Type: Sub

[jira] [Created] (FLINK-27982) FLIP-231: Introduce SupportsStatisticReport to support reporting statistics from source connectors

2022-06-09 Thread godfrey he (Jira)
godfrey he created FLINK-27982: -- Summary: FLIP-231: Introduce SupportsStatisticReport to support reporting statistics from source connectors Key: FLINK-27982 URL: https://issues.apache.org/jira/browse/FLINK-27982

[RESULT][VOTE] FLIP-231: Introduce SupportsStatisticReport to support reporting statistics from source connectors

2022-06-09 Thread godfrey he
Hi, everyone. FLIP-231: Introduce SupportsStatisticReport to support reporting statistics from source connectors[1] has been accepted. There are 5 binding votes, 1 non-binding votes[2]. - Jing Ge(non-binding) - Jark Wu(binding) - Jingsong Li(binding) - Martijn Visser(binding) - Jing

Re: [DISCUSS] FLIP-222: Support full query lifecycle statements in SQL client

2022-06-08 Thread godfrey he
Hi Paul, >>>>> >>>>> I'm still doubting the keyword for the SQL applications. SHOW QUERIES >>>>> could >>>>> imply that this will actually show the query, but we're returning IDs of >>>>> the running application. At first I was also not very

Re: [VOTE] FLIP-223: Support HiveServer2 Endpoint

2022-06-08 Thread godfrey he
+1 Best, Godfrey Jark Wu 于2022年6月7日周二 17:21写道: > > +1 (binding) > > Best, > Jark > > On Tue, 7 Jun 2022 at 13:32, Shengkai Fang wrote: > > > Hi, everyone. > > > > Thanks for all feedback for FLIP-223: Support HiveServer2 Endpoint[1] on > > the discussion thread[2]. I'd like to start a vote for

Re: [VOTE] FLIP-234: Support Retryable Lookup Join To Solve Delayed Updates Issue In External Systems

2022-06-08 Thread godfrey he
+1 Best, Godfrey Jingsong Li 于2022年6月9日周四 10:26写道: > > +1 (binding) > > Best, > Jingsong > > On Tue, Jun 7, 2022 at 5:21 PM Jark Wu wrote: > > > > +1 (binding) > > > > Best, > > Jark > > > > On Tue, 7 Jun 2022 at 12:17, Lincoln Lee wrote: > > > > > Dear Flink developers, > > > > > > Thanks

[VOTE] FLIP-231: Introduce SupportStatisticReport to support reporting statistics from source connectors

2022-06-06 Thread godfrey he
Hi everyone, Thanks for all the feedback so far. Based on the discussion[1] we seem to have consensus, so I would like to start a vote on FLIP-231 for which the FLIP has now also been updated[2]. The vote will last for at least 72 hours (Jun 10th 12:00 GMT) unless there is an objection or

Re: [DISCUSS] FLIP-223: Support HiveServer2 Endpoint

2022-06-06 Thread godfrey he
urls". Here I just mean users can switch to connect to > different metastore instances using the CREATE CATALOG DDL. I updated the > FLIP to make it more clear. > > Best, > Shengkai > > godfrey he 于2022年6月6日周一 13:45写道: > > > Hi Shengkai, > > > > Thanks for

Re: [DISCUSS] FLIP-231: Introduce SupportStatisticReport to support reporting statistics from source connectors

2022-06-06 Thread godfrey he
Hi, everyone. Thanks for all the inputs. Since there is no feedback any more, I will start the vote tomorrow. Best, Godfrey godfrey he 于2022年6月1日周三 13:30写道: > > Hi, Jing. > > Thanks for the suggestion, I have updated the doc and > will continue to optimize the code in subseque

Re: [DISCUSS] FLIP-223: Support HiveServer2 Endpoint

2022-06-05 Thread godfrey he
Hi Shengkai, Thanks for driving this. I have a few comments: Could you give a whole architecture about the Ecosystem of HiveServers and the SqlGateway, such as JDBC driver, Beeline, etc. Which is more clear for users. > Considering the different users may have different requirements to connect

Re: [DISCUSS] FLIP-231: Introduce SupportStatisticReport to support reporting statistics from source connectors

2022-05-31 Thread godfrey he
troducing some kind of > Action/Performer interface with many subclasses and factory class to get > rid of some if-else statements, which could optionally be the next step > provement in the future. > > Best regards, > Jing > > On Tue, May 31, 2022 at 3:42 PM godfrey he

Re: [DISCUSS] FLIP-231: Introduce SupportStatisticReport to support reporting statistics from source connectors

2022-05-31 Thread godfrey he
tistics-type" > > is not very straightforward and clean to me. Maybe > > "source.report-statistics" = "none/all/file-size" > > would be better. > > > > We can also change "table.optimizer.source.connect-statistics-enabled" to > > "table.optimizer.source.report-s

Re: [DISCUSS] FLIP-231: Introduce SupportStatisticReport to support reporting statistics from source connectors

2022-05-27 Thread godfrey he
FLIP. I prefer a option for > > FileSystemConnector, maybe a enum. > > > > Best, > > Jingsong > > > > On Tue, May 17, 2022 at 10:31 AM godfrey he wrote: > > > > > Hi Jingsong, > > > > > > Thanks for the feedback. > &g

[jira] [Created] (FLINK-27817) TaskManager metaspace OOM for session cluster

2022-05-27 Thread godfrey he (Jira)
godfrey he created FLINK-27817: -- Summary: TaskManager metaspace OOM for session cluster Key: FLINK-27817 URL: https://issues.apache.org/jira/browse/FLINK-27817 Project: Flink Issue Type: New

[jira] [Created] (FLINK-27815) Improve the join reorder strategy for batch sql job

2022-05-27 Thread godfrey he (Jira)
godfrey he created FLINK-27815: -- Summary: Improve the join reorder strategy for batch sql job Key: FLINK-27815 URL: https://issues.apache.org/jira/browse/FLINK-27815 Project: Flink Issue Type

Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-05-23 Thread godfrey he
e job can be submitted in > > detached mode. > > > > With this interface, we can easily support LEVEL-2 semantics by calling > > `Catalog#dropTable` in the > > `JobListener#onJobFailed`. We can also support LEVEL-3 by introducing > > `StagingTableCatalog` like Spark, >

Re: [DISCUSS] FLIP-222: Support full query lifecycle statements in SQL client

2022-05-23 Thread godfrey he
or for batch jobs and the non-running jobs? > >> > >> > >> In general, the behavior would be aligned with Flink CLI. Triggering a > >> savepoint for > >> a non-running job would cause errors, and the error message would be > >> printed to > >> the SQL client. Triggering a savepoint for batch(unbounded) jobs in > >> streaming > >> execution mode would be the same with streaming jobs. However, for batch > >> jobs in > >> batch execution mode, I think there would be an error, because batch > >> execution > >> doesn’t support checkpoints currently (please correct me if I’m wrong). > >> > >> WRT ’SHOW SAVEPOINTS’, I’ve thought about it, but Flink clusterClient/ > >> jobClient doesn’t have such a functionality at the moment, neither do > >> Flink CLI. > >> Maybe we could make it a follow-up FLIP, which includes the modifications > >> to > >> clusterClient/jobClient and Flink CLI. WDYT? > >> > >> Best, > >> Paul Lam > >> > >>> 2022年5月17日 20:34,godfrey he 写道: > >>> > >>> Godfrey > >> > >> >

Re: [DISCUSS] FLIP-231: Introduce SupportStatisticReport to support reporting statistics from source connectors

2022-05-23 Thread godfrey he
nector. > > Best, > Jark > > > > > On Tue, 17 May 2022 at 10:52, Jingsong Li wrote: > > > Hi Godfrey, > > > > Thanks for your reply. > > > > Sounds good to me. > > > > > I think we should also introduce a config option > &g

Re: [VOTE] FLIP-91: Support SQL Gateway

2022-05-23 Thread godfrey he
+1 Best, Godfrey LuNing Wang 于2022年5月23日周一 13:06写道: > > +1 (non-binding) > > Best, > LuNing Wang > > Nicholas Jiang 于2022年5月23日周一 12:57写道: > > > +1 (non-binding) > > > > Best, > > Nicholas Jiang > > > > On 2022/05/20 02:38:39 Shengkai Fang wrote: > > > Hi, everyone. > > > > > > Thanks for your

Re: [VOTE] FLIP-229: Introduces Join Hint for Flink SQL Batch Job

2022-05-17 Thread godfrey he
Thanks Xuyang for driving this, +1(binding) Best, Godfrey Xuyang 于2022年5月17日周二 10:21写道: > > Hi, everyone. > Thanks for your feedback for FLIP-229: Introduces Join Hint for Flink SQL > Batch Job[1] on the discussion thread[2]. > I'd like to start a vote for it. The vote will be open for at

Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-05-17 Thread godfrey he
Hi Mang, Thanks for driving this FLIP. Please follow the FLIP template[1] style, and the `Syntax ` is part of the `Public API Changes` section. ‘Program research’ and 'Implementation Plan' are part of the `Proposed Changes` section, or move ‘Program research’ to the appendix. > Providing

Re: [DISCUSS] FLIP-222: Support full query lifecycle statements in SQL client

2022-05-17 Thread godfrey he
Hi Paul, Thanks for driving this, LGTM overall. I have a few minor comments: >SHOW QUERIES I want to clear the scope the command, does the command show the queries submitted via SqlClient, or all queries in current cluster (submitted via other CLI)? History queries are included? What's the

Re: [DISCUSS] FLIP-231: Introduce SupportStatisticReport to support reporting statistics from source connectors

2022-05-16 Thread godfrey he
tition prune happen before the stats reporting. > - only partition prune happens > - only filter pushdown happens > - both filter pushdown and partition prune happen > > Best, > Jingsong > > On Fri, May 13, 2022 at 6:57 PM godfrey he wrote: > > > Hi all, &g

[DISCUSS] FLIP-231: Introduce SupportStatisticReport to support reporting statistics from source connectors

2022-05-13 Thread godfrey he
Hi all, I would like to open a discussion on FLIP-231: Introduce SupportStatisticReport to support reporting statistics from source connectors. Statistics are one of the most important inputs to the optimizer. Accurate and complete statistics allows the optimizer to be more powerful. Currently,

[jira] [Created] (FLINK-27591) Improve the plan for batch queries when statistics is unavailable

2022-05-12 Thread godfrey he (Jira)
godfrey he created FLINK-27591: -- Summary: Improve the plan for batch queries when statistics is unavailable Key: FLINK-27591 URL: https://issues.apache.org/jira/browse/FLINK-27591 Project: Flink

[jira] [Created] (FLINK-27583) Improve the plan for TPC-DS queries

2022-05-12 Thread godfrey he (Jira)
godfrey he created FLINK-27583: -- Summary: Improve the plan for TPC-DS queries Key: FLINK-27583 URL: https://issues.apache.org/jira/browse/FLINK-27583 Project: Flink Issue Type: New Feature

  1   2   3   4   5   >