+1 to make 1.16.0 released as soon as possible, it's been more than two months since feature freeze, 1.17 already starts kicking off. We can fix the critical bugs in 1.16.1.
Best, Godfrey Xintong Song <tonysong...@gmail.com> 于2022年10月21日周五 09:57写道： > > BTW, missing 1.16.0 is probably not that bad. From my experience, the x.y.0 > releases are usually considered unstable and are mainly for trying out > purposes. Most users do not upgrade to the new version in production until > the x.y.1/2 releases, which are considered more stable. As this bug-fix is > making 1.16.1 anyway, it barely misses anything. > > Best, > > Xintong > > > > On Fri, Oct 21, 2022 at 5:10 AM Danny Cranmer <dannycran...@apache.org> > wrote: > > > We had a similar situation for Flink 1.15.1 where a non-regression > > "critical" bug was impacting a connector [1]. We decided to not block the > > release to address this issue. Based on this, I am inclined to agree with > > Martijn and move forward with the release. This bug is not marked as a > > "blocker" and we should respect that. > > > > I am happy to manage a 1.15.3 or 1.16.1 release follow up to address these > > concerns. > > > > [1] https://lists.apache.org/thread/8hxz5n6x2v4c6v8z33hdz51h1bhn768d > > > > Thanks, > > Danny > > > > On Thu, Oct 20, 2022 at 5:01 PM Martijn Visser <martijnvis...@apache.org> > > wrote: > > > > > Taking in this fix would require us to cancel RC2 and create another > > > release candidate. We are already long-overdue on the Flink 1.16 release. > > > Given that 1.15.3 is not yet released, it can't be a regression compared > > to > > > the current situation of 1.15.2. The Flink Delta connector is not part of > > > the ASF Flink community so it can't be considered a blocker from a ASF > > > Flink community perspective. > > > > > > I do understand the pain. I'm curious what others think if this is worthy > > > of cancelling the release candidate. > > > > > > Thanks, Martijn > > > > > > On Thu, Oct 20, 2022 at 4:54 PM Krzysztof Chmielewski < > > > krzysiek.chmielew...@gmail.com> wrote: > > > > > > > Thank you all for response, > > > > however i think you may miss a bigger context regarding those 3 > > tickets. > > > > > > > > Those 3 tickets [29509, 29512, 29627] are part of a bigger thing. They > > > are > > > > fixing 1.15 Sink V2 issue, where Task manager will not start after > > > recovery > > > > for Sink topology with Global Committer. The problem was described by > > me > > > in > > > > this thread [1]. We need all three to fix the problem. > > > > > > > > All three tickets were merged into 1.15 release branch and will be > > > included > > > > in 1.15.3 probably, however 1.16 will be missing one fix (29627). > > > > In other words, there will be a regression between 1.16 and 1.15.3. > > > > > > > > Additionally for now this issue is blocking Flink migration for Delta > > > > connector [2]. > > > > We need to migrate because Flink 1.14 has another Sink problem with > > data > > > > loss during Sink Recovery with Global Committer [3] and this one most > > > > likely will not be fixed since 1.14 support is ending. > > > > > > > > Forgive my if I'm wrong but what do you mean by " we won't block 1.16.0 > > > on > > > > this." Fix is merged so couldn't we just cherry pick 1.16 merge commit > > to > > > > 1.16.0's RC2? > > > > > > > > [1] https://lists.apache.org/thread/otscy199g1l9t3llvo8s2slntyn2r1jc > > > > [2] https://github.com/delta-io/connectors/tree/master/flink > > > > [3] https://issues.apache.org/jira/browse/FLINK-29589 > > > > > > > > Regards, > > > > Krzysztof Chmielewski > > > > > > > > czw., 20 paź 2022 o 16:13 Xingbo Huang <h...@apache.org> napisał(a): > > > > > > > > > Hi Krzysztof, > > > > > > > > > > When I was building rc2, I tried to search whether issues with `fix > > > > > version` of 1.16.0 have not been closed. > > > > > https://issues.apache.org/jira/browse/FLINK-29627 was missed because > > > the > > > > > `fix version` was not marked. I agree with Martijn and Xintong that > > we > > > > > won't block 1.16.0 on this. > > > > > > > > > > Best, > > > > > Xingbo > > > > > > > > > > Xintong Song <tonysong...@gmail.com> 于2022年10月20日周四 18:23写道： > > > > > > > > > > > Hi Krzysztof, > > > > > > > > > > > > FLINK-29627 is merged after rc2 being created, that's why it > > doesn't > > > > > appear > > > > > > in the change list. See the commit history of rc2 [1]. > > > > > > > > > > > > It's unfortunate this fix didn't make the 1.16.0 release (if rc2 is > > > > > > approved). However, I agree with Martijn that we should not further > > > > block > > > > > > 1.16.0 on this. If there's no other blockers discovered in the rc2, > > > the > > > > > fix > > > > > > of FLINK-29627 will be shipped in 1.16.1. > > > > > > > > > > > > Best, > > > > > > > > > > > > Xintong > > > > > > > > > > > > > > > > > > [1] https://github.com/apache/flink/commits/release-1.16.0-rc2 > > > > > > > > > > > > On Thu, Oct 20, 2022 at 6:16 PM Krzysztof Chmielewski < > > > > > > krzysiek.chmielew...@gmail.com> wrote: > > > > > > > > > > > > > Thanks Martijn, > > > > > > > just to clarify from my end, > > > > > > > > > > > > > > All three tickets, [1] [2] [3] are fixed and merged to 1.16 > > branch > > > > > > > already. I just noticed that one of them [3] is not on included > > in > > > > the > > > > > > > change list. Hence my email. > > > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-29509 > > > > > > > [2] https://issues.apache.org/jira/browse/FLINK-29512 > > > > > > > [3] https://issues.apache.org/jira/browse/FLINK-29627 > > > > > > > > > > > > > > Regards, > > > > > > > Krzysztof Chmielewski > > > > > > > > > > > > > > czw., 20 paź 2022 o 11:51 Martijn Visser < > > martijnvis...@apache.org > > > > > > > > > > > napisał(a): > > > > > > > > > > > > > > > Hi Krzysztof, > > > > > > > > > > > > > > > > Given that this issue already exists in previous Flink > > versions, > > > I > > > > > > don't > > > > > > > > think it's a blocker for 1.16. We should get it fixed (all of > > the > > > > > > > tickets) > > > > > > > > so it will be addressed in a new Flink 1.15 version, in Flink > > > > 1.16.1 > > > > > > and > > > > > > > of > > > > > > > > course Flink 1.17. > > > > > > > > > > > > > > > > Best regards, > > > > > > > > > > > > > > > > Martijn > > > > > > > > > > > > > > > > On Thu, Oct 20, 2022 at 11:47 AM Krzysztof Chmielewski < > > > > > > > > krzysiek.chmielew...@gmail.com> wrote: > > > > > > > > > > > > > > > > > Hi, > > > > > > > > > I would like to ask about [1] ticket with PR [2]. It was > > merged > > > > to > > > > > > 1.16 > > > > > > > > > release branch today but I do not see it on the change list. > > > > > > > > > > > > > > > > > > It is closely related to [3] and [4] that are on the change > > > list. > > > > > > > However > > > > > > > > > to fully fix Sink architecture issue we need all 3 tickets > > [1], > > > > [3] > > > > > > and > > > > > > > > [4] > > > > > > > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-29627 > > > > > > > > > [2] https://github.com/apache/flink/pull/21115 > > > > > > > > > [3] https://issues.apache.org/jira/browse/FLINK-29509 > > > > > > > > > [4] https://issues.apache.org/jira/browse/FLINK-29512 > > > > > > > > > > > > > > > > > > Regards, > > > > > > > > > Krzysztof Chmielewski > > > > > > > > > > > > > > > > > > czw., 20 paź 2022 o 11:21 Xingbo Huang <h...@apache.org> > > > > > napisał(a): > > > > > > > > > > > > > > > > > > > Hi everyone, > > > > > > > > > > > > > > > > > > > > Please review and vote on the release candidate #2 for the > > > > > version > > > > > > > > > 1.16.0, > > > > > > > > > > as follows: > > > > > > > > > > [ ] +1, Approve the release > > > > > > > > > > [ ] -1, Do not approve the release (please provide specific > > > > > > comments) > > > > > > > > > > > > > > > > > > > > The complete staging area is available for your review, > > which > > > > > > > includes: > > > > > > > > > > * JIRA release notes [1], > > > > > > > > > > * the official Apache source release and binary convenience > > > > > > releases > > > > > > > to > > > > > > > > > be > > > > > > > > > > deployed to dist.apache.org [2], which are signed with the > > > key > > > > > > with > > > > > > > > > > fingerprint 3C2C9FFB59DF9F3E [3], > > > > > > > > > > * all artifacts to be deployed to the Maven Central > > > Repository > > > > > [4], > > > > > > > > > > * source code tag "release-1.16.0-rc2" [5], > > > > > > > > > > * website pull request listing the new release and adding > > > > > > > announcement > > > > > > > > > blog > > > > > > > > > > post [6]. > > > > > > > > > > > > > > > > > > > > The vote will be open for at least 72 hours. It is adopted > > by > > > > > > > majority > > > > > > > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > Chesnay, Martijn, Godfrey & Xingbo > > > > > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12351275 > > > > > > > > > > [2] > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-1.16.0-rc2 > > > > > > > > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > > > > > > > > [4] > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheflink-1541 > > > > > > > > > > [5] > > https://github.com/apache/flink/tree/release-1.16.0-rc2 > > > > > > > > > > [6] https://github.com/apache/flink-web/pull/574 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
