[DISCUSS] Add custom labels on AbstractPrometheusReporter like PrometheusPushGatewayReporter's groupingKey

2020-04-24 Thread jinhai wang
Hi all I'd like to start the discussion about Prometheus labelNames. We need to add some custom labels on Prometheus, so we can query by them. We can add groupingKey to PrometheusPushGatewayReporter in version 1.10, but not in PrometheusReporter. Can we add abstract addLabels method on

[DISCUSS] Add a custom label on MetricReporter like PrometheusPushGatewayReporter's groupingKey

2020-04-23 Thread jinhai wang
Hi all We need add some custom labels on MetricReporter. We can add groupingKey to PrometheusPushGatewayReporter in version 1.10, but not in PrometheusReporter. Can we add several methods to the interface MetricReporter to support? Best Regards jinhai...@gmail.com

Re: [jira] [Commented] (FLINK-17200) Add connectors to ClickHouse

2020-04-17 Thread jinhai wang
@Dawid @dev Can we separate the flink-connectors project so that we can support more connectors in the future? Like this jira:Add connectors to ClickHouse Best Regards jinhai...@gmail.com > 2020年4月17日 下午3:07,Dawid Wysakowicz (Jira) 写道: > > >[ >

Re: [DISCUSS] (FLINK-16648) Clean up the input parameter StreamQueryConfig of the API in StreamTableEnvironment

2020-03-18 Thread jinhai wang
+1 to remove, I think we can remove StreamQueryConfig too. since we have > deprecated StreamQueryConfig two versions. > > Remember to record it in release notes of issue. > > Best, > Jingsong Lee > > On Wed, Mar 18, 2020 at 5:58 PM jinhai wang wrote: > >>

[DISCUSS] (FLINK-16648) Clean up the input parameter StreamQueryConfig of the API in StreamTableEnvironment

2020-03-18 Thread jinhai wang
Hi Devs I would like to start the formal discussion about FLINK-16648. StreamQueryConfig is deprecated and replaced by TableConfig in the future, and TableEnvironment class has config object. Do we need to delete the interfaces in StreamTableEnvironment and StreamTableEnvironmentImpl:

Re: [DISCUSS] FLIP-115: Filesystem connector in Table

2020-03-13 Thread jinhai wang
Thanks for FLIP-115. It is really useful feature for platform developers who manage hundreds of Flink to Hive jobs in production. I think we need add 'connector.sink.username' for UserGroupInformation when data is written to HDFS 在 2020/3/13 下午3:33,“Jingsong Li” 写入: Hi everyone,

Re: [DISCUSS] FLIP-115: Filesystem connector in Table

2020-03-13 Thread jinhai wang
Thanks for FLIP-115. It is really useful feature for platform developers who manage hundreds of Flink to Hive jobs in production. I think we need add 'connector.sink.username' for UserGroupInformation when data is written to HDFS Jingsong Li 于2020年3月13日周五 下午3:33写道: > Hi everyone, > > I'd like

Re: [DISCUSS] Drop Bucketing Sink

2020-03-13 Thread jinhai wang
Hi +1 to drop bucketing sink FLIP-115 also needs to be prioritized for 1.11 在 2020/3/13 上午10:07,“Jingsong Li” 写入: Hi Robert, +1 to drop it but maybe not 1.11. ORC has not been supported on StreamingFileSink. I have seen lots of users run ORC in the bucketing sink.