Re: [DISCUSS] FLIP-10: Unify Savepoints and Checkpoints

2016-08-22 Thread Till Rohrmann
+1 for the FLIP. I like the described changes and new functionality. When looking at the public interface, I was wondering whether we should not allow the user to specify a TimeUnit for the periodic interval. I think it's nicer to be able to specify the time unit instead of converting everything

Re: [DISCUSS] FLIP-10: Unify Savepoints and Checkpoints

2016-08-19 Thread Aljoscha Krettek
+1 A great proposal. I'd like to suggest one change. In one paragraph you say "If no savepoint path is configured, fail the savepoint.". I think this is problematic because it means that users who forgot to add the setting to the config will be at a dead if they want to update. Can we make it

Re: [DISCUSS] FLIP-10: Unify Savepoints and Checkpoints

2016-08-19 Thread Gyula Fóra
Hi Ufuk, Great initiative in general I agree with pretty much everything in the proposal. Some minor comments: With these changes savepoints and checkpoints become pretty much the same thing so we might as well drop one of the concepts and just refer to checkpoints as savepoints that are

[DISCUSS] FLIP-10: Unify Savepoints and Checkpoints

2016-08-19 Thread Ufuk Celebi
Hey devs! I've created a FLIP to unify savepoints and checkpoints: https://cwiki.apache.org/confluence/display/FLINK/FLIP-10%3A+Unify+Checkpoints+and+Savepoints# Looking forward to your feedback. – Ufuk