Hi everyone,
Thanks for the comments in the doc. I have updated the doc into wiki page.
As there are no further concerns, I will start a voting process soon.
Thanks,
Jark
On Fri, 15 Nov 2019 at 23:36, Jark Wu wrote:
> Hi,
>
> Thank you all for the positive feedbacks so far.
>
> Timo
Hi,
Thank you all for the positive feedbacks so far.
Timo discussed with me offline about the format properties, and we think
that this FLIP
should also cover formats, otherwise we need to touch the properties again
in the future.
The bad experience of format properties is that
+1 to the general idea of this FLIP.
Regarding to connector properties, IIUC it would be divided into 2 parts:
1. connector.key1 = value1, these are interpreted by Flink framework and
do whatever needed for such property.
2. connector.properties.xxx.key = value. There items are prefixed with
Yes, personally I would also go with the external system's format for
the exact reason you mentioned.
Best,
Dawid
On 14/11/2019 10:32, Jark Wu wrote:
> Hi Dawid,
>
> The `connector.properties.zookeeper.connect` sounds good to me.
>
> Just to clarify, in this way, we can support arbitrary
Hi Dawid,
The `connector.properties.zookeeper.connect` sounds good to me.
Just to clarify, in this way, we can support arbitrary properties and we
can document the important ones.
And regarding to the value format, shall we use the external system's
format or use Flink's format, e.g. the list
Hi Jark,
I see the not readable point and that is also my concern about my
suggestion with all the properties under a single key as the list might
get quite long.
What do you think about modifying your suggestion a bit and at least add
the `properties` prefix? So that we can distinguish the
Hi Dawid, Konstantin,
This is an interesting topic. I will list the prons and cons of these 2
options.
1) under a single key: `connector.properties`
Cons:
- Users can pass in arbitrary properties defined in kafka docs
Prons:
- The property value is collapsed together and will be long and not
Hi Dawid, Hi Jark,
in my experience it is very important to be able to forward arbitrary
properties to the underlying KafkaClient. This seems to be possible in both
cases. I am leaning towards Jark's original suggestion. Flink's
documentation would only need to state that it forwards everything
Hi Jark,
Majority of the changes make sense to me. I think they will be helpful
for the users. I have a slight concern about the
kafka's connector.properties property :) . I wonder if we should have
them under a single key:
connector.properties:
Hi everyone,
Connector properties is a very basic component which is used to construct a
connector table via YAML, descriptor API, or DDL. It is also the
serialization representation when persisting into catalog. However, we have
encountered some problems when using connector properties,
10 matches
Mail list logo
