Re: [VOTE] FLIP-181: Custom netty HTTP request inbound/outbound handlers

Thanks for your input, team. Good catch, Chesney. Till, we will address said comments. All in all now we can close the vote successfully with the binding +1 votes of Gyula, Konstantin and Till. On Mon, Jul 12, 2021 at 10:42 AM Till Rohrmann wrote: > Thanks for starting the vote Marton. > > I

Re: [VOTE] FLIP-181: Custom netty HTTP request inbound/outbound handlers

Thanks for starting the vote Marton. I have two comments: * I would suggest that the interfaces return Optional or at least have a @Nullable annotation in order to make the contract explicit. * The test plan should contain tests for the general infrastructure which should live in Flink. We

Re: [VOTE] FLIP-181: Custom netty HTTP request inbound/outbound handlers

+1 (binding) Assuming that we continue to vote in this thread for now. Thank you for your patience! On Mon, Jul 12, 2021 at 8:56 AM Chesnay Schepler wrote: > The vote has not reached the required number of votes to be considered > successful. > > As outlined in the bylaws > < >

Re: [VOTE] FLIP-181: Custom netty HTTP request inbound/outbound handlers

The vote has not reached the required number of votes to be considered successful. As outlined in the bylaws FLIP votes require 3 binding +1 votes (i.e., from committers). On 10/07/2021 16:13,

Re: [VOTE] FLIP-181: Custom netty HTTP request inbound/outbound handlers

Hi team, Thank you for your input, I am closing this vote as successful. Austin: thank you, I have added the experimental annotation explicitly to the FLIP. On Tue, Jul 6, 2021 at 5:17 PM Gabor Somogyi wrote: > +1 (non-binding) > The @Experimental annotation is really missing, Marton could you

Re: [VOTE] FLIP-181: Custom netty HTTP request inbound/outbound handlers

+1 (non-binding) The @Experimental annotation is really missing, Marton could you add it please? On Tue, Jul 6, 2021 at 5:04 PM Austin Cawley-Edwards < austin.caw...@gmail.com> wrote: > Hi Márton, > > The FLIP looks generally good to me, though could we add the > `@Experimental` annotation to

Re: [VOTE] FLIP-181: Custom netty HTTP request inbound/outbound handlers

Hi Márton, The FLIP looks generally good to me, though could we add the `@Experimental` annotation to the proposed interfaces so it is in sync with what was agreed in the discussion thread? Thanks, Austin On Tue, Jul 6, 2021 at 9:40 AM Gyula Fóra wrote: > +1 from my side > > This is a good

Re: [VOTE] FLIP-181: Custom netty HTTP request inbound/outbound handlers

+1 from my side This is a good addition that will open many possibilities in the future and solve some immediate issues with the current Kerberos integration. Gyula On Tue, Jul 6, 2021 at 2:50 PM Márton Balassi wrote: > Hi everyone, I would like to start a vote on FLIP-181 [1] which was >

[VOTE] FLIP-181: Custom netty HTTP request inbound/outbound handlers

Hi everyone, I would like to start a vote on FLIP-181 [1] which was discussed in this thread [2]. The vote will be open for at least 72 hours until July 9th unless there is an objection or not enough votes. [1] https://cwiki.apache.org/confluence/x/CAUBCw [2]