Re: Re: Switch to Scala 2.11 as a default build profile

2017-06-29 Thread Stavros Kontopoulos
+10 I think it makes sense spark is also using 2.11 as the default for quite some time. On Thu, Jun 29, 2017 at 8:14 PM, Bowen Li wrote: > EMR's builtin Flink is always 1 or 2 versions behind Flink latest release. > We choose to install Flink on EMR ourselves. > > On Thu, Jun 29, 2017 at 2:37 AM

Re: Re: Switch to Scala 2.11 as a default build profile

2017-06-29 Thread Bowen Li
EMR's builtin Flink is always 1 or 2 versions behind Flink latest release. We choose to install Flink on EMR ourselves. On Thu, Jun 29, 2017 at 2:37 AM, 郭健 wrote: > +1 > Most of the time I need to build scala-2.11 version, although I can use > the script tools/change-version.sh to change scala v

Re: Re: Switch to Scala 2.11 as a default build profile

2017-06-29 Thread 郭健
+1 Most of the time I need to build scala-2.11 version, although I can use the script tools/change-version.sh to change scala version in all poms, it breaks the code consistency with the master branch. Aegeaner On 6/28/17, 22:23, "Piotr Nowojski" wrote: Yes, I know and I’m proposing to

Re: Switch to Scala 2.11 as a default build profile

2017-06-29 Thread Jörn Franke
EMR has a flink package. Just go to advanced options and but a checkbox on flink. No need to build yourself. > On 29. Jun 2017, at 05:56, Bowen Li wrote: > > +1. > > AWS EMR eco system is using Scala 2.11, and breaks with Scala 2.10. We had > to build several Flink components (e.g. flink-kines

Re: Switch to Scala 2.11 as a default build profile

2017-06-28 Thread Bowen Li
+1. AWS EMR eco system is using Scala 2.11, and breaks with Scala 2.10. We had to build several Flink components (e.g. flink-kinesis-connector) ourselves in order to run on EMR. Defaulting to Scala 2.11 will greatly reduce adoption cost for Flink on EMR On Wed, Jun 28, 2017 at 9:34 AM, Till Rohr

Re: Switch to Scala 2.11 as a default build profile

2017-06-28 Thread Till Rohrmann
I'm +1 for changing the profile and to start a discussion to drop Scala 2.10. Scala 2.10 is already quite old and the current stable version is 2.12. I would be surprised to see many people still using Scala 2.10. Cheers, Till On Wed, Jun 28, 2017 at 4:53 PM, Ted Yu wrote: > Here is the KIP th

Re: Switch to Scala 2.11 as a default build profile

2017-06-28 Thread Ted Yu
Here is the KIP that drops support for Scala 2.10 in Kafka 0.11 : https://cwiki.apache.org/confluence/display/KAFKA/KIP-119%3A+Drop+Support+for+Scala+2.10+in+Kafka+0.11 FYI On Wed, Jun 28, 2017 at 7:23 AM, Piotr Nowojski wrote: > Yes, I know and I’m proposing to change this in parent pom by de

Re: Switch to Scala 2.11 as a default build profile

2017-06-28 Thread Piotr Nowojski
Yes, I know and I’m proposing to change this in parent pom by default to scala-2.11. Changing parent pom every time anyone wants to touch/build in Intellij Kafka 0.11 connector is not a great idea. This would require a developer to constantly stash those changes or commit and revert them before

Re: Switch to Scala 2.11 as a default build profile

2017-06-28 Thread Greg Hogan
You don't need to use the build profile in IntelliJ, just change scala.version and scala.binary.version in the parent pom (recent refactorings made this possible without changing every pom). What is the benefit for changing the default without dropping older versions when contributions are still l

Re: Switch to Scala 2.11 as a default build profile

2017-06-28 Thread Piotr Nowojski
I have created an issue for this: https://issues.apache.org/jira/browse/FLINK-7030 and PR: https://github.com/apache/flink/pull/4209 Piotrek > On Jun 28, 2017, at 2:45 PM, Aljoscha Krettek wrote:

Re: Switch to Scala 2.11 as a default build profile

2017-06-28 Thread Aljoscha Krettek
+1 For changing the default. I think a lot of systems don’t even support 2.10 anymore. > On 28. Jun 2017, at 14:38, Ted Yu wrote: > > +1 on using Scale 2.11 as default. > Original message From: Piotr Nowojski > Date: 6/28/17 5:36 AM (GMT-08:00) To: > dev@flink.apache.org

Re: Switch to Scala 2.11 as a default build profile

2017-06-28 Thread Ted Yu
+1 on using Scale 2.11 as default.  Original message From: Piotr Nowojski Date: 6/28/17 5:36 AM (GMT-08:00) To: dev@flink.apache.org Subject: Switch to Scala 2.11 as a default build profile Hi, I propose to switch to Scala 2.11 as a default and to have a Scala 2.10 build pr