[jira] [Commented] (FLUME-1930) Inflights should clean up executors on close.

2013-03-14 Thread Hari Shreedharan (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13602072#comment-13602072 ] Hari Shreedharan commented on FLUME-1930: - If the checkpoint contents are present,

Re: Review Request: FLUME-1926. Optionally timeout Avro Sink Rpc Clients to avoid stickiness

2013-03-14 Thread Juhani Connolly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9813/#review17855 --- Ship it! Ship It! - Juhani Connolly On March 8, 2013, 1:56 a.m.,

[jira] [Updated] (FLUME-1930) Inflights should clean up executors on close.

2013-03-14 Thread Hari Shreedharan (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hari Shreedharan updated FLUME-1930: Attachment: FLUME-1930-1.patch Removed an accidental change to hbase sink.

[jira] [Created] (FLUME-1950) AsyncHBaseSink reconfiguration can fail if serializer.cleanUp() throws

2013-03-14 Thread Hari Shreedharan (JIRA)
Hari Shreedharan created FLUME-1950: --- Summary: AsyncHBaseSink reconfiguration can fail if serializer.cleanUp() throws Key: FLUME-1950 URL: https://issues.apache.org/jira/browse/FLUME-1950 Project:

[jira] [Updated] (FLUME-1950) AsyncHBaseSink reconfiguration can fail if serializer.cleanUp() throws or if hbase client is not shutdown correctly

2013-03-14 Thread Hari Shreedharan (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hari Shreedharan updated FLUME-1950: Summary: AsyncHBaseSink reconfiguration can fail if serializer.cleanUp() throws or if

Review Request: FLUME-1950. AsyncHBaseSink reconfiguration can fail if serializer.cleanUp() throws or if hbase client is not shutdown correctly

2013-03-14 Thread Hari Shreedharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9921/ --- Review request for Flume. Description --- Retry close of hbase client if

[jira] [Updated] (FLUME-1950) AsyncHBaseSink reconfiguration can fail if serializer.cleanUp() throws or if hbase client is not shutdown correctly

2013-03-14 Thread Hari Shreedharan (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hari Shreedharan updated FLUME-1950: Attachment: FLUME-1950.patch AsyncHBaseSink reconfiguration can fail if

Re: Review Request: Flume UDP Source for Windows Events being trimmed at \n characters by SyslogUtils.extractEvent() function

2013-03-14 Thread Alexander Alten-Lorenz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9842/#review17861 --- What do your think to rename MultilineBody into SyslogMultiLineBody?

Re: Review Request: FLUME-1950. AsyncHBaseSink reconfiguration can fail if serializer.cleanUp() throws or if hbase client is not shutdown correctly

2013-03-14 Thread Alexander Alten-Lorenz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9921/#review17862 ---

[jira] [Commented] (FLUME-1930) Inflights should clean up executors on close.

2013-03-14 Thread Juhani Connolly (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13602099#comment-13602099 ] Juhani Connolly commented on FLUME-1930: Confirmed working and committed, thanks

Re: Review Request: Flume UDP Source for Windows Events being trimmed at \n characters by SyslogUtils.extractEvent() function

2013-03-14 Thread Ambud Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9842/ --- (Updated March 14, 2013, 7:10 a.m.) Review request for Flume. Changes ---

Re: Review Request: Flume UDP Source for Windows Events being trimmed at \n characters by SyslogUtils.extractEvent() function

2013-03-14 Thread Ambud Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9842/ --- (Updated March 14, 2013, 7:14 a.m.) Review request for Flume. Changes ---

Re: Review Request: Flume UDP Source for Windows Events being trimmed at \n characters by SyslogUtils.extractEvent() function

2013-03-14 Thread Ambud Sharma
On March 14, 2013, 6:53 a.m., Alexander Alten-Lorenz wrote: What do your think to rename MultilineBody into SyslogMultiLineBody? I have changed the variable and constant names accordingly. Please let me know if the patch looks ok now? Als, do I need to provide a corresponding config

[jira] [Created] (FLUME-1951) Remove unused future from FlumeEventQueue

2013-03-14 Thread Hari Shreedharan (JIRA)
Hari Shreedharan created FLUME-1951: --- Summary: Remove unused future from FlumeEventQueue Key: FLUME-1951 URL: https://issues.apache.org/jira/browse/FLUME-1951 Project: Flume Issue Type:

Re: Review Request: FLUME-1516. Write dual checkpoints.

2013-03-14 Thread Hari Shreedharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8899/ --- (Updated March 14, 2013, 7:31 a.m.) Review request for Flume. Changes ---

[jira] [Updated] (FLUME-1516) Write Dual Checkpoints to avoid replays

2013-03-14 Thread Hari Shreedharan (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hari Shreedharan updated FLUME-1516: Attachment: FLUME-1516-4.patch Further rebased. Write Dual Checkpoints

[jira] [Commented] (FLUME-1951) Remove unused future from FlumeEventQueue

2013-03-14 Thread Hari Shreedharan (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13602134#comment-13602134 ] Hari Shreedharan commented on FLUME-1951: - This change is part of FLUME-1516, so

Re: Review Request: Flume UDP Source for Windows Events being trimmed at \n characters by SyslogUtils.extractEvent() function

2013-03-14 Thread Alexander Alten-Lorenz
On March 14, 2013, 6:53 a.m., Alexander Alten-Lorenz wrote: What do your think to rename MultilineBody into SyslogMultiLineBody? Ambud Sharma wrote: I have changed the variable and constant names accordingly. Please let me know if the patch looks ok now? Als, do I need to

Re: Review Request: FLUME-1516. Write dual checkpoints.

2013-03-14 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8899/#review17876 --- Hari, looks good and thanks for the hard work!! Below is a first

[jira] [Updated] (FLUME-1782) Elastic Search sink does not use UTC to determine the correct index to write to.

2013-03-14 Thread Edward Sargisson (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Sargisson updated FLUME-1782: Attachment: flume-1782-2.patch New patch attached which will only warn about missing

Re: Review Request: FLUME-1516. Write dual checkpoints.

2013-03-14 Thread Brock Noland
On March 14, 2013, 6:10 p.m., Hari Shreedharan wrote: flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java, line 154 https://reviews.apache.org/r/8899/diff/6/?file=270479#file270479line154 The reason there is a

[jira] [Updated] (FLUME-1516) Write Dual Checkpoints to avoid replays

2013-03-14 Thread Hari Shreedharan (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hari Shreedharan updated FLUME-1516: Attachment: FLUME-1516-5.patch Write Dual Checkpoints to avoid replays

[jira] [Commented] (FLUME-1782) Elastic Search sink does not use UTC to determine the correct index to write to.

2013-03-14 Thread Israel Ekpo (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13602910#comment-13602910 ] Israel Ekpo commented on FLUME-1782: It think it would be helpful if the user can

[jira] [Commented] (FLUME-1949) Documentation for sink processor lists incorrect default

2013-03-14 Thread Mike Percy (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13602911#comment-13602911 ] Mike Percy commented on FLUME-1949: --- +1 looks good. I am also fixing another layout

[jira] [Commented] (FLUME-1911) Add deprecation back to the legacy thrift code

2013-03-14 Thread Mike Percy (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13602919#comment-13602919 ] Mike Percy commented on FLUME-1911: --- +1 Add deprecation back to the

[jira] [Commented] (FLUME-1882) Allow case-insensitive deserializer value for SpoolDirectorySource

2013-03-14 Thread Mike Percy (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13602929#comment-13602929 ] Mike Percy commented on FLUME-1882: --- +1 lgtm Allow case-insensitive

[jira] [Resolved] (FLUME-1831) Flume User Guide specifies default value for bufferMaxLineLength for SpoolDirectorySource when there's no default

2013-03-14 Thread Mike Percy (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Percy resolved FLUME-1831. --- Resolution: Duplicate Thanks, this issue was taken care of as part of FLUME-1800

[jira] [Resolved] (FLUME-1806) Test Only a Test - Patch Available with no attachments

2013-03-14 Thread Mike Percy (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Percy resolved FLUME-1806. --- Resolution: Invalid I assume this was a temporary test :) Test Only a Test - Patch

[jira] [Commented] (FLUME-1511) Scribe-source doesn't handle zero message request correctly.

2013-03-14 Thread Mike Percy (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13602948#comment-13602948 ] Mike Percy commented on FLUME-1511: --- +1 lgtm. (I wish we had unit tests for this

[jira] [Commented] (FLUME-1521) Document the StressSource

2013-03-14 Thread Mike Percy (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13602960#comment-13602960 ] Mike Percy commented on FLUME-1521: --- Hi Denny, Any plans to update this patch based on

[jira] [Commented] (FLUME-1930) Inflights should clean up executors on close.

2013-03-14 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13602982#comment-13602982 ] Hudson commented on FLUME-1930: --- Integrated in flume-trunk #376 (See

[jira] [Commented] (FLUME-1926) Optionally timeout Avro Sink Rpc Clients to avoid stickiness

2013-03-14 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13602983#comment-13602983 ] Hudson commented on FLUME-1926: --- Integrated in flume-trunk #376 (See

[jira] [Commented] (FLUME-1939) FlumeEventQueue must check if file is open before setting the length of the file

2013-03-14 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13602985#comment-13602985 ] Hudson commented on FLUME-1939: --- Integrated in flume-trunk #376 (See

[jira] [Commented] (FLUME-1943) ExecSource tests failing on Jenkins

2013-03-14 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13602984#comment-13602984 ] Hudson commented on FLUME-1943: --- Integrated in flume-trunk #376 (See

[jira] [Commented] (FLUME-1929) CheckpointRebuilder main method does not work

2013-03-14 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13602986#comment-13602986 ] Hudson commented on FLUME-1929: --- Integrated in flume-trunk #376 (See

[jira] [Commented] (FLUME-1686) exclude target directories from rat checks

2013-03-14 Thread Mike Percy (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13602994#comment-13602994 ] Mike Percy commented on FLUME-1686: --- +1. But I am leaving out the last line (data/**)

[jira] [Updated] (FLUME-1686) Exclude target directories Eclipse files from rat checks

2013-03-14 Thread Mike Percy (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Percy updated FLUME-1686: -- Summary: Exclude target directories Eclipse files from rat checks (was: exclude target directories

[jira] [Commented] (FLUME-1822) Update javadoc for FlumeConfiguration

2013-03-14 Thread Mike Percy (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13602998#comment-13602998 ] Mike Percy commented on FLUME-1822: --- +1 lgtm Update javadoc for

[jira] [Commented] (FLUME-1932) no-reload-conf command line param does not work

2013-03-14 Thread Mike Percy (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13603010#comment-13603010 ] Mike Percy commented on FLUME-1932: --- +1 lgtm no-reload-conf command

Possible Conflicting Information Regarding Relationship Between Channels and Sinks within Documentation

2013-03-14 Thread Israel Ekpo
Hey guys, I have a quick question that I would like to ask based on what I found within the user and developer documentation. This could cause some confusion for first time folks. *Background:* From the documentation, a Flume source accepts event data and sends it into a channel. These event

Re: Possible Conflicting Information Regarding Relationship Between Channels and Sinks within Documentation

2013-03-14 Thread Connor Woodson
That statement in the developer guide appears to be inaccurate; feel free to submit a JIRA to that effect. I believe the user guide is updated much more than the developer guide and should thus be considered more correct (although there are outstanding issues with it I believe). To just go back

[jira] [Commented] (FLUME-1227) Introduce some sort of SpillableChannel

2013-03-14 Thread Roshan Naik (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13603141#comment-13603141 ] Roshan Naik commented on FLUME-1227: Looking to revive attention on this one.