Hello Andreas,
The new building(with redesigned useroptions.cxx and necessary changes
in the client binfilter,sc,sd,sw) has been done. I have tested it
manually and it works fine.
1)when redesigning useroptions.cxx, an element with a prop name
"customernumber" seems missed, so I should added
Yan Wu wrote:
> Hello Andreas,
>
>>>
>>> If changes like above, there will be no necessary to change the define
>>> of Class SvtUserOptions.
>>> How do you think of above changes comparing the incompatible changes?
>>
>> No - you shouldnt use "const String&" as return value ever.
>> It's never
Hello Mathias,
If you changed "const String& GetX()" to "String GetX()" no errors
should happen at compile time. There's only one possible problem: if the
returned reference was stored as reference somewhere. This code now
would keep a reference to a temporary object and surely will crash later
Hello Yan Wu,
Hello Andreas,
Now I have such two problems when using "String SvtUserOptions::GetXXX()":
1)All the functions of OOo will be disable after OOo starts.(Please see
the image in the attachment I captured.) I debugged it but didnt find
the cause.
Seams that the SFX library could
Mathias Bauer wrote:
Andreas Schlüns wrote:
Hello Yan Wu,
Hi Andreas,
When redesigning svtools\source\config\useroptions.cxx,
I made like below changes:
String SvtUserOptions_Impl::GetFirstName() const
{
::rtl::OUString sFirstName;
try
{
m_xData->getPropertyValue(s_sgive
Hello Andreas,
If changes like above, there will be no necessary to change the define
of Class SvtUserOptions.
How do you think of above changes comparing the incompatible changes?
No - you shouldnt use "const String&" as return value ever.
It's never a good idea to return a reference to an
Hello Yan Wu ,
Hello Andreas,
I want to change the code:
String SvtUserOptions_Impl::GetFirstName() const
{
::rtl::OUString sFirstName;
try
{
m_xData->getPropertyValue(s_sgivenname) >>= sFirstName;
}
catch ( const css::uno::Exception& ex)
Andreas Schlüns wrote:
> Hello Yan Wu,
>
>> Hi Andreas,
>>
>> When redesigning svtools\source\config\useroptions.cxx,
>> I made like below changes:
>>
>> String SvtUserOptions_Impl::GetFirstName() const
>> {
>> ::rtl::OUString sFirstName;
>> try
>> {
>> m_xData->getPropertyV
Hello Yan Wu ,
Hello Andreas,
I want to change the code:
String SvtUserOptions_Impl::GetFirstName() const
{
::rtl::OUString sFirstName;
try
{
m_xData->getPropertyValue(s_sgivenname) >>= sFirstName;
}
catch ( const css::uno::Exception& ex)
Hello Yan Wu ,
Hello Andreas,
I want to change the code:
String SvtUserOptions_Impl::GetFirstName() const
{
::rtl::OUString sFirstName;
try
{
m_xData->getPropertyValue(s_sgivenname) >>= sFirstName;
}
catch ( const css::uno::Exception& ex)
Hello Andreas,
I want to change the code:
String SvtUserOptions_Impl::GetFirstName() const
{
::rtl::OUString sFirstName;
try
{
m_xData->getPropertyValue(s_sgivenname) >>= sFirstName;
}
catch ( const css::uno::Exception& ex)
{
Hello Yan Wu,
Hi Andreas,
When redesigning svtools\source\config\useroptions.cxx,
I made like below changes:
String SvtUserOptions_Impl::GetFirstName() const
{
::rtl::OUString sFirstName;
try
{
m_xData->getPropertyValue(s_sgivenname) >>= sFirstName;
}
catch ( const
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
AFAIK, the return types of functions in C++ do not enter into the
function signature. That means that
String SvtUserOptions_Impl::GetFirstName() const
and
const String& SvtUserOptions::GetFirstName() const
should have the same signature
Hi Andreas,
When redesigning svtools\source\config\useroptions.cxx,
I made like below changes:
String SvtUserOptions_Impl::GetFirstName() const
{
::rtl::OUString sFirstName;
try
{
m_xData->getPropertyValue(s_sgivenname) >>= sFirstName;
}
catch ( const css::uno::Except
14 matches
Mail list logo
