[
https://issues.apache.org/jira/browse/GEARPUMP-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515173#comment-15515173
]
ASF GitHub Bot commented on GEARPUMP-204:
-
Github user manuzhang commented on the issue:
[
https://issues.apache.org/jira/browse/GEARPUMP-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515019#comment-15515019
]
ASF GitHub Bot commented on GEARPUMP-204:
-
Github user manuzhang commented on a diff in the pull
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/86
@huafengw any more comments ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/86#discussion_r80167763
--- Diff:
external/hbase/src/main/scala/org/apache/gearpump/external/hbase/HBaseSink.scala
---
@@ -114,16 +118,19 @@ object HBaseSink {
[
https://issues.apache.org/jira/browse/GEARPUMP-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515213#comment-15515213
]
ASF GitHub Bot commented on GEARPUMP-204:
-
Github user huafengw commented on a diff in the pull
[
https://issues.apache.org/jira/browse/GEARPUMP-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515195#comment-15515195
]
ASF GitHub Bot commented on GEARPUMP-212:
-
GitHub user huafengw opened a pull request:
[
https://issues.apache.org/jira/browse/GEARPUMP-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515349#comment-15515349
]
ASF GitHub Bot commented on GEARPUMP-213:
-
Github user codecov-io commented on the issue:
[
https://issues.apache.org/jira/browse/GEARPUMP-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515285#comment-15515285
]
ASF GitHub Bot commented on GEARPUMP-212:
-
Github user huafengw commented on the issue:
[
https://issues.apache.org/jira/browse/GEARPUMP-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515413#comment-15515413
]
ASF GitHub Bot commented on GEARPUMP-212:
-
Github user codecov-io commented on the issue:
[
https://issues.apache.org/jira/browse/GEARPUMP-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515219#comment-15515219
]
ASF GitHub Bot commented on GEARPUMP-204:
-
Github user huafengw commented on the issue:
[
https://issues.apache.org/jira/browse/GEARPUMP-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515235#comment-15515235
]
ASF GitHub Bot commented on GEARPUMP-212:
-
Github user manuzhang commented on the issue:
Manu Zhang created GEARPUMP-213:
---
Summary: Documentation improvement
Key: GEARPUMP-213
URL: https://issues.apache.org/jira/browse/GEARPUMP-213
Project: Apache Gearpump
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/GEARPUMP-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515317#comment-15515317
]
ASF GitHub Bot commented on GEARPUMP-213:
-
GitHub user manuzhang opened a pull request:
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/88
[GEARPUMP-213] build with mkdocs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manuzhang/incubator-gearpump new_doc
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/87
## [Current
coverage](https://codecov.io/gh/apache/incubator-gearpump/pull/87?src=pr) is
71.03% (diff: 100%)
> Merging
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/88
## [Current
coverage](https://codecov.io/gh/apache/incubator-gearpump/pull/88?src=pr) is
71.09% (diff: 100%)
> Merging
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/86#discussion_r80175062
--- Diff:
external/hbase/src/main/scala/org/apache/gearpump/external/hbase/HBaseSink.scala
---
@@ -115,15 +116,24 @@ object HBaseSink {
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/86
One question, now the `connection` is a transient value, will there be a
NPE after the HBaseSink deserialized?
---
If your project is set up for it, you can reply to this email and have
[
https://issues.apache.org/jira/browse/GEARPUMP-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512291#comment-15512291
]
ASF GitHub Bot commented on GEARPUMP-204:
-
Github user manuzhang commented on a diff in the pull
[
https://issues.apache.org/jira/browse/GEARPUMP-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512297#comment-15512297
]
ASF GitHub Bot commented on GEARPUMP-204:
-
Github user manuzhang commented on a diff in the pull
[
https://issues.apache.org/jira/browse/GEARPUMP-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512294#comment-15512294
]
ASF GitHub Bot commented on GEARPUMP-204:
-
Github user manuzhang commented on a diff in the pull
[
https://issues.apache.org/jira/browse/GEARPUMP-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512302#comment-15512302
]
ASF GitHub Bot commented on GEARPUMP-204:
-
Github user manuzhang commented on the issue:
[
https://issues.apache.org/jira/browse/GEARPUMP-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512957#comment-15512957
]
ASF GitHub Bot commented on GEARPUMP-204:
-
Github user manuzhang commented on a diff in the pull
[
https://issues.apache.org/jira/browse/GEARPUMP-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512959#comment-15512959
]
ASF GitHub Bot commented on GEARPUMP-204:
-
Github user manuzhang commented on a diff in the pull
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/86#discussion_r79979075
--- Diff:
external/hbase/src/main/scala/org/apache/gearpump/external/hbase/HBaseSink.scala
---
@@ -19,39 +19,47 @@ package
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/86#discussion_r79979330
--- Diff:
external/hbase/src/main/scala/org/apache/gearpump/external/hbase/HBaseSink.scala
---
@@ -19,39 +19,47 @@ package
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/86#discussion_r79979402
--- Diff:
external/hbase/src/main/scala/org/apache/gearpump/external/hbase/HBaseSink.scala
---
@@ -148,11 +158,24 @@ object HBaseSink {
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/86#discussion_r79979548
--- Diff:
external/hbase/src/test/scala/org/apache/gearpump/external/hbase/HBaseSinkSpec.scala
---
@@ -17,24 +17,52 @@
*/
package
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/86
## [Current
coverage](https://codecov.io/gh/apache/incubator-gearpump/pull/86?src=pr) is
70.63% (diff: 22.22%)
> Merging
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/86
Generally my question is that is there any way implementing the
HBaseSinkSpec without changing the HBaseSink?
---
If your project is set up for it, you can reply to this email and have
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/86#discussion_r79979272
--- Diff:
external/hbase/src/main/scala/org/apache/gearpump/external/hbase/HBaseSink.scala
---
@@ -148,11 +158,24 @@ object HBaseSink {
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/86#discussion_r79979177
--- Diff:
external/hbase/src/main/scala/org/apache/gearpump/external/hbase/HBaseSink.scala
---
@@ -115,15 +116,24 @@ object HBaseSink {
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/86#discussion_r79979033
--- Diff:
external/hbase/src/main/scala/org/apache/gearpump/external/hbase/HBaseSink.scala
---
@@ -19,39 +19,47 @@ package
Github user Roshanson commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/86#discussion_r79978998
--- Diff:
external/hbase/src/main/scala/org/apache/gearpump/external/hbase/HBaseSink.scala
---
@@ -19,39 +19,47 @@ package
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/86#discussion_r79979601
--- Diff: project/BuildExample.scala ---
@@ -57,6 +57,7 @@ object BuildExample extends sbt.Build {
)
) dependsOn(streaming %
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/86#discussion_r80017412
--- Diff:
external/hbase/src/main/scala/org/apache/gearpump/external/hbase/HBaseSink.scala
---
@@ -97,7 +101,7 @@ class HBaseSink(
}
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/86#discussion_r80017343
--- Diff:
external/hbase/src/main/scala/org/apache/gearpump/external/hbase/HBaseSink.scala
---
@@ -19,29 +19,33 @@ package
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/86#discussion_r80017362
--- Diff:
external/hbase/src/main/scala/org/apache/gearpump/external/hbase/HBaseSink.scala
---
@@ -19,29 +19,33 @@ package
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/86#discussion_r79979616
--- Diff: project/BuildExample.scala ---
@@ -57,6 +57,7 @@ object BuildExample extends sbt.Build {
)
) dependsOn(streaming %
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/86
@huafengw the current `HBaseSink` constructor is not testable. I'm afraid
changing it is the only way to go.
---
If your project is set up for it, you can reply to this email and have
GitHub user Roshanson opened a pull request:
https://github.com/apache/incubator-gearpump/pull/86
[GEARPUMP-204]add unit test for external_hbase module
[GEARPUMP-204]add unit test for external_hbase module
You can merge this pull request into a Git repository by running:
Github user Roshanson closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/84
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/86#discussion_r79978331
--- Diff:
external/hbase/src/main/scala/org/apache/gearpump/external/hbase/HBaseSink.scala
---
@@ -19,39 +19,47 @@ package
43 matches
Mail list logo
