GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/212
[GEARPUMP-339] Add ScalaDoc to Streaming DSL
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the commit mes
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/212
R: @huafengw
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wish
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/212#discussion_r131545040
--- Diff:
streaming/src/main/scala/org/apache/gearpump/streaming/dsl/scalaapi/StreamApp.scala
---
@@ -62,6 +62,17 @@ class StreamApp(
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/212
Generally LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wish
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/212
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
[
https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115949#comment-16115949
]
ASF GitHub Bot commented on GEARPUMP-339:
-
Github user asfgit closed the pull re
[
https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115825#comment-16115825
]
ASF GitHub Bot commented on GEARPUMP-339:
-
Github user huafengw commented on a d
[
https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115826#comment-16115826
]
ASF GitHub Bot commented on GEARPUMP-339:
-
Github user huafengw commented on the