Request change to Geode Nightly Build

2017-01-23 Thread Kirk Lund
Will someone who has permission to make a change, please add the results of FlakyTest to the Test Results so that any FlakyTest failures are visible on the Test Result page? Example: Console Output shows a FlakyTest failure: https://builds.apache.org/job/Geode-nightly/724/console But the Test Re

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #448 has FAILED (11 tests failed, no failures were new)

2017-01-23 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #448 failed. --- Scheduled 11/1666 tests failed, no failures were new. https://build.spring.io/browse/SGF-NAG-448

Re: Proposal to Coalesce Java and Native Client Config

2017-01-23 Thread Jacob Barrett
There are some differences. The Java version has several items that are very Java centric. There are also some items that probably need to be implemented in the native clients. Most the other items, like pools, servers, region, etc. are pretty much the same. I think it would be worth having a deta

Re: Nightly build failures

2017-01-23 Thread Kirk Lund
If the Geode Nightly Build is running FlakyTests but not adding those results to the Test Results, then I'm 100% for removing the execution of FlakyTests from the nightly build job. If others want the nightly build to run FlakyTests, then would someone please add it to the Test Results so we can s

[GitHub] geode pull request #350: Feature/geode 2316

2017-01-23 Thread pivotal-jbarrett
Github user pivotal-jbarrett closed the pull request at: https://github.com/apache/geode/pull/350 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] geode issue #350: Feature/geode 2316

2017-01-23 Thread mmartell
Github user mmartell commented on the issue: https://github.com/apache/geode/pull/350 +1 on the groups of changes identified above by echobravopapa. In particular, in addition to the namespace rename, I like the switch to nested namespaces, which will be even simpler in C++17. --- I

Nightly build failures

2017-01-23 Thread Kirk Lund
I'm looking at Geode Nightly Build #724. The console output shows that MemoryThresholdsOffHeapDUnitTest, however the Test Results shows zero failures. The failure in the console output does not show the full stack so there's no way to determine which assertion failed. #724 console output shows fa

[GitHub] geode issue #350: Feature/geode 2316

2017-01-23 Thread echobravopapa
Github user echobravopapa commented on the issue: https://github.com/apache/geode/pull/350 +1 on the renaming +1 on marking the closing braces too +1 modernizing the casting +1 on the language specific consistencies LGTM, Ship It! --- If your project is set up for it,

Re: Proposal to Coalesce Java and Native Client Config

2017-01-23 Thread Ernest Burghardt
+1 for common point of reference! On Mon, Jan 23, 2017 at 10:09 AM, Anthony Baker wrote: > Are there any differences between the client-cache element in Geode vs > Native XSD? Seems like a really good idea to use a single, common schema. > > Anthony > > > On Jan 23, 2017, at 10:05 AM, Jacob Bar

Re: Proposal to Coalesce Java and Native Client Config

2017-01-23 Thread Anthony Baker
Are there any differences between the client-cache element in Geode vs Native XSD? Seems like a really good idea to use a single, common schema. Anthony > On Jan 23, 2017, at 10:05 AM, Jacob Barrett wrote: > > Today we have Geode XSD which contains two root elements, cache (server) > and clie

Re: Proposal to Coalesce Java and Native Client Config

2017-01-23 Thread Michael William Dodge
I think this is a good idea: it reduces an unnecessary and potentially confusing redundancy. Sarge > On 23 Jan, 2017, at 10:05, Jacob Barrett wrote: > > Today we have Geode XSD which contains two root elements, cache (server) > and client-cache and Native XSD that contains a client-cache. For

Proposal to Coalesce Java and Native Client Config

2017-01-23 Thread Jacob Barrett
Today we have Geode XSD which contains two root elements, cache (server) and client-cache and Native XSD that contains a client-cache. For the most part these two schemas are the same for element client-cache. It strikes me that it makes sense to coalesce these into a single common XSD. For areas t

Re: Review Request 55849: GEODE-2333: Fix the race that multiple threads could release GatewaySenderEventImpl offheap more than once.

2017-01-23 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55849/#review162658 --- Ship it! Ship It! - Darrel Schneider On Jan. 23, 2017, 9:31

Review Request 55849: GEODE-2333: Fix the race that multiple threads could release GatewaySenderEventImpl offheap more than once.

2017-01-23 Thread Eric Shu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55849/ --- Review request for geode, anilkumar gingade and Darrel Schneider. Bugs: GEODE-2

Re: Geode Native Library Filenames

2017-01-23 Thread Anthony Baker
Here are some links to ASF branding policies: http://www.apache.org/foundation/marks/pmcs http://www.apache.org/foundation/marks/guide We discussed this quite a bit for the homebrew distribution [1]. The conclusion is this: wherever possible prefer to use the apache-geode naming convention.

Re: Geode Native Library Filenames

2017-01-23 Thread Jacob Barrett
Udo, Is you suggestion geode.dll for C++ and Apache.Geode.dll for .NET? The .NET convention is to name your DLL after the least common denominator of the namespaces you include in the DLL, in our case that is Apache.Geode. We could not do geode.dll (C++) and Geode.dll (.NET) since on Windows those

Re: Geode Native Library Filenames

2017-01-23 Thread Udo Kohlmeyer
+1 drop "native" -1 "apache-geode"... Not sure why we want to tie it directly to apache +1 "geode.dll" On 1/23/17 08:48, Michael Stolz wrote: One other thought...Maybe now is the time to drop the term "native". -- Mike Stolz Principal Engineer - Gemfire Product Manager Mobile: 631-835-4771 O

Re: Geode Native Library Filenames

2017-01-23 Thread Michael William Dodge
+1 to dropping "native" Sarge > On 23 Jan, 2017, at 08:48, Michael Stolz wrote: > > One other thought...Maybe now is the time to drop the term "native". > > -- > Mike Stolz > Principal Engineer - Gemfire Product Manager > Mobile: 631-835-4771 > On Jan 23, 2017 11:29 AM, "Michael William Dodge"

Re: Geode Native Library Filenames

2017-01-23 Thread Jacob Barrett
Michael, are you suggesting a new conversation around dropping the "Native" for the branding of the client? If so can you start a new thread? Let's keep this thread about the file name only. Too many conversations in one thread makes the +1 voting hard. On Mon, Jan 23, 2017 at 8:50 AM Michael Wi

Re: Geode Native Library Filenames

2017-01-23 Thread Michael Stolz
One other thought...Maybe now is the time to drop the term "native". -- Mike Stolz Principal Engineer - Gemfire Product Manager Mobile: 631-835-4771 On Jan 23, 2017 11:29 AM, "Michael William Dodge" wrote: > +1 for apache-geode and Apache.Geode > > > On 22 Jan, 2017, at 19:08, Ernest Burghardt

Re: Geode Native Library Filenames

2017-01-23 Thread Michael William Dodge
+1 for apache-geode and Apache.Geode > On 22 Jan, 2017, at 19:08, Ernest Burghardt wrote: > > +1 for apache-geode (.dll, .so, .dylib) and Apache.Geode.dll > > On Sun, Jan 22, 2017 at 7:18 AM, Michael Martell > wrote: > >> +1 for apache-geode (.dll, .so, .dylib) and Apache.Geode.dll >> >> On

Jenkins build is back to normal : Geode-nightly #725

2017-01-23 Thread Apache Jenkins Server
See