Build failed in Jenkins: Geode-nightly #838

2017-05-17 Thread Apache Jenkins Server
See Changes: [klund] GEODE-2929: remove superfluous uses of final from internal classes [bschuchardt] GEODE-2915 Messages rejected due to unknown "vmkind" [upthewaterspout] LuceneClientSecurityDUnitTest was not

[jira] [Commented] (GEODE-2913) Update Lucene documentation

2017-05-17 Thread Karen Smoler Miller (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014981#comment-16014981 ] Karen Smoler Miller commented on GEODE-2913: LuceneIndexStats need to be added to the docs.

Re: Review Request 59323: GEODE-1994: Overhaul of internal.lang.StringUtils to extend and heavily use commons.lang.StringUtils.

2017-05-17 Thread Patrick Rhomberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59323/ --- (Updated May 18, 2017, midnight) Review request for geode, Jinmei Liao, Jared

[jira] [Created] (GEODE-2936) Refactor OrderByComparator's compare method to reduce redundant code

2017-05-17 Thread nabarun (JIRA)
nabarun created GEODE-2936: -- Summary: Refactor OrderByComparator's compare method to reduce redundant code Key: GEODE-2936 URL: https://issues.apache.org/jira/browse/GEODE-2936 Project: Geode

[jira] [Resolved] (GEODE-2587) Refactor OrderByComparator's compare method

2017-05-17 Thread nabarun (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nabarun resolved GEODE-2587. Resolution: Fixed Fix Version/s: 1.2.0 > Refactor OrderByComparator's compare method >

[jira] [Commented] (GEODE-2587) Refactor OrderByComparator's compare method

2017-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014952#comment-16014952 ] ASF GitHub Bot commented on GEODE-2587: --- Github user asfgit closed the pull request at:

[jira] [Commented] (GEODE-2587) Refactor OrderByComparator's compare method

2017-05-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014951#comment-16014951 ] ASF subversion and git services commented on GEODE-2587: Commit

[GitHub] geode pull request #517: GEODE-2587: Refactored the OrderByComparator's comp...

2017-05-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/517 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

org.apache.geode.internal.InternalDataSerializer API Changes...

2017-05-17 Thread John Blum
Geode devs- I am not sure how decisions are made when changing Geode's API, but I would caution that more care should be taken when doing so, regardless of whether the APIs are public or not, but especially when they are public. Unfortunately, in this particular case, the API in question is

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #557 was SUCCESSFUL (with 1848 tests). Change made by John Blum.

2017-05-17 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #557 was successful (rerun once). --- This build was rerun by John Blum. 1850 tests in total.

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #557 has FAILED (2 tests failed). Change made by John Blum.

2017-05-17 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #557 failed. --- Scheduled with changes by John Blum. 2/1850 tests failed.

[jira] [Commented] (GEODE-2913) Update Lucene documentation

2017-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014856#comment-16014856 ] ASF GitHub Bot commented on GEODE-2913: --- Github user joeymcallister commented on a diff in the pull

[GitHub] geode pull request #518: GEODE-2913 Update Lucene index documentation

2017-05-17 Thread joeymcallister
Github user joeymcallister commented on a diff in the pull request: https://github.com/apache/geode/pull/518#discussion_r117123398 --- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb --- @@ -135,4 +117,164 @@ gfsh> lucene search --regionName=/orders

[jira] [Commented] (GEODE-2913) Update Lucene documentation

2017-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014853#comment-16014853 ] ASF GitHub Bot commented on GEODE-2913: --- Github user joeymcallister commented on a diff in the pull

[GitHub] geode pull request #518: GEODE-2913 Update Lucene index documentation

2017-05-17 Thread joeymcallister
Github user joeymcallister commented on a diff in the pull request: https://github.com/apache/geode/pull/518#discussion_r117123228 --- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb --- @@ -135,4 +117,164 @@ gfsh> lucene search --regionName=/orders

[jira] [Commented] (GEODE-2913) Update Lucene documentation

2017-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014852#comment-16014852 ] ASF GitHub Bot commented on GEODE-2913: --- Github user joeymcallister commented on a diff in the pull

[GitHub] geode pull request #518: GEODE-2913 Update Lucene index documentation

2017-05-17 Thread joeymcallister
Github user joeymcallister commented on a diff in the pull request: https://github.com/apache/geode/pull/518#discussion_r117122942 --- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb --- @@ -135,4 +117,164 @@ gfsh> lucene search --regionName=/orders

[jira] [Commented] (GEODE-2913) Update Lucene documentation

2017-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014851#comment-16014851 ] ASF GitHub Bot commented on GEODE-2913: --- Github user joeymcallister commented on a diff in the pull

[GitHub] geode pull request #518: GEODE-2913 Update Lucene index documentation

2017-05-17 Thread joeymcallister
Github user joeymcallister commented on a diff in the pull request: https://github.com/apache/geode/pull/518#discussion_r117122734 --- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb --- @@ -135,4 +117,164 @@ gfsh> lucene search --regionName=/orders

[jira] [Commented] (GEODE-2913) Update Lucene documentation

2017-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014849#comment-16014849 ] ASF GitHub Bot commented on GEODE-2913: --- Github user joeymcallister commented on a diff in the pull

[GitHub] geode pull request #518: GEODE-2913 Update Lucene index documentation

2017-05-17 Thread joeymcallister
Github user joeymcallister commented on a diff in the pull request: https://github.com/apache/geode/pull/518#discussion_r117122540 --- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb --- @@ -135,4 +117,164 @@ gfsh> lucene search --regionName=/orders

[jira] [Commented] (GEODE-2913) Update Lucene documentation

2017-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014848#comment-16014848 ] ASF GitHub Bot commented on GEODE-2913: --- Github user joeymcallister commented on a diff in the pull

[GitHub] geode pull request #518: GEODE-2913 Update Lucene index documentation

2017-05-17 Thread joeymcallister
Github user joeymcallister commented on a diff in the pull request: https://github.com/apache/geode/pull/518#discussion_r117122461 --- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb --- @@ -135,4 +117,164 @@ gfsh> lucene search --regionName=/orders

[jira] [Commented] (GEODE-2913) Update Lucene documentation

2017-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014843#comment-16014843 ] ASF GitHub Bot commented on GEODE-2913: --- Github user joeymcallister commented on a diff in the pull

[GitHub] geode pull request #518: GEODE-2913 Update Lucene index documentation

2017-05-17 Thread joeymcallister
Github user joeymcallister commented on a diff in the pull request: https://github.com/apache/geode/pull/518#discussion_r117121920 --- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb --- @@ -135,4 +117,164 @@ gfsh> lucene search --regionName=/orders

[GitHub] geode pull request #518: GEODE-2913 Update Lucene index documentation

2017-05-17 Thread joeymcallister
Github user joeymcallister commented on a diff in the pull request: https://github.com/apache/geode/pull/518#discussion_r117119685 --- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb --- @@ -35,85 +35,67 @@ The Apache Lucene integration: For more details, see

[jira] [Commented] (GEODE-2913) Update Lucene documentation

2017-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014830#comment-16014830 ] ASF GitHub Bot commented on GEODE-2913: --- Github user joeymcallister commented on a diff in the pull

[jira] [Commented] (GEODE-2929) Remove superfluous uses of final from classes and methods

2017-05-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014802#comment-16014802 ] ASF subversion and git services commented on GEODE-2929: Commit

[jira] [Commented] (GEODE-2913) Update Lucene documentation

2017-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014801#comment-16014801 ] ASF GitHub Bot commented on GEODE-2913: --- GitHub user karensmolermiller opened a pull request:

[GitHub] geode pull request #518: GEODE-2913 Update Lucene index documentation

2017-05-17 Thread karensmolermiller
GitHub user karensmolermiller opened a pull request: https://github.com/apache/geode/pull/518 GEODE-2913 Update Lucene index documentation This update needs detailed reviews. Is the information now correct? And, is there any missing documentation for Lucene indexes?

[jira] [Commented] (GEODE-2587) Refactor OrderByComparator's compare method

2017-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014797#comment-16014797 ] ASF GitHub Bot commented on GEODE-2587: --- Github user nabarunnag commented on the issue:

[GitHub] geode issue #517: GEODE-2587: Refactored the OrderByComparator's compare met...

2017-05-17 Thread nabarunnag
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/517 Yes, we are opening a new ticket for eliminating the repeated code. Analyzing the testcode for ORDER BY queries. --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (GEODE-2587) Refactor OrderByComparator's compare method

2017-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014782#comment-16014782 ] ASF GitHub Bot commented on GEODE-2587: --- Github user jhuynh1 commented on the issue:

[GitHub] geode issue #517: GEODE-2587: Refactored the OrderByComparator's compare met...

2017-05-17 Thread jhuynh1
Github user jhuynh1 commented on the issue: https://github.com/apache/geode/pull/517 We definitely have order by in the tests, whether or not they are adequate I am not sure. doing a find on "order by" will show a log of queries in the tests... The changes look good to me, if in

[jira] [Commented] (GEODE-2913) Update Lucene documentation

2017-05-17 Thread Karen Smoler Miller (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014738#comment-16014738 ] Karen Smoler Miller commented on GEODE-2913: The {{destroy lucene index}} gfsh command

[jira] [Commented] (GEODE-2587) Refactor OrderByComparator's compare method

2017-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014670#comment-16014670 ] ASF GitHub Bot commented on GEODE-2587: --- Github user nabarunnag commented on the issue:

[GitHub] geode issue #517: GEODE-2587: Refactored the OrderByComparator's compare met...

2017-05-17 Thread nabarunnag
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/517 @ladyVader I am assuming that there should be tests already present testing the functional aspect. One of the tests did fail and caught an issue in my fix. @jhuynh1 what do you think? --- If

[jira] [Updated] (GEODE-2935) Add Events link to Geode site footer

2017-05-17 Thread Joey McAllister (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joey McAllister updated GEODE-2935: --- Priority: Minor (was: Major) > Add Events link to Geode site footer >

[jira] [Commented] (GEODE-2662) Gfsh displays field value on wrong line!

2017-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014615#comment-16014615 ] ASF GitHub Bot commented on GEODE-2662: --- Github user jinmeiliao commented on a diff in the pull

[jira] [Commented] (GEODE-2662) Gfsh displays field value on wrong line!

2017-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014614#comment-16014614 ] ASF GitHub Bot commented on GEODE-2662: --- Github user jinmeiliao commented on a diff in the pull

Passed: apache/geode-native#305 (pre-modernization - e2630b1)

2017-05-17 Thread Travis CI
Build Update for apache/geode-native - Build: #305 Status: Passed Duration: 26 minutes and 49 seconds Commit: e2630b1 (pre-modernization) Author: masaki.yamakawa Message: GEDOE-2832: Fixing the link of README.md Fixed an error in Markdown link notation of

[GitHub] geode pull request #500: GEODE-2662: Gfsh displays field value on wrong line...

2017-05-17 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/500#discussion_r117080378 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DataCommandResult.java --- @@ -406,124 +400,140 @@ public Result

[GitHub] geode pull request #500: GEODE-2662: Gfsh displays field value on wrong line...

2017-05-17 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/500#discussion_r117081706 --- Diff: geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java --- @@ -145,6 +153,7 @@ public void startServer(boolean

[jira] [Commented] (GEODE-2774) CI failure: LuceneIndexDestroyDUnitTest.verifyDestroyAllIndexesWhileDoingPuts

2017-05-17 Thread Diane Hardman (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014548#comment-16014548 ] Diane Hardman commented on GEODE-2774: -- Latest comment from Nabarun in Tracker story: Unable to

[jira] [Assigned] (GEODE-2774) CI failure: LuceneIndexDestroyDUnitTest.verifyDestroyAllIndexesWhileDoingPuts

2017-05-17 Thread Diane Hardman (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Diane Hardman reassigned GEODE-2774: Assignee: Diane Hardman > CI failure:

[jira] [Commented] (GEODE-2905) CI failure: org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommandsDUnitTest > searchWithoutIndexShouldReturnError

2017-05-17 Thread Diane Hardman (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014545#comment-16014545 ] Diane Hardman commented on GEODE-2905: -- Adding comment Naba made in Tracker story: Made changes to

Re: Review Request 59323: GEODE-1994: Overhaul of internal.lang.StringUtils to extend and heavily use commons.lang.StringUtils.

2017-05-17 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59323/#review175280 ---

[jira] [Commented] (GEODE-2587) Refactor OrderByComparator's compare method

2017-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014520#comment-16014520 ] ASF GitHub Bot commented on GEODE-2587: --- Github user nabarunnag commented on the issue:

[GitHub] geode issue #517: GEODE-2587: Refactored the OrderByComparator's compare met...

2017-05-17 Thread nabarunnag
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/517 Potential Reviewers @ladyVader @jhuynh1 @boglesby @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[jira] [Commented] (GEODE-2587) Refactor OrderByComparator's compare method

2017-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014514#comment-16014514 ] ASF GitHub Bot commented on GEODE-2587: --- GitHub user nabarunnag opened a pull request:

[GitHub] geode pull request #517: GEODE-2587: Refactored the OrderByComparator's comp...

2017-05-17 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/517 GEODE-2587: Refactored the OrderByComparator's compare method Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you

Re: Review Request 59246: GEODE-2876: reset isGfshVM flag to false when tearing down tests using CliCommandTestBase.

2017-05-17 Thread Patrick Rhomberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59246/#review175290 --- Ship it! Ship It! - Patrick Rhomberg On May 12, 2017, 10:12

[jira] [Commented] (GEODE-2741) Use C++11 shared pointer over custom shared pointer

2017-05-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014502#comment-16014502 ] ASF subversion and git services commented on GEODE-2741: Commit

[jira] [Commented] (GEODE-2741) Use C++11 shared pointer over custom shared pointer

2017-05-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014500#comment-16014500 ] ASF subversion and git services commented on GEODE-2741: Commit

[jira] [Commented] (GEODE-2741) Use C++11 shared pointer over custom shared pointer

2017-05-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014503#comment-16014503 ] ASF subversion and git services commented on GEODE-2741: Commit

[jira] [Commented] (GEODE-2741) Use C++11 shared pointer over custom shared pointer

2017-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014504#comment-16014504 ] ASF GitHub Bot commented on GEODE-2741: --- Github user asfgit closed the pull request at:

[jira] [Commented] (GEODE-2741) Use C++11 shared pointer over custom shared pointer

2017-05-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014505#comment-16014505 ] ASF subversion and git services commented on GEODE-2741: Commit

[jira] [Commented] (GEODE-2741) Use C++11 shared pointer over custom shared pointer

2017-05-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014507#comment-16014507 ] ASF subversion and git services commented on GEODE-2741: Commit

[GitHub] geode-native pull request #99: GEODE-2741: Remove custom shared painter and ...

2017-05-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode-native/pull/99 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Commented] (GEODE-2741) Use C++11 shared pointer over custom shared pointer

2017-05-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014499#comment-16014499 ] ASF subversion and git services commented on GEODE-2741: Commit

[jira] [Commented] (GEODE-2587) Refactor OrderByComparator's compare method

2017-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014494#comment-16014494 ] ASF GitHub Bot commented on GEODE-2587: --- Github user nabarunnag closed the pull request at:

[GitHub] geode pull request #516: GEODE-2587: Refactored the OrderByComparator's comp...

2017-05-17 Thread nabarunnag
Github user nabarunnag closed the pull request at: https://github.com/apache/geode/pull/516 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (GEODE-2587) Refactor OrderByComparator's compare method

2017-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014488#comment-16014488 ] ASF GitHub Bot commented on GEODE-2587: --- GitHub user nabarunnag opened a pull request:

[jira] [Commented] (GEODE-2934) Refactor AnalyzeSerializablesJUnitTest and subclasses

2017-05-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014487#comment-16014487 ] ASF subversion and git services commented on GEODE-2934: Commit

[GitHub] geode pull request #516: GEODE-2587: Refactored the OrderByComparator's comp...

2017-05-17 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/516 GEODE-2587: Refactored the OrderByComparator's compare method Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you

Re: Review Request 59326: GEODE-2934: refactor AnalyzeSerializablesJUnitTest and subclasses

2017-05-17 Thread Kirk Lund
> On May 17, 2017, 5:20 p.m., Patrick Rhomberg wrote: > > geode-core/src/test/java/org/apache/geode/internal/lang/SystemUtilsJUnitTest.java > > Lines 17-18 (original), 17-18 (patched) > > > > > > Are star-imports as

[jira] [Commented] (GEODE-2934) Refactor AnalyzeSerializablesJUnitTest and subclasses

2017-05-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014483#comment-16014483 ] ASF subversion and git services commented on GEODE-2934: Commit

[jira] [Commented] (GEODE-1279) Tests for old TRAC bugs should be renamed to useful names

2017-05-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014482#comment-16014482 ] ASF subversion and git services commented on GEODE-1279: Commit

Re: Review Request 59287: GEODE-2420: Enable export logs size estimation and user warning

2017-05-17 Thread Patrick Rhomberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59287/#review175282 --- On a Mac, Alt-Shift-I does all the inspections for the current

Re: Review Request 59323: GEODE-1994: Overhaul of internal.lang.StringUtils to extend and heavily use commons.lang.StringUtils.

2017-05-17 Thread Jinmei Liao
> On May 17, 2017, 5:32 p.m., Jinmei Liao wrote: > > geode-core/src/main/java/org/apache/geode/internal/lang/StringUtils.java > > Line 29 (original), 29 (patched) > > > > > > I would not make this class extends

Re: Review Request 59323: GEODE-1994: Overhaul of internal.lang.StringUtils to extend and heavily use commons.lang.StringUtils.

2017-05-17 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59323/#review175278 ---

Re: Review Request 59326: GEODE-2934: refactor AnalyzeSerializablesJUnitTest and subclasses

2017-05-17 Thread Patrick Rhomberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59326/#review175277 ---

[jira] [Commented] (GEODE-2741) Use C++11 shared pointer over custom shared pointer

2017-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014431#comment-16014431 ] ASF GitHub Bot commented on GEODE-2741: --- GitHub user pivotal-jbarrett opened a pull request:

[GitHub] geode-native pull request #99: GEODE-2741: Remove custom shared painter and ...

2017-05-17 Thread pivotal-jbarrett
GitHub user pivotal-jbarrett opened a pull request: https://github.com/apache/geode-native/pull/99 GEODE-2741: Remove custom shared painter and replace with std::shared_ptr. Tests pass on Linux, Windows, Solaris and Mac. Please review. You can merge this pull request into

Re: Review Request 59326: GEODE-2934: refactor AnalyzeSerializablesJUnitTest and subclasses

2017-05-17 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59326/#review175276 --- Ship it! Ship It! - Jinmei Liao On May 17, 2017, 1:10 a.m.,

Re: Review Request 59326: GEODE-2934: refactor AnalyzeSerializablesJUnitTest and subclasses

2017-05-17 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59326/#review175274 ---

Re: Review Request 59326: GEODE-2934: refactor AnalyzeSerializablesJUnitTest and subclasses

2017-05-17 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59326/#review175275 --- Ship it! Ship It! - Jared Stewart On May 17, 2017, 1:10

Re: Review Request 59316: GEODE-2927: fix pulse logging and useLocator, SSL flags

2017-05-17 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59316/#review175271 --- Ship it! Ship It! - Jared Stewart On May 17, 2017, 4:39

Re: Review Request 59324: GEODE-1279: rename Bug51193DUnitTest to ClientFunctionTimeoutRegressionTest

2017-05-17 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59324/#review175270 --- Ship it! Ship It! - Jared Stewart On May 16, 2017, 11:46

Re: Review Request 59324: GEODE-1279: rename Bug51193DUnitTest to ClientFunctionTimeoutRegressionTest

2017-05-17 Thread Patrick Rhomberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59324/#review175269 --- Ship it! Ship It! - Patrick Rhomberg On May 16, 2017, 11:46

Re: Review Request 59324: GEODE-1279: rename Bug51193DUnitTest to ClientFunctionTimeoutRegressionTest

2017-05-17 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59324/#review175268 --- Ship it! Ship It! - Jinmei Liao On May 16, 2017, 11:46

Re: Review Request 59316: GEODE-2927: fix pulse logging and useLocator, SSL flags

2017-05-17 Thread Jinmei Liao
> On May 16, 2017, 11:07 p.m., Jared Stewart wrote: > > geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/EmbeddedPulseRule.java > > Lines 38 (patched) > > > > > > I was a bit surprised that these `set`

Re: Review Request 59316: GEODE-2927: fix pulse logging and useLocator, SSL flags

2017-05-17 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59316/ --- (Updated May 17, 2017, 4:39 p.m.) Review request for geode, Jared Stewart, Ken

[jira] [Commented] (GEODE-2900) BucketRegionQueue transitions from primary/secondary/primary can lead to events lingering in queue

2017-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014346#comment-16014346 ] ASF GitHub Bot commented on GEODE-2900: --- Github user jhuynh1 closed the pull request at:

[GitHub] geode pull request #502: GEODE-2900: push shadow key to the front of eventSe...

2017-05-17 Thread jhuynh1
Github user jhuynh1 closed the pull request at: https://github.com/apache/geode/pull/502 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: JetBrains ReSharper License

2017-05-17 Thread Ernest Burghardt
+1 go for it Jake On Thu, May 11, 2017 at 12:26 PM, Jacob Barrett wrote: > Has anyone on the project already applied to JetBrains for a Open Source > license for ReSharper of the Geode Project? > > JetBrains offers complimentary licenses to Apache projects for use by their