Re: Geode Clubhouse meeting on the integration of Lucene text search indexes in Geode

2017-08-22 Thread Jagdish Mirani
Hello Geode Enthusiasts: Pivotal is hosting a Geode Clubhouse meeting on Sept 5th to present and demo the integration of Lucene indexes in Geode 1.2.0. Date: Tuesday, Sept 5th Time: 10AM - 10:30AM PST (short meeting, the Lucene text search feature is our only agenda item). Meeting logistics:

[GitHub] geode pull request #719: GEODE-3447 Implement client authorization for the n...

2017-08-22 Thread galen-pivotal
Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/719#discussion_r134635734 --- Diff: geode-protobuf/src/test/java/org/apache/geode/protocol/AuthorizationIntegrationTest.java --- @@ -0,0 +1,206 @@ +/* + * Licensed to

[GitHub] geode pull request #719: GEODE-3447 Implement client authorization for the n...

2017-08-22 Thread galen-pivotal
Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/719#discussion_r134634705 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/registry/OperationContextRegistry.java --- @@ -47,41 +48,57 @@ private void

[GitHub] geode pull request #719: GEODE-3447 Implement client authorization for the n...

2017-08-22 Thread galen-pivotal
Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/719#discussion_r134633950 --- Diff: geode-core/src/main/java/org/apache/geode/security/StreamAuthorizer.java --- @@ -0,0 +1,19 @@ +/* + * Licensed to the Apache Software

Re: Tombstones

2017-08-22 Thread Anilkumar Gingade
Thats right...They are not returned as part of public/user apis... -Anil. On Tue, Aug 22, 2017 at 11:09 AM, Dan Smith wrote: > I believe tombstones are not included in those operations, so you won't see > them. > > -Dan > > On Tue, Aug 22, 2017 at 10:56 AM, Michael Stolz

Re: Adding parallel import/export of snapshots to gfsh

2017-08-22 Thread Anilkumar Gingade
>> One other idea that hasn't been mentioned is making parallel the only way My vote is to support both option; we could make parallel default but having an option to take snapshot at one node may be useful for use-cases where: - Easier to manage snapshot at one file location; in a large cluster

Review Request 61829: GEODE-3408 Flood of EOF warnings

2017-08-22 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61829/ --- Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh Khamesra,

[GitHub] geode pull request #732: GEODE-3276: Managing race conditions while the send...

2017-08-22 Thread jhuynh1
Github user jhuynh1 commented on a diff in the pull request: https://github.com/apache/geode/pull/732#discussion_r134622619 --- Diff: geode-wan/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderImpl.java --- @@ -107,6 +107,9 @@ public void stop() {

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #655 was SUCCESSFUL (with 2027 tests)

2017-08-22 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #655 was successful. --- Scheduled 2029 tests in total. https://build.spring.io/browse/SGF-NAG-655/ -- This

Re: Adding parallel import/export of snapshots to gfsh

2017-08-22 Thread Nick Reich
With minimal code change, it is possible to enable the use of —dir for both standard and parallel export/import, allowing —file to function only for standard exports (and optionally, make it depricated in favor of the —dir option). While not inherently opposed to forcing all Partitioned Region

[GitHub] geode pull request #729: GEODE-3461: increase test timeouts

2017-08-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/729 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

2017-08-22 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/730#discussion_r134618712 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/result/AbstractResultData.java --- @@ -147,11 +147,10 @@ public ResultData

[GitHub] geode issue #729: GEODE-3461: increase test timeouts

2017-08-22 Thread kirklund
Github user kirklund commented on the issue: https://github.com/apache/geode/pull/729 This PR should also fix GEODE-3505. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

Passed: apache/geode#3649 (develop - a1ac45d)

2017-08-22 Thread Travis CI
Build Update for apache/geode - Build: #3649 Status: Passed Duration: 22 minutes and 28 seconds Commit: a1ac45d (develop) Author: Dave Barnes Message: GEODE-3504: Add Experimental caveat for Redis and Auto-rebalance View the changeset:

Re: Gitbox enables the full GitHub workflow

2017-08-22 Thread Bruce Schuchardt
+1 On 8/22/17 1:48 PM, Udo Kohlmeyer wrote: +1 to migrate :) On 8/22/17 10:43, Anthony Baker wrote: On Aug 7, 2017, at 6:09 PM, Roman Shaposhnik wrote: Hi! it has just come to my attention that Gitbox at ASF has been enabling full GitHub workflow (with being able

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

2017-08-22 Thread pdxrunner
Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/730#discussion_r134616035 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/result/AbstractResultData.java --- @@ -147,11 +147,10 @@ public ResultData

Re: [Discuss] FunctionStats over the JMX [GEODE-3462]

2017-08-22 Thread Kirk Lund
I just ran across a test in Geode which manipulates similar APIs for Client stats on the CacheServerMXBean: String[] clientIds = cacheServerMXBean.getClientIds(); ClientHealthStatus clientStatus1 = cacheServerMXBean.showClientStats(clientIds[0]); ClientHealthStatus clientStatus2 =

[GitHub] geode pull request #732: GEODE-3276: Managing race conditions while the send...

2017-08-22 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/732 GEODE-3276: Managing race conditions while the senders are stopped * When a connection is initialized, a readAckThread may be alive from a previous incarnation. * This AckThread will

[GitHub] geode pull request #659: GEODE-3308: Lucene rolling upgrade and backwards co...

2017-08-22 Thread nabarunnag
Github user nabarunnag closed the pull request at: https://github.com/apache/geode/pull/659 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Build failed in Jenkins: Geode-release-flaky #30

2017-08-22 Thread Apache Jenkins Server
See -- [...truncated 94.19 KB...] :geode-wan:compileJava :geode-wan:processResources :geode-wan:classes :geode-web:compileJava UP-TO-DATE :geode-web:processResources UP-TO-DATE

Re: Review Request 61701: GEODE-3277: Fix error path constructors of Launcher inner State classess

2017-08-22 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61701/ --- (Updated Aug. 22, 2017, 9:28 p.m.) Review request for geode, Emily Yeh, Jinmei

[GitHub] geode pull request #731: GEODE-2842: Removed redundant default annotation pa...

2017-08-22 Thread PurelyApplied
GitHub user PurelyApplied opened a pull request: https://github.com/apache/geode/pull/731 GEODE-2842: Removed redundant default annotation parameter values. Driven by IntelliJ inspection, I have extended the reach of this ticket to include any annotation, not only `@CliOption`.

Re: Adding parallel import/export of snapshots to gfsh

2017-08-22 Thread Michael Stolz
One other idea that hasn't been mentioned is making parallel the only way for Partitioned Regions, and having --file serve the purpose of defining both a path and a filename pattern where the bucket ID or whatever we're using gets automatically inserted before the .gfd extension. No need for a

Re: Adding parallel import/export of snapshots to gfsh

2017-08-22 Thread Nick Reich
Parallel export will write the data to files on the bucket primary for each bucket, distributing the work (and therefore files) to all the members. That would be a big enough deviation from the current behavior (single file on single machine), that I think it makes it worth having the additional

Re: Adding parallel import/export of snapshots to gfsh

2017-08-22 Thread Dan Smith
I don't really like the idea of adding a separate command. It really is the same command - you just want to have the parallel flag interact with other options. A separate command would be more confusing for users, and more of a maintenance issue as we add more options to export. Having a --path

[GitHub] geode pull request #719: GEODE-3447 Implement client authorization for the n...

2017-08-22 Thread bschuchardt
Github user bschuchardt commented on a diff in the pull request: https://github.com/apache/geode/pull/719#discussion_r134600589 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSimpleAuthenticator.java --- @@ -40,20 +42,28 @@ public void

Re: Adding parallel import/export of snapshots to gfsh

2017-08-22 Thread Jacob Barrett
On Tue, Aug 22, 2017 at 1:49 PM Nick Reich wrote: > The idea of deprecating —file in favor of path is interesting. I wonder if > instead of making them mutually exclusive to start, having —path be able to > support both modes from the start would be better? That way —file

[GitHub] geode pull request #719: GEODE-3447 Implement client authorization for the n...

2017-08-22 Thread bschuchardt
Github user bschuchardt commented on a diff in the pull request: https://github.com/apache/geode/pull/719#discussion_r134599066 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSimpleAuthorizer.java --- @@ -0,0 +1,42 @@ +/* + * Licensed to

Re: Review Request 61816: GEODE-3409 Protobuf Client Can't Connect Once Connection Limit Has Been Reached, Even After Connections Closed

2017-08-22 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61816/#review183524 --- Ship it! Ship It! - Udo Kohlmeyer On Aug. 22, 2017, 5:16

Re: Adding parallel import/export of snapshots to gfsh

2017-08-22 Thread Nick Reich
I thought about a mutually exclusive —file and —dir, but in that case, -—file is required for standard and —path required for parallel export, which I think could be better than overloading —file, but still has potential for confusion. The idea of deprecating —file in favor of path is

Re: Gitbox enables the full GitHub workflow

2017-08-22 Thread Udo Kohlmeyer
+1 to migrate :) On 8/22/17 10:43, Anthony Baker wrote: On Aug 7, 2017, at 6:09 PM, Roman Shaposhnik wrote: Hi! it has just come to my attention that Gitbox at ASF has been enabling full GitHub workflow (with being able to click Merge this PR button, etc.) for quite

[GitHub] geode issue #730: GEODE-3472: Remove a great deal of commented-out code.

2017-08-22 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/730 Precheckin green after merge with `be4551191a17b9f50169f375798785ab5373e975`. Subsequently rebased again with minor merge conflict resolved. --- If your project is set up for it, you can

Re: Gitbox enables the full GitHub workflow

2017-08-22 Thread Ernest Burghardt
+1 On Tue, Aug 22, 2017 at 12:28 PM, Joey McAllister wrote: > +1 > > On Tue, Aug 22, 2017 at 11:28 AM Ken Howe wrote: > > > +1 Yes, let’s make the move > > > > > On Aug 22, 2017, at 11:21 AM, Nabarun Nag wrote: > > > > > > +1 > > > >

Re: Adding parallel import/export of snapshots to gfsh

2017-08-22 Thread Jacob Barrett
How about deprecate —file and replace with —path? In the transition make them mutually exclusive and —path required for —parallel. Any reason to not just make all export parallel rather than supporting two different modes? -Jake Sent from my iPhone > On Aug 22, 2017, at 12:27 PM, Kenneth

Re: Review Request 61722: GEODE-3047 Atomic creation flag is not set if the region is recoverd from the disk.

2017-08-22 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61722/#review183507 --- Ship it! Ship It! - Darrel Schneider On Aug. 18, 2017, 9:58

Re: Adding parallel import/export of snapshots to gfsh

2017-08-22 Thread Kenneth Howe
I agrees that overloading the “file” option seems like a bad idea. As an alternative to separate commands, what about mutually exclusive options, ‘—file’ and ‘—dir’? If you go for implementing the new functionality as a separate command, I would suggest calling the gfsh commands: “export

Re: Native commit messages going to dev instead of commit list

2017-08-22 Thread Mark Bretl
Hey Jake, Sorry I missed your ticket last week, my ticket has been completed and the commits should now be going to commits@geode and notifications should be going to dev@geode. I set my issue Type to GitBox Request and got though the queue fairly quickly. I don't know the GitBox configuration

Adding parallel import/export of snapshots to gfsh

2017-08-22 Thread Nick Reich
Team, I am working on exposing the parallel export/import of snapshots through gfsh and would appreciate input on the best approach to adding to / updating the existing interface. Currently, ExportDataCommand and ImportDataCommand take a region name, a member to run the command on, and a file

Re: Gitbox enables the full GitHub workflow

2017-08-22 Thread Joey McAllister
+1 On Tue, Aug 22, 2017 at 11:28 AM Ken Howe wrote: > +1 Yes, let’s make the move > > > On Aug 22, 2017, at 11:21 AM, Nabarun Nag wrote: > > > > +1 > > > > On Tue, Aug 22, 2017 at 11:15 AM Kirk Lund wrote: > > > >> +1 to move all our repos

Re: Gitbox enables the full GitHub workflow

2017-08-22 Thread Ken Howe
+1 Yes, let’s make the move > On Aug 22, 2017, at 11:21 AM, Nabarun Nag wrote: > > +1 > > On Tue, Aug 22, 2017 at 11:15 AM Kirk Lund wrote: > >> +1 to move all our repos to gitbox >> >> On Tue, Aug 22, 2017 at 11:08 AM, Jacob Barrett

Re: Review Request 61701: GEODE-3277: Fix error path constructors of Launcher inner State classess

2017-08-22 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61701/ --- (Updated Aug. 22, 2017, 6:26 p.m.) Review request for geode, Emily Yeh, Jinmei

Re: Gitbox enables the full GitHub workflow

2017-08-22 Thread Nabarun Nag
+1 On Tue, Aug 22, 2017 at 11:15 AM Kirk Lund wrote: > +1 to move all our repos to gitbox > > On Tue, Aug 22, 2017 at 11:08 AM, Jacob Barrett > wrote: > > > +1 > > > > Sent from my iPhone > > > > > On Aug 22, 2017, at 10:49 AM, Jared Stewart

Re: Gitbox enables the full GitHub workflow

2017-08-22 Thread Kirk Lund
+1 to move all our repos to gitbox On Tue, Aug 22, 2017 at 11:08 AM, Jacob Barrett wrote: > +1 > > Sent from my iPhone > > > On Aug 22, 2017, at 10:49 AM, Jared Stewart wrote: > > > > +1 for moving the other repos to Gitbox > > > > On Aug 22, 2017

Re: Tombstones

2017-08-22 Thread Dan Smith
I believe tombstones are not included in those operations, so you won't see them. -Dan On Tue, Aug 22, 2017 at 10:56 AM, Michael Stolz wrote: > Do tombstones show up in operations that indicate presence of keys like > Region.keyset(), containsKey(key), etc? > They probably

Re: Gitbox enables the full GitHub workflow

2017-08-22 Thread Jacob Barrett
+1 Sent from my iPhone > On Aug 22, 2017, at 10:49 AM, Jared Stewart wrote: > > +1 for moving the other repos to Gitbox > > On Aug 22, 2017 10:43 AM, "Anthony Baker" wrote: > > >> On Aug 7, 2017, at 6:09 PM, Roman Shaposhnik

Re: Gitbox enables the full GitHub workflow

2017-08-22 Thread Dan Smith
+1 - Let's do it! -Dan On Tue, Aug 22, 2017 at 10:58 AM, Dave Barnes wrote: > +1 > I'm interested to see how it works for geode-site, which has a sorta quirky > build/branch structure. > > On Tue, Aug 22, 2017 at 10:49 AM, Jared Stewart > wrote: > > >

Re: Gitbox enables the full GitHub workflow

2017-08-22 Thread Dave Barnes
+1 I'm interested to see how it works for geode-site, which has a sorta quirky build/branch structure. On Tue, Aug 22, 2017 at 10:49 AM, Jared Stewart wrote: > +1 for moving the other repos to Gitbox > > On Aug 22, 2017 10:43 AM, "Anthony Baker" wrote: >

Tombstones

2017-08-22 Thread Michael Stolz
Do tombstones show up in operations that indicate presence of keys like Region.keyset(), containsKey(key), etc? They probably shouldn't. -- Mike Stolz Principal Engineer, GemFire Product Manager Mobile: +1-631-835-4771

Re: Gitbox enables the full GitHub workflow

2017-08-22 Thread Jared Stewart
+1 for moving the other repos to Gitbox On Aug 22, 2017 10:43 AM, "Anthony Baker" wrote: > On Aug 7, 2017, at 6:09 PM, Roman Shaposhnik wrote: > > Hi! > > it has just come to my attention that Gitbox at ASF > has been enabling full GitHub workflow

Re: Gitbox enables the full GitHub workflow

2017-08-22 Thread Anthony Baker
> On Aug 7, 2017, at 6:09 PM, Roman Shaposhnik wrote: > > Hi! > > it has just come to my attention that Gitbox at ASF > has been enabling full GitHub workflow (with being > able to click Merge this PR button, etc.) for quite > some time. > > This basically allows a

Review Request 61816: GEODE-3409 Protobuf Client Can't Connect Once Connection Limit Has Been Reached, Even After Connections Closed

2017-08-22 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61816/ --- Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh Khamesra,

Re: [Discuss] FunctionStats over the JMX [GEODE-3462]

2017-08-22 Thread Kirk Lund
Hi Dinesh, Check out this project by Charlie Black: https://github.com/charliemblack/geode-exposing-metrics-via-JMX We currently have no plans to introduce out-of-the box Geode MXBeans for every Function or for all stats. When you combine this with federating of MBeans to the JMX Manager(s), it

Re: Review Request 61701: GEODE-3277: Fix error path constructors of Launcher inner State classess

2017-08-22 Thread Jared Stewart
> On Aug. 17, 2017, 5:35 p.m., Jared Stewart wrote: > > geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java > > Lines 2017 (patched) > > > > > > I think this double-ternary might be easier to

Re: Review Request 61701: GEODE-3277: Fix error path constructors of Launcher inner State classess

2017-08-22 Thread Ken Howe
> On Aug. 17, 2017, 5:35 p.m., Jared Stewart wrote: > > geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java > > Lines 2017 (patched) > > > > > > I think this double-ternary might be easier to

[GitHub] geode pull request #702: GEODE-3416: Reduce synchronization blockages in Soc...

2017-08-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/702 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #668: GEODE-3306: Remove whitespace StringBuffers/nodes c...

2017-08-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/668 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-22 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134514607 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java --- @@ -50,51 +37,23 @@

Monitor the neighbour JVM using neihbour's member-timeout

2017-08-22 Thread Aravind Musigumpula
Hi Team, We have a requirement to configure different member timeout for different members as we need some members to survive in the view for longer time than the other the members before being kicked out of the view in case they aren't responding. 1. Now with the current monitoring

Jenkins build is back to normal : Geode-release #80

2017-08-22 Thread Apache Jenkins Server
See

Build failed in Jenkins: Geode-nightly #931

2017-08-22 Thread Apache Jenkins Server
See Changes: [ukohlmeyer] GEODE-3474: protobuf auth with ExampleSecurityManager. This closes #726 [klund] GEODE-3322: delete empty javadocs to fix javadoc warning [abaker] GEODE-3495 Bump log4j to v2.8.2