[GitHub] geode pull request #732: GEODE-3276: Managing race conditions while the send...

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/732 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [DISCUSS] Updating Spotless

I'm for making our spotless better match our style guide, and it's easy enough to update branches with this. On Wed, Aug 23, 2017 at 4:31 PM, Patrick Rhomberg wrote: > [tl;dr:] > - We are inconsistent with our own established style rules. > - We should become not that. > -

[DISCUSS] Updating Spotless

[tl;dr:] - We are inconsistent with our own established style rules. - We should become not that. - How do we coordinate becoming better? - Do you have any other areas where we can become more spotless? -- Hello, devs. There are a great many instances throughout the geode codebase that

[GitHub] geode pull request #737: GEODE-3503: Removal of Codec classes left behind.

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/737#discussion_r134895876 --- Diff: geode-protobuf/src/main/proto/region_API.proto --- @@ -58,6 +58,7 @@ message GetAllRequest { message GetAllResponse {

[GitHub] geode pull request #735: GEODE-3249 Document geode.allow-internal-messages-w...

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/735 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode issue #731: GEODE-2842: Removed redundant default annotation parameter...

Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/731 Precheckin green, with some flakiness observed in `org.apache.geode.internal.cache.ha.Bug48571DUnitTest`. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] geode issue #737: GEODE-3503: Removal of Codec classes left behind.

Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/737 Looks like JSONCodecJUnitTest has multiple failures. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] geode pull request #737: GEODE-3503: Removal of Codec classes left behind.

Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/737#discussion_r134890133 --- Diff: geode-protobuf/src/main/proto/region_API.proto --- @@ -58,6 +58,7 @@ message GetAllRequest { message GetAllResponse { repeated

[GitHub] geode pull request #649: GEODE-2997: Change new protocol GetAllResponse.

Github user galen-pivotal closed the pull request at: https://github.com/apache/geode/pull/649 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode issue #649: GEODE-2997: Change new protocol GetAllResponse.

Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/649 closing for #739 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #656 was SUCCESSFUL (with 2027 tests)

--- Spring Data GemFire > Nightly-ApacheGeode > #656 was successful. --- Scheduled 2029 tests in total. https://build.spring.io/browse/SGF-NAG-656/ -- This

[GitHub] geode pull request #734: GEODE-3508: Remove unused internal deprecated class...

Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/734#discussion_r134881817 --- Diff: geode-core/src/main/java/org/apache/geode/internal/process/ClusterConfigurationNotAvailableException.java --- @@ -1,33 +0,0 @@ -/* -

[GitHub] geode pull request #739: GEODE-3385: Change GetAllRequest to return list of ...

GitHub user galen-pivotal opened a pull request: https://github.com/apache/geode/pull/739 GEODE-3385: Change GetAllRequest to return list of errors. Also: * Rename `KeyedErrorResponse` to `KeyedError`. * move `ErrorResponse` to `clientProtocol.proto`. * Check for null

[GitHub] geode pull request #738: GEODE-3506: improve validation/error checking for p...

GitHub user kirklund opened a pull request: https://github.com/apache/geode/pull/738 GEODE-3506: improve validation/error checking for process file control We only ever hit this failure once and I don't think it's a flaky test. This could actually be one more (last remaining?) root

[GitHub] geode pull request #734: GEODE-3508: Remove unused internal deprecated class...

Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/734#discussion_r134875716 --- Diff: geode-core/src/main/java/org/apache/geode/internal/process/ClusterConfigurationNotAvailableException.java --- @@ -1,33 +0,0 @@ -/* - *

[GitHub] geode pull request #734: GEODE-3508: Remove unused internal deprecated class...

Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/734#discussion_r134875140 --- Diff: geode-core/src/main/java/org/apache/geode/internal/process/ClusterConfigurationNotAvailableException.java --- @@ -1,33 +0,0 @@ -/* - *

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/730#discussion_r134872863 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/MBeanJMXAdapter.java --- @@ -72,16 +72,13 @@ private DistributedMember

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/730#discussion_r134869226 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java --- @@ -158,7 +156,7 @@ private Thread runner;

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/730#discussion_r134869699 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/CliUtil.java --- @@ -212,8 +211,7 @@ public static void

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/730#discussion_r134867453 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DataCommandResult.java --- @@ -415,9 +413,8 @@ public Result

[GitHub] geode pull request #737: GEODE-3503: Removal of Codec classes left behind.

GitHub user kohlmu-pivotal opened a pull request: https://github.com/apache/geode/pull/737 GEODE-3503: Removal of Codec classes left behind. Added tests to test the remaining JSONCodec. Thank you for submitting a contribution to Apache Geode. In order to streamline

[GitHub] geode pull request #736: GEODE-3503: Removal of Codec classes left behind.

Github user kohlmu-pivotal closed the pull request at: https://github.com/apache/geode/pull/736 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode pull request #736: GEODE-3503: Removal of Codec classes left behind.

GitHub user kohlmu-pivotal opened a pull request: https://github.com/apache/geode/pull/736 GEODE-3503: Removal of Codec classes left behind. Added tests to test the remaining JSONCodec. Thank you for submitting a contribution to Apache Geode. In order to streamline

Re: Review Request 61701: GEODE-3277: Fix error path constructors of Launcher inner State classess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61701/ --- (Updated Aug. 23, 2017, 8:43 p.m.) Review request for geode, Emily Yeh, Jinmei

[GitHub] geode pull request #735: GEODE-3249 Document geode.allow-internal-messages-w...

GitHub user karensmolermiller opened a pull request: https://github.com/apache/geode/pull/735 GEODE-3249 Document geode.allow-internal-messages-without-credentials @bschuchardt @metatype Please review documentation of the new property. You can merge this pull request into a Git

Review Request 61860: GEODE-3510: GfshRule displays output from StdError

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61860/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and

Re: Nightly build failures caused by attempted use of default ports

I think we just need to have AcceptanceTest (and possibly IntegrationTest) run inside Docker like DistributedTest already does. - Jared. > On Aug 23, 2017, at 11:32 AM, Anilkumar Gingade wrote: > >>> 1) use Docker for AcceptanceTest and IntegrationTest targets? > To be

[GitHub] geode pull request #722: GEODE-3184: Cleaned up Cargo tests

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/722 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Nightly build failures caused by attempted use of default ports

>> 1) use Docker for AcceptanceTest and IntegrationTest targets? To be clear, the failing tests are only in Acceptance Test and Integration Tests? And distributed tests are not seeing this issue as they are running in docker nowIf moving docker address this issue, my vote is for moving docker;

Nightly build failures caused by attempted use of default ports

The following nightly build failures are tests that are testing default ports which are failing because the port is not available. Should we: 1) use Docker for AcceptanceTest and IntegrationTest targets? 2) not test default ports? 3) use a hacky System property to force Geode to think that

Re: Review Request 61829: GEODE-3408 Flood of EOF warnings

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61829/#review183634 --- Ship it! Ship It! - Hitesh Khamesra On Aug. 22, 2017, 11:41

Re: Gradle Docker Plugin Fails After Upgrading Gradle To 3.5.1

+1 to upgrading both On Wed, Aug 23, 2017 at 10:49 AM, Mark Bretl wrote: > Hi Everyone, > > In the last nightly builds, the builds are not running the distributed > tests due to the Docker plugin not being compatible with Gradle 3.5.1. I > didn't notice this in my testing

Re: Review Request 61829: GEODE-3408 Flood of EOF warnings

> On Aug. 23, 2017, 9:29 a.m., Hitesh Khamesra wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java > > Line 68 (original), 72 (patched) > > > > > >

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/716 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Review Request 61829: GEODE-3408 Flood of EOF warnings

> On Aug. 23, 2017, 9:29 a.m., Hitesh Khamesra wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java > > Line 68 (original), 72 (patched) > > > > > >

[GitHub] geode pull request #734: GEODE-3508: Remove unused internal deprecated class...

GitHub user PurelyApplied opened a pull request: https://github.com/apache/geode/pull/734 GEODE-3508: Remove unused internal deprecated classes. * Update ClusterConfigurationNotAvailableException to extend Exception directly, rather than the deprecated class. --

Gradle Docker Plugin Fails After Upgrading Gradle To 3.5.1

Hi Everyone, In the last nightly builds, the builds are not running the distributed tests due to the Docker plugin not being compatible with Gradle 3.5.1. I didn't notice this in my testing because for 'precheckin' I do not use the Docker option. I do see the newest version of the Docker plugin

[GitHub] geode issue #733: Keeping old versions around even during a clean

Github user upthewaterspout commented on the issue: https://github.com/apache/geode/pull/733 > Would it be possible to include old versions as dependencies? Yeah, that's what I would really like to do, actually. The problem is that gradle doesn't make it easy to cache an

Re: Review Request 61852: GEODE-3507 actualRedundantCopies stat in org.apache.geode.internal.cache.PartitionedRegionStats can go negative

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61852/#review183626 --- Ship it! Ship It! - Darrel Schneider On Aug. 23, 2017, 9:55

Re: Review Request 61852: GEODE-3507 actualRedundantCopies stat in org.apache.geode.internal.cache.PartitionedRegionStats can go negative

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61852/#review183627 --- Ship it! Ship It! - Eric Shu On Aug. 23, 2017, 4:55 p.m.,

[GitHub] geode issue #733: Keeping old versions around even during a clean

Github user scmbuildguy commented on the issue: https://github.com/apache/geode/pull/733 I am hesitant about this change since it doesn't follow the Gradle workflow very well. Would it be possible to include old versions as dependencies? Maybe then we could leverage Gradle

[GitHub] geode issue #733: Keeping old versions around even during a clean

Github user metatype commented on the issue: https://github.com/apache/geode/pull/733 Um, should we add a `reallyClean` task to scrub this dir? What about users of `-PbuildRoot`? I'm inclined towards keeping temporary build files in `build`. But IMO... +0 --- If

Re: Review Request 61701: GEODE-3277: Fix error path constructors of Launcher inner State classess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61701/#review183621 ---

Review Request 61852: GEODE-3507 actualRedundantCopies stat in org.apache.geode.internal.cache.PartitionedRegionStats can go negative

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61852/ --- Review request for geode, anilkumar gingade, Darrel Schneider, Eric Shu, and

Re: Review Request 61829: GEODE-3408 Flood of EOF warnings

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61829/#review183620 --- Ship it! Ship It! - Udo Kohlmeyer On Aug. 22, 2017, 11:41

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/730#discussion_r134804772 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/result/AbstractResultData.java --- @@ -147,11 +147,10 @@ public ResultData

Re: Review Request 61816: GEODE-3409 Protobuf Client Can't Connect Once Connection Limit Has Been Reached, Even After Connections Closed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61816/#review183617 --- Ship it! Ship It! - Brian Rowe On Aug. 23, 2017, 3:47 p.m.,

Re: Review Request 61829: GEODE-3408 Flood of EOF warnings

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61829/#review183616 ---

[GitHub] geode pull request #733: Keeping old versions around even during a clean

GitHub user upthewaterspout opened a pull request: https://github.com/apache/geode/pull/733 Keeping old versions around even during a clean Putting old versions of geode in a separate directory so they are not removed during a clean. Thank you for submitting a

Re: Review Request 61816: GEODE-3409 Protobuf Client Can't Connect Once Connection Limit Has Been Reached, Even After Connections Closed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61816/#review183615 --- Ship it! Ship It! - Hitesh Khamesra On Aug. 23, 2017, 3:47

[GitHub] geode issue #719: GEODE-3447 Implement client authorization for the new prot...

Github user bschuchardt commented on the issue: https://github.com/apache/geode/pull/719 GetAvailableServers will be executed on a Locator which installs a no-op authorizer in the execution "context". That can change if we decide later on that we want to perform authentication and

Re: Review Request 61816: GEODE-3409 Protobuf Client Can't Connect Once Connection Limit Has Been Reached, Even After Connections Closed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61816/ --- (Updated Aug. 23, 2017, 8:47 a.m.) Review request for geode, Alexander

Build failed in Jenkins: Geode-nightly-flaky #100

See Changes: [jstewart] GEODE-3306: Remove whitespace StringBuffers/nodes created by Apache [ukohlmeyer] GEODE-3416: Reduce synchronization blockages in SocketCloser. This now [hkhamesra] GEODE-3406:

Build failed in Jenkins: Geode-nightly #932

See Changes: [jstewart] GEODE-3306: Remove whitespace StringBuffers/nodes created by Apache [ukohlmeyer] GEODE-3416: Reduce synchronization blockages in SocketCloser. This now [hkhamesra] GEODE-3406: Locator