Re: geode-junit and geode-dunit classpath problems

2019-02-08 Thread Kirk Lund
Alright, this one is figured out! I think most of these issues are other 3rd party dependencies that aren't in geode-junit or geode-dunit because the tests that run and require those dependencies are over in geode-core. I believe I can handle this sort of thing one at a time... On Fri, Feb 8,

geode-junit and geode-dunit classpath problems

2019-02-08 Thread Kirk Lund
We have a src/main class called UseJacksonForJsonPathRule which uses classes from this dependency in geode-junit/build.gradle: compile('com.jayway.jsonpath:json-path') I'm trying to write a unit test in src/test called UseJacksonForJsonPathRuleTest but it fails with the following

Re: [Proposal] Adding Micrometer to Apache Geode

2019-02-08 Thread Dale Emery
I have submitted a new PR https://github.com/apache/geode/pull/3180 , superseding the original one. I invite your review. Cheers, Dale — Dale Emery dem...@pivotal.io > On Feb 4, 2019, at 9:10 AM, Kirk Lund wrote: > > +1 to add Micrometer in the

[DISCUSS] Static analysis of statics

2019-02-08 Thread Dan Smith
Hi devs, We've expressed interest in getting rid of singletons and allowing multiple copies of cache to run in the same JVM. I'd like to get a handle on what static state we have. As a first step I'd like to introduce a few annotations and some static analysis to find all of our mutable static

Re: Very red CI -> Hold merges, please

2019-02-08 Thread Kirk Lund
If you put quotes around "WANRollingUpgradeNewSenderProcessOldEvent" in Jira, then the search finds no hits. Without the quotes it results in two tickets now including the one you worked on. Jira must be searching for partial string matches without quotes -- so some sequence of words in the name

Re: Adding integrationTest src set to geode-dunit

2019-02-08 Thread Robert Houghton
If i'm not responsive, it because family stuff came up. But i can definitely do this on Monday On Fri, Feb 8, 2019 at 9:45 AM Kirk Lund wrote: > Yep, I'll ping you later this afternoon to see if you're free. Thanks! > > On Thu, Feb 7, 2019 at 4:11 PM Robert Houghton > wrote: > > > Can I work

Re: Adding integrationTest src set to geode-dunit

2019-02-08 Thread Kirk Lund
Yep, I'll ping you later this afternoon to see if you're free. Thanks! On Thu, Feb 7, 2019 at 4:11 PM Robert Houghton wrote: > Can I work with you on this tomorrow? > > On Thu, Feb 7, 2019, 15:09 Kirk Lund wrote: > > > The usual geode src sets like integrationTest don't already exist in some >

Re: Very red CI -> Hold merges, please

2019-02-08 Thread Bruce Schuchardt
Testing on the fix for GEODE-6363 passed on overnight runs.  I could push a change to mask the problem and do more testing today if that's what folks want or I could push the fix. On 2/7/19 4:20 PM, Alexander Murmann wrote: Bruce, would it make sense to for now revert the suspect change to