Re: [DISCUSS] Add a test dependency to geode-core - ArchUnit

2019-06-20 Thread Jacob Barrett
Gotcha! Sounds good. > On Jun 20, 2019, at 4:35 PM, Dan Smith wrote: > > We don't have a membership gradle module, just a package. We're adding this > to geode-core. > > For a little more context - we are thinking about refactoring membership > (and/or maybe some other pieces) into separate gra

Re: [DISCUSS] Add a test dependency to geode-core - ArchUnit

2019-06-20 Thread Michael Oleske
Seems alright to me given the context that you're trying to separate code into modules (and want to make sure you're not including packages you shouldn't). Looking forward to see how the progress goes! -michael On Thu, Jun 20, 2019 at 4:35 PM Dan Smith wrote: > We don't have a membership gradl

Re: [DISCUSS] Add a test dependency to geode-core - ArchUnit

2019-06-20 Thread Dan Smith
We don't have a membership gradle module, just a package. We're adding this to geode-core. For a little more context - we are thinking about refactoring membership (and/or maybe some other pieces) into separate gradle modules - proposal forthcoming! However, as a first step we need to untangle tho

Re: [DISCUSS] Add a test dependency to geode-core - ArchUnit

2019-06-20 Thread Jacob Barrett
Are you adding this dependency to just the membership module? I am cool with that. > On Jun 20, 2019, at 2:39 PM, Dan Smith wrote: > > Hi all, > > Bill, Ernie, and I would like to add a new (apache licensed) test > dependency to geode-core - https://github.com/TNG/ArchUnit. This is a tool > th

Re: "Output path is not specified for module" (IntelliJ)

2019-06-20 Thread Jacob Barrett
Murtuza, If you are using the Gradle building it will take longer to than the built in IntelliJ builder. Mixing the Gradle builder and the IntelliJ test runner seems odd to me. Using the Gradle test running will ensure the the test runs exactly as it does in the CI. The downside is that IntelliJ

Re: "Output path is not specified for module" (IntelliJ)

2019-06-20 Thread Eric Shu
Here is my settings. I only set ‘inherit project compile path’ when it is needed. [image: image.png] On Thu, Jun 20, 2019 at 1:28 PM Murtuza Boxwala wrote: > Eric, > > Can you please share a screen shot of your gradle preferences in Intellij > (I attached mine, too). I tried Jens’ solution and

Re: [PROPOSAL]: Improve OQL Method Invocation Security

2019-06-20 Thread Dan Smith
+1 This looks really good! I put a couple of comments inline, and I have a few more general questions here: 1. Is the RegionQueryInvocationAuthorizer different than our existing shiro permissions? I thought users can already grant permissions for specific regions. What does this add in addition t

[DISCUSS] Add a test dependency to geode-core - ArchUnit

2019-06-20 Thread Dan Smith
Hi all, Bill, Ernie, and I would like to add a new (apache licensed) test dependency to geode-core - https://github.com/TNG/ArchUnit. This is a tool that lets you write tests that make assertions about the interdependencies of your code - for example enforcing that package A does not depend on pac

[CVE-2017-15694] Apache Geode metadata modification vulnerability

2019-06-20 Thread Anthony Baker
CVE-2017-15694 Apache Geode metadata modification vulnerability Severity: Medium Vendor: The Apache Software Foundation Versions Affected: Apache Geode 1.0.0 through 1.8.0 Description: When a Geode server is operating in secure mode, a user with write permissions for specific data regions can m