Review Request 58213: GEODE-2749: don't ignore bin/ because we have bin/ in src

2017-04-05 Thread Kirk Lund
ff: https://reviews.apache.org/r/58213/diff/1/ Testing --- precheckin in progress Thanks, Kirk Lund

Re: Review Request 58162: GEM-1351: Move a test to the open side and fix the other tests

2017-04-04 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58162/#review171074 --- Ship it! Ship It! - Kirk Lund On April 4, 2017, 10:02 p.m

Re: GEODE-2749: ignore bin/ and out/ which are commonly created by IDEs

2017-04-04 Thread Kirk Lund
Thanks for the reviews! On Tue, Apr 4, 2017 at 11:33 AM, Kirk Lund <kl...@apache.org> wrote: > Can someone please review my review request: > > https://reviews.apache.org/r/58158/ > > Thanks, > Kirk > >

[jira] [Resolved] (GEODE-2748) geode-web web.xml specifies the wrong xml namespace

2017-04-04 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-2748. -- Resolution: Fixed Fix Version/s: 1.2.0 > geode-web web.xml specifies the wrong xml namesp

[jira] [Resolved] (GEODE-2749) git and rat should ignore out/ and bin/ directories created by IDEs

2017-04-04 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-2749. -- Resolution: Fixed Fix Version/s: 1.2.0 > git and rat should ignore out/ and bin/ director

Re: Review Request 58162: GEM-1351: Move a test to the open side and fix the other tests

2017-04-04 Thread Kirk Lund
twined by accessing each others variables and other craziness. geode-core/src/test/java/org/apache/geode/management/internal/configuration/ImportClusterConfigDistributedTest.java Lines 80 (patched) <https://reviews.apache.org/r/58162/#comment243849> Can we make this private too?

GEODE-2749: ignore bin/ and out/ which are commonly created by IDEs

2017-04-04 Thread Kirk Lund
Can someone please review my review request: https://reviews.apache.org/r/58158/ Thanks, Kirk

ServerLauncher with test classpath causes main to go into ExportLogsIntegrationTest

2017-04-03 Thread Kirk Lund
I just started forked a JVM from a benchmark setup using something like this: List command = new ArrayList<>(); command.add( new File(new File(System.getProperty("java.home"), "bin"), "java").getCanonicalPath()); command.add( "-D" +

CacheServer and fake in-process client

2017-04-03 Thread Kirk Lund
Has anyone written a test where they use a single JVM in which they start a server Cache and then fake up a connection from a non-existent client to feed messages into the server? I think most folks have gone the easy route of using dunit for client/server tests. I need to do something like this

Re: Client Commands and SecurityService

2017-04-03 Thread Kirk Lund
Kohlmeyer < >>>>>>> >>>>>> ukohlme...@pivotal.io> >>> >>>> wrote: >>>>>>> >>>>>>> -1 For using singletons >>>>>>>> >>>>>>>> Using a Factory pattern you c

Review Request 58158: GEODE-2749: ignore bin/ and out/ which are commonly created by IDEs

2017-04-03 Thread Kirk Lund
/diff/1/ Testing --- precheckin in progress Thanks, Kirk Lund

Re: Review Request 58080: GEODE-2420: Add classes to estimated the size of exported logs

2017-04-03 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58080/#review170922 --- Ship it! Ship It! - Kirk Lund On March 31, 2017, 10:35 p.m

Re: Review Request 58050: GEODE-2725: export logs --dir now honored when not connected via HTTP[S].

2017-04-03 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58050/#review170921 --- Ship it! Ship It! - Kirk Lund On March 31, 2017, 11:16 p.m

[jira] [Assigned] (GEODE-2749) git and rat should ignore out/ and bin/ directories created by IDEs

2017-04-03 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2749: Assignee: Kirk Lund > git and rat should ignore out/ and bin/ directories created by I

[jira] [Commented] (GEODE-2748) geode-web web.xml specifies the wrong xml namespace

2017-04-03 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954002#comment-15954002 ] Kirk Lund commented on GEODE-2748: -- The other web.xml files in Geode seem to be ok (specifying javaee

[jira] [Updated] (GEODE-2748) geode-web web.xml specifies the wrong xml namespace

2017-04-03 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2748: - Component/s: (was: rest (dev)) rest (admin) > geode-web web.xml specifies the wr

[jira] [Assigned] (GEODE-2748) geode-web web.xml specifies the wrong xml namespace

2017-04-03 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2748: Assignee: Kirk Lund > geode-web web.xml specifies the wrong xml namesp

Compilation error involving stream/lambda in Eclipse

2017-04-03 Thread Kirk Lund
I'm trying to use JMH plugins in IntelliJ and Eclipse. The one for IntelliJ seems to lock up the latest version of IntelliJ, so I've built a fresh Eclipse workspace for a clean checkout of Geode develop. Eclipse is complaining about a single line of code in ClusterConfigurationService.java line

Re: Review Request 58010: GEODE-2716: export logs default behavior changed from filtering at log level INFO to ALL.

2017-03-31 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58010/#review170789 --- Ship it! Ship It! - Kirk Lund On March 30, 2017, 7:19 p.m

Re: Review Request 58080: GEODE-2420: Add classes to estimated the size of exported logs

2017-03-31 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58080/#review170788 --- Ship it! Ship It! - Kirk Lund On March 31, 2017, 7:55 p.m

Fwd: Build failed in Jenkins: Geode-nightly #793

2017-03-31 Thread Kirk Lund
What does the community want to do with this test? I have already done everything I can to make it more dependable. Delete the assertion? Delete the test? Someone else want to take stab at fixing it? -- Forwarded message -- From: Apache Jenkins Server

Re: Client Commands and SecurityService

2017-03-30 Thread Kirk Lund
PS: I'll be writing and using JMH benchmarks to drive these changes. I'll also create new unit tests for each of these classes that don't currently have unit tests. On Thu, Mar 30, 2017 at 10:58 AM, Kirk Lund <kl...@apache.org> wrote: > The client Commands now check with SecuritySer

Client Commands and SecurityService

2017-03-30 Thread Kirk Lund
The client Commands now check with SecurityService even when security is not configured. This has introduced a negative performance impact. The best way to fix something like this is to tell the Command instance when it's being constructed that is does or does not need to perform security checks.

Re: Requesting edit permissions for Geode tickets

2017-03-30 Thread Kirk Lund
I gave you permissions for Jira. Someone else still needs to give you karma on the Wiki. -Kirk On Thu, Mar 30, 2017 at 9:22 AM, Fred Krone wrote: > Hi, > > Could I get editing permissions for Geode tickets? I can only edit mine > and I'd like to reword some descriptions etc

Re: Request for edit permissions

2017-03-30 Thread Kirk Lund
I gave you access in Jira. I'm not sure how to give you access in Wiki though. Roman, if you want to give me permissions to give Wiki karma, I'll be happy to help Brian there as well. -Kirk On Thu, Mar 30, 2017 at 9:08 AM, Brian Baynes wrote: > Hi, Roman. > > Sure,

[jira] [Updated] (GEODE-2735) CliUtil.isGfshVM is not thread-safe and unnecessary

2017-03-30 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2735: - Issue Type: Wish (was: Bug) > CliUtil.isGfshVM is not thread-safe and unnecess

[jira] [Assigned] (GEODE-2735) CliUtil.isGfshVM is not thread-safe and unnecessary

2017-03-30 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2735: Assignee: Kirk Lund > CliUtil.isGfshVM is not thread-safe and unnecess

[jira] [Created] (GEODE-2735) CliUtil.isGfshVM is not thread-safe and unnecessary

2017-03-30 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2735: Summary: CliUtil.isGfshVM is not thread-safe and unnecessary Key: GEODE-2735 URL: https://issues.apache.org/jira/browse/GEODE-2735 Project: Geode Issue Type: Bug

Re: Review Request 58052: HttpClientRule does not need port at intialization time

2017-03-29 Thread Kirk Lund
we can work together on a bunch more refactoring of these JUnit Rules. - Kirk Lund On March 29, 2017, 11:14 p.m., Jared Stewart wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 58050: GEODE-2725: export logs --dir now honored when not connected via HTTP[S].

2017-03-29 Thread Kirk Lund
Test and start writing some unit tests for this class. - Kirk Lund On March 29, 2017, 10:33 p.m., Patrick Rhomberg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 58010: GEODE-2716: export logs default behavior changed from filtering at log level INFO to ALL.

2017-03-29 Thread Kirk Lund
internal/cli/functions/ExportLogsFunction.java Line 156 (original), 156 (patched) <https://reviews.apache.org/r/58010/#comment243331> - Kirk Lund On March 28, 2017, 10:34 p.m., Patrick Rhomberg wrote: > > --- > This is an aut

Re: [VOTE] Apache Geode release - v1.1.1 RC2

2017-03-29 Thread Kirk Lund
I'll change my vote to +0. Go ahead and release now and then we should define better criteria going forward. On Wed, Mar 29, 2017 at 2:06 PM, Anthony Baker <aba...@pivotal.io> wrote: > > > > On Mar 29, 2017, at 11:59 AM, Kirk Lund <kl...@apache.org> wrote: >

Re: [VOTE] Apache Geode release - v1.1.1 RC2

2017-03-29 Thread Kirk Lund
e. Do you > agree? What happens when you run the test? > > Anthony > > > > On Mar 28, 2017, at 5:19 PM, Kirk Lund <kl...@apache.org> wrote: > > > > -1 > > > > We still have failing tests in Geode-release #50 (this is the most recent > >

Re: [VOTE] Apache Geode release - v1.1.1 RC2

2017-03-28 Thread Kirk Lund
-1 We still have failing tests in Geode-release #50 (this is the most recent CI for Geode-release). I assume "Geode-release #50" is testing v1.1.1 RC2. org.junit.ComparisonFailure: expected:<[tru]e> but was:<[fals]e> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native

Re: Geode 1.2.0 should not ship with failing tests

2017-03-28 Thread Kirk Lund
Oops, I mean "v1.1.1 RC2" On Tue, Mar 28, 2017 at 5:16 PM, Kirk Lund <kl...@apache.org> wrote: > Is anyone working on stabilizing ClusterConfigImportDUnitTest? > > This is a recently created test. One criteria for shipping Geode 1.2.0 > should be no failures in

Geode 1.2.0 should not ship with failing tests

2017-03-28 Thread Kirk Lund
Is anyone working on stabilizing ClusterConfigImportDUnitTest? This is a recently created test. One criteria for shipping Geode 1.2.0 should be no failures in new tests including this one. [...truncated 105.03 KB...] org.junit.ComparisonFailure: expected:<[tru]e> but was:<[fals]e> at

[jira] [Updated] (GEODE-2632) Integrated Security performance improvements

2017-03-27 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2632: - Labels: performance (was: ) > Integrated Security performance improveme

[jira] [Updated] (GEODE-2632) Integrated Security performance improvements

2017-03-27 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2632: - Component/s: security > Integrated Security performance improveme

Writing JMH benchmarks for Geode

2017-03-27 Thread Kirk Lund
I was about to writing some JMH benchmarks for specific areas of Geode code and place the benchmarks in src/jmh/java parallel to src/main/java and src/tests/java in the appropriate geode module containing the code I want to benchmark. I see that we already have a "geode-benchmarks" module which

Re: Contributor Permissions Request

2017-03-22 Thread Kirk Lund
I've added you to the correct group in Jira so can create/edit/assign Jira tickets. Thanks, Kirk On Wed, Mar 22, 2017 at 9:03 AM, Patrick S Rhomberg wrote: > Hello! > > I am requesting contributor permissions to the Geode project. My JIRA > username is also prhomberg.

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

2017-03-22 Thread Kirk Lund
o do the logging instead of > > using LogService.getLogger api if we want to get rid of PulseLogWriter > > Kirk Lund wrote: > This change only includes geode-core and geode-common classes in the > classpath for Pulse code. Imagine using > org.apache.geode.internal.util

Re: Review Request 57729: GEODE-2634: use log4j levels for auto-completion

2017-03-22 Thread Kirk Lund
m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57729/ > ------- > > (Updated March 17, 20

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

2017-03-22 Thread Kirk Lund
> On March 21, 2017, 10:28 p.m., Kirk Lund wrote: > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java > > Line 87 (original), 89 (patched) > > <https://reviews.apache.org/r/57822/diff/1/?file=1671157#file1671157line90> > &g

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

2017-03-22 Thread Kirk Lund
utomatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57822/ > --- > > (Updated March 21, 2017, 10:05 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, > Kirk Lund, and Swapnil Bawa

[jira] [Updated] (GEODE-2671) When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

2017-03-21 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2671: - Component/s: jmx > When a locator is started with a custom jmx-manager-port, the embedded pulse >

[jira] [Updated] (GEODE-2670) pulse with integrated security has authentication and authorization issues

2017-03-21 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2670: - Component/s: security pulse > pulse with integrated security has authenticat

Blacklist asf904 for Geode nightly job

2017-03-21 Thread Kirk Lund
Please blacklist asf904 for the Geode nightly job. It seems to be giving bad DNS info to our tests, causing UniversalMembershipListenerAdapterDUnitTest to fail again. Alternatively, if someone else wants to look into the failures in UniversalMembershipListenerAdapterDUnitTest please go ahead. I've

[jira] [Resolved] (GEODE-2648) DiskSpaceLimitIntegrationTest.aboveZeroDeletesPreviousFiles fails with TimeoutException

2017-03-17 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-2648. -- Resolution: Fixed Fix Version/s: 1.2.0

[jira] [Resolved] (GEODE-2645) Refactor CacheLogRollDUnitTest to be an IntegrationTest

2017-03-16 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-2645. -- Resolution: Fixed Fix Version/s: 1.2.0 These changes also fixed GEODE-674, GEODE-675, GEODE-676

[jira] [Resolved] (GEODE-677) CI failure: CacheLogRollDUnitTest.testStartWithRollingThenRestartWithRolling

2017-03-16 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-677. - Resolution: Fixed Fix Version/s: 1.2.0 Fixed by GEODE-2645 > CI fail

[jira] [Assigned] (GEODE-676) CI failure: CacheLogRollDUnitTest.testLogFileLayoutAndRolling

2017-03-16 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-676: --- Assignee: Kirk Lund > CI failure: CacheLogRollDUnitTest.testLogFileLayoutAndRoll

[jira] [Resolved] (GEODE-676) CI failure: CacheLogRollDUnitTest.testLogFileLayoutAndRolling

2017-03-16 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-676. - Resolution: Fixed Fix Version/s: 1.2.0 Fixed by GEODE-2645 > CI fail

[jira] [Assigned] (GEODE-677) CI failure: CacheLogRollDUnitTest.testStartWithRollingThenRestartWithRolling

2017-03-16 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-677: --- Assignee: Kirk Lund > CI failure: CacheLogRollDUnitTest.testStartWithRollingThenRestartWithRoll

[jira] [Resolved] (GEODE-675) CI failure: CacheLogRollDUnitTest.testSecurityLogFileLayoutAndRolling

2017-03-16 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-675. - Resolution: Fixed Fix Version/s: 1.2.0 Fixed by GEODE-2645 > CI fail

[jira] [Assigned] (GEODE-675) CI failure: CacheLogRollDUnitTest.testSecurityLogFileLayoutAndRolling

2017-03-16 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-675: --- Assignee: Kirk Lund > CI failure: CacheLogRollDUnitTest.testSecurityLogFileLayoutAndRoll

[jira] [Resolved] (GEODE-674) CI failure: CacheLogRollDUnitTest.testSimpleStartRestartWithRolling

2017-03-16 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-674. - Resolution: Fixed Fix Version/s: 1.2.0 Fixed by GEODE-2645 > CI fail

[jira] [Updated] (GEODE-2395) PulseDataExportTest.dataBrowserExportWorksAsExpected fails intermittently with ComparisonFailure

2017-03-16 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2395: - Component/s: tests > PulseDataExportTest.dataBrowserExportWorksAsExpected fails intermitten

[jira] [Assigned] (GEODE-2395) PulseDataExportTest.dataBrowserExportWorksAsExpected fails intermittently with ComparisonFailure

2017-03-16 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2395: Assignee: Jinmei Liao > PulseDataExportTest.dataBrowserExportWorksAsExpected fails intermitten

[jira] [Resolved] (GEODE-2646) PulseDataExportTest.dataBrowserExportWorksAsExpected fails with BindException

2017-03-16 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-2646. -- Resolution: Duplicate > PulseDataExportTest.dataBrowserExportWorksAsExpected fails with BindExcept

[jira] [Commented] (GEODE-2395) PulseDataExportTest.dataBrowserExportWorksAsExpected fails intermittently with ComparisonFailure

2017-03-16 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928483#comment-15928483 ] Kirk Lund commented on GEODE-2395: -- This was refiled as GEODE-2646. This shows how frequently this flaky

Re: Geode log levels vs. log4j log levels

2017-03-16 Thread Kirk Lund
Here's the equivalent log levels between LogWriter levels and Log4J2 levels LogWriter Log4J2 SEVERE= FATAL ERROR = ERROR WARN = WARNING INFO = INFO, CONFIG DEBUG = FINE TRACE = FINER, FINEST On Thu, Mar 16, 2017 at 10:08 AM, Darrel Schneider

[jira] [Commented] (GEODE-2646) PulseDataExportTest.dataBrowserExportWorksAsExpected fails with BindException

2017-03-16 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928367#comment-15928367 ] Kirk Lund commented on GEODE-2646: -- These Rules need to be altered to not use default ports for JMX

[jira] [Assigned] (GEODE-2646) PulseDataExportTest.dataBrowserExportWorksAsExpected fails with BindException

2017-03-16 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2646: Assignee: Jinmei Liao (was: Kirk Lund) > PulseDataExportTest.dataBrowserExportWorksAsExpec

[jira] [Created] (GEODE-2673) PartitionedRegionMultipleDUnitTest.testPartitionedRegionDestroyAndContainsAPI fails intermittently with ForcedDisconnectException

2017-03-15 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2673: Summary: PartitionedRegionMultipleDUnitTest.testPartitionedRegionDestroyAndContainsAPI fails intermittently with ForcedDisconnectException Key: GEODE-2673 URL: https://issues.apache.org

[jira] [Updated] (GEODE-2673) PartitionedRegionMultipleDUnitTest.testPartitionedRegionDestroyAndContainsAPI fails intermittently with ForcedDisconnectException

2017-03-15 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2673: - Labels: Flaky (was: ) > PartitionedRegionMultipleDUnitTest.testPartitionedRegionDestroyAndContains

[jira] [Created] (GEODE-2672) LuceneManagementDUnitTest.testMBeanAndProxiesCreated fails intermittently with ConditionTimeoutException

2017-03-15 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2672: Summary: LuceneManagementDUnitTest.testMBeanAndProxiesCreated fails intermittently with ConditionTimeoutException Key: GEODE-2672 URL: https://issues.apache.org/jira/browse/GEODE-2672

Re: Review Request 57573: GEODE-2648: always move deleted files to dirOfDeletedFiles

2017-03-15 Thread Kirk Lund
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57573/#review168945 --- On March 15, 2017, 8:02 p.m., Kirk Lund wrote: > > ---

[jira] [Updated] (GEODE-2648) DiskSpaceLimitIntegrationTest.aboveZeroDeletesPreviousFiles fails with TimeoutException

2017-03-15 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2648: - Labels: Flaky (was: ) > DiskSpaceLimitIntegrationTest.aboveZeroDeletesPreviousFiles fa

[jira] [Commented] (GEODE-2647) ClientHealthStatsDUnitTest.testClientHealthStats_SubscriptionEnabled fails with NullPointerException

2017-03-15 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926533#comment-15926533 ] Kirk Lund commented on GEODE-2647: -- This failure is intermittent, but I don't see evidence of it being

[jira] [Updated] (GEODE-2646) PulseDataExportTest.dataBrowserExportWorksAsExpected fails with BindException

2017-03-15 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2646: - Labels: Flaky (was: ) > PulseDataExportTest.dataBrowserExportWorksAsExpected fails with BindExcept

region put followed by region getEntry returns null

2017-03-15 Thread Kirk Lund
I'm looking into a CI test failure (ClientHealthStatsDUnitTest.testClientHealthStats_SubscriptionEnabled). I don't see anything wrong with the test so far. It looks to me like region.getEntry(KEY1) must have either returned a null RegionEntry or RegionEntry.getValue returned a null immediately

[jira] [Updated] (GEODE-2653) GMSJoinLeaveJUnitTest.testRemoveMember fails with AssertionError

2017-03-13 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2653: - Labels: Flaky (was: ) > GMSJoinLeaveJUnitTest.testRemoveMember fails with AssertionEr

[jira] [Created] (GEODE-2653) GMSJoinLeaveJUnitTest.testRemoveMember fails with AssertionError

2017-03-13 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2653: Summary: GMSJoinLeaveJUnitTest.testRemoveMember fails with AssertionError Key: GEODE-2653 URL: https://issues.apache.org/jira/browse/GEODE-2653 Project: Geode

Review Request 57569: GEODE-2645: rewrite test to fix flakiness and improve readability

2017-03-13 Thread Kirk Lund
--- CacheLogRollingIntegrationTest precheckin in progress Thanks, Kirk Lund

[jira] [Resolved] (GEODE-2594) Remove optional usage of Attach API

2017-03-13 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-2594. -- Resolution: Fixed Fix Version/s: 1.2.0 > Remove optional usage of Attach

[jira] [Updated] (GEODE-2652) IntegratedSecurityService class has state that is not thread safe

2017-03-13 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2652: - Description: The state of IntegratedSecurityService is currently not thread safe. One thread may set

[jira] [Created] (GEODE-2652) IntegratedSecurityService class has state that is not thread safe

2017-03-13 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2652: Summary: IntegratedSecurityService class has state that is not thread safe Key: GEODE-2652 URL: https://issues.apache.org/jira/browse/GEODE-2652 Project: Geode

Re: Split geode nightly build into two jobs

2017-03-13 Thread Kirk Lund
-flaky tests first and then flaky-tests... > > -Anil. > > > On Mon, Mar 13, 2017 at 10:44 AM, Kirk Lund <kl...@apache.org> wrote: > > > I'd like to propose splitting the Geode Nightly build into two jobs: > > > > 1) precheckin without flakyTest > > 2) flakyTest by itself > > >

Geode Nightly build failures

2017-03-13 Thread Kirk Lund
I'm working on these failures from the last 4 days: GEODE-2648 - DiskSpaceLimitIntegrationTest.aboveZeroDeletesPreviousFiles - race condition in test GEODE-2647 - ClientHealthStatsDUnitTest.testClientHealthStats_SubscriptionEnabled - race condition in test GEODE-2646 -

[jira] [Assigned] (GEODE-2649) ExportLogsDUnitTest.testExportWithStartAndEndDateTimeFiltering fails with AssertionError

2017-03-13 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2649: Assignee: Jared Stewart > ExportLogsDUnitTest.testExportWithStartAndEndDateTimeFiltering fa

[jira] [Created] (GEODE-2649) ExportLogsDUnitTest.testExportWithStartAndEndDateTimeFiltering fails with AssertionError

2017-03-13 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2649: Summary: ExportLogsDUnitTest.testExportWithStartAndEndDateTimeFiltering fails with AssertionError Key: GEODE-2649 URL: https://issues.apache.org/jira/browse/GEODE-2649

[jira] [Created] (GEODE-2648) DiskSpaceLimitIntegrationTest.aboveZeroDeletesPreviousFiles fails with TimeoutException

2017-03-13 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2648: Summary: DiskSpaceLimitIntegrationTest.aboveZeroDeletesPreviousFiles fails with TimeoutException Key: GEODE-2648 URL: https://issues.apache.org/jira/browse/GEODE-2648

[jira] [Assigned] (GEODE-2648) DiskSpaceLimitIntegrationTest.aboveZeroDeletesPreviousFiles fails with TimeoutException

2017-03-13 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2648: Assignee: Kirk Lund > DiskSpaceLimitIntegrationTest.aboveZeroDeletesPreviousFiles fa

Re: Review Request 57514: GEODE-2267: enhance error output for gfsh.

2017-03-13 Thread Kirk Lund
ExportLogsCommand.java. geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogCommand.java Line 53 (original), 53 (patched) <https://reviews.apache.org/r/57514/#comment241046> I thought we renamed this to ExportLogsCommand.java? - Kirk Lund On March 13

Re: Review Request 57514: GEODE-2267: enhance error output for gfsh.

2017-03-13 Thread Kirk Lund
> On March 13, 2017, 5:47 p.m., Kirk Lund wrote: > > I think we renamed the tests but missed ExportLogsCommand.java. My review includes a Ship It! But the GUI is showing it under "Fix It!" - Kirk --- This is an auto

[jira] [Created] (GEODE-2647) ClientHealthStatsDUnitTest.testClientHealthStats_SubscriptionEnabled fails with NullPointerException

2017-03-13 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2647: Summary: ClientHealthStatsDUnitTest.testClientHealthStats_SubscriptionEnabled fails with NullPointerException Key: GEODE-2647 URL: https://issues.apache.org/jira/browse/GEODE-2647

[jira] [Assigned] (GEODE-2647) ClientHealthStatsDUnitTest.testClientHealthStats_SubscriptionEnabled fails with NullPointerException

2017-03-13 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2647: Assignee: Kirk Lund > ClientHealthStatsDUnitTest.testClientHealthStats_SubscriptionEnabled fa

[jira] [Created] (GEODE-2646) PulseDataExportTest.dataBrowserExportWorksAsExpected fails with BindException

2017-03-13 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2646: Summary: PulseDataExportTest.dataBrowserExportWorksAsExpected fails with BindException Key: GEODE-2646 URL: https://issues.apache.org/jira/browse/GEODE-2646 Project: Geode

[jira] [Assigned] (GEODE-2646) PulseDataExportTest.dataBrowserExportWorksAsExpected fails with BindException

2017-03-13 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2646: Assignee: Kirk Lund > PulseDataExportTest.dataBrowserExportWorksAsExpected fa

Split geode nightly build into two jobs

2017-03-13 Thread Kirk Lund
I'd like to propose splitting the Geode Nightly build into two jobs: 1) precheckin without flakyTest 2) flakyTest by itself

[jira] [Resolved] (GEODE-2313) PulseDataExportTest.dataBrowserExportWorksAsExpected fails with ConditionTimeoutException

2017-03-13 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-2313. -- Resolution: Fixed Fix Version/s: 1.2.0 > PulseDataExportTest.dataBrowserExportWorksAsExpec

[jira] [Assigned] (GEODE-2645) Refactor CacheLogRollDUnitTest to be an IntegrationTest

2017-03-13 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2645: Assignee: Kirk Lund > Refactor CacheLogRollDUnitTest to be an IntegrationT

Re: Upgrading Jetty

2017-03-10 Thread Kirk Lund
Upgrading to 9.3.11 for now sounds like a good idea. We can file a different Jira ticket to upgrade to 9.4 in the future. At least we get to pick up the bug fixes from 9.3.6 to 9.3.11! On Fri, Mar 10, 2017 at 3:03 PM, Kevin Duling wrote: > I've been working on GEODE-2539 to

Re: Review Request 57514: GEODE-2267: enhance error output for gfsh.

2017-03-10 Thread Kirk Lund
eviews.apache.org/r/57514/#comment240954> Another class that we really need to create a UnitTest or IntegrationTest for. - Kirk Lund On March 10, 2017, 5:17 p.m., Jinmei Liao wrote: > > --- > This is an automatically gener

[jira] [Created] (GEODE-2645) Refactor CacheLogRollDUnitTest to be an IntegrationTest

2017-03-10 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2645: Summary: Refactor CacheLogRollDUnitTest to be an IntegrationTest Key: GEODE-2645 URL: https://issues.apache.org/jira/browse/GEODE-2645 Project: Geode Issue Type

[jira] [Updated] (GEODE-1383) Please add gemfire,heap, xml configuration information to start of every log file

2017-03-10 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-1383: - Priority: Major (was: Minor) > Please add gemfire,heap, xml configuration information to start of ev

[jira] [Assigned] (GEODE-1383) Please add gemfire,heap, xml configuration information to start of every log file

2017-03-10 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-1383: Assignee: Kirk Lund > Please add gemfire,heap, xml configuration information to start of every

[jira] [Updated] (GEODE-1383) Please add gemfire,heap, xml configuration information to start of every log file

2017-03-10 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-1383: - Issue Type: Improvement (was: New Feature) > Please add gemfire,heap, xml configuration informat

[jira] [Updated] (GEODE-1383) Please add gemfire,heap, xml configuration information to start of every log file

2017-03-10 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-1383: - Priority: Minor (was: Major) > Please add gemfire,heap, xml configuration information to start of ev

[jira] [Updated] (GEODE-1383) Please add gemfire,heap, xml configuration information to start of every log file

2017-03-10 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-1383: - Labels: LogBanner (was: ) > Please add gemfire,heap, xml configuration information to start of every

<    6   7   8   9   10   11   12   13   14   15   >