[jira] [Updated] (GEODE-2556) RollingUpgradeDUnitTest.testRollServersOnPersistentRegion_dataserializable[0] fails intermittently

2017-02-28 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2556: - Labels: Flaky (was: ) > RollingUpgradeDUnitTest.testRollServersOnPersistentRegion_dataserializabl

[jira] [Updated] (GEODE-2556) RollingUpgradeDUnitTest.testRollServersOnPersistentRegion_dataserializable[0] fails intermittently

2017-02-28 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2556: - Description: I've seen this fail off and on in precheckin, but it always passes when I run it by itself

[jira] [Created] (GEODE-2556) RollingUpgradeDUnitTest.testRollServersOnPersistentRegion_dataserializable[0] fails intermittently

2017-02-28 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2556: Summary: RollingUpgradeDUnitTest.testRollServersOnPersistentRegion_dataserializable[0] fails intermittently Key: GEODE-2556 URL: https://issues.apache.org/jira/browse/GEODE-2556

apache-geode/lib/ra.jar

2017-02-28 Thread Kirk Lund
Does anyone know why "apache-geode/lib/ra.jar" doesn't have a geode- prefix and release numbers in the jar name? This is the only unidentified jar in the Apache Geode lib directory, and I think we should change this to be named like the other jars if possible. It seems to contain JCA classes from

Re: Review Request 57064: GEODE-2460: update dependency versions

2017-02-27 Thread Kirk Lund
gradle/dependency-versions.properties be828af14826ff63adee18717de063d87e2f1c6c Diff: https://reviews.apache.org/r/57064/diff/ Testing (updated) --- precheckin passed (100% green) 2nd precheckin in progress Thanks, Kirk Lund

Re: Review Request 57064: GEODE-2460: update dependency versions

2017-02-27 Thread Kirk Lund
> On Feb. 27, 2017, 11:13 p.m., Kirk Lund wrote: > > gradle/dependency-versions.properties, line 62 > > <https://reviews.apache.org/r/57064/diff/1/?file=1647896#file1647896line62> > > > > I suspect this can be removed as an explicit dependency Drop

Re: Review Request 57064: GEODE-2460: update dependency versions

2017-02-27 Thread Kirk Lund
> > geode-web-api/src/main/webapp/META-INF/NOTICE:Jackson Core 2.8.2 > > ``` > > Kirk Lund wrote: > Yep, thanks for finding those! I found a couple more NOTICE files that had incorrect versions so I'm combining the fix for those with this changeset. - Kirk

Re: Review Request 57064: GEODE-2460: update dependency versions

2017-02-27 Thread Kirk Lund
visit: https://reviews.apache.org/r/57064/#review166967 --- On Feb. 27, 2017, 11:12 p.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57064/ > -

Re: Review Request 57064: GEODE-2460: update dependency versions

2017-02-27 Thread Kirk Lund
tps://reviews.apache.org/r/57064/#comment239056> I suspect this can be removed as an explicit dependency - Kirk Lund On Feb. 27, 2017, 11:12 p.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail. To reply,

Review Request 57064: GEODE-2460: update dependency versions

2017-02-27 Thread Kirk Lund
://reviews.apache.org/r/57064/diff/ Testing --- precheckin passed (100% green) Thanks, Kirk Lund

[jira] [Commented] (GEODE-2275) CI Failure: ClearTXLockingDUnitTest.testPutWithClearDifferentVM

2017-02-24 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884033#comment-15884033 ] Kirk Lund commented on GEODE-2275: -- This reproduced in one of my private precheckin runs. Since there's

Re: Review Request 56964: GEODE-2526: Enhance log statement in StatsArchiveReader

2017-02-24 Thread Kirk Lund
> On Feb. 23, 2017, 10:18 p.m., Kirk Lund wrote: > > +1 I know this change is good and would be safe commit it as is, however we > > have been trying to create UnitTests for any class that we touch that > > doesn't already have a UnitTest. As a whole, the project relies

Re: Review Request 56991: GEODE-2416: Collect together artifacts from individual servers into a single zip file

2017-02-24 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56991/#review166794 --- Ship it! Ship It! - Kirk Lund On Feb. 24, 2017, 3:12 a.m

Re: Review Request 57050: GEODE-2461: remove unnecessary explicit dependencies

2017-02-24 Thread Kirk Lund
in both geode-junit and geode-core. - Kirk --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57050/#review166772 ---

Re: [DISCUSS] changes to Redis implementation

2017-02-24 Thread Kirk Lund
+1 for merging in these changes even though they break rolling upgrade for redis storage format -- it should be ok to break API or data format if it was "experimental" in all releases so far On Fri, Feb 24, 2017 at 3:25 PM, Bruce Schuchardt wrote: > Gregory Green has

[jira] [Updated] (GEODE-2546) RollingUpgradeDUnitTest fails intermittently with ClusterConfigurationNotAvailableException

2017-02-24 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2546: - Labels: Flaky (was: ) > RollingUpgradeDUnitTest fails intermitten

[jira] [Created] (GEODE-2546) RollingUpgradeDUnitTest fails intermittently with ClusterConfigurationNotAvailableException

2017-02-24 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2546: Summary: RollingUpgradeDUnitTest fails intermittently with ClusterConfigurationNotAvailableException Key: GEODE-2546 URL: https://issues.apache.org/jira/browse/GEODE-2546

Review Request 57050: GEODE-2461: remove unnecessary explicit dependencies

2017-02-24 Thread Kirk Lund
% green) Thanks, Kirk Lund

[jira] [Assigned] (GEODE-2544) gfsh incorrectly reports that tools.jar is required if JAVA_ARGS=-Dgemfire.test.ProcessControllerFactory.DisableAttachApi=true

2017-02-24 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2544: Assignee: Kirk Lund > gfsh incorrectly reports that tools.jar is required if > JAV

[jira] [Commented] (GEODE-2461) Remove unnecessary explicit dependencies

2017-02-24 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883200#comment-15883200 ] Kirk Lund commented on GEODE-2461: -- Removing cglib from explicit dependency declaration results in JMock

[jira] [Created] (GEODE-2542) LocatorDUnitTest and LocatorUDPSecurityDUnitTest fail frequently in Geode Nightly Build

2017-02-24 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2542: Summary: LocatorDUnitTest and LocatorUDPSecurityDUnitTest fail frequently in Geode Nightly Build Key: GEODE-2542 URL: https://issues.apache.org/jira/browse/GEODE-2542

[jira] [Updated] (GEODE-2542) LocatorDUnitTest and LocatorUDPSecurityDUnitTest fail frequently in Geode Nightly Build

2017-02-24 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2542: - Labels: Flaky (was: ) > LocatorDUnitTest and LocatorUDPSecurityDUnitTest fail frequently in Ge

[jira] [Updated] (GEODE-2541) NetstatDUnitTest fails with ClassCastException

2017-02-24 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2541: - Labels: MiscellaneousCommands NetstatCommand gfsh netstat (was: ) > NetstatDUnitTest fa

[jira] [Updated] (GEODE-2541) NetstatDUnitTest fails with ClassCastException

2017-02-24 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2541: - Description: This might be a bug in the error handling code for gfsh or the functions used

[jira] [Created] (GEODE-2541) NetstatDUnitTest fails with ClassCastException

2017-02-24 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2541: Summary: NetstatDUnitTest fails with ClassCastException Key: GEODE-2541 URL: https://issues.apache.org/jira/browse/GEODE-2541 Project: Geode Issue Type: Bug

Please blacklist asf91

2017-02-24 Thread Kirk Lund
UniversalMembershipListenerAdapterDUnitTest always fails on asf91 but the test is correct. It looks like asf91 has incorrect DNS configuration.

[jira] [Created] (GEODE-2539) Upgrading Jetty causes RestSecurityIntegrationTest to fail

2017-02-23 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2539: Summary: Upgrading Jetty causes RestSecurityIntegrationTest to fail Key: GEODE-2539 URL: https://issues.apache.org/jira/browse/GEODE-2539 Project: Geode Issue Type

[jira] [Updated] (GEODE-2461) Remove unnecessary explicit dependencies

2017-02-23 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2461: - Description: These unused entries are potential candidates for removal from gradle/dependency

[jira] [Updated] (GEODE-2461) Remove unnecessary explicit dependencies

2017-02-23 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2461: - Summary: Remove unnecessary explicit dependencies (was: Remove unnecessary entries from gradle

[jira] [Assigned] (GEODE-2461) Remove unnecessary entries from gradle/dependency-versions.properties

2017-02-23 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2461: Assignee: Kirk Lund > Remove unnecessary entries from gradle/dependency-versions.propert

[jira] [Updated] (GEODE-2461) Remove unnecessary entries from gradle/dependency-versions.properties

2017-02-23 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2461: - Description: These unused entries are potential candidates for removal from gradle/dependency

[jira] [Updated] (GEODE-2461) Remove unnecessary entries from gradle/dependency-versions.properties

2017-02-23 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2461: - Description: These unused entries are potential candidates for removal from gradle/dependency

[jira] [Updated] (GEODE-2461) Remove unnecessary entries from gradle/dependency-versions.properties

2017-02-23 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2461: - Description: These unused entries are potential candidates for removal from gradle/dependency

Re: Review Request 56991: GEODE-2416: Collect together artifacts from individual servers into a single zip file

2017-02-23 Thread Kirk Lund
ply, visit: > https://reviews.apache.org/r/56991/ > --- > > (Updated Feb. 23, 2017, 6:01 p.m.) > > > Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, and Kirk > Lund. > > > Repository: geode > > > Description > --- > > I am pu

Re: Review Request 56964: GEODE-2526: Enhance log statement in StatsArchiveReader

2017-02-23 Thread Kirk Lund
> On Feb. 23, 2017, 10:18 p.m., Kirk Lund wrote: > > +1 I know this change is good and would be safe commit it as is, however we > > have been trying to create UnitTests for any class that we touch that > > doesn't already have a UnitTest. As a whole, the project relies

Re: Review Request 56964: GEODE-2526: Enhance log statement in StatsArchiveReader

2017-02-23 Thread Kirk Lund
> On Feb. 23, 2017, 10:18 p.m., Kirk Lund wrote: > > +1 I know this change is good and would be safe commit it as is, however we > > have been trying to create UnitTests for any class that we touch that > > doesn't already have a UnitTest. As a whole, the project relies

Re: Review Request 56964: GEODE-2526: Enhance log statement in StatsArchiveReader

2017-02-23 Thread Kirk Lund
sing for resourceTypeId xxx, resourceName yyy") but that does tend to make for a more brittle test. - Kirk Lund On Feb. 23, 2017, 3:03 a.m., Srikanth Manvi wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 56991: GEODE-2416: Collect together artifacts from individual servers into a single zip file

2017-02-23 Thread Kirk Lund
e-web/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsOverHttpDunit.java (line 45) <https://reviews.apache.org/r/56991/#comment238581> Rename to ExportLogsOverHttpDunitTest - Kirk Lund On Feb. 23, 2017, 6:01 p.m., Jinmei Liao wrote: > > -

Re: Review Request 56934: GEODE-2460: update dependency versions

2017-02-22 Thread Kirk Lund
-web/src/main/webapp/META-INF/NOTICE a8caa6b6f4e29c63a6f322ee32c2322185e1dedf gradle/dependency-versions.properties 12a76b4f7ae46f94e85123945d5ffbcbad6bcb77 Diff: https://reviews.apache.org/r/56934/diff/ Testing --- precheckin passed 100% green Thanks, Kirk Lund

commons-beanutils in PR #403

2017-02-22 Thread Kirk Lund
I'm comparing Anthony's PR with my changes for GEODE-2460, and I'm trying to understand why we need to add the override for commons-beanutils to gradle/dependency-resolution.gradle. Without this, GEODE-2460 passes precheckin and uiTest. Is there some way to detect that commons-beanutils needs

[jira] [Resolved] (GEODE-2514) Need more tests for statistics archive rolling and removal

2017-02-22 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-2514. -- Resolution: Fixed Fix Version/s: 1.2.0 > Need more tests for statistics archive roll

Re: Review Request 56934: GEODE-2460: update dependency versions

2017-02-22 Thread Kirk Lund
PR in first? - Kirk --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56934/#review166406 --- On Feb. 22, 2017, 9:05

Review Request 56934: GEODE-2460: update dependency versions

2017-02-22 Thread Kirk Lund
/diff/ Testing --- precheckin passed 100% green Thanks, Kirk Lund

[jira] [Updated] (GEODE-2461) Remove unnecessary entries from gradle/dependency-versions.properties

2017-02-22 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2461: - Description: These unused entries are potential candidates for removal from gradle/dependency

Re: Review Request 56899: GEODE-2514: add new tests for statistics archive rolling and removal

2017-02-21 Thread Kirk Lund
passed (all green) Thanks, Kirk Lund

[jira] [Updated] (GEODE-2461) Remove unnecessary entries from gradle/dependency-versions.properties

2017-02-21 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2461: - Description: These are potential candidates for removal from explicit inclusion in gradle/dependency

[jira] [Updated] (GEODE-2461) Remove unnecessary entries from gradle/dependency-versions.properties

2017-02-21 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2461: - Description: These are potential candidates for removal from explicit inclusion in gradle/dependency

Review Request 56899: GEODE-2514: add new tests for statistics archive rolling and removal

2017-02-21 Thread Kirk Lund
geode-core/src/test/java/org/apache/geode/internal/statistics/StatArchiveHandlerIntegrationTest.java PRE-CREATION Diff: https://reviews.apache.org/r/56899/diff/ Testing --- precheckin in progress Thanks, Kirk Lund

[jira] [Assigned] (GEODE-2514) Need more tests for statistics archive rolling and removal

2017-02-21 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2514: Assignee: Kirk Lund > Need more tests for statistics archive rolling and remo

[jira] [Assigned] (GEODE-2267) Add gfsh command to export stat files

2017-02-21 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2267: Assignee: Kirk Lund > Add gfsh command to export stat fi

Re: Review Request 56801: GEODE-2457: Replace org.apache.geode.internal.FileUtil with org.apache.commons.io.FileUtils

2017-02-21 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56801/#review166223 --- Ship it! Ship It! - Kirk Lund On Feb. 17, 2017, 11:56 p.m

Re: Review Request 56803: GEODE-2142: Update GEODE-JSON module with compliant ORG.JSON implementation

2017-02-21 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56803/#review166222 --- Ship it! Ship It! - Kirk Lund On Feb. 21, 2017, 8:42 p.m

Re: for discussion: separate website into its own repo

2017-02-17 Thread Kirk Lund
+1 On Thu, Feb 16, 2017 at 4:45 PM, Joey McAllister wrote: > +1 to Karen's suggestion of moving the website to its own repo. > > +1 to Dan's suggestion scripting the website build/publishing with a CI > system based on commits. > > On Thu, Feb 16, 2017 at 4:38 PM Dan

Re: Create JUnit Rules instead of extending other test classes

2017-02-16 Thread Kirk Lund
It's possible this might be caused by a bug in Gradle's JUnit task which is how Jenkins is running this test. The test method is skipped as expected when run in IntelliJ. On Thu, Feb 16, 2017 at 2:17 PM, Kirk Lund <kl...@apache.org> wrote: > LocatorUDPSecurityDUnitTest extends Locator

Create JUnit Rules instead of extending other test classes

2017-02-16 Thread Kirk Lund
LocatorUDPSecurityDUnitTest extends LocatorDUnitTest. LocatorDUnitTest has a test named testSSLEnabledLocatorDiesWhenConnectingToNonSSLLocator which is currently annotated with @Ignore. Despite the test being marked with @Ignore, apparently the test still gets executed by

[jira] [Resolved] (GEODE-2474) netstat command fails to correctly identify OS and --with-lsof fails on Mac

2017-02-16 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-2474. -- Resolution: Fixed Fix Version/s: 1.2.0 > netstat command fails to correctly identify

[jira] [Updated] (GEODE-2496) MemberMBeanSecurityJUnitTest intermittently fails with rmi ConnectException: Connection refused (Connection refused)

2017-02-16 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2496: - Labels: Flaky JMX Security (was: ) > MemberMBeanSecurityJUnitTest intermittently fails with

[jira] [Updated] (GEODE-2496) MemberMBeanSecurityJUnitTest intermittently fails with rmi ConnectException: Connection refused (Connection refused)

2017-02-16 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2496: - Description: Two tests in MemberMBeanSecurityJUnitTest are failing intermittently: * testClusterAdmin

[jira] [Updated] (GEODE-2496) MemberMBeanSecurityJUnitTest intermittently fails with rmi ConnectException: Connection refused (Connection refused)

2017-02-16 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2496: - Description: Two tests in MemberMBeanSecurityJUnitTest are failing intermittently: * testClusterAdmin

[jira] [Created] (GEODE-2496) MemberMBeanSecurityJUnitTest intermittently fails with rmi ConnectException: Connection refused (Connection refused)

2017-02-16 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2496: Summary: MemberMBeanSecurityJUnitTest intermittently fails with rmi ConnectException: Connection refused (Connection refused) Key: GEODE-2496 URL: https://issues.apache.org/jira/browse

Re: Review Request 56735: GEODE-2481: extract default properties generation to its own class

2017-02-15 Thread Kirk Lund
/apache/geode/internal/GemFireVersionIntegrationJUnitTest.java cae331325f17b470e6dd786d0f9a52bba7cb42a6 Diff: https://reviews.apache.org/r/56735/diff/ Testing --- precheckin passed Thanks, Kirk Lund

Review Request 56735: GEODE-2481: extract default properties generation to its own class

2017-02-15 Thread Kirk Lund
d Thanks, Kirk Lund

Re: Review Request 56734: GEODE-2474: refactor code to use SystemUtils to read OS system props

2017-02-15 Thread Kirk Lund
ce to add a TODO for that. - Kirk --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56734/#review165787 --- On Feb. 16, 2017, 12:23 a.m.,

Review Request 56734: GEODE-2474: refactor code to use SystemUtils to read OS system props

2017-02-15 Thread Kirk Lund
48f176eabc18d3ffa56daaa7da12634a9554f39d Diff: https://reviews.apache.org/r/56734/diff/ Testing --- precheckin passed Thanks, Kirk Lund

Re: Review Request 56635: GEODE-2481: extract default properties generation to its own class

2017-02-15 Thread Kirk Lund
; > > > > The test does not compile for me as this import (`import static > > org.apache.geode.internal.lang.SystemUtils.getClassPath;`) does not > > resolve. It looks like `import static > > org.apache.bcel.util.ClassPath.getClassPath;` is the the right one. >

Re: Review Request 56635: GEODE-2481: extract default properties generation to its own class

2017-02-15 Thread Kirk Lund
eview and you'll see SystemUtils changes there. - Kirk --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56635/#review165551 -----

Re: Review Request 56633: GEODE-2474: refactor code to use SystemUtils to read OS system props

2017-02-15 Thread Kirk Lund
> On Feb. 14, 2017, 4:23 a.m., Kirk Lund wrote: > > geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/NetstatFunction.java, > > line 127 > > <https://reviews.apache.org/r/56633/diff/1/?file=1632709#file1632709line127> > > > >

[jira] [Commented] (GEODE-2125) GFSH cannot communicate with Locators that go into reconnect mode

2017-02-15 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868703#comment-15868703 ] Kirk Lund commented on GEODE-2125: -- Note: because the stop commands are asynchronously stopping Locator

[jira] [Updated] (GEODE-2125) GFSH cannot communicate with Locators that go into reconnect mode

2017-02-15 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2125: - Summary: GFSH cannot communicate with Locators that go into reconnect mode (was: GFSH cannot information

[jira] [Updated] (GEODE-2125) GFSH cannot information about Locators that go into reconnect mode

2017-02-15 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2125: - Summary: GFSH cannot information about Locators that go into reconnect mode (was: GFSH should provide

[jira] [Updated] (GEODE-2125) GFSH cannot information about Locators that go into reconnect mode

2017-02-15 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2125: - Issue Type: Bug (was: Improvement) > GFSH cannot information about Locators that go into reconnect m

Re: Gradle build for idea

2017-02-15 Thread Kirk Lund
I think this sort of error message would indicate that we have something wrong in our gradle files. So, yes we should be concerned and fix it. Unfortunately, I don't know how to fix it... On Tue, Feb 14, 2017 at 1:36 PM, Udo Kohlmeyer wrote: > Ok... just to clarify... I

[jira] [Updated] (GEODE-2488) Netstat command fails with OutOfMemoryError

2017-02-15 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2488: - Description: Note: this can occur outside of dunit tests as well. Just using the gfsh netstat command

[jira] [Updated] (GEODE-2488) Netstat command fails with OutOfMemoryError

2017-02-15 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2488: - Summary: Netstat command fails with OutOfMemoryError (was: NetstatDUnitTest fails with OutOfMemoryError

[jira] [Comment Edited] (GEODE-2488) NetstatDUnitTest fails with OutOfMemoryError

2017-02-15 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868317#comment-15868317 ] Kirk Lund edited comment on GEODE-2488 at 2/15/17 6:37 PM: --- NetstatFunction

[jira] [Commented] (GEODE-2488) NetstatDUnitTest fails with OutOfMemoryError

2017-02-15 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868317#comment-15868317 ] Kirk Lund commented on GEODE-2488: -- NetstatFunction reads in every line from the netstat output and lsof

[jira] [Updated] (GEODE-2488) NetstatDUnitTest fails with OutOfMemoryError

2017-02-15 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2488: - Labels: MiscellaneousCommands NetstatCommand netstat (was: ) > NetstatDUnitTest fa

[jira] [Updated] (GEODE-2488) NetstatDUnitTest fails with OutOfMemoryError

2017-02-15 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2488: - Component/s: management > NetstatDUnitTest fails with OutOfMemoryEr

[jira] [Created] (GEODE-2488) NetstatDUnitTest fails with OutOfMemoryError

2017-02-15 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2488: Summary: NetstatDUnitTest fails with OutOfMemoryError Key: GEODE-2488 URL: https://issues.apache.org/jira/browse/GEODE-2488 Project: Geode Issue Type: Bug

Re: Review Request 56633: GEODE-2474: refactor code to use SystemUtils to read OS system props

2017-02-15 Thread Kirk Lund
On Feb. 14, 2017, 4:33 p.m., Kirk Lund wrote: > > Everything else looks great. It happens from following TDD. I write the test first and then write the code. This is an example where the results of TDD produce a test with questionable value, but if the tests are ver

Re: Review Request 56633: GEODE-2474: refactor code to use SystemUtils to read OS system props

2017-02-13 Thread Kirk Lund
netstat -rs [-s] So two problems here: 1) it's broken on Mac, 2) we clearly don't have test coverage to verify that netstat command works or not. So we'll need to fix up NetstatDUnit and probaby add soem integration tests as well. - Kirk Lund On Feb. 14, 2017, 2:31 a.m.,

Re: New Committer And PMC Member: Jared Stewart

2017-02-13 Thread Kirk Lund
Welcome Jared! It's great to have you with us! On Mon, Feb 13, 2017 at 11:58 AM, Mark Bretl wrote: > The Apache Geode Project Management Committee has invited Jared Stewart to > be a committer on the project and join the Geode PMC. We are pleased to > announce he has accepted

[jira] [Updated] (GEODE-2482) gfsh intermittently repeats output and prompt

2017-02-13 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2482: - Affects Version/s: 1.1.0 1.0.0-incubating > gfsh intermittently repeats out

[jira] [Updated] (GEODE-2482) gfsh intermittently repeats output and prompt

2017-02-13 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2482: - Priority: Minor (was: Major) > gfsh intermittently repeats output and pro

[jira] [Created] (GEODE-2482) gfsh intermittently repeats output and prompt

2017-02-13 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2482: Summary: gfsh intermittently repeats output and prompt Key: GEODE-2482 URL: https://issues.apache.org/jira/browse/GEODE-2482 Project: Geode Issue Type: Bug

Re: Review Request 56635: GEODE-2481: extract default properties generation to its own class

2017-02-13 Thread Kirk Lund
/GemFireVersionIntegrationJUnitTest.java cae331325f17b470e6dd786d0f9a52bba7cb42a6 Diff: https://reviews.apache.org/r/56635/diff/ Testing --- DefaultPropertiesGeneratorIntegrationTest GemFireVersionJUnitTest Thanks, Kirk Lund

Re: Review Request 56633: GEODE-2474: refactor code to use SystemUtils to read OS system props

2017-02-13 Thread Kirk Lund
java 5fa30f47187972a209a781eae9024957dc80fb72 geode-core/src/test/java/org/apache/geode/internal/lang/SystemUtilsJUnitTest.java 48f176eabc18d3ffa56daaa7da12634a9554f39d Diff: https://reviews.apache.org/r/56633/diff/ Testing --- SystemUtilsJUnitTest NetstatDUnitTest Thanks, Kirk Lund

Re: Review Request 56633: GEODE-2474: refactor code to use SystemUtils to read OS system props

2017-02-13 Thread Kirk Lund
NetstatDUnitTest Thanks, Kirk Lund

Review Request 56635: GEODE-2481: extract default properties generation to its own class

2017-02-13 Thread Kirk Lund
: https://reviews.apache.org/r/56635/diff/ Testing --- DefaultPropertiesGeneratorIntegrationTest GemFireVersionJUnitTest Thanks, Kirk Lund

Review Request 56633: GEODE-2474: refactor code to use SystemUtils to read OS system props

2017-02-13 Thread Kirk Lund
5fa30f47187972a209a781eae9024957dc80fb72 geode-core/src/test/java/org/apache/geode/internal/lang/SystemUtilsJUnitTest.java 48f176eabc18d3ffa56daaa7da12634a9554f39d Diff: https://reviews.apache.org/r/56633/diff/ Testing --- SystemUtilsJUnitTest NetstatDUnitTest Thanks, Kirk Lund

[jira] [Assigned] (GEODE-2474) netstat command fails to correctly identify OS and --with-lsof fails on Mac

2017-02-13 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2474: Assignee: Kirk Lund > netstat command fails to correctly identify OS and --with-lsof fails on

[jira] [Created] (GEODE-2481) Refactor generation of default configuration properties

2017-02-13 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2481: Summary: Refactor generation of default configuration properties Key: GEODE-2481 URL: https://issues.apache.org/jira/browse/GEODE-2481 Project: Geode Issue Type

[jira] [Updated] (GEODE-2481) Refactor generation of default configuration properties

2017-02-13 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2481: - Component/s: build > Refactor generation of default configuration propert

[jira] [Assigned] (GEODE-2481) Refactor generation of default configuration properties

2017-02-13 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2481: Assignee: Kirk Lund > Refactor generation of default configuration propert

[jira] [Updated] (GEODE-2481) Refactor generation of default configuration properties

2017-02-13 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2481: - Component/s: configuration > Refactor generation of default configuration propert

[jira] [Updated] (GEODE-2474) netstat command fails to correctly identify OS and --with-lsof fails on Mac

2017-02-13 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2474: - Labels: MiscellaneousCommands NetstatCommand gfsh netstat (was: ) > netstat command fails to correc

[jira] [Updated] (GEODE-2474) netstat command fails to correctly identify OS and --with-lsof fails on Mac

2017-02-13 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2474: - Affects Version/s: 1.1.0 1.0.0-incubating > netstat command fails to correc

[jira] [Created] (GEODE-2474) netstat command fails to correctly identify OS and --with-lsof fails on Mac

2017-02-13 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2474: Summary: netstat command fails to correctly identify OS and --with-lsof fails on Mac Key: GEODE-2474 URL: https://issues.apache.org/jira/browse/GEODE-2474 Project: Geode

Re: Geode nightly build failures

2017-02-13 Thread Kirk Lund
on my Mac, but apparently NetstatFunction identifies my Mac as Windows and doesn't attempt to use lsof. I'll file a bug for this. I'll try to figure out why NetstatFunction seems to keep executing in a loop and file a bug for that as well. On Mon, Feb 13, 2017 at 9:31 AM, Kirk Lund <kl...@apac

Re: Geode nightly build failures

2017-02-13 Thread Kirk Lund
review is sent out. > > NetstatDUnitTest fails with OutofMemeoryError, probably the machine does > not have enough memory to run this test? > > On Mon, Feb 13, 2017 at 8:40 AM, Kirk Lund <kl...@apache.org> wrote: > > > Some tests still seem t

<    8   9   10   11   12   13   14   15   16   17   >