Re: Review Request 56586: GEODE-1716: refactor JMXMBeanDunitTest

2017-02-13 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56586/#review165355 --- Ship it! Ship It! - Kirk Lund On Feb. 13, 2017, 4:07 a.m

GEODE-2460: update dependency versions

2017-02-13 Thread Kirk Lund
I'm going to be pushing this change this morning: https://reviews.apache.org/r/56520/ After you pull and/or rebase any feature branches on this, you'll need to do a clean build and IDE refresh. GEODE-2460: update dependency versions Update the following dependency versions defined in

[jira] [Resolved] (GEODE-2431) Upgrade use of Awaitility from 1.7.0 to 2.0.0

2017-02-10 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-2431. -- Resolution: Fixed Fix Version/s: 1.2.0 > Upgrade use of Awaitility from 1.7.0 to 2.

[jira] [Updated] (GEODE-2460) Update dependency versions

2017-02-10 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2460: - Component/s: docs > Update dependency versions > -- > >

Re: Review Request 56520: GEODE-2460: update dependency versions

2017-02-10 Thread Kirk Lund
-versions.properties a0b291e55220e303b1608dbe5f3eb4cf3e510e4b Diff: https://reviews.apache.org/r/56520/diff/ Testing (updated) --- precheckin passed uiTest passed Thanks, Kirk Lund

Re: Review Request 56520: Update dependency versions

2017-02-10 Thread Kirk Lund
-site/website/content/docs/guide/10/managing/logging/configuring_log4j2.html b02422b104cfcea14a34522d35fcbe0e391d8db7 gradle/dependency-versions.properties a0b291e55220e303b1608dbe5f3eb4cf3e510e4b Diff: https://reviews.apache.org/r/56520/diff/ Testing --- precheckin passed Thanks, Kirk

Re: Review Request 56520: Update dependency versions

2017-02-10 Thread Kirk Lund
--- precheckin passed Thanks, Kirk Lund

Re: [VOTE] RC2: Apache Geode release - v1.1.0

2017-02-10 Thread Kirk Lund
Can we replace all of these hardcoded 1.0.0 and 1.0.0-incubating strings with a replacement token that is updated in the artifacts for a release? On Fri, Feb 10, 2017 at 2:46 PM, Karen Miller wrote: > +0 for me as well. I had also noted that the documentation has a couple

[jira] [Updated] (GEODE-2460) Update dependency versions

2017-02-10 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2460: - Description: Here's the first bunch of dependency version updates that passes precheckin without

Re: Review Request 56520: Update dependency versions

2017-02-10 Thread Kirk Lund
> On Feb. 10, 2017, 10:29 p.m., Kirk Lund wrote: > > gradle/dependency-versions.properties, line 111 > > <https://reviews.apache.org/r/56520/diff/1/?file=1629115#file1629115line111> > > > > This change also requires corresponding change to these files: &

Re: Review Request 56520: Update dependency versions

2017-02-10 Thread Kirk Lund
/http_session_mgmt/tc_setting_up_the_module.html * geode-site/website/content/docs/guide/10/tools_modules/http_session_mgmt/tomcat_setting_up_the_module.html - Kirk Lund On Feb. 10, 2017, 12:07 a.m., Kirk Lund wrote: > > --- > This is an aut

[jira] [Created] (GEODE-2461) Remove unnecessary entries from gradle/dependency-versions.properties

2017-02-10 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2461: Summary: Remove unnecessary entries from gradle/dependency-versions.properties Key: GEODE-2461 URL: https://issues.apache.org/jira/browse/GEODE-2461 Project: Geode

Re: Review Request 56520: Update dependency versions

2017-02-10 Thread Kirk Lund
rg.apache.regexp.RE; This is now fixed by: commit 6f35a027b5a044e7755faa70971c7d23aec6fab7 Author: Kirk Lund <kl...@apache.org> Date: Fri Feb 10 12:02:51 2017 -0800 GEODE-2460: remove unused imports to a

Geode develop updated to use Awaitility 2.0

2017-02-10 Thread Kirk Lund
As of last Friday, we are now using Awaitility 2.0 on develop. Here are some links and things that are new: Import from *org.awaitility.Awaitility *now instead of com.jayway.awaitility.Awaitility. See http://www.javadoc.io/doc/org.awaitility/awaitility/2.0.0 You can now use *atLeast*

[jira] [Resolved] (GEODE-2458) RegionManagementDUnitTest fails with AssertionError in verifyMemberNotifications

2017-02-10 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-2458. -- Resolution: Fixed Fix Version/s: 1.2.0 > RegionManagementDUnitTest fails with AssertionEr

[jira] [Resolved] (GEODE-2456) Distributed Transaction dunit tests are failing during tearDown

2017-02-10 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-2456. -- Resolution: Fixed Fix Version/s: 1.2.0 > Distributed Transaction dunit tests are failing dur

[jira] [Created] (GEODE-2460) Update dependency versions

2017-02-10 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2460: Summary: Update dependency versions Key: GEODE-2460 URL: https://issues.apache.org/jira/browse/GEODE-2460 Project: Geode Issue Type: Wish Components

[jira] [Reopened] (GEODE-2454) UniversalMembershipListenerAdapterDUnitTest test fails on jenkins

2017-02-10 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reopened GEODE-2454: -- > UniversalMembershipListenerAdapterDUnitTest test fails on jenk

[jira] [Resolved] (GEODE-2454) UniversalMembershipListenerAdapterDUnitTest test fails on jenkins

2017-02-10 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-2454. -- Resolution: Fixed > UniversalMembershipListenerAdapterDUnitTest test fails on jenk

[jira] [Resolved] (GEODE-2454) UniversalMembershipListenerAdapterDUnitTest test fails on jenkins

2017-02-10 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-2454. -- Resolution: Fixed Fix Version/s: 1.2.0 > UniversalMembershipListenerAdapterDUnitTest test fa

Review Request 56556: GEODE-2454: use DistributedMember.getId() for memberId assertions

2017-02-10 Thread Kirk Lund
deleted old comments from the code. Diffs - geode-core/src/test/java/org/apache/geode/management/UniversalMembershipListenerAdapterDUnitTest.java e0d3d8b Diff: https://reviews.apache.org/r/56556/diff/ Testing --- UniversalMembershipListenerAdapterDUnitTest Thanks, Kirk Lund

[jira] [Commented] (GEODE-2454) UniversalMembershipListenerAdapterDUnitTest test fails on jenkins

2017-02-10 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861718#comment-15861718 ] Kirk Lund commented on GEODE-2454: -- This test is failing because the assertion is incorrect. It asserts

[jira] [Updated] (GEODE-2454) UniversalMembershipListenerAdapterDUnitTest test fails on jenkins

2017-02-10 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2454: - Component/s: tests > UniversalMembershipListenerAdapterDUnitTest test fails on jenk

[jira] [Assigned] (GEODE-2454) UniversalMembershipListenerAdapterDUnitTest test fails on jenkins

2017-02-10 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2454: Assignee: Kirk Lund > UniversalMembershipListenerAdapterDUnitTest test fails on jenk

Re: Review Request 56522: GEODE-2198: do not import cluster config if any region exists to prevent different servers having conflicing region definitions at one point of time.

2017-02-09 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56522/#review165046 --- Ship it! Ship It! - Kirk Lund On Feb. 10, 2017, 12:57 a.m

Re: Review Request 56520: Update dependency versions

2017-02-09 Thread Kirk Lund
those eventually. - Kirk --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56520/#review165029 --- On Feb. 10, 2017,

Review Request 56520: Update dependency versions

2017-02-09 Thread Kirk Lund
in review or direct message. Diffs - gradle/dependency-versions.properties a0b291e Diff: https://reviews.apache.org/r/56520/diff/ Testing --- precheckin passed Thanks, Kirk Lund

BaseLineAndCompareQueryPerfJUnitTest failure

2017-02-09 Thread Kirk Lund
I just had a precheckin fail in BaseLineAndCompareQueryPerfJUnitTest. I'm not sure a junit test is really a good place for perf testing like this. Between JVM optimizing at runtime and possibility for machine CPU pollution, I'm surprised we haven't seen this fail before. Just wanted to mention

Fixing AcceptorImplDUnitTest

2017-02-09 Thread Kirk Lund
I'm committing a fix for AcceptorImplDUnitTest. Looks like a recent commit missed the upgrade to Awaitility 2.0. Easy fix.

Re: WaitUntilParallelGatewaySenderFlushedCoordinatorJUnitTest

2017-02-09 Thread Kirk Lund
Date: Wed Feb 8 23:02:51 2017 -0800 > > > > GEODE-2400: The > > WaitUntilParallelGatewaySenderFlushedCoordinatorJUnitTest should return > > false for local callable > > in negative case since there's no more remote message. > > > > -Dan > >

[jira] [Updated] (GEODE-2458) RegionManagementDUnitTest fails with AssertionError in verifyMemberNotifications

2017-02-09 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2458: - Description: This appears to be a race condition. The assertion finds 5 members when 6 is expected

[jira] [Updated] (GEODE-2458) RegionManagementDUnitTest fails with AssertionError in verifyMemberNotifications

2017-02-09 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2458: - Description: This appears to be a race condition. The assertion finds 5 members when 6 is expected

[jira] [Updated] (GEODE-2458) RegionManagementDUnitTest fails with AssertionError in verifyMemberNotifications

2017-02-09 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2458: - Summary: RegionManagementDUnitTest fails with AssertionError in verifyMemberNotifications

Re: Review Request 56519: GEODE-2458: await expected JMX notifications in verifyMemberNotifications

2017-02-09 Thread Kirk Lund
a 7ff5f02 Diff: https://reviews.apache.org/r/56519/diff/ Testing --- RegionManagementDUnitTest full precheckin in progress Thanks, Kirk Lund

Review Request 56519: GEODE-2458: await expected JMX notifications in verifyMemberNotifications

2017-02-09 Thread Kirk Lund
: https://reviews.apache.org/r/56519/diff/ Testing --- RegionManagementDUnitTest full precheckin in progress Thanks, Kirk Lund

[jira] [Created] (GEODE-2458) RegionManagementDUnitTest.testFixedPRRegionMBean fails with AssertionError in verifyMemberNotifications

2017-02-09 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2458: Summary: RegionManagementDUnitTest.testFixedPRRegionMBean fails with AssertionError in verifyMemberNotifications Key: GEODE-2458 URL: https://issues.apache.org/jira/browse/GEODE-2458

[jira] [Updated] (GEODE-2458) RegionManagementDUnitTest.testFixedPRRegionMBean fails with AssertionError in verifyMemberNotifications

2017-02-09 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2458: - Labels: Flaky (was: ) > RegionManagementDUnitTest.testFixedPRRegionMBean fails with AssertionEr

WaitUntilParallelGatewaySenderFlushedCoordinatorJUnitTest

2017-02-09 Thread Kirk Lund
Does anyone want to look into this geode nightly build failure involving WaitUntilParallelGatewaySenderFlushedCoordinatorJUnitTest? java.lang.AssertionError at org.junit.Assert.fail(Assert.java:86) at org.junit.Assert.assertTrue(Assert.java:41) at org.junit.Assert.assertFalse(Assert.java:64) at

Nightly geode failure due to DNS

2017-02-09 Thread Kirk Lund
Any opinions on this failure? I'm not sure if we should change the test, change our use of host name lookup or blacklist asf91 from our nightly build. org.apache.geode.management.UniversalMembershipListenerAdapterDUnitTest.testSystemClientEventsInServer org.junit.ComparisonFailure:

Re: Review Request 56459: GEODE-2247: GFSH connect over HTTP without credentials should fail earlier

2017-02-09 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56459/#review165019 --- Ship it! Ship It! - Kirk Lund On Feb. 9, 2017, 8:50 p.m

Re: Removal of distributed transaction tests

2017-02-09 Thread Kirk Lund
My reasoning is simple: Apache Geode does not currently have a distributed transactions feature. On Thu, Feb 9, 2017 at 12:03 PM, Dan Smith <dsm...@pivotal.io> wrote: > What's wrong with these tests? Are you saying there is coverage elsewhere? > > -Dan > > On Thu, Feb 9, 2

[jira] [Created] (GEODE-2457) Replace org.apache.geode.internal.FileUtil with org.apache.commons.io.FileUtils

2017-02-09 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2457: Summary: Replace org.apache.geode.internal.FileUtil with org.apache.commons.io.FileUtils Key: GEODE-2457 URL: https://issues.apache.org/jira/browse/GEODE-2457 Project: Geode

Review Request 56516: GEODE-2456: change JUnit4CacheTestCase tearDown to use deleteQuietly

2017-02-09 Thread Kirk Lund
DistTXPersistentDebugDUnitTest DistTXRestrictionsDUnitTest DistTXWithDeltaDUnitTest DistributedTransactionDUnitTest PRDistTXDUnitTest PRDistTXWithVersionsDUnitTest full precheckin in progress Thanks, Kirk Lund

Removal of distributed transaction tests

2017-02-09 Thread Kirk Lund
Do we really want our nightly build and precheckin runs to waste time running these tests? DistributedTransactionDUnitTest DistTXDebugDUnitTest DistTXOrderDUnitTest DistTXPersistentDebugDUnitTest DistTXRestrictionsDUnitTest DistTXWithDeltaDUnitTest DistributedTransactionDUnitTest

[jira] [Resolved] (GEODE-2455) DescribeDiskStoreFunctionJUnitTest will still pass when wrong line throws expected exception

2017-02-09 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-2455. -- Resolution: Fixed Fix Version/s: 1.2.0 > DescribeDiskStoreFunctionJUnitTest will still pass w

Re: Review Request 56514: GEODE-2455: change test to use AssertJ assertThatThrownBy

2017-02-09 Thread Kirk Lund
/test/java/org/apache/geode/management/internal/cli/functions/DescribeDiskStoreFunctionJUnitTest.java 469fab8 Diff: https://reviews.apache.org/r/56514/diff/ Testing --- DescribeDiskStoreFunctionJUnitTest Thanks, Kirk Lund

Review Request 56514: GEODE-2455: change test to use AssertJ assertThatThrownBy

2017-02-09 Thread Kirk Lund
469fab8 Diff: https://reviews.apache.org/r/56514/diff/ Testing --- DescribeDiskStoreFunctionJUnitTest Thanks, Kirk Lund

[jira] [Created] (GEODE-2456) Distributed Transaction dunit tests are failing during tearDown

2017-02-09 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2456: Summary: Distributed Transaction dunit tests are failing during tearDown Key: GEODE-2456 URL: https://issues.apache.org/jira/browse/GEODE-2456 Project: Geode Issue

[jira] [Assigned] (GEODE-2456) Distributed Transaction dunit tests are failing during tearDown

2017-02-09 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2456: Assignee: Kirk Lund > Distributed Transaction dunit tests are failing during tearD

[jira] [Created] (GEODE-2455) DescribeDiskStoreFunctionJUnitTest will still pass when wrong line throws expected exception

2017-02-09 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2455: Summary: DescribeDiskStoreFunctionJUnitTest will still pass when wrong line throws expected exception Key: GEODE-2455 URL: https://issues.apache.org/jira/browse/GEODE-2455

[jira] [Assigned] (GEODE-2455) DescribeDiskStoreFunctionJUnitTest will still pass when wrong line throws expected exception

2017-02-09 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2455: Assignee: Kirk Lund > DescribeDiskStoreFunctionJUnitTest will still pass when wrong line thr

Re: Nightly geode build still failing due to dist tx tests

2017-02-09 Thread Kirk Lund
eache file one-by-one and is failing to find a > file. It's in JUnit4CacheTestCase tear-down code, not code specific to > distributed transactions. > > > Le 2/9/2017 à 10:53 AM, Kirk Lund a écrit : > >> The nightly build continues to fail with many dist tx test failures &

Re: Nightly geode build still failing due to dist tx tests

2017-02-09 Thread Kirk Lund
h()); > } > > > On Thu, Feb 9, 2017 at 1:08 PM, Kirk Lund <kl...@pivotal.io> wrote: > > > Here's the source of the exceptions in JUnit4CacheTestCase: > > > > public static final void cleanDiskDirs() throws IOException { > > FileU

Re: Nightly geode build still failing due to dist tx tests

2017-02-09 Thread Kirk Lund
. public static void delete(File file) throws IOException { if (!file.exists()) return; if (file.isDirectory()) { for (File child : listFiles(file)) { delete(child); } } Files.delete(file.toPath()); } On Thu, Feb 9, 2017 at 11:08 AM, Kirk Lund <

Nightly geode build still failing due to dist tx tests

2017-02-09 Thread Kirk Lund
The nightly build continues to fail with many dist tx test failures involving cleanup of diskstores. Should we delete the dist tx tests since we don't have dist tx in geode yet? https://builds.apache.org/job/Geode-nightly/743/ [error 2017/02/09 11:20:30.602 UTC tid=0x600] Error cleaning disk

Re: Review Request 56425: GEODE-2272: do not use a new method to start locator with pulse

2017-02-08 Thread Kirk Lund
t know what the correct approach is but I think this is wrong. - Kirk Lund On Feb. 8, 2017, 3:03 a.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 56396: Refactor test rules

2017-02-07 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56396/#review164597 --- Ship it! - Kirk Lund On Feb. 7, 2017, 5:28 p.m., Jinmei Liao

[jira] [Commented] (GEODE-1930) JMX DistributedTests are in need of overhauling

2017-02-07 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856984#comment-15856984 ] Kirk Lund commented on GEODE-1930: -- Overhauling RegionManagementDUnitTest is incomplete and still needs

[jira] [Resolved] (GEODE-173) DLockManagementDUnitTest.testDLockMBean fails intermittently with suspect string

2017-02-07 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-173. - Resolution: Fixed Fix Version/s: 1.2.0 > DLockManagementDUnitTest.testDLockMBean fa

[jira] [Resolved] (GEODE-553) DLockManagementDUnitTest.testDLockAggregate failed

2017-02-07 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-553. - Resolution: Fixed Fix Version/s: 1.2.0 > DLockManagementDUnitTest.testDLockAggregate fai

[jira] [Assigned] (GEODE-553) DLockManagementDUnitTest.testDLockAggregate failed

2017-02-07 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-553: --- Assignee: Kirk Lund > DLockManagementDUnitTest.testDLockAggregate fai

Re: Nightly build broken

2017-02-07 Thread Kirk Lund
) On Tue, Feb 7, 2017 at 12:55 PM, Udo Kohlmeyer <ukohlme...@pivotal.io> wrote: > Looking at some of the failures, it seems it is complaining about not > finding diskstores to delete. > > > > On 2/7/17 12:53, Kirk Lund wrote: > >> Last night's nightly build is pretty

Nightly build broken

2017-02-07 Thread Kirk Lund
Last night's nightly build is pretty horrible. 121 dunit test failures. Cluster config accounts for 13 of them and we already have a fix for those 13 only. Anyone else want to look into the other failures? Looks like some of the other failures are diskstore related.

Re: [VOTE] RC1: Apache Geode release - v1.1.0

2017-02-06 Thread Kirk Lund
These .zip and .jar files are now removed on develop. These two commits should be merged if we want this fix on the release branch: commit e769796c5611f4fad1a21869ddea29853ed1958e Author: Jared Stewart Date: Mon Feb 6 14:54:49 2017 -0800 GEODE-2430: Remove jar and zip

Re: geode-old-versions subproject?

2017-02-06 Thread Kirk Lund
For me, the "--tests" option seems to only work with the "test" task (not "integrationTest" or "distributedTest" which I've brought up before). Are you sure the BC tests aren't run during the "precheckin" task despite not running with the "--tests" option? On Mon, Feb 6, 2017 at 11:12 AM, Dan

Re: Review Request 56332: GEODE-2431: Upgrade use of Awaitility from 1.7.0 to 2.0.0

2017-02-06 Thread Kirk Lund
. 6, 2017, 6:18 p.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56332/ > --- >

Re: Review Request 56332: GEODE-2431: Upgrade use of Awaitility from 1.7.0 to 2.0.0

2017-02-06 Thread Kirk Lund
) --- precheckin passed except for Flaky tests: LocatorDUnitTest, LocatorUDPSecurityDUnitTest, LuceneQueriesPeerPRRedundancyDUnitTest (all 3 of these pass when rerun) Thanks, Kirk Lund

Review Request 56332: GEODE-2431: Upgrade use of Awaitility from 1.7.0 to 2.0.0

2017-02-06 Thread Kirk Lund
40fa962379af319f0d17c4b2ca47805857a88da1 Diff: https://reviews.apache.org/r/56332/diff/ Testing --- precheckin passed except for Flaky tests: LocatorDUnitTest, LocatorUDPSecurityDUnitTest, LuceneQueriesPeerPRRedundancyDUnitTest Thanks, Kirk Lund

[jira] [Assigned] (GEODE-2431) Upgrade use of Awaitility from 1.7.0 to 2.0.0

2017-02-06 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2431: Assignee: Kirk Lund > Upgrade use of Awaitility from 1.7.0 to 2.

[jira] [Updated] (GEODE-2431) Upgrade use of Awaitility from 1.7.0 to 2.0.0

2017-02-06 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2431: - Issue Type: Test (was: Bug) > Upgrade use of Awaitility from 1.7.0 to 2.

[jira] [Created] (GEODE-2431) Upgrade use of Awaitility from 1.7.0 to 2.0.0

2017-02-06 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2431: Summary: Upgrade use of Awaitility from 1.7.0 to 2.0.0 Key: GEODE-2431 URL: https://issues.apache.org/jira/browse/GEODE-2431 Project: Geode Issue Type: Bug

Re: Apache policy on files types allowed in source code

2017-02-06 Thread Kirk Lund
on list if anyone has issues with what's in geode src code. Thanks, Kirk On Wed, Nov 2, 2016 at 1:46 PM, Kirk Lund <kl...@apache.org> wrote: > I do have a particular case in mind involving stats files that geode > creates and reads. The StatArchiveWriter.java class writes o

Fwd: Build failed in Jenkins: Geode-nightly #738

2017-02-06 Thread Kirk Lund
Can someone please do one of the following (I don't have build job permissions)? a) disable FlakyTest in the nightly build or b) add FlakyTest results to the test results Also, I think we need to either fix testSSLEnabledLocatorDiesWhenConnectingToNonSSLLocator or disable it. It's failing

Re: JMXMBeanDUnitTest and SSL properties

2017-02-03 Thread Kirk Lund
PS: the test is using DistributedRestoreSystemProperties as a JUnit Rule, so it's saving and restoring all System properties before and after every test. This gives each test a clean slate for System properties. On Fri, Feb 3, 2017 at 1:41 PM, Kirk Lund <kl...@pivotal.io>

Re: Unable to build from 'develop' branch

2017-02-03 Thread Kirk Lund
[moved to dev] The AsyncInvocation lambdas in MultiUserDUnitTest.testMultiUser do appear to be ambiguous to me even if the later releases of JDK 1.8.0 no longer detects it as ambiguous. The 1st AsyncInvocation ends up invoking "public AsyncInvocation invokeAsync(final name, final

[jira] [Updated] (GEODE-2427) JMXMBeanDUnitTest.testJMXOverLegacySSL cannot run with the other tests

2017-02-03 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2427: - Description: JMXMBeanDUnitTest.testJMXOverLegacySSL is currently marked as a FlakyTest. If you run

Re: Review Request 56242: GEODE-2206: Add junit-quickcheck to geode-core; add a test that uses it.

2017-02-02 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56242/#review164041 --- Ship it! Ship It! - Kirk Lund On Feb. 2, 2017, 9:35 p.m

Re: Review Request 56243: GEODE-2386 Don't call System.setProperties(null) when rule is used twice

2017-02-02 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56243/#review164028 --- Ship it! Ship It! - Kirk Lund On Feb. 2, 2017, 9:38 p.m

GEODE-2413

2017-02-02 Thread Kirk Lund
Can you please add a Description? It's hard to figure out what this ticket is actually about. Thanks, Kirk

buildSrc recompiles anytime I run a dunit test

2017-01-30 Thread Kirk Lund
Right after I do a clean build, if I then execute a single dunit test via gradle, buildSrc recompiles again. Is this intentional? Is there a way to configure our build to not recompile it again? BUILD SUCCESSFUL Total time: 4 mins 34.685 secs /Users/klund/dev/geode_CLEAN

Review Request 56106: GEODE-2395: add FlakyCategory to intermittently failing test

2017-01-30 Thread Kirk Lund
org/apache/geode/tools/pulse/PulseDataExportTest.java 679f486fc2729643080199da7acce3b60680d88c Diff: https://reviews.apache.org/r/56106/diff/ Testing --- PulseDataExportTest Thanks, Kirk Lund

Re: Review Request 56099: GEODE-2250: gfsh -e connect will throw java.lang.StackOverflowError rather than prompt for username/password

2017-01-30 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56099/#review163600 --- Ship it! Ship It! - Kirk Lund On Jan. 30, 2017, 11:24 p.m

Re: Review Request 56099: GEODE-2250: gfsh -e connect will throw java.lang.StackOverflowError rather than prompt for username/password

2017-01-30 Thread Kirk Lund
/cli/commands/ShellCommands.java (line 375) <https://reviews.apache.org/r/56099/#comment235059> What if just one of them is null? Do we want to do this "if (userName == null || passwordToUse == null)" instead? - Kirk Lund On Jan. 30, 2017, 11:24 p.m., Ke

Re: Build failed in Jenkins: Geode-release #39

2017-01-30 Thread Kirk Lund
Seems to always be from line 220: Caused by: java.lang.RuntimeException: VMs did not start up within 120 seconds at org.apache.geode.test.dunit.standalone.DUnitLauncher.launch(DUnitLauncher.java:220) at org.apache.geode.test.dunit.standalone.DUnitLauncher.launchIfNeeded(DUnitLauncher.java:142)

Review Request 56091: GEODE-1276: change to IntegrationTest and use caught exceptions

2017-01-30 Thread Kirk Lund
9392838fe6b415a9e721324a4b9d7306b6dabb6c Diff: https://reviews.apache.org/r/56091/diff/ Testing --- JarDeployerIntegrationTest Thanks, Kirk Lund

[jira] [Updated] (GEODE-2380) Replace use of geode-json with Jackson

2017-01-27 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2380: - Summary: Replace use of geode-json with Jackson (was: Replace GFSH use of geode-json with Jackson

[jira] [Updated] (GEODE-2380) Replace use of geode-json with Jackson

2017-01-27 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2380: - Component/s: rest (dev) rest (admin) pulse > Replace use of geode-j

[jira] [Issue Comment Deleted] (GEODE-488) OffHeapMemoryMonitor deliverNextAbnormalEvent logic needs review

2017-01-27 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-488: Comment: was deleted (was: A Pivotal Tracker story has been created for this Issue: https

[jira] [Issue Comment Deleted] (GEODE-1975) CI Failure: SecurityClusterConfigDUnitTest.serverWithDifferentSecurityManagerShouldThrowException

2017-01-27 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-1975: - Comment: was deleted (was: A Pivotal Tracker story has been created for this Issue: https

[jira] [Issue Comment Deleted] (GEODE-2079) CI failure: ConnectToLocatorSSLDUnitTest.testConnectToLocatorWithLegacyJMXSSL

2017-01-27 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2079: - Comment: was deleted (was: A Pivotal Tracker story has been created for this Issue: https

[jira] [Issue Comment Deleted] (GEODE-17) Provide Integrated Security

2017-01-27 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-17?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-17: --- Comment: was deleted (was: David Barnes deleted the linked story in Pivotal Tracker) > Provide Integra

[jira] [Issue Comment Deleted] (GEODE-16) Provide distributed transactions in Geode

2017-01-27 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-16: --- Comment: was deleted (was: A Pivotal Tracker story has been created for this Issue: https

[jira] [Issue Comment Deleted] (GEODE-508) Remove older gfsh (v1) code

2017-01-27 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-508: Comment: was deleted (was: A Pivotal Tracker story has been created for this Issue: https

[jira] [Issue Comment Deleted] (GEODE-17) Provide Integrated Security

2017-01-27 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-17?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-17: --- Comment: was deleted (was: A Pivotal Tracker story has been created for this Issue: https

[jira] [Issue Comment Deleted] (GEODE-903) Update copyright year in website footer

2017-01-27 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-903: Comment: was deleted (was: A Pivotal Tracker story has been created for this Issue: https

[jira] [Issue Comment Deleted] (GEODE-968) Stat Need stats to know the time spent by receiver-thread to deliver udp message

2017-01-27 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-968: Comment: was deleted (was: A Pivotal Tracker story has been created for this Issue: https

[jira] [Issue Comment Deleted] (GEODE-2204) CI Failure: PDXPostProcessorDUnitTest.testRegisterInterest

2017-01-27 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2204: - Comment: was deleted (was: A Pivotal Tracker story has been created for this Issue: https

[jira] [Issue Comment Deleted] (GEODE-2126) CI failure: MiscellaneousCommandsDUnitTest.testShowLogNumLines

2017-01-27 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2126: - Comment: was deleted (was: A Pivotal Tracker story has been created for this Issue: https

[jira] [Issue Comment Deleted] (GEODE-2102) CI Failure: DiskStoreCommandsDUnitTest.testMissingDiskStore fails assertion

2017-01-27 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2102: - Comment: was deleted (was: A Pivotal Tracker story has been created for this Issue: https

[jira] [Issue Comment Deleted] (GEODE-2009) CI Failure: CreateAlterDestroyRegionCommandsDUnitTest.testCreateAlterDestroyUpdatesSharedConfig

2017-01-27 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2009: - Comment: was deleted (was: A Pivotal Tracker story has been created for this Issue: https

<    9   10   11   12   13   14   15   16   17   18   >