[GitHub] geode pull request #398: Split the redis adapter into its own package

2017-02-16 Thread galen-pivotal
Github user galen-pivotal closed the pull request at: https://github.com/apache/geode/pull/398 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode pull request #398: Split the redis adapter into its own package

2017-02-15 Thread galen-pivotal
Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/398#discussion_r101401136 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java --- @@ -1330,21 +1360,12 @@ private void

[GitHub] geode pull request #398: Split the redis adapter into its own package

2017-02-15 Thread metatype
Github user metatype commented on a diff in the pull request: https://github.com/apache/geode/pull/398#discussion_r101391406 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java --- @@ -1330,21 +1360,12 @@ private void startMemcachedServer() {

[GitHub] geode pull request #398: Split the redis adapter into its own package

2017-02-15 Thread galen-pivotal
Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/398#discussion_r101388974 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java --- @@ -1330,21 +1360,12 @@ private void

[GitHub] geode pull request #398: Split the redis adapter into its own package

2017-02-15 Thread galen-pivotal
Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/398#discussion_r101388584 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java --- @@ -1330,21 +1360,12 @@ private void

[GitHub] geode pull request #398: Split the redis adapter into its own package

2017-02-15 Thread metatype
Github user metatype commented on a diff in the pull request: https://github.com/apache/geode/pull/398#discussion_r101375546 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java --- @@ -1330,21 +1360,12 @@ private void startMemcachedServer() {

[GitHub] geode pull request #398: Split the redis adapter into its own package

2017-02-15 Thread galen-pivotal
Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/398#discussion_r101374277 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java --- @@ -1330,21 +1360,12 @@ private void

[GitHub] geode pull request #398: Split the redis adapter into its own package

2017-02-15 Thread galen-pivotal
Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/398#discussion_r101354076 --- Diff: geode-redis/src/test/java/org/apache/geode/redis/AuthJUnitTest.java --- @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software

[GitHub] geode pull request #398: Split the redis adapter into its own package

2017-02-15 Thread galen-pivotal
Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/398#discussion_r101353985 --- Diff: geode-redis/src/test/java/org/apache/geode/redis/AuthJUnitTest.java --- @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software

[GitHub] geode pull request #398: Split the redis adapter into its own package

2017-02-15 Thread galen-pivotal
Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/398#discussion_r101354013 --- Diff: geode-core/src/main/java/org/apache/geode/redis/GeodeRedisService.java --- @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software

[GitHub] geode pull request #398: Split the redis adapter into its own package

2017-02-15 Thread scmbuildguy
Github user scmbuildguy commented on a diff in the pull request: https://github.com/apache/geode/pull/398#discussion_r101351743 --- Diff: geode-redis/src/test/java/org/apache/geode/redis/AuthJUnitTest.java --- @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software

[GitHub] geode pull request #398: Split the redis adapter into its own package

2017-02-15 Thread galen-pivotal
GitHub user galen-pivotal opened a pull request: https://github.com/apache/geode/pull/398 Split the redis adapter into its own package Under this PR, the redis adapter is moved to its own source root, and registered as a service. We're intending to make this a feature