[GitHub] geode pull request #687: GEODE-3258: Refactoring DiskStoreCommands

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/687 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #687: GEODE-3258: Refactoring DiskStoreCommands

Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/687#discussion_r131787338 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ValidateDiskStoreCommand.java --- @@ -0,0 +1,107 @@ +/* + *

[GitHub] geode pull request #687: GEODE-3258: Refactoring DiskStoreCommands

Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/687#discussion_r131787137 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ValidateDiskStoreCommand.java --- @@ -0,0 +1,107 @@ +/* + *

[GitHub] geode pull request #687: GEODE-3258: Refactoring DiskStoreCommands

Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/687#discussion_r131787085 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/UpgradeOfflineDiskStoreCommand.java --- @@ -0,0 +1,179 @@ +/*

[GitHub] geode pull request #687: GEODE-3258: Refactoring DiskStoreCommands

Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/687#discussion_r131783193 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CompactOfflineDiskStoreCommand.java --- @@ -0,0 +1,178 @@ +/*

[GitHub] geode pull request #687: GEODE-3258: Refactoring DiskStoreCommands

Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/687#discussion_r131783008 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CompactDiskStoreCommand.java --- @@ -0,0 +1,185 @@ +/* + *

[GitHub] geode pull request #687: GEODE-3258: Refactoring DiskStoreCommands

Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/687#discussion_r131782938 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CompactOfflineDiskStoreCommand.java --- @@ -0,0 +1,178 @@ +/*

[GitHub] geode pull request #687: GEODE-3258: Refactoring DiskStoreCommands

Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/687#discussion_r131777554 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CompactDiskStoreCommand.java --- @@ -0,0 +1,185 @@ +/* + *

[GitHub] geode pull request #687: GEODE-3258: Refactoring DiskStoreCommands

Github user YehEmily closed the pull request at: https://github.com/apache/geode/pull/687 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #687: GEODE-3258: Refactoring DiskStoreCommands

GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/687 GEODE-3258: Refactoring DiskStoreCommands [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3258) `DiskStoreCommands` was a huge class that contained a large number