Hi @Xiaojian, it's unclear what your -1 refers to. This VOTE has already
closed. Perhaps you were just expressing content for keeping geode-examples a
separate repo?
When you checkout geode-examples, your first stop will likely be the README,
which describes how to select the desired version
-1
I often need to build geode-examples on older geode version (more frequent than
current version).
One more irrelevant comments: we do need to enhance our geode-examples. The
current examples are too weak.
On 7/30/20, 8:16 AM, "Blake Bender" wrote:
FWIW, Geode Native works around th
FWIW, Geode Native works around this by not keeping a separate examples repo at
all. To build our examples, you *must* build your own Geode Native
"installation," which includes the examples tree, or download the desired
tarball/zip file from our GitHub releases.
I’m pretty much agnostic as to
Voting Results:
+1: 5 votes
0: 0 votes
-1: 1 vote
The voting is successful by majority vote. INFRA has completed the requested
change and git clone g...@github.com:apache/geode-examples.git now checks out
develop, making geode-examples consistent with all other geode- projects, and
clearing
-1. Happy to change my mind if there’s a user-friendly way to deal with the
scenario I mentioned below.
Anthony
On Jul 14, 2020, at 8:40 AM, Owen Nichols
mailto:onich...@vmware.com>> wrote:
Hi Anthony, there is a separate discuss thread [1] for this topic. This is the
vote thread for the A
Hi Anthony, there is a separate discuss thread [1] for this topic. This is the
vote thread for the ASF INFRA ticket [2] to make this one specific change that
came out of the discussion. Your input is valuable and I encourage you to both
vote on this thread and continue the conversation on the
+1
On Fri, 10 Jul 2020 at 15:52, Alberto Bustamante Reyes
wrote:
> +1
>
> De: Joris Melchior
> Enviado: viernes, 10 de julio de 2020 15:54
> Para: dev@geode.apache.org
> Asunto: Re: [VOTE] change Default branch for geode-examples to '
Consider the use case of an application developer who wants to run
geode-examples against the latest geode release:
1) brew install apache-geode
2) git clone geode-examples
3) Get some runtime errors because geode-examples won’t connect to a previous
geode release
At this point, you have to do
+1
De: Joris Melchior
Enviado: viernes, 10 de julio de 2020 15:54
Para: dev@geode.apache.org
Asunto: Re: [VOTE] change Default branch for geode-examples to 'develop'
+1
On 2020-07-10, 12:39 AM, "Owen Nichols" wrote:
A fresh checkout
+1
On 2020-07-10, 12:39 AM, "Owen Nichols" wrote:
A fresh checkout of geode and all but one geode- repos
checks out develop as the Default branch.
The lone exception is geode-examples. Please vote +1 if you are in favor
of changing its Default branch to develop for consistency with
+1
> On Jul 9, 2020, at 10:04 PM, Dick Cavender wrote:
>
> +1
>
> -Original Message-
> From: Owen Nichols
> Sent: Thursday, July 9, 2020 9:39 PM
> To: dev@geode.apache.org
> Subject: [VOTE] change Default branch for geode-examples to 'develop'
&
+1
-Original Message-
From: Owen Nichols
Sent: Thursday, July 9, 2020 9:39 PM
To: dev@geode.apache.org
Subject: [VOTE] change Default branch for geode-examples to 'develop'
A fresh checkout of geode and all but one geode- repos checks
out develop as the Default branch.
A fresh checkout of geode and all but one geode- repos checks
out develop as the Default branch.
The lone exception is geode-examples. Please vote +1 if you are in favor of
changing its Default branch to develop for consistency with the other repos and
other reasons as per recent discussion[1]
Consistency is best in my opinion.
--
Mike Stolz
Principal Engineer - Gemfire Product Manager
Mobile: 631-835-4771
On Dec 12, 2018 9:59 AM, "Jacob Barrett" wrote:
> Make the default “develop” to be consistent with the rest of our
> repositories. Put a statement in the https://urldefense.proofpo
Make the default “develop” to be consistent with the rest of our repositories.
Put a statement in the README.md that these examples for the 1.9.0-SNAPSHOT
(develop). When cutting a release and merging to master change the say they are
for 1.9.0 (rel/v1.9.0).
> On Dec 12, 2018, at 9:07 AM, Anth
I agree that there is a conflict here of what might be most usable for
users vs. developers contributing to the geode-examples repo.
No matter which route we go down, we should improve guidance. If we keep
master the default, I +1 Owen's suggestion of amending the template. If we
make develop the
I believe master is still the best default branch for most users. Can we add a
PR template for geode-examples reminding developers that examples PRs must be
based on develop, not master?
Generally the only difference between examples' develop and master is which
maven repo it points to (snapsh
I’m fine with moving all development work to master given the use case for
geode-examples—I just don’t want PR’s merged to *both* master and develop.
Other thoughts?
Anthony
> On Dec 12, 2018, at 9:16 AM, Dan Smith wrote:
>
> Good question! I think we intentionally left the default branch a
Good question! I think we intentionally left the default branch as master
so that users cloning the examples from github will get examples that work
against a released version of geode.
That said, I don't feel too strongly if we would rather make things more
consistent with the geode repo - it se
Alexander noticed that some recent PR’s against the geode-examples repo made
against the master branch. That breaks the gitflow approach where only
released code is on master. Should we update the default branch to be develop?
Anthony
We merge develop to master for geode-examples whenever we cut a release.
When we release, we release all of the repos at once - currently just geode
and geode-examples since geode-native isn't ready to release yet. The
master branch of geode-examples builds and run against the latest geode
release.
I vote for changing the default branch to develop.
Sarge
> On 2 Jan, 2018, at 10:05, Alexander Murmann wrote:
>
> I noticed that many recent commits in the geode-examples repo have been
> merged to develop, but not master. Will those be merged to master at some
> point or should we change the d
I noticed that many recent commits in the geode-examples repo have been
merged to develop, but not master. Will those be merged to master at some
point or should we change the default branch of the repo to develop?
23 matches
Mail list logo
