Re: [DISCUSS] Using Pull Requests over Review Board

On Mon, Jun 12, 2017 at 9:37 AM Dave Barnes wrote: > Proposal as written says "...for changes that would require peer review > before committing...". > If this means that minor changes (in my case, typo repairs are the common > case) can be checked in without going through a

Re: [DISCUSS] Using Pull Requests over Review Board

On Mon, Jun 12, 2017 at 7:57 AM Bruce Schuchardt wrote: > It places an unnecessary burden on committers Considering committers need to use PR to commit changes from non-committers how does reducing the number of review systems increase the burden on committers? > and

Re: [DISCUSS] Using Pull Requests over Review Board

One feature I like about PRs on GitHub that I haven't figured out how to do on Review Board is breaking up a large changeset (which I would like to have reviewed together) into multiple commits. It can be a useful way to tell a story about your changes, but keep the review for them in one place.

Re: [DISCUSS] Using Pull Requests over Review Board

On Thu, Jun 8, 2017 at 2:24 PM Nabarun Nag wrote: > Also, IMHO feature branches from which the PRs are created should be in our > personal fork rather than the main geode git repo. > +1 - I had planned to bring this up in a separate discussion but yes, I think all work should

Re: [DISCUSS] Using Pull Requests over Review Board

+1 on using PR. We can use the @tags and the github notification page[Participating tag] to check the PRs that need our attention. Also, IMHO feature branches from which the PRs are created should be in our personal fork rather than the main geode git repo. Because when we push a branch called

Re: [DISCUSS] Using Pull Requests over Review Board

On Thu, Jun 8, 2017 at 12:35 PM Mark Bretl wrote: > I like the functionality we get with GitHub, including the Travis CI > integration. > > Do we have a proposed workflow change for committers? The proposed workflow change to committers is to use the same workflow as

Re: [DISCUSS] Using Pull Requests over Review Board

I like the functionality we get with GitHub, including the Travis CI integration. Do we have a proposed workflow change for committers? --Mark On Thu, Jun 8, 2017 at 11:20 AM, Jacob Barrett wrote: > Some more fuel on this fire... PR's get checked against Travis CI >

Re: [DISCUSS] Using Pull Requests over Review Board

Some more fuel on this fire... PR's get checked against Travis CI automatically and the results show up in the PR. This is a good safety check even for committers before merging their branch into the development branch. -Jake

Re: [DISCUSS] Using Pull Requests over Review Board

On Thu, Jun 8, 2017 at 10:20 AM Dan Smith wrote: > One thing that can > help is if you add your github id to your apache profile - the PR will then > show that it is coming from an apache member. To illustrate what Dan is saying, notice the "Member" tag on my comment in the

Re: [DISCUSS] Using Pull Requests over Review Board

+1 for just PRs +1 for trying the functionality Jared has pointed out in Github On Thu, Jun 8, 2017 at 10:19 AM, Jared Stewart wrote: > > On Jun 8, 2017, at 8:32 AM, Bruce Schuchardt > wrote: > > I also don't see any way to push a PR to specific

Re: [DISCUSS] Using Pull Requests over Review Board

+1 to just using PRs. I think the benefits to new people to the project make it worth it to switch. New people will see PRs from committers when they are creating their PRs, which will help provide good examples. It's one less system to sign up on as a contributor so it's easier for new people to

Re: [DISCUSS] Using Pull Requests over Review Board

On Thu, Jun 8, 2017 at 8:32 AM Bruce Schuchardt wrote: > One thing I find confusing in PRs is whether the person submitting the > request is a committer or not. Non-committers need someone to merge the > PR while committers are just looking for a review and will merge

Re: [DISCUSS] Using Pull Requests over Review Board

I've used both PRs and Review Boards for doc changes. The Review Board's targeted reviewer list, as Bruce points out, is a plus. It would be great if PRs could do that. On Thu, Jun 8, 2017 at 9:28 AM, John Blum wrote: > +1 to Bruce's comments. > > PRs are for contributors that

Re: [DISCUSS] Using Pull Requests over Review Board

On Thu, Jun 8, 2017 at 9:28 AM John Blum wrote: > PRs are for contributors that do not have commit privileges. ReviewBoard > is a tool for "reviewing" changes. > This isn't some law, it was our choice. What I am proposing is that we re-evaluate this choice for consistency.

Re: [DISCUSS] Using Pull Requests over Review Board

+1 to Bruce's comments. PRs are for contributors that do not have commit privileges. ReviewBoard is a tool for "reviewing" changes. However, what is also common practice on open source projects, even for committers, is to create a topic branch containing the commit with the desired changes

Re: [DISCUSS] Using Pull Requests over Review Board

One thing I find confusing in PRs is whether the person submitting the request is a committer or not. Non-committers need someone to merge the PR while committers are just looking for a review and will merge the changes to develop themselves. I also don't see any way to push a PR to specific