Re: Release branch for Apache Geode 1.8.0 has been cut

2018-11-21 Thread Alexander Murmann
Hi Ryan, This looks like a solid fix to a critical issue. 👍from me if everyone else agree. On Wed, Nov 21, 2018 at 11:00 AM Ryan McMahon wrote: > HI Alexander, > > I have another fix that I believe would be beneficial for the 1.8 release. > We have seen that issues related to intermittent DNS l

Re: Release branch for Apache Geode 1.8.0 has been cut

2018-11-21 Thread Ryan McMahon
HI Alexander, I have another fix that I believe would be beneficial for the 1.8 release. We have seen that issues related to intermittent DNS lookup failures can cause WAN event processing to cease where a retry would have been more appropriate. The fix is already merged to develop. May I cherry

Re: Release branch for Apache Geode 1.8.0 has been cut

2018-11-15 Thread Alexander Murmann
Ryan, Jason & Nabarun, these all look like critical issues to me that we should address in 1.8 to not introduce a regression. If nobody else has an objection, I am fine with you cherry-picking these into the relase branch. Thanks! On Wed, Nov 14, 2018 at 5:19 PM Nabarun Nag wrote: > I would als

Re: Release branch for Apache Geode 1.8.0 has been cut

2018-11-14 Thread Nabarun Nag
I would also like to put in the fix for GEODE-6053. It's in the review phase and soon will be in the develop and the release branch. Regards Nabarun Nag > On Nov 14, 2018, at 10:28 AM, Jason Huynh wrote: > > I'd like to cherry pick the following two commits to release/1.8. > > > https://gith

Re: Release branch for Apache Geode 1.8.0 has been cut

2018-11-14 Thread Jason Huynh
I'd like to cherry pick the following two commits to release/1.8. https://github.com/apache/geode/commit/6d9e026feb584309dff269e593417082a71434fc https://github.com/apache/geode/commit/d22e83e167f261e933b79b2619367d2e1b788db6 Reason: There was a previous commit that modified the way FunctionIn

Re: Release branch for Apache Geode 1.8.0 has been cut

2018-11-12 Thread Ryan McMahon
Hi Alexander, I would like to cherry pick the following commits from develop to release/1.8.0: https://github.com/apache/geode/commit/e9ea18e18c85b977b91192d4edbb9a4e18b2643e *Reason*: This was a revert of a previous commit which addressed data inconsistencies between WAN sites, but it was found