Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58518/ --- (Updated April 25, 2017, 9:32 p.m.) Review request for geode, Jinmei Liao, Ken

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58518/#review172985 --- Ship it! Ship It! - Jinmei Liao On April 25, 2017, 6:20

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58518/#review172981 --- Fix it, then Ship it! Fix and Ship!

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58518/ --- (Updated April 25, 2017, 6:20 p.m.) Review request for geode, Jinmei Liao, Ken

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

> On April 22, 2017, 12:50 a.m., Jinmei Liao wrote: > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java > > Line 73 (original), 69 (patched) > > > > > > Why 8? I think we

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58518/#review172727 ---

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58518/ --- (Updated April 21, 2017, 10:34 p.m.) Review request for geode, Jinmei Liao,

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58518/#review172523 --- Ship it! Ship It! - Kirk Lund On April 19, 2017, 11:22

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58518/#review172485 ---

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58518/#review172428 --- Ship it! Ship It! - Jinmei Liao On April 19, 2017, 11:22

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58518/ --- (Updated April 19, 2017, 11:22 p.m.) Review request for geode, Jinmei Liao,

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

> On April 19, 2017, 8:32 p.m., Kirk Lund wrote: > > It looks like LocatorServerStartupRule now always bounces VMs even if the > > test did not change user.dir. I thought you wanted it to bounce only if > > user.dir was altered? Maybe a UserDirRule would be better? This change will cause us

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58518/#review172401 --- It looks like LocatorServerStartupRule now always bounces VMs

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

> On April 19, 2017, 4:30 p.m., Jinmei Liao wrote: > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java > > Lines 82 (patched) > > > > > > this class also has a stopMember

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

> On April 19, 2017, 4:30 p.m., Jinmei Liao wrote: > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java > > Lines 82 (patched) > > > > > > this class also has a stopMember

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58518/#review172364 --- Ship it! Ship It! - Ken Howe On April 18, 2017, 9:58 p.m.,

Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58518/ --- Review request for geode. Repository: geode Description --- GEODE-2795: