Re: geode-3153 waiting on reviews

[Mark Bretl]

Hi Barry,

What Geode versions are these related to?

Please only use Geode versions when discussing issues on the community
lists.

Thanks,

--Mark

On Mon, Jul 3, 2017 at 6:26 PM Barry Oglesby  wrote:

> Bruce,
>
> Here is what I am seeing in my test (same one I sent you).
>
> 904 server -> 823 client:
>
> Before writing to stream: Client Message Dispatcher for
> 192.168.2.4(client:78763:loner):49721:b274160b:client(version:GFE 8.1):
> ClientUpdateMessageImpl.getGFE70Message membershipIdLength=39;
> membershipId=[4, -64, -88, 2, 4, 0, 0, 4, 3, 5, 10, 87, 0, 1, 57, 87, 0, 4,
> 112, 101, 101, 114, -80, 114, 25, 102, 117, -114, -43, -72, -98, -85, -124,
> -126, 97, -21, -116, 115, 0]
>
> Being written to stream: Client Message Dispatcher for
> 192.168.2.4(client:78763:loner):49721:b274160b:client(version:GFE 8.1):
> EventID.toData writing membershipIdLength=39; membershipId=[4, -64, -88, 2,
> 4, 0, 0, 4, 3, 5, 10, 87, 0, 1, 57, 87, 0, 4, 112, 101, 101, 114, -80, 114,
> 25, 102, 117, -114, -43, -72, -98, -85, -124, -126, 97, -21, -116, 115, 0]
>
> 91 server -> 823 client:
>
> Before writing to stream: Client Message Dispatcher for
> 192.168.2.4(client:78763:loner):49721:b274160b:client(version:GFE 8.1):
> ClientUpdateMessageImpl.getGFE70Message membershipIdLength=39;
> membershipId=[4, -64, -88, 2, 4, 0, 0, 4, 3, 5, 10, 87, 0, 1, 57, 87, 0, 4,
> 112, 101, 101, 114, -80, 114, 25, 102, 117, -114, -43, -72, -98, -85, -124,
> -126, 97, -21, -116, 115, 0]
>
> Being written to stream: Client Message Dispatcher for
> 192.168.2.4(client:78763:loner):49721:b274160b:client(version:GFE 8.1):
> EventID.toData writing membershipIdLength=22; membershipId=[4, -64, -88, 2,
> 4, 0, 0, 4, 3, 5, 10, 87, 0, 1, 57, 87, 0, 4, 112, 101, 101, 114]
>
> In the 904 case, the bytes in the original membership id are written to the
> stream. In the 91 case, the last 17 bytes are removed before the membership
> id is written to the stream.
>
>
> Thanks,
> Barry Oglesby
>
>
> On Mon, Jul 3, 2017 at 1:14 PM, Bruce Schuchardt 
> wrote:
>
> > I've checked in the fix for geode-3153, though Barry said he may still be
> > seeing trouble with it.  I plan to get together with him on-line
> wednesday
> > morning, if possible, to step through his test & verify if the problem
> > still exists.
> >
> > I've also pushed the commit to release/1.2.0
> >
> >
> >
> > On 7/1/17 8:54 AM, Bruce Schuchardt wrote:
> >
> >> This is a 1.2.0 blocker.  It's passed precheckin and new
> >> backward-compatibility unit tests and the reviewboard code review has no
> >> outstanding issues.  I'd like to get a shipIt or two & I'll push the
> >> changes to develop and release/1.2.0.
> >>
> >> https://reviews.apache.org/r/60570/
> >>
> >>
> >
>

Fixed: apache/geode#3082 (release/1.2.0 - 00a066b)

[Travis CI]

Build Update for apache/geode
-

Build: #3082
Status: Fixed

Duration: 11 minutes and 23 seconds
Commit: 00a066b (release/1.2.0)
Author: Dan Smith
Message: GEODE-3139: Fixing compilation errors

ProcessManager appears to have been screwed up in the merge from
develop. Changed the class so that it matches the contents on develop.

View the changeset: 
https://github.com/apache/geode/compare/30e2eb2080af...00a066b6ba1a

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/249805514?utm_source=email_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

Broken: apache/geode#3078 (release/1.2.0 - 30e2eb2)

[Travis CI]

Build Update for apache/geode
-

Build: #3078
Status: Broken

Duration: 5 minutes and 32 seconds
Commit: 30e2eb2 (release/1.2.0)
Author: Bruce Schuchardt
Message: GEODE-3139 remove artifacts from classpath of backward-compatibility 
tests

reinstating this - passes precheckin

GEODE-3153 Client receives duplicate events during rolling upgrade

Another problem was found in backward-compatibility testing.  If a
1.0.0 client was receiving subscription events generated by a 1.0.0
peer "feeder" member and the events were routed through a 1.0.0 server
the client might see duplicate events when the server is stopped and
the client fails over to a 1.2.0 server holding its redundant
subscription queue.  This is especially possible if a large "ack"
period is established in the client.

The problem stems from the EventID deserialization/reserialization of
the memberID bytes when sending to a 1.0 client.  It was deserializing
using Version.CURRENT, which ignores the UUID bytes in the serialized ID.
Then it serialized the identifier using the client's version, which
includes the UUID bytes but which are zero due to the version used
in deserialization.

View the changeset: 
https://github.com/apache/geode/compare/9f55eb125514...30e2eb2080af

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/249764972?utm_source=email_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

Broken: apache/geode#3077 (develop - fb4e96b)

[Travis CI]

Build Update for apache/geode
-

Build: #3077
Status: Broken

Duration: 9 minutes and 25 seconds
Commit: fb4e96b (develop)
Author: Bruce Schuchardt
Message: GEODE-3139 remove artifacts from classpath of backward-compatibility 
tests

reinstating this - passes precheckin

GEODE-3153 Client receives duplicate events during rolling upgrade

Another problem was found in backward-compatibility testing.  If a
1.0.0 client was receiving subscription events generated by a 1.0.0
peer "feeder" member and the events were routed through a 1.0.0 server
the client might see duplicate events when the server is stopped and
the client fails over to a 1.2.0 server holding its redundant
subscription queue.  This is especially possible if a large "ack"
period is established in the client.

The problem stems from the EventID deserialization/reserialization of
the memberID bytes when sending to a 1.0 client.  It was deserializing
using Version.CURRENT, which ignores the UUID bytes in the serialized ID.
Then it serialized the identifier using the client's version, which
includes the UUID bytes but which are zero due to the version used
in deserialization.

View the changeset: 
https://github.com/apache/geode/compare/92f270805a83...fb4e96bfbad9

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/249764167?utm_source=email_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

Fixed: apache/geode#3079 (develop - 3433b3e)

[Travis CI]

Build Update for apache/geode
-

Build: #3079
Status: Fixed

Duration: 21 minutes and 54 seconds
Commit: 3433b3e (develop)
Author: nabarun
Message: GEODE-3139: Spotless error fix

View the changeset: 
https://github.com/apache/geode/compare/fb4e96bfbad9...3433b3e27a51

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/249775839?utm_source=email_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

Re: geode-3153 waiting on reviews

[Barry Oglesby]

Bruce,

Here is what I am seeing in my test (same one I sent you).

904 server -> 823 client:

Before writing to stream: Client Message Dispatcher for
192.168.2.4(client:78763:loner):49721:b274160b:client(version:GFE 8.1):
ClientUpdateMessageImpl.getGFE70Message membershipIdLength=39;
membershipId=[4, -64, -88, 2, 4, 0, 0, 4, 3, 5, 10, 87, 0, 1, 57, 87, 0, 4,
112, 101, 101, 114, -80, 114, 25, 102, 117, -114, -43, -72, -98, -85, -124,
-126, 97, -21, -116, 115, 0]

Being written to stream: Client Message Dispatcher for
192.168.2.4(client:78763:loner):49721:b274160b:client(version:GFE 8.1):
EventID.toData writing membershipIdLength=39; membershipId=[4, -64, -88, 2,
4, 0, 0, 4, 3, 5, 10, 87, 0, 1, 57, 87, 0, 4, 112, 101, 101, 114, -80, 114,
25, 102, 117, -114, -43, -72, -98, -85, -124, -126, 97, -21, -116, 115, 0]

91 server -> 823 client:

Before writing to stream: Client Message Dispatcher for
192.168.2.4(client:78763:loner):49721:b274160b:client(version:GFE 8.1):
ClientUpdateMessageImpl.getGFE70Message membershipIdLength=39;
membershipId=[4, -64, -88, 2, 4, 0, 0, 4, 3, 5, 10, 87, 0, 1, 57, 87, 0, 4,
112, 101, 101, 114, -80, 114, 25, 102, 117, -114, -43, -72, -98, -85, -124,
-126, 97, -21, -116, 115, 0]

Being written to stream: Client Message Dispatcher for
192.168.2.4(client:78763:loner):49721:b274160b:client(version:GFE 8.1):
EventID.toData writing membershipIdLength=22; membershipId=[4, -64, -88, 2,
4, 0, 0, 4, 3, 5, 10, 87, 0, 1, 57, 87, 0, 4, 112, 101, 101, 114]

In the 904 case, the bytes in the original membership id are written to the
stream. In the 91 case, the last 17 bytes are removed before the membership
id is written to the stream.


Thanks,
Barry Oglesby


On Mon, Jul 3, 2017 at 1:14 PM, Bruce Schuchardt 
wrote:

> I've checked in the fix for geode-3153, though Barry said he may still be
> seeing trouble with it.  I plan to get together with him on-line wednesday
> morning, if possible, to step through his test & verify if the problem
> still exists.
>
> I've also pushed the commit to release/1.2.0
>
>
>
> On 7/1/17 8:54 AM, Bruce Schuchardt wrote:
>
>> This is a 1.2.0 blocker.  It's passed precheckin and new
>> backward-compatibility unit tests and the reviewboard code review has no
>> outstanding issues.  I'd like to get a shipIt or two & I'll push the
>> changes to develop and release/1.2.0.
>>
>> https://reviews.apache.org/r/60570/
>>
>>
>

[GitHub] geode pull request #617: GEODE-3129 - Added error messages to protobuf proto...

[WireBaron]

GitHub user WireBaron opened a pull request:

https://github.com/apache/geode/pull/617

GEODE-3129 - Added error messages to protobuf protocol

added a new ErrorResponse type to ClientProtocol
removed success field from several RegionAPI response objects and 
refactored operation handlers to instead return ErrorResponses
made all op handlers take ClientProtocol.Requests and return 
ClientProtocol.Responses instead of operation specific types
moved the protobuf specific response building code from operation handlers 
to ProtobufResponseUtilities
moved the request building functions from MessageUtil (under Test) to 
ProtobufRequestUtilities
moved all utility classes to ...protocol.protobuf.utilities and added 
javadoc comments throughout
changed GetRegions to GetRegionNames, returns strings instead of Regions
replaced logging through the cache's LogWriter with log4j logging
updated all imports to be in the correct order for the new geode style guide

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [x] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/WireBaron/geode feature/GEODE-3129

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/617.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #617


commit 14c142d1853c87932ab58f66e2a0d54d3caf0652
Author: Brian Rowe 
Date:   2017-07-03T23:01:56Z

GEODE-3129 - Added error messages to protobuf protocol

added a new ErrorResponse type to ClientProtocol
removed success field from several RegionAPI response objects and 
refactored operation handlers to instead return ErrorResponses
made all op handlers take ClientProtocol.Requests and return 
ClientProtocol.Responses instead of operation specific types
moved the protobuf specific response building code from operation handlers 
to ProtobufResponseUtilities
moved the request building functions from MessageUtil (under Test) to 
ProtobufRequestUtilities
moved all utility classes to ...protocol.protobuf.utilities and added 
javadoc comments throughout
changed GetRegions to GetRegionNames, returns strings instead of Regions
replaced logging through the cache's LogWriter with log4j logging
updated all imports to be in the correct order for the new geode style guide




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Review Request 60629: GEODE-3129 - Added error messages to protobuf protocol

[Brian Rowe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60629/
---

Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.


Bugs: GEODE-3129
https://issues.apache.org/jira/browse/GEODE-3129


Repository: geode


Description
---

added a new ErrorResponse type to ClientProtocol
removed success field from several RegionAPI response objects and refactored 
operation handlers to instead return ErrorResponses
made all op handlers take ClientProtocol.Requests and return 
ClientProtocol.Responses instead of operation specific types
moved the protobuf specific response building code from operation handlers to 
ProtobufResponseUtilities
moved the request building functions from MessageUtil (under Test) to 
ProtobufRequestUtilities
moved all utility classes to ...protocol.protobuf.utilities and added javadoc 
comments throughout
changed GetRegions to GetRegionNames, returns strings instead of Regions
replaced logging through the cache's LogWriter with log4j logging
updated all imports to be in the correct order for the new geode style guide


Diffs
-

  
geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/OperationsHandlerRegistry.java
 2b9f52597 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/EncodingTypeTranslator.java
 edb7c7eb1 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
 4318fb444 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
 4e76de4a1 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufUtilities.java
 c92da67a2 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRegionsRequestOperationHandler.java
 dc1d8acdd 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
 95026e8d7 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandler.java
 f375244d8 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/serializer/ProtobufProtocolSerializer.java
 683e42f3f 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufRequestUtilities.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/IntCodec.java 
6bd2b5c91 
  geode-protobuf/src/main/proto/clientProtocol.proto 0c192950a 
  geode-protobuf/src/main/proto/region_API.proto d3af17acb 
  
geode-protobuf/src/test/java/org/apache/geode/protocol/IntegrationJUnitTest.java
 42cc7b3d0 
  geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUtil.java 
dc897241f 
  
geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
 77b984f7e 
  
geode-protobuf/src/test/java/org/apache/geode/protocol/operations/registry/OperationsHandlerRegistryJUnitTest.java
 612e6a76f 
  
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/EncodingTypeToSerializationTypeTranslatorJUnitTest.java
 8e6f66aae 
  
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessorJUnitTest.java
 c51be5cbb 
  
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRegionRequestOperationHandlerJUnitTest.java
 e8f1e651a 
  
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandlerJUnitTest.java
 f92b1941a 
  
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandlerJUnitTest.java
 ddc23fc42 
  
geode-protobuf/src/test/java/org/apache/geode/protocol/serializer/ProtobufProtocolSerializerJUnitTest.java
 5a94dae01 
  
geode-protobuf/src/test/java/org/apache/geode/serialization/codec/BinaryFormatJUnitTest.java
 dd72a190e 


Diff: https://reviews.apache.org/r/60629/diff/1/


Testing
---

Protobuf tests impacted by these changes have been refactored to check for 
error responses.


Thanks,

Brian Rowe

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #605 was SUCCESSFUL (with 1908 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #605 was successful.
---
Scheduled
1910 tests in total.

https://build.spring.io/browse/SGF-NAG-605/





--
This message is automatically generated by Atlassian Bamboo

Re: Build failed in Jenkins: Geode-release #72

[Dan Smith]

Looks like compilation of the release branch was broken by these changes. I
went ahead and fixed the compilation error since we are trying to get this
release out - I just made ProcessManager match the contents on develop,
which I think was the intention.

commit 30e2eb2080afff3af2f5226a412259c3a5302f63
Author: Bruce Schuchardt 
Date:   Mon Jul 3 13:06:30 2017 -0700

GEODE-3139 remove artifacts from classpath of backward-compatibility
tests

reinstating this - passes precheckin

GEODE-3153 Client receives duplicate events during rolling upgrade


On Mon, Jul 3, 2017 at 1:25 PM, Apache Jenkins Server <
jenk...@builds.apache.org> wrote:

> See  redirect?page=changes>
>
> Changes:
>
> [bschuchardt] GEODE-3139 remove artifacts from classpath of
> backward-compatibility
>
> --
> [...truncated 68.57 KB...]
> :geode-lucene:processResources
> :geode-lucene:classes
> :geode-old-client-support:compileJavaNote: Some input files use or
> override a deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
>
> :geode-old-client-support:processResources
> :geode-old-client-support:classes
> :geode-pulse:compileJavaNote: Some input files use or override a
> deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
>
> :geode-pulse:copyGemFireVersionFile
> :geode-pulse:processResources
> :geode-pulse:classes
> :geode-rebalancer:compileJava
> :geode-rebalancer:processResources UP-TO-DATE
> :geode-rebalancer:classes
> :geode-wan:compileJava
> :geode-wan:processResources
> :geode-wan:classes
> :geode-web:compileJava UP-TO-DATE
> :geode-web:processResources UP-TO-DATE
> :geode-web:classes UP-TO-DATE
> :geode-web-api:compileJavaNote: Some input files use unchecked or unsafe
> operations.
> Note: Recompile with -Xlint:unchecked for details.
>
> :geode-web-api:processResources
> :geode-web-api:classes
> :geode-assembly:docs
> :geode-assembly:gfshDepsJar
> :geode-common:javadocJar
> :geode-common:sourcesJar
> :geode-common:signArchives SKIPPED
> :geode-core:javadocJar
> :geode-core:raJar
> :geode-core:jcaJar
> :geode-core:sourcesJar
> :geode-core:signArchives SKIPPED
> :geode-core:webJar
> :geode-cq:jar
> :geode-cq:javadoc
> :geode-cq:javadocJar
> :geode-cq:sourcesJar
> :geode-cq:signArchives SKIPPED
> :geode-json:javadocJar
> :geode-json:sourcesJar
> :geode-json:signArchives SKIPPED
> :geode-lucene:jar
> :geode-lucene:javadoc
> :geode-lucene:javadocJar
> :geode-lucene:sourcesJar
> :geode-lucene:signArchives SKIPPED
> :geode-old-client-support:jar
> :geode-old-client-support:javadoc
> :geode-old-client-support:javadocJar
> :geode-old-client-support:sourcesJar
> :geode-old-client-support:signArchives SKIPPED
> :geode-pulse:javadoc
> :geode-pulse:javadocJar
> :geode-pulse:sourcesJar
> :geode-pulse:war
> :geode-pulse:signArchives SKIPPED
> :geode-rebalancer:jar
> :geode-rebalancer:javadoc
> :geode-rebalancer:javadocJar
> :geode-rebalancer:sourcesJar
> :geode-rebalancer:signArchives SKIPPED
> :geode-wan:jar
> :geode-wan:javadoc
> :geode-wan:javadocJar
> :geode-wan:sourcesJar
> :geode-wan:signArchives SKIPPED
> :geode-web:javadoc UP-TO-DATE
> :geode-web:javadocJar
> :geode-web:sourcesJar
> :geode-web:war
> :geode-web:signArchives SKIPPED
> :geode-web-api:javadoc
> :geode-web-api:javadocJar
> :geode-web-api:sourcesJar
> :geode-web-api:war
> :geode-web-api:signArchives SKIPPED
> :geode-assembly:distTar
> :geode-assembly:distZip
> :geode-assembly:writeBuildInfo
> :geode-assembly:srcDistTar
> :geode-assembly:srcDistZip
> :geode-assembly:signArchives SKIPPED
> :geode-assembly:assemble
> :geode-pulse:jar
> :geode-assembly:processTestResources
> :geode-assembly:spotlessJavaCheck
> :geode-assembly:spotlessCheck
> :geode-assembly:installDist
> :geode-benchmarks:jar
> :geode-benchmarks:javadoc UP-TO-DATE
> :geode-benchmarks:javadocJar
> :geode-benchmarks:sourcesJar
> :geode-benchmarks:signArchives SKIPPED
> :geode-benchmarks:assemble
> :geode-benchmarks:compileTestJava UP-TO-DATE
> :geode-benchmarks:processTestResources UP-TO-DATE
> :geode-benchmarks:testClasses UP-TO-DATE
> :geode-benchmarks:checkMissedTests UP-TO-DATE
> :geode-benchmarks:spotlessJavaCheck
> :geode-benchmarks:spotlessCheck
> :geode-benchmarks:test UP-TO-DATE
> :geode-benchmarks:check
> :geode-benchmarks:build
> :geode-benchmarks:distributedTest UP-TO-DATE
> :geode-benchmarks:integrationTest UP-TO-DATE
> :geode-common:assemble
> :geode-common:compileTestJava
> :geode-common:processTestResources UP-TO-DATE
> :geode-common:testClasses
> :geode-common:checkMissedTests
> :geode-common:spotlessJavaCheck
> :geode-common:spotlessCheck
> :geode-common:test
> :geode-common:check
> :geode-common:build
> :geode-common:distributedTest
> :geode-common:integrationTest
> :geode-core:assemble
> :geode-core:spotlessJavaCheck

[GitHub] geode pull request #616: GEODE-2860: Refactor use of EventTracker

[nreich]

GitHub user nreich opened a pull request:

https://github.com/apache/geode/pull/616

GEODE-2860: Refactor use of EventTracker

  * change EventTracker to an interface with two implementations
  * move as much logic out of LocalRegion down into subclasses that
make use EventTracker
  * move and refactor static inner classes in EventTracker into own
class files
  * migrate some of event-focused classes into a new sub package
  * add tests for existing logic from EventTracker

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [x] Have you written or updated unit tests to verify your changes?

- [NA] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nreich/geode feature/GEODE-2860

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/616.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #616


commit 0e215d4ba961abb7dd293662a7586aacf2369f00
Author: Nick Reich 
Date:   2017-06-30T23:05:58Z

GEODE-2860: Refactor use of EventTracker

  * change EventTracker to an interface with two implementations
  * move as much logic out of LocalRegion down into subclasses that
make use EventTracker
  * move and refactor static inner classes in EventTracker into own
class files
  * migrate some of event-focused classes into a new sub package
  * add tests for existing logic from EventTracker




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: Geode-release-flaky #21

[Apache Jenkins Server]

See 


Changes:

[bschuchardt] GEODE-3139 remove artifacts from classpath of 
backward-compatibility

--
[...truncated 73.70 KB...]
:geode-core:javadoc
:extensions/geode-modules:javadoc
:extensions/geode-modules-session-internal:javadoc
:extensions/geode-modules-session:javadoc
:extensions/geode-modules-session:javadocJar
:extensions/geode-modules-session:sourcesJar
:extensions/geode-modules-session:signArchives SKIPPED
:extensions/geode-modules-session:assemble
:extensions/geode-modules-assembly:distAppServer
Download 
https://repo1.maven.org/maven2/org/slf4j/slf4j-jdk14/1.7.23/slf4j-jdk14-1.7.23.pom
Download 
https://repo1.maven.org/maven2/org/slf4j/slf4j-jdk14/1.7.23/slf4j-jdk14-1.7.23.jar
:extensions/geode-modules:javadocJar
:extensions/geode-modules:sourcesJar
:extensions/geode-modules:signArchives SKIPPED
:extensions/geode-modules:assemble
:extensions/geode-modules-tomcat7:jar
:extensions/geode-modules-tomcat7:javadoc
:extensions/geode-modules-tomcat7:javadocJar
:extensions/geode-modules-tomcat7:sourcesJar
:extensions/geode-modules-tomcat7:signArchives SKIPPED
:extensions/geode-modules-tomcat7:assemble
:extensions/geode-modules-tomcat8:jar
:extensions/geode-modules-tomcat8:javadoc
:extensions/geode-modules-tomcat8:javadocJar
:extensions/geode-modules-tomcat8:sourcesJar
:extensions/geode-modules-tomcat8:signArchives SKIPPED
:extensions/geode-modules-tomcat8:assemble
:extensions/geode-modules-assembly:distTcServer
:extensions/geode-modules-assembly:distTcServer30
:extensions/geode-modules-assembly:distTomcat
:extensions/geode-modules-assembly:dist
:geode-assembly:defaultCacheConfig
:geode-assembly:defaultDistributionConfig
:geode-assembly:depsJar
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-analyzers-common/6.4.1/lucene-analyzers-common-6.4.1.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-parent/6.4.1/lucene-parent-6.4.1.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-solr-grandparent/6.4.1/lucene-solr-grandparent-6.4.1.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-core/6.4.1/lucene-core-6.4.1.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-queries/6.4.1/lucene-queries-6.4.1.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-queryparser/6.4.1/lucene-queryparser-6.4.1.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-analyzers-common/6.4.1/lucene-analyzers-common-6.4.1.jar
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-core/6.4.1/lucene-core-6.4.1.jar
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-queries/6.4.1/lucene-queries-6.4.1.jar
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-queryparser/6.4.1/lucene-queryparser-6.4.1.jar
Download 
https://repo1.maven.org/maven2/org/springframework/spring-aspects/4.3.6.RELEASE/spring-aspects-4.3.6.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/springframework/spring-oxm/4.3.6.RELEASE/spring-oxm-4.3.6.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/springframework/spring-aspects/4.3.6.RELEASE/spring-aspects-4.3.6.RELEASE.jar
Download 
https://repo1.maven.org/maven2/org/springframework/spring-oxm/4.3.6.RELEASE/spring-oxm-4.3.6.RELEASE.jar
:geode-benchmarks:compileJava UP-TO-DATE
:geode-benchmarks:processResources UP-TO-DATE
:geode-benchmarks:classes UP-TO-DATE
:geode-cq:compileJavaNote: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processResources
:geode-cq:classes
:geode-lucene:compileJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processResources
:geode-lucene:classes
:geode-old-client-support:compileJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:geode-old-client-support:processResources
:geode-old-client-support:classes
:geode-pulse:compileJava
Download 
https://repo1.maven.org/maven2/org/springframework/ldap/spring-ldap-core/2.3.1.RELEASE/spring-ldap-core-2.3.1.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/springframework/security/spring-security-config/4.2.1.RELEASE/spring-security-config-4.2.1.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/springframework/spring-framework-bom/4.3.5.RELEASE/spring-framework-bom-4.3.5.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/springframework/security/spring-security-ldap/4.2.1.RELEASE/spring-security-ldap-4.2.1.RELEASE.pom
Download 

Build failed in Jenkins: Geode-release #72

[Apache Jenkins Server]

See 


Changes:

[bschuchardt] GEODE-3139 remove artifacts from classpath of 
backward-compatibility

--
[...truncated 68.57 KB...]
:geode-lucene:processResources
:geode-lucene:classes
:geode-old-client-support:compileJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:geode-old-client-support:processResources
:geode-old-client-support:classes
:geode-pulse:compileJavaNote: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:copyGemFireVersionFile
:geode-pulse:processResources
:geode-pulse:classes
:geode-rebalancer:compileJava
:geode-rebalancer:processResources UP-TO-DATE
:geode-rebalancer:classes
:geode-wan:compileJava
:geode-wan:processResources
:geode-wan:classes
:geode-web:compileJava UP-TO-DATE
:geode-web:processResources UP-TO-DATE
:geode-web:classes UP-TO-DATE
:geode-web-api:compileJavaNote: Some input files use unchecked or unsafe 
operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-web-api:processResources
:geode-web-api:classes
:geode-assembly:docs
:geode-assembly:gfshDepsJar
:geode-common:javadocJar
:geode-common:sourcesJar
:geode-common:signArchives SKIPPED
:geode-core:javadocJar
:geode-core:raJar
:geode-core:jcaJar
:geode-core:sourcesJar
:geode-core:signArchives SKIPPED
:geode-core:webJar
:geode-cq:jar
:geode-cq:javadoc
:geode-cq:javadocJar
:geode-cq:sourcesJar
:geode-cq:signArchives SKIPPED
:geode-json:javadocJar
:geode-json:sourcesJar
:geode-json:signArchives SKIPPED
:geode-lucene:jar
:geode-lucene:javadoc
:geode-lucene:javadocJar
:geode-lucene:sourcesJar
:geode-lucene:signArchives SKIPPED
:geode-old-client-support:jar
:geode-old-client-support:javadoc
:geode-old-client-support:javadocJar
:geode-old-client-support:sourcesJar
:geode-old-client-support:signArchives SKIPPED
:geode-pulse:javadoc
:geode-pulse:javadocJar
:geode-pulse:sourcesJar
:geode-pulse:war
:geode-pulse:signArchives SKIPPED
:geode-rebalancer:jar
:geode-rebalancer:javadoc
:geode-rebalancer:javadocJar
:geode-rebalancer:sourcesJar
:geode-rebalancer:signArchives SKIPPED
:geode-wan:jar
:geode-wan:javadoc
:geode-wan:javadocJar
:geode-wan:sourcesJar
:geode-wan:signArchives SKIPPED
:geode-web:javadoc UP-TO-DATE
:geode-web:javadocJar
:geode-web:sourcesJar
:geode-web:war
:geode-web:signArchives SKIPPED
:geode-web-api:javadoc
:geode-web-api:javadocJar
:geode-web-api:sourcesJar
:geode-web-api:war
:geode-web-api:signArchives SKIPPED
:geode-assembly:distTar
:geode-assembly:distZip
:geode-assembly:writeBuildInfo
:geode-assembly:srcDistTar
:geode-assembly:srcDistZip
:geode-assembly:signArchives SKIPPED
:geode-assembly:assemble
:geode-pulse:jar
:geode-assembly:processTestResources
:geode-assembly:spotlessJavaCheck
:geode-assembly:spotlessCheck
:geode-assembly:installDist
:geode-benchmarks:jar
:geode-benchmarks:javadoc UP-TO-DATE
:geode-benchmarks:javadocJar
:geode-benchmarks:sourcesJar
:geode-benchmarks:signArchives SKIPPED
:geode-benchmarks:assemble
:geode-benchmarks:compileTestJava UP-TO-DATE
:geode-benchmarks:processTestResources UP-TO-DATE
:geode-benchmarks:testClasses UP-TO-DATE
:geode-benchmarks:checkMissedTests UP-TO-DATE
:geode-benchmarks:spotlessJavaCheck
:geode-benchmarks:spotlessCheck
:geode-benchmarks:test UP-TO-DATE
:geode-benchmarks:check
:geode-benchmarks:build
:geode-benchmarks:distributedTest UP-TO-DATE
:geode-benchmarks:integrationTest UP-TO-DATE
:geode-common:assemble
:geode-common:compileTestJava
:geode-common:processTestResources UP-TO-DATE
:geode-common:testClasses
:geode-common:checkMissedTests
:geode-common:spotlessJavaCheck
:geode-common:spotlessCheck
:geode-common:test
:geode-common:check
:geode-common:build
:geode-common:distributedTest
:geode-common:integrationTest
:geode-core:assemble
:geode-core:spotlessJavaCheck
:geode-core:spotlessCheck
:geode-cq:assemble
:geode-cq:processTestResources
:geode-cq:spotlessJavaCheck
:geode-cq:spotlessCheck
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources
:geode-json:testClasses
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:integrationTest
:geode-lucene:assemble

Re: geode-3153 waiting on reviews

[Bruce Schuchardt]

I've checked in the fix for geode-3153, though Barry said he may still 
be seeing trouble with it.  I plan to get together with him on-line 
wednesday morning, if possible, to step through his test & verify if the 
problem still exists.


I've also pushed the commit to release/1.2.0


On 7/1/17 8:54 AM, Bruce Schuchardt wrote:
This is a 1.2.0 blocker.  It's passed precheckin and new 
backward-compatibility unit tests and the reviewboard code review has 
no outstanding issues.  I'd like to get a shipIt or two & I'll push 
the changes to develop and release/1.2.0.


https://reviews.apache.org/r/60570/

Re: Apache Geode + Narayana JTA = Global Transactions with Last-Resource Optimization

[Swapnil Bawaskar]

Great work Christian!
Can you add a page about this on the wiki
 as well, so that
your work is not lost.

On Mon, Jul 3, 2017 at 10:58 AM Dan Smith  wrote:

> Awesome!
>
> -Dan
>
> On Mon, Jul 3, 2017 at 6:08 AM, Christian Tzolov 
> wrote:
>
> > Recent experience of setting up Geode as a last-resource inside WebSphere
> > JTA, has motivated me to find a simpler way to integrate with JTA.
> >
> > The https://github.com/tzolov/narayana-jta-geode-support provides
> > utilities
> > to integrate Geode with Narayana JTA. This enables global transactions
> > using the embeddable, standalone, open-source Narayana JTA and implements
> > the Last-Resource Commit Optimization (LRCO) to preserve the ACID
> > properties.  (e.g. Geode is registered as last-resource in the global
> > transactions).
> >
> > With narayana-geode-core you can use it with the plain Geode API:
> > http://bit.ly/2tByAr5
> > or use narayana-geode-springboot for seamless integration with Spring
> Boot
> > and SpringDataGemfire. See the http://bit.ly/2siBEof example
> >
> > All dependencies are resolved from maven central.
> >
> > So if you build a SpringBoot app you only need to add the maven
> > dependencies and set a single annotation @EnableGeodeNarayanaJta. No need
> > for obsolete, commercial  Application Servers no accidental complexity.
> >
> > I’ve tried to explain the problem and the solution in my blog here:
> > http://blog.tzolov.net/2017/07/apache-geode-gemfire-
> > narayana-jta.html?view=sidebar
> >
> > Because Narayana uses LGPL it is not compatible for distribution with
> ASF,
> > but it can be referred as optional component.
> >
> > Cheers,
> > Christian
> >
> > P.S. the implementation uses code and ideas from the Geode engineering
> team
> > and from John Blum ;)
> > --
> > Christian Tzolov  | Data Engineer,
> EMEA
> > | Pivotal  | ctzo...@pivotal.io |+31610285517
> <+31%206%2010285517>
> >
>

Apache Nightly build machine disk space usage

[Nabarun Nag]

Hello all,

Build 54

has a failed test where the machine has reached 92% disk usage

*Failed Test:*
testStartServerAndExecuteCommands –
org.apache.geode.management.internal.configuration.ClusterConfigurationServiceEndToEndDUnitTest

*Error message:*
[error 2017/07/03 16:44:53.906 UTC  tid=62] The disk
volume ds1 for disk store ds1 has exceeded the critical usage threshold and
is 92% full

*Machine in use:*

Building remotely on H14 (ubuntu xenial) in workspace
/home/jenkins/jenkins-slave/workspace/Geode-nightly-flaky


Is it possible for someone with credentials to validate if this
machine is suitable to run nightly builds. Or any other steps that can
be done to prevent this from happening.


Regards

Nabarun

Re: Apache Geode + Narayana JTA = Global Transactions with Last-Resource Optimization

[Dan Smith]

Awesome!

-Dan

On Mon, Jul 3, 2017 at 6:08 AM, Christian Tzolov  wrote:

> Recent experience of setting up Geode as a last-resource inside WebSphere
> JTA, has motivated me to find a simpler way to integrate with JTA.
>
> The https://github.com/tzolov/narayana-jta-geode-support provides
> utilities
> to integrate Geode with Narayana JTA. This enables global transactions
> using the embeddable, standalone, open-source Narayana JTA and implements
> the Last-Resource Commit Optimization (LRCO) to preserve the ACID
> properties.  (e.g. Geode is registered as last-resource in the global
> transactions).
>
> With narayana-geode-core you can use it with the plain Geode API:
> http://bit.ly/2tByAr5
> or use narayana-geode-springboot for seamless integration with Spring Boot
> and SpringDataGemfire. See the http://bit.ly/2siBEof example
>
> All dependencies are resolved from maven central.
>
> So if you build a SpringBoot app you only need to add the maven
> dependencies and set a single annotation @EnableGeodeNarayanaJta. No need
> for obsolete, commercial  Application Servers no accidental complexity.
>
> I’ve tried to explain the problem and the solution in my blog here:
> http://blog.tzolov.net/2017/07/apache-geode-gemfire-
> narayana-jta.html?view=sidebar
>
> Because Narayana uses LGPL it is not compatible for distribution with ASF,
> but it can be referred as optional component.
>
> Cheers,
> Christian
>
> P.S. the implementation uses code and ideas from the Geode engineering team
> and from John Blum ;)
> --
> Christian Tzolov  | Data Engineer, EMEA
> | Pivotal  | ctzo...@pivotal.io |+31610285517
>

Re: Review Request 60570: GEODE-3153 Client receives duplicate events during rolling upgrade

[Dan Smith]

> On July 3, 2017, 4:02 p.m., Dan Smith wrote:
> > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
> > Lines 129 (patched)
> > 
> >
> > I don't see this property ever get used?
> 
> Bruce Schuchardt wrote:
> This is used in ProcessManager.  The setting is already in place.

Ok - it's using the same string? It would be better for everything to use the 
same java constant. Or better yet, our tests should be doing what users do and 
use an old version locator.


> On July 3, 2017, 4:02 p.m., Dan Smith wrote:
> > geode-core/src/main/java/org/apache/geode/internal/cache/EventID.java
> > Lines 307 (patched)
> > 
> >
> > Is this not just targetVersion.equals(GFE_90) ?
> 
> Bruce Schuchardt wrote:
> Anything between 1.0.0-incubating and GEODE-110 could have this problem

Got it.


- Dan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60570/#review179513
---


On June 30, 2017, 11:17 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60570/
> ---
> 
> (Updated June 30, 2017, 11:17 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Barry Oglesby, Galen O'Sullivan, 
> Hitesh Khamesra, and Brian Rowe.
> 
> 
> Bugs: GEODE-3153
> https://issues.apache.org/jira/browse/GEODE-3153
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Another problem was found in backward-compatibility testing.  If a 1.0.0 
> client was receiving subscription events generated by a 1.0.0 peer "feeder" 
> member and the events were routed through a 1.0.0 server the client might see 
> duplicate events when the server is stopped and the client fails over to a 
> 1.2.0 server holding its redundant subscription queue.  This is especially 
> possible if a large "ack" period is established in the client.
> 
> The problem stems from the EventID deserialization/reserialization of the 
> memberID bytes when sending to a 1.0 client.  It was deserializing using 
> Version.CURRENT, which ignores the UUID bytes in the serialized ID.  Then it 
> serialized the identifier using the client's version, which includes the UUID 
> bytes but which are zero due to the version used in deserialization.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  bc3d708da2ae9a8e386accb8d15e2ed49123241e 
>   geode-core/src/main/java/org/apache/geode/internal/Version.java 
> 557697159da644915e4ffe2405cdddc9ef37c5ac 
>   geode-core/src/main/java/org/apache/geode/internal/cache/EventID.java 
> 55c89f1f2e0800371dd4a30c4312c44f942a45ea 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscBCDUnitTest.java
>  bc48d976096fafe2545e707da68dab5120ddca51 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
>  bfe4646b9abdf6075e8d30fab3d79924faade2aa 
>   
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedDataSerializables.txt
>  b69e004d63d74eccd5cd562ea269363ba3f2782e 
> 
> 
> Diff: https://reviews.apache.org/r/60570/diff/3/
> 
> 
> Testing
> ---
> 
> new unit tests, precheckin
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Re: Review Request 60570: GEODE-3153 Client receives duplicate events during rolling upgrade

[Bruce Schuchardt]

> On July 3, 2017, 8:29 a.m., Alexander Murmann wrote:
> > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscBCDUnitTest.java
> > Lines 131 (patched)
> > 
> >
> > Nit pick: Do our tests commonly print debugging information? On other 
> > projects I've been on, everyone aimed for noise free tests.

We commonly have debugging information in test output.


- Bruce


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60570/#review179512
---


On June 30, 2017, 4:17 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60570/
> ---
> 
> (Updated June 30, 2017, 4:17 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Barry Oglesby, Galen O'Sullivan, 
> Hitesh Khamesra, and Brian Rowe.
> 
> 
> Bugs: GEODE-3153
> https://issues.apache.org/jira/browse/GEODE-3153
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Another problem was found in backward-compatibility testing.  If a 1.0.0 
> client was receiving subscription events generated by a 1.0.0 peer "feeder" 
> member and the events were routed through a 1.0.0 server the client might see 
> duplicate events when the server is stopped and the client fails over to a 
> 1.2.0 server holding its redundant subscription queue.  This is especially 
> possible if a large "ack" period is established in the client.
> 
> The problem stems from the EventID deserialization/reserialization of the 
> memberID bytes when sending to a 1.0 client.  It was deserializing using 
> Version.CURRENT, which ignores the UUID bytes in the serialized ID.  Then it 
> serialized the identifier using the client's version, which includes the UUID 
> bytes but which are zero due to the version used in deserialization.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  bc3d708da2ae9a8e386accb8d15e2ed49123241e 
>   geode-core/src/main/java/org/apache/geode/internal/Version.java 
> 557697159da644915e4ffe2405cdddc9ef37c5ac 
>   geode-core/src/main/java/org/apache/geode/internal/cache/EventID.java 
> 55c89f1f2e0800371dd4a30c4312c44f942a45ea 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscBCDUnitTest.java
>  bc48d976096fafe2545e707da68dab5120ddca51 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
>  bfe4646b9abdf6075e8d30fab3d79924faade2aa 
>   
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedDataSerializables.txt
>  b69e004d63d74eccd5cd562ea269363ba3f2782e 
> 
> 
> Diff: https://reviews.apache.org/r/60570/diff/3/
> 
> 
> Testing
> ---
> 
> new unit tests, precheckin
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Re: Review Request 60570: GEODE-3153 Client receives duplicate events during rolling upgrade

[Bruce Schuchardt]

> On July 3, 2017, 9:02 a.m., Dan Smith wrote:
> > It looks like this code should work. I'm still a bit worried that we are 
> > relying on code that tries to deserialize the member id with the wrong 
> > version and then ignores errors that occur. I'd like to see us revisit 
> > propegating the version with the membership id bytes.

Yes, we need to have the version info in bytes that we retain in serialized 
form like this.


> On July 3, 2017, 9:02 a.m., Dan Smith wrote:
> > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
> > Lines 129 (patched)
> > 
> >
> > I don't see this property ever get used?

This is used in ProcessManager.  The setting is already in place.


> On July 3, 2017, 9:02 a.m., Dan Smith wrote:
> > geode-core/src/main/java/org/apache/geode/internal/cache/EventID.java
> > Lines 307 (patched)
> > 
> >
> > Is this not just targetVersion.equals(GFE_90) ?

Anything between 1.0.0-incubating and GEODE-110 could have this problem


- Bruce


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60570/#review179513
---


On June 30, 2017, 4:17 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60570/
> ---
> 
> (Updated June 30, 2017, 4:17 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Barry Oglesby, Galen O'Sullivan, 
> Hitesh Khamesra, and Brian Rowe.
> 
> 
> Bugs: GEODE-3153
> https://issues.apache.org/jira/browse/GEODE-3153
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Another problem was found in backward-compatibility testing.  If a 1.0.0 
> client was receiving subscription events generated by a 1.0.0 peer "feeder" 
> member and the events were routed through a 1.0.0 server the client might see 
> duplicate events when the server is stopped and the client fails over to a 
> 1.2.0 server holding its redundant subscription queue.  This is especially 
> possible if a large "ack" period is established in the client.
> 
> The problem stems from the EventID deserialization/reserialization of the 
> memberID bytes when sending to a 1.0 client.  It was deserializing using 
> Version.CURRENT, which ignores the UUID bytes in the serialized ID.  Then it 
> serialized the identifier using the client's version, which includes the UUID 
> bytes but which are zero due to the version used in deserialization.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  bc3d708da2ae9a8e386accb8d15e2ed49123241e 
>   geode-core/src/main/java/org/apache/geode/internal/Version.java 
> 557697159da644915e4ffe2405cdddc9ef37c5ac 
>   geode-core/src/main/java/org/apache/geode/internal/cache/EventID.java 
> 55c89f1f2e0800371dd4a30c4312c44f942a45ea 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscBCDUnitTest.java
>  bc48d976096fafe2545e707da68dab5120ddca51 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
>  bfe4646b9abdf6075e8d30fab3d79924faade2aa 
>   
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedDataSerializables.txt
>  b69e004d63d74eccd5cd562ea269363ba3f2782e 
> 
> 
> Diff: https://reviews.apache.org/r/60570/diff/3/
> 
> 
> Testing
> ---
> 
> new unit tests, precheckin
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

[GitHub] geode pull request #615: GEODE-2991 Add man page for gfsh destroy gateway-se...

[karensmolermiller]

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode/pull/615

GEODE-2991 Add man page for gfsh destroy gateway-sender

@boglesby @joeymcallister @davebarnes97 @upthewaterspout 
Please review.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode feature/GEODE-2991

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/615.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #615


commit 0017913723b12e2ffb934be08bb1efa79f7ec536
Author: Karen Miller 
Date:   2017-07-03T16:34:23Z

GEODE-2991 Add man page for gfsh destroy gateway-sender




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: Geode-nightly #885

[Apache Jenkins Server]

See 

--
[...truncated 115.00 KB...]
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources
:geode-json:testClasses
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest UP-TO-DATE
:geode-old-versions:integrationTest UP-TO-DATE
:geode-protobuf:assemble
:geode-protobuf:extractIncludeTestProto
:geode-protobuf:extractTestProto UP-TO-DATE
:geode-protobuf:generateTestProto UP-TO-DATE
:geode-protobuf:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-protobuf:processTestResources UP-TO-DATE
:geode-protobuf:testClasses
:geode-protobuf:checkMissedTests
:geode-protobuf:spotlessJavaCheck
:geode-protobuf:spotlessCheck
:geode-protobuf:test
:geode-protobuf:check
:geode-protobuf:build
:geode-protobuf:distributedTest
:geode-protobuf:integrationTest
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: 

 uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:spotlessJavaCheck
:geode-pulse:spotlessCheck
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:integrationTest
:geode-rebalancer:assemble
:geode-rebalancer:compileTestJava
:geode-rebalancer:processTestResources UP-TO-DATE
:geode-rebalancer:testClasses
:geode-rebalancer:checkMissedTests
:geode-rebalancer:spotlessJavaCheck
:geode-rebalancer:spotlessCheck
:geode-rebalancer:test
:geode-rebalancer:check
:geode-rebalancer:build
:geode-rebalancer:distributedTest
:geode-rebalancer:integrationTest
:geode-wan:assemble
:geode-wan:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-wan:processTestResources
:geode-wan:testClasses
:geode-wan:checkMissedTests
:geode-wan:spotlessJavaCheck
:geode-wan:spotlessCheck
:geode-wan:test
:geode-wan:check

Re: Question regarding node failure scenario

[Dan Smith]

How are you performing the updates? Is N1 directly making updates or are
they coming from some other source?

What is the subscription-redundancy of your client that has registered
continuous queries?

-Dan

On Mon, Jul 3, 2017 at 8:19 AM, Roi Apelker  wrote:

> Hi,
>
> I have the following scenario, I wonder if anyone can comment on it - is
> it a known issue, maybe it was solved already in later version, etc. (I am
> using version 1.0.0)
>
> Bear with me I am a bit new here :)
>
> I have a replicated Node, say N1 and its replicated N2 (N2 gets activated
> when N1 is down) and they are configured to send updates via continuous
> query to my process which then reports on these updates.
>
> N1 is working all the time and serves as a server, and data is written to
> it continuously. If 1000 events are written to N1, the final report I am
> referring to will indicate 1000.
>
> When N1 gets killed for any reason, sometimes the updates do get to my
> reporting process and the report is 100% accurate.
>
> But sometimes, the report is inaccurate, e.g. after running 1000 events,
> my report says 950.
>
> The fact is, that the report is not accurate, and I only assume that
> something is wrong in the update mechanism, somewhere in the area of
> continuous query, or somewhere in the replication between the nodes.
>
> Has anyone encountered something similar and can share a thought? Maybe it
> was even solved in a later version?
>
> Thanks
>
> Roi
> This message and the information contained herein is proprietary and
> confidential and subject to the Amdocs policy statement,
>
> you may review at https://www.amdocs.com/about/email-disclaimer <
> https://www.amdocs.com/about/email-disclaimer>
>

Re: Review Request 60570: GEODE-3153 Client receives duplicate events during rolling upgrade

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60570/#review179513
---


Fix it, then Ship it!




It looks like this code should work. I'm still a bit worried that we are 
relying on code that tries to deserialize the member id with the wrong version 
and then ignores errors that occur. I'd like to see us revisit propegating the 
version with the membership id bytes.


geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
Lines 129 (patched)


I don't see this property ever get used?



geode-core/src/main/java/org/apache/geode/internal/cache/EventID.java
Lines 307 (patched)


Is this not just targetVersion.equals(GFE_90) ?


- Dan Smith


On June 30, 2017, 11:17 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60570/
> ---
> 
> (Updated June 30, 2017, 11:17 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Barry Oglesby, Galen O'Sullivan, 
> Hitesh Khamesra, and Brian Rowe.
> 
> 
> Bugs: GEODE-3153
> https://issues.apache.org/jira/browse/GEODE-3153
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Another problem was found in backward-compatibility testing.  If a 1.0.0 
> client was receiving subscription events generated by a 1.0.0 peer "feeder" 
> member and the events were routed through a 1.0.0 server the client might see 
> duplicate events when the server is stopped and the client fails over to a 
> 1.2.0 server holding its redundant subscription queue.  This is especially 
> possible if a large "ack" period is established in the client.
> 
> The problem stems from the EventID deserialization/reserialization of the 
> memberID bytes when sending to a 1.0 client.  It was deserializing using 
> Version.CURRENT, which ignores the UUID bytes in the serialized ID.  Then it 
> serialized the identifier using the client's version, which includes the UUID 
> bytes but which are zero due to the version used in deserialization.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  bc3d708da2ae9a8e386accb8d15e2ed49123241e 
>   geode-core/src/main/java/org/apache/geode/internal/Version.java 
> 557697159da644915e4ffe2405cdddc9ef37c5ac 
>   geode-core/src/main/java/org/apache/geode/internal/cache/EventID.java 
> 55c89f1f2e0800371dd4a30c4312c44f942a45ea 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscBCDUnitTest.java
>  bc48d976096fafe2545e707da68dab5120ddca51 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
>  bfe4646b9abdf6075e8d30fab3d79924faade2aa 
>   
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedDataSerializables.txt
>  b69e004d63d74eccd5cd562ea269363ba3f2782e 
> 
> 
> Diff: https://reviews.apache.org/r/60570/diff/3/
> 
> 
> Testing
> ---
> 
> new unit tests, precheckin
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

WFH Today (7/3)

[Dan Smith]

I'll be working from home today.

-Dan

Re: Review Request 60570: GEODE-3153 Client receives duplicate events during rolling upgrade

[Alexander Murmann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60570/#review179512
---


Fix it, then Ship it!




Ship It!


geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscBCDUnitTest.java
Lines 131 (patched)


Nit pick: Do our tests commonly print debugging information? On other 
projects I've been on, everyone aimed for noise free tests.


- Alexander Murmann


On June 30, 2017, 11:17 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60570/
> ---
> 
> (Updated June 30, 2017, 11:17 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Barry Oglesby, Galen O'Sullivan, 
> Hitesh Khamesra, and Brian Rowe.
> 
> 
> Bugs: GEODE-3153
> https://issues.apache.org/jira/browse/GEODE-3153
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Another problem was found in backward-compatibility testing.  If a 1.0.0 
> client was receiving subscription events generated by a 1.0.0 peer "feeder" 
> member and the events were routed through a 1.0.0 server the client might see 
> duplicate events when the server is stopped and the client fails over to a 
> 1.2.0 server holding its redundant subscription queue.  This is especially 
> possible if a large "ack" period is established in the client.
> 
> The problem stems from the EventID deserialization/reserialization of the 
> memberID bytes when sending to a 1.0 client.  It was deserializing using 
> Version.CURRENT, which ignores the UUID bytes in the serialized ID.  Then it 
> serialized the identifier using the client's version, which includes the UUID 
> bytes but which are zero due to the version used in deserialization.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  bc3d708da2ae9a8e386accb8d15e2ed49123241e 
>   geode-core/src/main/java/org/apache/geode/internal/Version.java 
> 557697159da644915e4ffe2405cdddc9ef37c5ac 
>   geode-core/src/main/java/org/apache/geode/internal/cache/EventID.java 
> 55c89f1f2e0800371dd4a30c4312c44f942a45ea 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscBCDUnitTest.java
>  bc48d976096fafe2545e707da68dab5120ddca51 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
>  bfe4646b9abdf6075e8d30fab3d79924faade2aa 
>   
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedDataSerializables.txt
>  b69e004d63d74eccd5cd562ea269363ba3f2782e 
> 
> 
> Diff: https://reviews.apache.org/r/60570/diff/3/
> 
> 
> Testing
> ---
> 
> new unit tests, precheckin
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Question regarding node failure scenario

[Roi Apelker]

Hi,

I have the following scenario, I wonder if anyone can comment on it - is it a 
known issue, maybe it was solved already in later version, etc. (I am using 
version 1.0.0)

Bear with me I am a bit new here :)

I have a replicated Node, say N1 and its replicated N2 (N2 gets activated when 
N1 is down) and they are configured to send updates via continuous query to my 
process which then reports on these updates.

N1 is working all the time and serves as a server, and data is written to it 
continuously. If 1000 events are written to N1, the final report I am referring 
to will indicate 1000.

When N1 gets killed for any reason, sometimes the updates do get to my 
reporting process and the report is 100% accurate.

But sometimes, the report is inaccurate, e.g. after running 1000 events, my 
report says 950.

The fact is, that the report is not accurate, and I only assume that something 
is wrong in the update mechanism, somewhere in the area of continuous query, or 
somewhere in the replication between the nodes.

Has anyone encountered something similar and can share a thought? Maybe it was 
even solved in a later version?

Thanks

Roi
This message and the information contained herein is proprietary and 
confidential and subject to the Amdocs policy statement,

you may review at https://www.amdocs.com/about/email-disclaimer 

[GitHub] geode-native issue #105: GEODE-2891 connect-timeout violation in C++ Native ...

[pivotal-jbarrett]

Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/105
  
> I suggest to fix the issue by defining handshake pseudo message within 
the range probably defined for such pseudo messages by original design i.e.:
>  typedef enum {
>/* Server couldn't read message; handle it like a server side
>   exception that needs retries */
>HANDSHAKE = -3
>NOT_PUBLIC_API_WITH_TIMEOUT = -2,

I think that would certainly work better but I think ultimately the fix is 
to remove the ambiguity between the C++ API and the Server API by strongly 
typing the duration values as addressed in the mentioned tickets. All duration 
values can be cast to the internal API supported unit without any ambiguity. 
After which there is no need to create this pseudo message to change the unit 
of the ambiguous int value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Apache Geode + Narayana JTA = Global Transactions with Last-Resource Optimization

[Christian Tzolov]

Recent experience of setting up Geode as a last-resource inside WebSphere
JTA, has motivated me to find a simpler way to integrate with JTA.

The https://github.com/tzolov/narayana-jta-geode-support provides utilities
to integrate Geode with Narayana JTA. This enables global transactions
using the embeddable, standalone, open-source Narayana JTA and implements
the Last-Resource Commit Optimization (LRCO) to preserve the ACID
properties.  (e.g. Geode is registered as last-resource in the global
transactions).

With narayana-geode-core you can use it with the plain Geode API:
http://bit.ly/2tByAr5
or use narayana-geode-springboot for seamless integration with Spring Boot
and SpringDataGemfire. See the http://bit.ly/2siBEof example

All dependencies are resolved from maven central.

So if you build a SpringBoot app you only need to add the maven
dependencies and set a single annotation @EnableGeodeNarayanaJta. No need
for obsolete, commercial  Application Servers no accidental complexity.

I’ve tried to explain the problem and the solution in my blog here:
http://blog.tzolov.net/2017/07/apache-geode-gemfire-narayana-jta.html?view=sidebar

Because Narayana uses LGPL it is not compatible for distribution with ASF,
but it can be referred as optional component.

Cheers,
Christian

P.S. the implementation uses code and ideas from the Geode engineering team
and from John Blum ;)
-- 
Christian Tzolov  | Data Engineer, EMEA
| Pivotal  | ctzo...@pivotal.io |+31610285517

[GitHub] geode issue #613: GEODE-3151: Internal Region Registration in JMX as per con...

[dineshpune2006]

Github user dineshpune2006 commented on the issue:

https://github.com/apache/geode/pull/613
  
 i have added  etc/eclipseFormatterProfile.xml in eclipse profile & did the 
code style set.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native issue #105: GEODE-2891 connect-timeout violation in C++ Native ...

[gregt5259]

Github user gregt5259 commented on the issue:

https://github.com/apache/geode-native/pull/105
  
I suggest to fix the issue by defining handshake pseudo message within the 
range probably defined for such pseudo messages by original design i.e.:

  typedef enum {
/* Server couldn't read message; handle it like a server side
   exception that needs retries */
HANDSHAKE = -3
NOT_PUBLIC_API_WITH_TIMEOUT = -2,

WDYT?

Thanks,
Dr. Gregory Turovets

"…We're all mad here. I'm mad. You're mad."
"How do you know I'm mad?" said Alice.
"You must be," said the Cat, "or you wouldn't have come here."
Alice's Adventures in Wonderland by Lewis 
Carroll.

From: Jacob Barrett [mailto:notificati...@github.com]
Sent: Sunday, July 02, 2017 17:46
To: apache/geode-native 
Cc: Gregory Turovets ; Author 

Subject: Re: [apache/geode-native] GEODE-2891 connect-timeout violation in 
C++ Native Client (#105)


@pivotal-jbarrett requested changes on this pull request.

Please rebase your changes on develop rather than merge.

Do not include comments with ticket numbers.
Do not include comments with your name or initials.
Do not leave sources commented out, delete or delete not.

Please follow the C++ style of the community.

I am concerned with the approach of trying to define a pseudo message for 
handshaking to get a different timeout unit. This may bite us in the future 
when added new messages to the protocol.

There are a few tickets in flight, or soon to be in flight, that address 
this problem.

https://issues.apache.org/jira/browse/GEODE-3136
https://issues.apache.org/jira/browse/GEODE-3137

I have begun some experiments with GEODE-3136 and should start committing 
to it in a few days. All API exposed timeouts will be based on 
std::chrono::duration so you can clearly see what unit of time your time is and 
the code behind that API doesn't have to guess. GEODE-3137 will address on use 
cases internally that aren't addressed when updating the public API. Any 
configuration files that specify timeout will be updated to take a duration 
string as well in the format of "1234s", "1234ms", etc.



In 
src/cppcache/src/TcrConnection.cpp:

> @@ -318,7 +318,9 @@ bool TcrConnection::InitTcrConnection(

   LOGFINE("Attempting handshake with endpoint %s for %s%s connection", 
endpoint,

   isClientNotification ? (isSecondary ? "secondary " : "primary ") 
: "",

   isClientNotification ? "subscription" : "client");

-  ConnErrType error = sendData(data, msgLengh, connectTimeout, false);

+  // GT GEODE-2891

Do not include comments with your name or the ticket number.



In 
src/cppcache/src/TcrConnection.cpp:

> @@ -318,7 +318,9 @@ bool TcrConnection::InitTcrConnection(

   LOGFINE("Attempting handshake with endpoint %s for %s%s connection", 
endpoint,

   isClientNotification ? (isSecondary ? "secondary " : "primary ") 
: "",

   isClientNotification ? "subscription" : "client");

-  ConnErrType error = sendData(data, msgLengh, connectTimeout, false);

+  // GT GEODE-2891

+  //ConnErrType error = sendData( data, msgLengh, connectTimeout, false );

Do not leave commented out sources, this is what revision control is for.



In 
src/cppcache/src/TcrConnection.cpp:

> -  // then app has set timeout in millis, change it to microSeconds

-  sendTimeoutSec = sendTimeoutSec * 1000;

-  isPublicApiTimeout = true;

-  LOGDEBUG("sendData2 %d ", sendTimeoutSec);

-} else {

-  sendTimeoutSec = sendTimeoutSec * 1000;

-}

+   notPublicApiWithTimeout == 
TcrMessage::EXECUTE_REGION_FUNCTION_SINGLE_HOP ||

+  // GT GEODE-2891

+  notPublicApiWithTimeout == TcrMessage::HANDSHAKE)

+   {

+   // then app has set timeout in millis, change it to microSeconds

+   sendTimeoutSec = sendTimeoutSec * 1000;

+   isPublicApiTimeout = true;

+   LOGDEBUG("sendData2 %d ", sendTimeoutSec);

+   }

Formatting does not conform to Google C++ Style 
Guide.

[GitHub] geode-native pull request #104: GEODE-3143 : close socket before deteting

[fdaniel7]

Github user fdaniel7 closed the pull request at:

https://github.com/apache/geode-native/pull/104


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---