[GitHub] geode pull request #609: GEODE-2886 : sent IllegalStateException instead of ...

Github user ameybarve15 commented on a diff in the pull request: https://github.com/apache/geode/pull/609#discussion_r131056489 --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunction.java --- @@ -85,8 +72,10 @@ public void

behavior of "connect" command when --use-ssl

I am looking at a behavior of Gfsh's connect command using ssl. I am not sure whether it's a valid use case or just some side effect of spaghetti code. So if SSL is configured on locator, and we need to connect to it in Gfsh gfsh>connect --security-properties-file=ssl.properties this will try to

Re: [DISCUSS] Feature branch cleanup

Along those same lines it would be really nice if people would use their own forks for feature branches, then we wouldn't have this mess at all. Sent from my iPhone > On Aug 2, 2017, at 9:44 PM, Nabarun Nag wrote: > > > Hi > I was wondering if we should clean up the feature

[DISCUSS] Feature branch cleanup

Hi I was wondering if we should clean up the feature branches related to closed or resolved GEODE tickets in the origin repository. Below are the listed tickets and associated branch. Regards Nabarun Nag Branch Name Ticket Status Committers [merged to develop] origin/feature/GEODE-11

[GitHub] geode pull request #664: Fix for GEODE-3292

Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/664#discussion_r131050219 --- Diff: geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseConnectivityTest.java --- @@ -0,0 +1,110 @@ +/* + * Licensed to the

[GitHub] geode pull request #664: Fix for GEODE-3292

Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/664#discussion_r131049554 --- Diff: geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseConnectivityTest.java --- @@ -0,0 +1,110 @@ +/* + * Licensed to the

[GitHub] geode pull request #664: Fix for GEODE-3292

Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/664#discussion_r131049401 --- Diff: geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseConnectivityTest.java --- @@ -0,0 +1,110 @@ +/* + * Licensed to the

[GitHub] geode pull request #664: Fix for GEODE-3292

Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/664#discussion_r131050061 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/ManagementAgent.java --- @@ -270,6 +271,7 @@ private void

[GitHub] geode pull request #664: Fix for GEODE-3292

Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/664#discussion_r131049994 --- Diff: geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/EmbeddedPulseRule.java --- @@ -38,6 +38,12 @@ protected void before() throws

[GitHub] geode issue #681: Lucene refactoring and clean up

Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/681 Potential reviewers @ladyVader @jhuynh1 @boglesby @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] geode pull request #681: Lucene refactoring and clean up

GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/681 Lucene refactoring and clean up Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps

[GitHub] geode pull request #680: GEODE-3257: Refactoring DeployCommands

GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/680 GEODE-3257: Refactoring DeployCommands [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3257) **Testing Status: Precheckin to be run on morning of 8/3** -

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #635 was SUCCESSFUL (with 2024 tests)

--- Spring Data GemFire > Nightly-ApacheGeode > #635 was successful. --- Scheduled 2026 tests in total. https://build.spring.io/browse/SGF-NAG-635/ -- This

Re: Stored procedures on Apache Geode.

Hi Marios- Any application config annotated with @PeerCacheApplication / @CacheServerApplication, or CacheFactoryBean directly in *JavaConfig*, or in XML, is a Geode (GemFire) Server, a peer member of the distributed system (cluster) defined by a Locator. For instance, I can... gfsh>start

[GitHub] geode pull request #677: GEODE-3038: A server process shuts down quietly whe...

Github user dschneider-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/677#discussion_r131003885 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java --- @@ -1208,6 +1208,9 @@ private void initialize() {

[GitHub] geode pull request #679: GEODE-3340: Refactor ConfigCommandsDUnitTest to use...

Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/679#discussion_r131003469 --- Diff: geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ConfigCommandDUnitTest.java --- @@ -0,0 +1,242 @@ +/* + *

[GitHub] geode pull request #679: GEODE-3340: Refactor ConfigCommandsDUnitTest to use...

Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/679#discussion_r131003075 --- Diff: geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ConfigCommandDUnitTest.java --- @@ -0,0 +1,242 @@ +/* + *

[GitHub] geode pull request #671: GEODE-3255: Refactor CreateAlterDestroyRegionComman...

Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/671#discussion_r131002611 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateRegionCommand.java --- @@ -1143,4 +721,26 @@ private boolean

[GitHub] geode issue #676: GEODE-3321: Adding ErrorCode values to protobuf protocol

Github user WireBaron commented on the issue: https://github.com/apache/geode/pull/676 Rebased to fix conflicts and added an error code to the new GetAvailableServers handler. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] geode pull request #679: GEODE-3340: Refactor ConfigCommandsDUnitTest to use...

Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/679#discussion_r130998820 --- Diff: geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ConfigCommandDUnitTest.java --- @@ -0,0 +1,242 @@ +/* + *

[GitHub] geode pull request #679: GEODE-3340: Refactor ConfigCommandsDUnitTest to use...

Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/679#discussion_r130998592 --- Diff: geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ConfigCommandDUnitTest.java --- @@ -0,0 +1,242 @@ +/* + *

Re: Review Request 61281: GEODE-3379 Geode transaction may commit on a secondary bucket after bucket rebalance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61281/ --- (Updated Aug. 2, 2017, 9:12 p.m.) Review request for geode, anilkumar gingade,

[GitHub] geode issue #664: Fix for GEODE-3292

Github user jaredjstewart commented on the issue: https://github.com/apache/geode/pull/664 Thanks @jujoramos, this looks good to me. Do you have any thoughts @jinmeiliao? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] geode issue #676: GEODE-3321: Adding ErrorCode values to protobuf protocol

Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/676 Looks like there are some conflicts that need to be resolved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] geode pull request #676: GEODE-3321: Adding ErrorCode values to protobuf pro...

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/676#discussion_r130987753 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtocolErrorCode.java --- @@ -0,0 +1,39 @@ +/* + * Licensed to the

JIRA permissions

Hello all, I'm having some trouble assigning tickets to myself and closing them in JIRA. Can someone grant me the appropriate permissions. My username is: WireBaron Thanks, -Brian

RE: Stored procedures on Apache Geode.

Hi John, Thanks for providing these details. I am gonna update clone and verify. I am also have another question for you. I noticed that while executing "list members" only application listed as member. Locators and servers are not supposed to be listed as well? Thanks Marios

Broken: apache/geode#3379 (develop - bb847c7)

Build Update for apache/geode - Build: #3379 Status: Broken Duration: 19 minutes and 54 seconds Commit: bb847c7 (develop) Author: zhouxh Message: GEODE-3055: The old primary's the shadow bucket is not initialized when rebalance remove it. Thus the new primary

Broken: apache/geode#3378 (develop - 867ac06)

Build Update for apache/geode - Build: #3378 Status: Broken Duration: 10 minutes and 20 seconds Commit: 867ac06 (develop) Author: nabarun Message: GEODE-3384: Javadoc change for PageableLuceneQueryResults * Javadocs now mention that

Errored: apache/geode#3374 (develop - d77d69f)

Build Update for apache/geode - Build: #3374 Status: Errored Duration: 11 minutes and 28 seconds Commit: d77d69f (develop) Author: masaki.yamakawa Message: GEODE-3028: Fix the expected value of the test that depended on Locale Fix the test that uses the

[GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings

Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/651#discussion_r130982335 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java --- @@ -633,8 +631,8 @@ public

Re: Stored procedures on Apache Geode.

Hi Marios- That is strange. Seems your problem is this... Failed to instantiate [org.springframework.data.gemfire.CacheFactoryBean]: Factory method 'gemfireCache' threw exception; nested exception is *java.lang.NoSuchMethodError*: *org.springframework.data.*

RE: Stored procedures on Apache Geode.

Hi John, Thanks a lot for getting back to me. This is the example am trying , https://github.com/jxblum/contacts-application/blob/master/configuration-example/src/main/java/example/app/spring/annotation/geode/server/AnnotationConfiguredGeodeServerApplication.java Please find below the output

Jenkins build is back to normal : Geode-nightly-flaky #83

See

[GitHub] geode pull request #665: GEODE-3254: Refactoring ConfigCommands and ConfigCo...

Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/665#discussion_r130965197 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/Interceptor.java --- @@ -0,0 +1,79 @@ +/* + * Licensed to the

[GitHub] geode pull request #665: GEODE-3254: Refactoring ConfigCommands and ConfigCo...

Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/665#discussion_r130960231 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/Interceptor.java --- @@ -0,0 +1,79 @@ +/* + * Licensed to the

[GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings

Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/651#discussion_r130959623 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java --- @@ -633,8 +631,8 @@ public

[GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings

Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/651#discussion_r130959557 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/Launcher.java --- @@ -99,7 +99,6 @@ protected Launcher() {

[GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings

Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/651#discussion_r130958981 --- Diff: geode-core/src/main/java/org/apache/geode/internal/process/MBeanProcessController.java --- @@ -260,6 +265,7 @@ private JMXServiceURL

[GitHub] geode pull request #609: GEODE-2886 : sent IllegalStateException instead of ...

Github user jhuynh1 commented on a diff in the pull request: https://github.com/apache/geode/pull/609#discussion_r130952081 --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunction.java --- @@ -85,8 +72,10 @@ public void

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

> On Aug. 2, 2017, 4:44 p.m., Kirk Lund wrote: > > You might consider hoisting these classes out of management pkg and into > > org.apache.geode.test.something. Maybe even move them to geode-test module. > > They seem very useful even outside of geode-core and management. > > > > Ship It!

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61166/ --- (Updated Aug. 2, 2017, 5:54 p.m.) Review request for geode, Emily Yeh, Jared

[GitHub] geode pull request #570: GEODE-3055: waitUntilFlush should use data region's...

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/570 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #672: GEODE-3256: Refactoring DataCommands

Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/672#discussion_r130944162 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommandsUtils.java --- @@ -0,0 +1,311 @@ +/* + * Licensed

[GitHub] geode pull request #674: GEODE-3380: There're 2 problems here

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/674 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Review Request 61281: GEODE-3379 Geode transaction may commit on a secondary bucket after bucket rebalance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61281/#review182006 --- Ship it! Ship It! - Darrel Schneider On Aug. 1, 2017, 2:41

[GitHub] geode pull request #678: GEODE-3384: Javadoc change for PageableLuceneQueryR...

GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/678 GEODE-3384: Javadoc change for PageableLuceneQueryResults * Javadocs now mention that PageableLuceneQueryResults are serializable and can be sent to other members Thank you for

[GitHub] geode pull request #570: GEODE-3055: waitUntilFlush should use data region's...

Github user boglesby commented on a diff in the pull request: https://github.com/apache/geode/pull/570#discussion_r130941287 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionDataStore.java --- @@ -494,6 +494,18 @@ CreateBucketResult

[GitHub] geode issue #467: GEODE-258: Remove deprecated Cache.getLoggerI18n and getSe...

Github user kirklund commented on the issue: https://github.com/apache/geode/pull/467 @davinash Sorry to take so long to respond! For the security logger you can use this: ```java private static Logger securityLogger = LogService.getLogger(LogService.SECURITY_LOGGER_NAME);

[GitHub] geode pull request #570: GEODE-3055: waitUntilFlush should use data region's...

Github user boglesby commented on a diff in the pull request: https://github.com/apache/geode/pull/570#discussion_r130937683 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionDataStore.java --- @@ -494,6 +494,18 @@ CreateBucketResult

[GitHub] geode pull request #663: GEODE-3314: Fix DLockService token leak.

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/663 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Jenkins build is back to normal : Geode-nightly #914

See

[GitHub] geode pull request #556: GEODE-3028: Fix the expected value of the test that...

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/556 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #661: GEODE-3319 - refactor to use protobuf encoding for ...

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/661 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #673: GEODE-3284: New flow: getAvailableServers

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/673 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Review Request 61119: GEODE-3097: GFSH works over HTTP with SSL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61119/#review182002 --- Ship it! Ship It! - Kirk Lund On July 25, 2017, 10:11 p.m.,

Re: Review Request 61185: GEODE-3231: use tempWorkingFolder to avoid test log file contamination between tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61185/#review182001 --- Ship it! Ship It! - Kirk Lund On July 27, 2017, 4:57 p.m.,

Re: Review Request 61231: GEODE-3328: simply extract connect command from ShellCommand

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61231/#review182000 --- Ship it! Ship It! - Kirk Lund On July 28, 2017, 8:41 p.m.,

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61166/#review181999 --- Ship it! You might consider hoisting these classes out of

[GitHub] geode pull request #676: GEODE-3321: Adding ErrorCode values to protobuf pro...

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/676#discussion_r130928395 --- Diff: geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/RemoveRequestOperationHandlerJUnitTest.java --- @@ -95,8 +97,8

[GitHub] geode pull request #676: GEODE-3321: Adding ErrorCode values to protobuf pro...

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/676#discussion_r130928974 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtocolErrorCode.java --- @@ -0,0 +1,39 @@ +/* + * Licensed to the

[GitHub] geode pull request #676: GEODE-3321: Adding ErrorCode values to protobuf pro...

Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/676#discussion_r130920986 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtocolErrorCode.java --- @@ -0,0 +1,39 @@ +/* + * Licensed to

[GitHub] geode pull request #670: GEODE-3336: Refactor IndexCommandsDUnitTest to use ...

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/670 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #675: GEODE-3339: Refactoring ClusterConfigurationService...

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/675 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode issue #673: GEODE-3284: New flow: getAvailableServers

Github user bschuchardt commented on the issue: https://github.com/apache/geode/pull/673 Locators aren't configured via cluster config. None of the distributed-system properties are configured through cluster configuration because you must connect to the distributed system in order

[GitHub] geode issue #676: GEODE-3321: Adding ErrorCode values to protobuf protocol

Github user bschuchardt commented on the issue: https://github.com/apache/geode/pull/676 The license header was probably damaged during some search operations to transform the google-doc version of the list into an enum --- If your project is set up for it, you can reply to this

Re: Stored procedures on Apache Geode.

Hi Marios- To which example are you referring and what is the error you are getting? Also, if you could please share a small snippet of code showing how you used the annotations, that would be helpful. The new Annotation based configuration (beginning with 1 of... @ClientCacheApplication,

RE: Stored procedures on Apache Geode.

Hi John, I am following you example for setting up geode cluster using annotation but getting a few errors. Do these annotations apply only for gemfire? Thanks Marios From: John Blum [via Apache Geode (Incubating) Developers Forum]

[GitHub] geode pull request #677: GEODE-3038: A server process shuts down quietly whe...

GitHub user anton-mironenko opened a pull request: https://github.com/apache/geode/pull/677 GEODE-3038: A server process shuts down quietly when path to cache.xml is incorrect [GEODE-3038](https://issues.apache.org/jira/browse/GEODE-3038) The error "Declarative Cache XML

[GitHub] geode issue #664: Fix for GEODE-3292

Github user jujoramos commented on the issue: https://github.com/apache/geode/pull/664 Hello @jaredjstewart, Just pushed the requested changes. - Renamed `PulseVerificationTest` to `PulseConnectivityTest`. - Removed `loginWithIncorrectPassword` test method, it is